960 Commits

Author SHA1 Message Date
tjhunt
b4a2e41313 quiz editing: MDL-17284 fix infinite redirect bug. 2009-01-07 07:12:37 +00:00
tjhunt
807a1a8427 question bank database: MDL-17608 Drop originalquestion field from the question_states table - it was never used for anything. 2009-01-06 05:20:21 +00:00
skodak
11e7b506ce MDL-17754, MDL-11061, MDL-9276, MDL-17777, MDL-17787 - various url handling improvemetns; rewritten $FULLME and added $ME, $SCRIPT and $FULLSCRIPT; improved slashargument handling especially for IIS; removed legacy slasharguments functions obsoleted since 1.6; some other refactoring; reverse procy support, ssl appliance support 2009-01-05 21:37:20 +00:00
thepurpleblob
9843511764 MDL-17779
Add simple check that question at least has questiontext before allowing it.
2009-01-05 15:23:10 +00:00
skodak
973d2660e6 MDL-16613 sesskey cleanup 2009-01-02 10:51:26 +00:00
skodak
d4a1fcaf11 MDL-16613 sesskey cleanup 2009-01-02 10:36:25 +00:00
tjhunt
7028ab335d match qtype: MDL-17326 backup and restore problems
* The shuffleanswers options was not backed up or restored.

* Responses were not properly recoded on restore.
2008-12-12 06:45:07 +00:00
dongsheng
771dc7b298 "MDL-14129, fix error() in moodle2" 2008-12-12 05:45:43 +00:00
dongsheng
60e40dda6c "MDL-14129, remove the rest error() in moodle2" 2008-12-12 04:53:32 +00:00
tjhunt
299d9fb834 matching qtype: MDL-17496 With filterall and multilang, the contents of the dropdowns was not being properly filtered
This was caused becuse the solution to MDL-9005 was not quite right.
2008-12-12 04:39:38 +00:00
tjhunt
be8563b63a numerical and shortanswer question types: problems with compare_responses and test_response.
MDL-15315 The previous fix for this issue with wildcard answers in the item analysis report caused the following two regressions. This patch fixes it properly.

MDL-17247 This is basiclly pointing out the weridness in the previous fix and gave some useful clues as to a proper solution. Thanks Oleg.

MDL-17610 This was a report of a problem with each attempt builds on last, with a shortanswer question, where the sutdent's response contains a '.

Also, lots of unit tests to try to ensure the new code is right.
2008-12-12 03:48:39 +00:00
tjhunt
f932b81953 matching qtype: MDL-14420 Could not use '0' as a question stem. Oops, more tests need to be corrected. 2008-12-11 05:01:37 +00:00
tjhunt
9ce0983b0d matching qtype: MDL-14420 Could not use '0' as a question stem. Bloody PHP! 2008-12-11 04:57:39 +00:00
tjhunt
f8394114c3 matching qtype: whitespace cleanup. 2008-12-11 04:55:41 +00:00
tjhunt
26b266625b numerical qtype: MDL-15159 Error moving a numerical question type with no units from one category to another. 2008-12-11 04:33:41 +00:00
tjhunt
e8f99abc68 quiz manual grading: MDL-5517 manual grading pop-up is too small. HTML editor does not fit. Merged from MOODLE_19_STABLE.
Also MDL-17585 Improve layout of manual grading forms to make them look more like formslib forms. The standard trick of stealing the HTML and class names that formslib works, so the standard style rules apply to your form.
2008-12-10 09:11:30 +00:00
dongsheng
ff9b4ea40a "MDL-17570,clean align property, merged from 1.9" 2008-12-10 07:24:11 +00:00
tjhunt
aafdb447bf quiz: MDL-6085 when editing a question from various places like a preview attempt or review screen, don't use a popup, instead take advantage of the fact that question.php now takes a returnurl. Merged from MOODLE_19_STABLE.
And MDL-17568 minor niggles with new queston navigation:
* The bit that scrolls down to the question you just submitted in adaptive mode was not working with random questions.
* Teachers reviewing an open attempt were shown the qusetions as editable, not read only!
2008-12-10 06:26:47 +00:00
tjhunt
0a9356aad3 truefalse qtype: MDL-12027 remove spurious alt attribute from truefalse qtype radio buttons. 2008-12-10 00:54:27 +00:00
pichetp
636bbc8728 MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other question
} missing...
2008-12-04 16:04:48 +00:00
pichetp
57db70affb MDL-17524 Deleting a calculated question delete datasetdefinitions shared by other question 2008-12-04 15:56:01 +00:00
pichetp
77f60b432a removing an echo diagnostic output... 2008-12-01 04:03:48 +00:00
pichetp
cae0b24abb Modify a DB call so that the first index is not multiple .
Eliminate references to datasetdefinition->type  other  than 1
as the dataset tables are just used by calculated that used type =1 i.e. LITERAL.
2008-12-01 04:00:54 +00:00
pichetp
0bddf4b6ac Displacing <label> to enclose correctly answer text in question display
so no possible XML problem.
Cleaning comments
Better handling of empty responses when grading,
2008-11-29 15:02:27 +00:00
jamiesensei
2280e147c5 MDL-12418 "Item Analysis shows duplicate responses for Multiple Choice questions with LaTeX in answers" This problem was caused by the formatting of questions in get_actual_responses. Now formatting is done in response_summary rather than get_actual_response which returns an array of unformatted strings.
Have fixed the formatting in responses report and in statistics report to use the correct formatting for the question type.

Created new functions format_responses and format_response. format_responses works on an array and normally just walks through the array calling format_response.
2008-11-28 10:14:19 +00:00
tjhunt
f24493ec9b random essay questions: MDL-8648 Allow essay questions to be selected by random question.
In the 1.9 branch this is controlled by a new option under Admin -> Experimental. In Moodle 2.0 dev it is not optional, it just works.

The main change is letting the manual grading report know which random questions might need manual grading. MDL-4004 - this depends on the random question under consideration, which requires a new questiontype method.

I also changed the random question code so that I could remove some global variables.
2008-11-28 06:07:11 +00:00
tjhunt
df4e224454 question bank: MDL-14434 Cannot edit the only question category in a context. 2008-11-27 11:50:29 +00:00
tjhunt
21cbf9da8b question bank: MDL-17078 Error after deleting a question category. 2008-11-27 07:30:17 +00:00
tjhunt
16590517fa fix notices: MDL-15974 Some systems that were upgraded have nullable columns, leading to notices
A new install has NOT NULL DEFAULT 0.
2008-11-27 05:12:11 +00:00
tjhunt
bcc234b0a7 random question editing: Don't show permission information when editing a random question. It is just confusing. 2008-11-26 05:19:34 +00:00
tjhunt
1e69a6562f MDL-17361 Problems with the question category editing forms.
When editing an existing category, the logic should have been to prevent you from moving the category if it was the last remaining top-level category in its context.

When creating a new category as part of creating a random question, there should be no restriction.
2008-11-26 04:25:42 +00:00
pichetp
fd97082c59 MDL-17264 Adding control of usecase for the shortanswer type using SHORTANSER_C or
SAC or MWC
2008-11-24 04:10:43 +00:00
pilpi
4070210d93 quiz editing: MDL-17293 Added a default value to avoid error messages
Added a default value  to the function that passes a page number to avoid error messages.
2008-11-22 17:30:12 +00:00
pilpi
5c8505d034 quiz editing: MDL-17293 changed how the page number to add on is passed to the form for creating a random question 2008-11-22 16:32:36 +00:00
pilpi
9fa363896e quiz editing: MDL-17293 removed two lines of code that did nothing good but some bad, showing an extra form where it should have not been. 2008-11-22 15:52:17 +00:00
pilpi
a9b6e4b88a question: MDL-17337 Add the new essay and random question icons 2008-11-20 18:26:35 +00:00
tjhunt
fa583f5f6e quiz editing: MDL-17285 This is Olli Savolainen's new interface for editing quizzes.
This was started and usability tested as a Finnish Summer of Code project, and then Olli did further work on it in his own time to get it in shape for inclusion in Moodle 2.0. I reviewed all the code. There are a number of minor outstanding issues that will be fixed soon. See the subtasks of MDL-17284 for a list.

The goal of these changes is to:
* help teachers new to Moodle, so when they first see the quiz editing page, they don't go "Huh! What on earth am I supposed to do here?"
* help novice Moodle users understand and learn to use some of the more advanced quiz feature;
* but, without slowing down more experienced quiz users.

Naturally, with ambitous goals like that, we won't have managed to satisy everybody, but I think this change is a big step in the right direction.

There is extensive documentation on this project at http://docs.moodle.org/en/Development:Quiz_UI_redesign.
2008-11-20 06:59:11 +00:00
pichetp
f96e83d4b6 MDL-17228 Synchronizing dataitems between calculated questions in a quiz 2008-11-18 18:28:20 +00:00
pichetp
e95d204d9a MDL-14763 remove automatic numbering of multichoice vertical or horizontal display 2008-11-12 07:02:25 +00:00
pichetp
665e82f8f8 MDL-14763 new lang strings and MDL-17134 2008-11-10 19:47:49 +00:00
tjhunt
41d3730951 random questions: MDL-17185 regression from MDL-17160 random questions were no longer randomising.
Backporting Jamie's fix to 1.9, and making a minor improvement along the way.
2008-11-10 07:56:37 +00:00
jamiesensei
01bb194a4e MDL-17185 "random questions always the same!" Randomized question selection 2008-11-10 07:32:05 +00:00
pichetp
2605364117 MDL-17104 and MDL-17105 unused old questions are deleted more correclty and take in
account that the actual questiontype/save_question() create a new question when categorytomove
 is not set..
2008-11-09 21:55:58 +00:00
tjhunt
339ef4c246 random questions: MDL-17160 Adding random questions, maximum option.
When counting how many options to put in the add NN random questions dropdown, we should only count questions of types that are usable by random.
2008-11-07 05:50:02 +00:00
tjhunt
4568bf99a8 Fix misleading comment. 2008-11-05 08:10:17 +00:00
tjhunt
da012eb63a qtype multichoice: MDL-17029 - followup - revert my overzealous copying and pasting. Thanks to Myles Carrick for noticing my mistake. 2008-10-27 23:36:07 +00:00
tjhunt
4b31ac5cd1 qtype multichoice: MDL-17029 answernumbering option was not being backed up or restored. 2008-10-27 04:23:23 +00:00
tjhunt
6cfa5ec17d qtype match: MDL-16450 Change validation so it is possible to create matching questions with two stems and three answers.
Thanks to Oleg Sychev for implementing this.
2008-10-27 02:33:34 +00:00
tjhunt
41c96651b5 question bank category editing: To be honest, I can't rememeber exactly what bug this fixes, but it was a problem I found and fixed while preparing to demo stuff at the Brisbane Moodle Moot. In the process of fixing whatever issue it was (I think it was something to do with the permissions checks in some cases) I cleaned to code up and made it easier to understand, and I trust myself, so I am checking this in. 2008-10-23 09:23:52 +00:00
tjhunt
ef33a9cd37 Question bank: error when deleting empty categories. 2008-10-23 09:17:50 +00:00