5077 Commits

Author SHA1 Message Date
Gordon Bateson
44c4676fc4 MDL-79863 qtype_ordering: Co-authored-by: Anupama Sarjoshi <anupama.sarjoshi@open.ac.uk> 2024-04-04 10:59:31 +08:00
Tim Hunt
ba23a42edd MDL-79863 qtype_ordering: Ordering question type. Upgrade to work with Moodle 4.0, 4.1 and 4.2 (#72)
* Add moodle-plugin-ci github actions configuration

* Rebuild JavaScript

* Fix behat test failing in Moodle 4.0

* Ordering: better define 'rows' for items in horizontal list #401861 #55

* Ordering: Option to show number of correct choices/highlight correct and incorrect placement.

* Ordering: Improper alignment of feedback with Horizontal layout of items

* Ordering: make M4-compatible (including behat etc.) #606639

* M4: Behat: question/type/ordering tests failing #598659

* Fix grunt errors

* Fix unreliability in the preview Behat tests

* Fix Moodle 4.0-style regrading

Also, correctly initialise all parts of the question object in initialise_question_instance

* Update CI config

---------

Co-authored-by: sangnguyen <sna67@open.ac.uk>
Co-authored-by: Thong Bui <qktc1422@gmail.com>
Co-authored-by: Anupama Sarjoshi <anupama.sarjoshi@open.ac.uk>
2024-04-04 10:59:31 +08:00
Gordon Bateson
fc4adc6003 MDL-79863 qtype_ordering: qtype_ordering optimize code to ensure that recorded responses are no longer than 100 bytes. 2024-04-04 10:59:30 +08:00
Gordon Bateson
b3c86b05b7 MDL-79863 qtype_ordering: qtype_ordering optimize code to ensure that recorded responses are no longer than 100 bytes. 2024-04-04 10:59:30 +08:00
Mahmoud Kassaei
b681b06a26 MDL-79863 qtype_ordering: PHPunit: Some compatibilirty in question_test & questiontype_test (#69)
qtype_ordering #69 Fix errors in unit test. Many thanks to Mahmoud Kassaei
2024-04-04 10:59:30 +08:00
Gordon Bateson
f56dc82e52 MDL-79863 qtype_ordering: qtype_ordering modify markdown syntax for long help messages (for compatability with Moodle 3.11) 2024-04-04 10:59:30 +08:00
ewallah
1ba7af3582 MDL-79863 qtype_ordering: Update questiontype_test.php (#64)
Declaration of qtype_ordering_test::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void
Declaration of qtype_ordering_test::tearDown() must be compatible with PHPUnit\Framework\TestCase::TearDown(): void
2024-04-04 10:59:30 +08:00
Gordon Bateson
164bca54d6 MDL-79863 qtype_ordering: qtype_ordering fix Issue #63. Restore missing method 'set_default_value()' 2024-04-04 10:59:30 +08:00
Gordon Bateson
d5691b5097 MDL-79863 qtype_ordering: qtype_ordering add message to CHANGES.txt 2024-04-04 10:59:30 +08:00
Gordon Bateson
8973b055d3 MDL-79863 qtype_ordering: qtype_ordering in edit form, rename 'get_default_value()' method to 'get_my_default_value()' for compatability with Moodle >= 3.10 2024-04-04 10:59:30 +08:00
Gordon Bateson
c74e93c23c MDL-79863 qtype_ordering: qtype_ordering modify declaration of parameters accepted by get_default_value method in the edit form 2024-04-04 10:59:30 +08:00
Gordon Bateson
c6be47652f MDL-79863 qtype_ordering: qtype_ordering update CHANGES.txt to include recent contributions by Tim Hunt and HuongNV13 2024-04-04 10:59:30 +08:00
Gordon Bateson
6a1d9cb57f MDL-79863 qtype_ordering: qtype_ordering update CHANGES.txt to include recent contributions by Tim Hunt and HuongNV13 2024-04-04 10:59:30 +08:00
Huong Nguyen
72f9dbe111 MDL-79863 qtype_ordering: Fixing bugs (#52)
Thanks very much, HuongNV13 (1) Items crash together horizontally (2) Number/letter no longer tracks with dragged item
2024-04-04 10:59:30 +08:00
Tim Hunt
211edfdaeb MDL-79863 qtype_ordering: Update Behat tests to use the MDL-66821 changes (#49)
Thanks very much, Tim Hunt. (1) Update Behat tests to use the MDL-66821 changes (2) Fix Behat test that was failing
2024-04-04 10:59:30 +08:00
Gordon Bateson
6c6942faca MDL-79863 qtype_ordering: qtype_ordering fix JS error on Moodle >= 3.7 caused by incorrect syntax in 'define' statement in key_codes.js 2024-04-04 10:59:29 +08:00
Gordon Bateson
43c7e39a74 MDL-79863 qtype_ordering: qtype_ordering standardize layout and spelling in CHANGES.txt 2024-04-04 10:59:29 +08:00
Gordon Bateson
f87cb2c76b MDL-79863 qtype_ordering: qtype_ordering standardize layout and spelling in CHANGES.txt 2024-04-04 10:59:29 +08:00
Gordon Bateson
5b1ca09260 MDL-79863 qtype_ordering: Many thanks as always Mahmoud Kassaei ! 2024-04-04 10:59:29 +08:00
Mahmoud Kassaei
62becffa9b MDL-79863 qtype_ordering: Numberingstyle does not display properly in notactive mode (#47)
Many thanks as always Mahmoud Kassaei !
2024-04-04 10:59:29 +08:00
Gordon Bateson
932437c333 MDL-79863 qtype_ordering: qtype_ordering tidy up text in CHANGES.txt 2024-04-04 10:59:29 +08:00
Gordon Bateson
c26560a2b9 MDL-79863 qtype_ordering: qtype_ordering set up preliminary version of CHANGES.txt 2024-04-04 10:59:29 +08:00
Gordon Bateson
58cd34d502 MDL-79863 qtype_ordering: qtype_ordering fix behavior in Adaptive mode, with 'Whether correct' review option enabled 2024-04-04 10:59:29 +08:00
Gordon Bateson
ae7ee93bf0 MDL-79863 qtype_ordering: qtype_ordering (github-issue #43 and #44): rename upper case numberstyles to ABCD and IIII in order to differentiate from lower case styles on DBs, such as MySQL, which use case insensitive indexes. 2024-04-04 10:59:29 +08:00
Gordon Bateson
d784021b8d MDL-79863 qtype_ordering: qtype_ordering rename 'answernumbering' to 'numberingstyle' and include this field in import/export of xml/gift formats. 2024-04-04 10:59:29 +08:00
Mahmoud Kassaei
76a6fce839 MDL-79863 qtype_ordering: Qtype_ordering: Numbering for lists (123.., abc...) (#42)
Thanks Mahmoud. Great job!
2024-04-04 10:59:29 +08:00
Gordon Bateson
9935253fea MDL-79863 qtype_ordering: qtype_ordering fix small typo in behat test file 2024-04-04 10:59:29 +08:00
Gordon Bateson
4a70e6211f MDL-79863 qtype_ordering: qtype_ordering fix small typo in language file and optimize logic in form validation 2024-04-04 10:59:28 +08:00
Mahmoud Kassaei
9d3998ecf5 MDL-79863 qtype_ordering: Qtype ordering should not allow duplicatue items (#40)
Thank you Mahmoud Kassaei for your continuing work to improve the Ordering question type
2024-04-04 10:59:28 +08:00
Gordon Bateson
356ad12ad4 MDL-79863 qtype_ordering: * Code checker issues in version.php 2024-04-04 10:59:28 +08:00
Mahmoud Kassaei
09be025919 MDL-79863 qtype_ordering: Ordering codechecker (#39)
* Code checker issues on edit_ordering_form.php

* function question_register_questiontype() not needed in questiontype.php

* Code checker issues in questiontype.php

* Code checker issues in question.php

* Code checker issues in renderer.php

* Code checker issues in version.php
2024-04-04 10:59:28 +08:00
Gordon Bateson
bf48b2f7b3 MDL-79863 qtype_ordering: Ordering cleanup - thanks Mahmoud Kassaei! 2024-04-04 10:59:28 +08:00
M Kassaei
5d9a051d42 MDL-79863 qtype_ordering: There is no need for legacy 'default_questionetype' 2024-04-04 10:59:28 +08:00
M Kassaei
9238005a73 MDL-79863 qtype_ordering: lang-file is sorted 2024-04-04 10:59:28 +08:00
M Kassaei
ee4edb506b MDL-79863 qtype_ordering: method_exists() not needed anymore in edit_ordering_form.php 2024-04-04 10:59:28 +08:00
M Kassaei
3ca76335a6 MDL-79863 qtype_ordering: Install.xml is loaded into XMLDB and then saved again 2024-04-04 10:59:28 +08:00
Gordon Bateson
8c7c9d055a MDL-79863 qtype_ordering: qtype_ordering remove deprecated jquery folder and amd/*.js files 2024-04-04 10:59:28 +08:00
Tim Hunt
d812ee087f MDL-79863 qtype_ordering: Fix a bug with keyboard control with multiple questions per page 2024-04-04 10:59:28 +08:00
Tim Hunt
393de4b871 MDL-79863 qtype_ordering: Show a dotted border around the entire list if the question is active 2024-04-04 10:59:28 +08:00
Tim Hunt
d876a38973 MDL-79863 qtype_ordering: Remove some unused code. 2024-04-04 10:59:28 +08:00
Tim Hunt
7eff0c7fdb MDL-79863 qtype_ordering: Add travis config for Moodle 3.6 2024-04-04 10:59:27 +08:00
Tim Hunt
59d28a856b MDL-79863 qtype_ordering: Ensure the new JavaScript works with any Moodle 2.9 or later
That is, since js_call_amd existed.
2024-04-04 10:59:27 +08:00
M Kassaei
0fdf194fab MDL-79863 qtype_ordering: Ordering qtype: rewrite JavaScript and add keyboard interaction
* This rewrite was mainly to add keyboard support, which is important
for accessibility.
* At the same time, the CSS was changed, to make the question appear
visually much more like the other core drag-drop question types.
* The new drag-drop code is based on the same underlying libraries that
the code drag-drop question types have been using since Moodle 3.6
* Unfortunately, so far we have only been able to make this work back to
Moodle 2.9.
2024-04-04 10:59:27 +08:00
Gordon Bateson
e885659edf MDL-79863 qtype_ordering: qtype_ordering add further details of contribution by Tim Hunt and Mahmoud Kassei of OU 2024-04-04 10:59:27 +08:00
Gordon Bateson
912e5646e9 MDL-79863 qtype_ordering: qtype/ordering add showgrading field to backup file 2024-04-04 10:59:27 +08:00
Gordon Bateson
52f064a5b6 MDL-79863 qtype_ordering: qtype/ordering (readme.txt) added credits for recent improvements: Thanks to Tim Hunt, Mahmoud Kassaei, and Dominique Bauer 2024-04-04 10:59:27 +08:00
Gordon Bateson
5aab59423e MDL-79863 qtype_ordering: qtype/ordering fix Github issue #36: remove contenteditable from LI element, and instead attach to ancestor element in DOM 2024-04-04 10:59:27 +08:00
Gordon Bateson
ce8a32b5b4 MDL-79863 qtype_ordering: qtype/ordering fix Github issue #36: draggable items become stuck to cursor when logged as student in Boost theme on Moodle 3.6 2024-04-04 10:59:27 +08:00
Gordon Bateson
50bc2c0f5d MDL-79863 qtype_ordering: qtype/ordering improve logic and of code to get_subset and code to add repeated elements to form 2024-04-04 10:59:27 +08:00
Gordon Bateson
33b360975b MDL-79863 qtype_ordering: qtype/ordering fix Github issue #35: Clicking Add to add items more than once without saving the question in between has incorrect and unwanted behavior 2024-04-04 10:59:27 +08:00