24294 Commits

Author SHA1 Message Date
Andrew Nicols
6092574ddf Merge branch 'MDL-61240' of git://github.com/stronk7/moodle 2018-01-22 11:36:41 +08:00
Andrew Nicols
0cc0f72ceb MDL-60078 behat: Convert ErrorException to DriverException 2018-01-22 11:29:29 +08:00
Andrew Nicols
60ce5848f6 Merge branch 'MDL-60078-master' of https://github.com/nashtechdev01/moodle 2018-01-22 11:08:19 +08:00
Eloy Lafuente (stronk7)
dba5826124 Merge branch 'MDL-50469-master' of git://github.com/junpataleta/moodle 2018-01-22 02:43:08 +01:00
Eloy Lafuente (stronk7)
5405354d88 MDL-61240 dml: php72 compatibility, avoid counting on non-countables
This was not detected earlier because we have been unable to
run sqlsrv + php72 till now (not available).
2018-01-19 00:59:16 +01:00
Eloy Lafuente (stronk7)
2ab36722f2 Merge branch 'MDL-53113-master' of git://github.com/junpataleta/moodle 2018-01-17 10:37:23 +01:00
Jun Pataleta
dd9c292700 MDL-53113 libraries: Add cleaned up PHP doc blocks 2018-01-17 10:52:16 +08:00
Eloy Lafuente (stronk7)
76f8b36105 MDL-53113 libraries: Also remove core_renderer->notify_xxx() methods
Keeping the methods instead of fully deleting them alternative.
2018-01-17 02:18:16 +01:00
Eloy Lafuente (stronk7)
0e68db9e83 MDL-41312 groups: documment final removal in upgrade.txt 2018-01-17 02:04:16 +01:00
Jun Pataleta
3f5cae3679 Merge branch 'MDL-61221-master' of git://github.com/andrewnicols/moodle 2018-01-16 23:00:59 +08:00
KietLy
26872a8006 MDL-60078 User tours accessibility: Tab should go back into the pop-up 2018-01-16 17:36:25 +07:00
Andrew Nicols
389aad6eef MDL-61221 badges: Ignore site availabilty for behat
Behat sites should not be available publically, and the check against
the backpack API for site availablity can time out in some situations.

We should be testing as though the site _is_ available, as this is the
standard expectation.
2018-01-16 13:21:51 +08:00
Andrew Nicols
174fbacc9b Merge branch 'MDL-60815-master' of git://github.com/ryanwyllie/moodle 2018-01-16 12:27:43 +08:00
Ryan Wyllie
bb8bb8e41c MDL-60815 theme: fix loading editor styles 2018-01-16 03:39:09 +00:00
Jun Pataleta
56c9d66652 MDL-50469 core: Update lib/upgrade.txt about notify() final deprecation 2018-01-16 11:34:00 +08:00
Ankit Agarwal
943e290059 MDL-50469 libraries: Final deprecation of notify() 2018-01-16 11:28:26 +08:00
Eloy Lafuente (stronk7)
d7ba45290b Merge branch 'MDL-61063-master' of https://github.com/sammarshallou/moodle 2018-01-15 22:02:08 +01:00
Ankit Agarwal
3becfcd226 MDL-53113 libraries: Remove deprecated constants 2018-01-15 20:19:07 +01:00
Shamim Rezaie
e4d3ed18ff MDL-61166 Groups: Fixed a typo in PHPDoc 2018-01-14 09:18:12 +11:00
sam marshall
470d59d31f MDL-61063 Scheduled tasks: Add link to clear fail delay 2018-01-12 11:10:29 +00:00
Cameron Ball
9aa776a848 MDL-61143 core_files: Don't append dot when checking domain names or IP addresses.
Previously we appended a dot at the end of IP addresses and domain names in the
cURL security helper, but it causes issues with Google OAuth so this patch removes it.
2018-01-10 15:22:17 +08:00
Andrew Nicols
6d019541ad Merge branch 'MDL-43648-int-fix-1' of github.com:ryanwyllie/moodle 2018-01-10 10:38:20 +08:00
Ryan Wyllie
9f421a184a MDL-43648 form: fix hours and minutes in date_time_selector 2018-01-10 02:28:19 +00:00
Andrew Nicols
168fc2d9ec Merge branch 'MDL-61061_hideif_group' of git://github.com/davosmith/moodle 2018-01-10 08:46:05 +08:00
Cameron Ball
4cca0082df MDL-61143 core_files: Update unit tests for curl_security_helper
Previously some of the unit tests were passing "by accident" becuase
we had the security helper letting through domains where the DNS lookup
failed. That behaviour has changed and now such domains are blocked.

Additionally tests for domains with multiple A records and weird Unicode
stuff have been added.

This patch also mocks the DNS resolution in the test, rather than actually
resolving the domain.
2018-01-09 16:54:32 +08:00
Cameron Ball
fbe7f1f8ba MDL-61143 core_files: Block hosts that cannot be determined to be an IP address of domain name
Freaky deaky Unicode/octal/hex domains can be resolved by cURL but are technically not valid.

This patch causes anything that Moodle does not consider to be a valid domain or IP to be blocked
by the cURL security helper.
2018-01-09 16:54:32 +08:00
Cameron Ball
cae2eb357d MDL-61143 core_files: Check all A records when testing blocked IPs 2018-01-09 16:54:32 +08:00
Andrew Nicols
61f56fd5f9 Merge branch 'MDL-43648_m35v2' of https://github.com/sbourget/moodle 2018-01-09 11:43:33 +08:00
Davo Smith
d5cd1496ce MDL-61061 formslib: make sure hideIf rules hide labels within groups 2018-01-03 13:05:58 +00:00
Mark Nelson
e8a1a5868a MDL-40613 auth_ldap: removed usage of profile_load_custom_fields()
Also reverted profile_load_custom_fields() signature and changed
behaviour of the new function profile_save_custom_fields().
2018-01-03 18:13:01 +08:00
Eloy Lafuente (stronk7)
ff9a93a8b6 Merge branch 'MDL-23887-master-2' of https://github.com/snake/moodle 2018-01-03 00:24:41 +01:00
Jake Dallimore
fa2a9cc933 MDL-23887 database: fix use of deprecated system tables for mssql
Catalog views are available which we should use instead.
2018-01-02 17:19:17 +08:00
Jun Pataleta
1588837a9d Merge branch 'MDL-40613_master' of git://github.com/markn86/moodle 2018-01-02 16:50:29 +08:00
David Monllao
6ffb51e74c Merge branch 'MDL-59813-master' of git://github.com/farhan6318/moodle 2018-01-02 09:03:03 +01:00
Farhan Karmali
c0aca8f3c7 MDL-59813 navigation: Changed 'more..' link to point to dashboard
In the navigation menu , the 'more' option was previously taking the user to all course page
This patch fixes that behavior and takes the user to the dashboard
2017-12-29 15:10:56 +05:30
Eloy Lafuente (stronk7)
bb3e956ed9 Merge branch 'MDL-60966-master' of https://github.com/snake/moodle 2017-12-27 17:54:58 +01:00
Eloy Lafuente (stronk7)
72614d74d8 Merge branch 'MDL-60981-master' of https://github.com/sammarshallou/moodle 2017-12-27 17:54:58 +01:00
David Monllao
3410ff644f Merge branch 'MDL-60942-master' of git://github.com/ryanwyllie/moodle 2017-12-27 17:54:54 +01:00
Eloy Lafuente (stronk7)
d048e94dfe Merge branch 'MDL-43827-master' of git://github.com/mihailges/moodle 2017-12-26 00:25:28 +01:00
sam marshall
8736fbc190 MDL-60981 core_search: New indexpriority field in search index queue
Adds indexpriority field to the database table which holds a queue of
indexing requests. This allows for potentially large area reindexes
to have a lower priority, so as not to halt the special indexes that
run after a course restore.
2017-12-22 13:05:10 +00:00
Ryan Wyllie
0377e78e36 MDL-60966 external: contexts can be passed to external format funcs 2017-12-22 13:10:39 +08:00
David Mudrák
7cdb4266e0 MDL-32113 xmldb: Fix and extend unit tests for XMLDB_TYPE_NUMBER
These tests describe the new behaviour of the XMLDB_TYPE_NUMBER fields.
2017-12-21 19:48:04 +01:00
David Mudrák
521252d642 MDL-32113 xmldb: Support numeric fields with precision up to 38 digits
The patch increases the maximum supported precision (total number of
digits) for numeric (decimal) fields to 38 digits (current limit on
Oracle and MSSQL).

Additionally, we add our own limit for the whole number part of numeric
fields so they are no longer than integer fields (20 digits). This is to
make it easier to eventually convert from one field type to another.
Note that PHP floats commonly support precision of roughly 15 digits
anyway.
2017-12-21 19:48:03 +01:00
David Mudrák
457eaef9ec MDL-32113 xmldb: Remove hard-coded exceptions for long number fields
We are going to unify the maximum supported precision of all numeric
fields to 38 digits (which are the current Oracle and MSSQL limits). Get
rid of hard-coded exceptions for longer fields.
2017-12-21 15:37:08 +01:00
Mihail Geshoski
f44f9db418 MDL-43827 filepicker: Multiple actions not accessible using keyboard 2017-12-21 14:06:25 +08:00
Jun Pataleta
8403325c9e MDL-50666 core: Add sortorder to fields to be queried 2017-12-20 15:43:19 +13:00
Jun Pataleta
10c607a9bc MDL-50666 core: Add allowview key in install.xml 2017-12-20 14:46:42 +13:00
Jun Pataleta
a8dffa2d03 Merge branch 'MDL-50666-master' of https://github.com/junpataleta/moodle 2017-12-20 12:49:28 +13:00
Davo Smith
c62f0a396b MDL-61061 formslib: add data-groupname to groups to fix hideIf rules 2017-12-19 10:47:54 +00:00
Mark Nelson
4afad1faeb MDL-40613 auth: moved lang string to common auth file
Also fixed call to get_string() and defined var 'errorlogtag'
in base class.

AMOS BEGIN
 MOV [auth_dbusernotexist,auth_db],[auth_usernotexist,auth]
AMOS END
2017-12-19 14:13:35 +08:00