321 Commits

Author SHA1 Message Date
Tim Hunt
06f87d2f57 quiz: MDL-15452 fix themes breakage found when preparing my MoodleMoot talk. 2010-05-01 08:14:32 +00:00
Tim Hunt
59be14de39 questionlib: MDL-21828 Fix database query that does not work in Oracle.
Bug report and fix thanks to David Binney.
2010-04-07 09:47:19 +00:00
David Mudrak
16be897441 MDL-21652 html_table rendering refactored
* class html_component does not exist any more
* class html_table rendered via html_writer::table()
* html_table, html_table_row and html_table_cell have public $attributes property to set their CSS classes
* dropped rotateheaders feature, should be added again after more research of possible ways (<svg> is not nice IMHO)
* dropped possibility to define CSS classes for table heading, body and footer - can be easily done and better done using just table class and context
2010-03-20 22:15:54 +00:00
Petr Skoda
94fa6be479 MDL-20204 more single_selects converted 2010-02-10 11:51:49 +00:00
Tim Hunt
0b8506ec85 question state loading MDL-9327 and MDL-19114 fix loading the state of ungraded essay questions
In two situations, the correct state was not being loaded for essay questions that had
not yet been manually graded:
1. When starting a subsequent attempt in each attempt builds on last mode.
2. In the quiz reports.

This commit fixes the problem. It has one other side-effect. When viewing the individual
question grades in the overview report for an attempt that is still in progress, the
information displayed will be slightly different. This only affects adaptive mode quizzes,
and will acutally cause the report to show slighly more up-to-date information.

Interestingly, the reportlib.php change had already been made in HEAD, as part of MDL 16529
2010-02-05 16:37:01 +00:00
Petr Skoda
9dec75dbcc MDL-21240 shortened urls now start with / everywhere 2010-01-18 20:57:32 +00:00
Petr Skoda
8afba50b84 MDL-21233 get_query_string() is definitely not recommended in new code, instead use moodle_url constructors with proper parameters; removed some more legacy url concatenation operations; realized out_action is not needed often, because we shoudl pass arounf moodle_url instances instead of old url strings 2010-01-17 10:54:13 +00:00
Petr Skoda
6770330d17 MDL-21235 support for optgroups in select 2010-01-16 19:48:01 +00:00
Petr Skoda
b5d0cafc6f MDL-20787 final switch to new $OUTPUT->pix_url() - yay! 2009-12-16 21:50:45 +00:00
Petr Skoda
f44b10ed93 MDL-21139 replace all yui functions/methods with yui2 to make room for yui3 2009-12-16 20:25:14 +00:00
Petr Skoda
117bd74897 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 11:31:16 +00:00
nicolasconnault
3bd6b994fc MDL-19799 Upgraded calls to link_to_popup_window() 2009-08-20 13:18:08 +00:00
nicolasconnault
642816a60c MDL-19799 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno 2009-08-20 08:50:50 +00:00
nicolasconnault
aa9a686740 MDL-19799 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:20:12 +00:00
nicolasconnault
7b1f2c829f MDL-19756 Renamed moodle_select to html_select for better API consistency 2009-08-10 08:38:45 +00:00
nicolasconnault
641454c6b2 MDL-19799 Upgraded calls to choose_from_menu_nested 2009-08-06 00:35:06 +00:00
tjhunt
d4a03c00ea themes & blocks - MDL-19077 & MDL-19010 blocks are now printed by the theme
The code to print blocks in now in theme layout.php files. (Or in
moodle_core_renderer::handle_legacy_theme)

Code for printing blocks everywhere else has been stripped out.
(Total diffstat 1225 insertions, 2019 deletions)

The way the HTML for a block instance is generated has been cleaned
up a lot. Now, the block_instance generates a block_contents
object which gives a structured representation of the block,
and then $OUTPUT->block builds all the HTML from that.

How theme config.php files specify the layout template and block
regions by page general type has been changed to be even more flexible.

Further refinement for how the theme and block code gets initialised.

Ability for scrits to add 'pretend blocks' to the page. That is,
things that look like blocks, but are not normal block_instances.
(Like the add a new block UI.)

Things that are still broken:
 * some pages in lesson, quiz and resource. I'm working on it.
 * lots of developer debug notices pointing out things that
   need to be updated.
2009-07-09 07:35:03 +00:00
tjhunt
ddedf979b4 MDL-19690 - more $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-03 06:19:25 +00:00
tjhunt
34a2777ccb themes: MDL-19077 new $OUTPUT->header/footer to replace print_header/footer.
Also, part of the change from weblib.php functions to $OUTPUT-> methods.

This is part of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F

This is a big change, and the result is not perfect yet. Expect some debugging output
on some pages.

The main part of these changes are that $OUTPUT->header now looks for a file
in the theme called layout.php, rather than header.html and footer.html. Also
you can have special templates for certain pages like layout-home.php. There is
fallback code for Moodle 1.9 themes, so they still work.

A few of the old arguments to print_header are no longer supported. (You get an
exception if you try to use them.) Sam H will be cleaning those up.

All the weblib functions that have been replaced with $OUTPUT-> have version in
deprecatedlib, so existing code will go on working for the foreseeable future.
2009-06-26 09:06:16 +00:00
arborrow
b0ea27b441 MDL-19950 - check for format type name in qformat if not found in quiz.php lang file 2009-06-21 04:29:37 +00:00
skodak
17da2e6f28 MDL-16438 centralise information about plugins to avoid duplication, includes local customisation conversion to standard plugin structure + fixes for some recent regressions; see tracker for more details and links to docs and forums discussions 2009-06-19 14:25:56 +00:00
tjhunt
25ddb7efc9 javascript: MDL-19475 replace require_js calls with $PAGE->requires->js.
This is the final batch.
2009-06-15 07:57:53 +00:00
tjhunt
c28bf5c9f8 javascript: MDL-19475 replace require_js calls with $PAGE->requires->js.
Also, some related JavaScript cleanup.

More to follow.
2009-06-15 05:37:57 +00:00
skodak
fc29e51b2d MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 18:34:43 +00:00
skodak
a8f3a651c0 MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 18:16:08 +00:00
skodak
bb4b6010f3 MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:17:10 +00:00
tjhunt
cf6155226c ajaxlib/require_js: MDL-16693 $PAGE->requires->... deprecates require_js etc.
There is a new implementation of require_js in lib/deprecatedlib.php,
based on $PAGE->requires.

There were a few other recently introduced functions in lib/weblib.php,
namely print_js_call, print_delayed_js_call, print_js_config and
standard_js_config. These have been removed, since they were never in
a stable branch, and all the places that used them have been changed
to use the newer $PAGE->requires->... methods.

get_require_js_code is also gone, and the evil places that were calling
it, even though it is an internal function, have been fixed.

Also, I made some minor improvements to the code I committed yesterday
for MDL-16695.

All that remains is to update all the places in core code that are
still using require_js.

(This commit also fixes the problem where the admin tree would not
start with the right categories expanded.)
2009-06-12 12:13:07 +00:00
skodak
a8d6ef8c6c MDL-18293 $DB->somethiong is using exceptions, no need for ifs there, removing useless strings 2009-06-03 20:16:20 +00:00
skodak
bf8e93d704 MDL-18293 $DB->somethiong is using exceptions, no need for ifs tehre, removing useless strings 2009-06-03 20:00:08 +00:00
samhemelryk
50fcb1d835 lib MDL-19236 Added boilerplates and copyrights 2009-05-26 03:23:32 +00:00
tjhunt
50da63ebd9 qtypes: MDL-18711 Allow qtype plugins to have custom CSS and JavaScript on the editing page. 2009-03-30 09:15:46 +00:00
tjhunt
574c37507f random essay questions: MDL-8648 fix merge problem. 2009-03-26 01:54:40 +00:00
tjhunt
80f7bafdab question bank: MDL-18531 Sorry, capability name typo. 2009-03-18 05:33:56 +00:00
tjhunt
353b2d700d question bank: MDL-18531 if someone can use questions in the quiz context, but not the course context, choose a more sensible default category in the question bank. Merged from MOODLE_19_STABLE. 2009-03-18 05:02:27 +00:00
tjhunt
84e628a027 quiz settings: MDL-18485 Improve quiz settings form
* Reorder form fields to group things more logically.
** and on the corresponding admin page too.

* Set some options to be 'Advanced' by default:
** Apply penalties.
** Each attempt builds on the last.
** Decimal places for question grades.
** The five 'Extra restrictions on attempts' settings. (password, etc.)
* Admins can still change this to suit their institiution at Administration > Plugins > Activity modules > Quiz.
* These new defaults are applied if the admin had not previously set any fields to be advanced.

* Disable some filds when they are not applicable:
** Grading method, if num attempts = 1
** Penaly scheme, if adaptive mode = no
** Each attempt builds of last, if num attempts = 1
** Review after quiz closed options, if no close date.
** Delay between 1st and 2nd attempts, if num attempts = 1
** Delay between later attempts, if num attempts < 3

* Convert quiz.timelimit to be in seconds, for consistency, and ready for the new duration field type (MDL 18500).
** Including ensuring that backup and restore is backwards compatible.

* MDL-5537 New setting, questiondecimalpoints, so, for example, you can show the quiz grade as an integer, but have fractional question grades.
** There is a 'Same as overall decimal points' option, which is the default.

* Improve some field labels.

* Make corresponding changes in the help files.
2009-03-10 08:39:51 +00:00
tjhunt
af52eceef4 qtype admin: MDL-18425 also related to MDL-18355.
Allow question types  to be displayed in order that is better than random or alphabetical. Since we don't know all the qtypes there may be:
1. Store the order in the DB (config plugins).
2. Set up a good default order for the standard types. (Unknown types go at the end by default.)
3. Allow admins to edit the order on the qtype admin screen.
2009-03-03 07:47:32 +00:00
tjhunt
7f92f0ad39 quiz editing: MDL-18355 further refinements to the UI. 2009-03-03 05:13:53 +00:00
tjhunt
a781921fd0 question bank: MDL-16412 Allow admins to enable/disable of each question type 2009-02-25 09:31:49 +00:00
tjhunt
f3409e53a0 questionlib: fix typo. 2009-02-25 06:12:55 +00:00
tjhunt
d11de005c6 question bank: MDL-16345 Assorted small efficiency gains. 2009-02-13 06:27:08 +00:00
tjhunt
c599a68240 question bank: MDL-12787, MDL-17870 field in the question editing form to tag questions, and load and save the tags from the DB. 2009-01-16 08:00:06 +00:00
tjhunt
83f0fef567 questions manual grading: MDL-15147 refine the logic for distinguishing '' and 0, so you can grade an essay 0 without making a comment, but also, grade some, but not all student's work in the manual grading report. 2008-12-12 09:00:11 +00:00
tjhunt
47ceac47e4 questionlib: clarify a comment. 2008-12-12 02:50:36 +00:00
tjhunt
3c573960ec question bank: MDL-14376 Errors deleting a course containing Cloze questions.
(For some reason, this only seemed to cause problems on MySQL.)
2008-12-11 05:31:33 +00:00
tjhunt
e8f99abc68 quiz manual grading: MDL-5517 manual grading pop-up is too small. HTML editor does not fit. Merged from MOODLE_19_STABLE.
Also MDL-17585 Improve layout of manual grading forms to make them look more like formslib forms. The standard trick of stealing the HTML and class names that formslib works, so the standard style rules apply to your form.
2008-12-10 09:11:30 +00:00
tjhunt
426091ee1f Simple whitespace cleanup. 2008-12-10 05:32:51 +00:00
tjhunt
f24493ec9b random essay questions: MDL-8648 Allow essay questions to be selected by random question.
In the 1.9 branch this is controlled by a new option under Admin -> Experimental. In Moodle 2.0 dev it is not optional, it just works.

The main change is letting the manual grading report know which random questions might need manual grading. MDL-4004 - this depends on the random question under consideration, which requires a new questiontype method.

I also changed the random question code so that I could remove some global variables.
2008-11-28 06:07:11 +00:00
tjhunt
df4e224454 question bank: MDL-14434 Cannot edit the only question category in a context. 2008-11-27 11:50:29 +00:00
tjhunt
24ada7b2b6 Yay! found a global variable that was not being used anywhere. Kill! Kill! 2008-11-26 08:55:24 +00:00
jamiesensei
91ec2c427a MDL-17183 "function 'question_get_real_state' fails when response is empty string" fixed regular expression 2008-11-10 07:03:25 +00:00