2789 Commits

Author SHA1 Message Date
Tim Hunt
0eafc98852 MDL-29627 fix code-checker issues throughout the quiz code. 2011-10-13 11:13:16 +01:00
Tim Hunt
1d9e1a3c06 MDL-29627 refactor the way the rules are constructed from the quiz. 2011-10-13 11:13:14 +01:00
Tim Hunt
d755b0f577 MDL-29627 quiz_access_manager move all output code to the renderer.
This achieves a massive clean-up. It simplifies comples code in a number
of places. It allows some methods and functions to be moved to a more
appropriate home (for example cannot_review_message to the quiz class).
It moves more logic out of the renderer.
2011-10-13 11:13:12 +01:00
Tim Hunt
dd70d561ef MDL-29627 quiz load access settings when a quiz is being attempted. 2011-10-13 11:13:10 +01:00
Tim Hunt
c18ba64c3e MDL-29627 load the existing settings when the quiz settings are re-edited. 2011-10-13 11:13:08 +01:00
Tim Hunt
b83c32d39f MDL-29627 quiz access plugins can add fields to mod_form and save the data. 2011-10-13 11:13:06 +01:00
Tim Hunt
ea38245cfb MDL-29627 quiz access: move the unit tests into the relevant plugins. 2011-10-13 11:13:04 +01:00
Tim Hunt
e5844040a0 MDL-29627 quiz access: fix variable names that don't match the coding style. 2011-10-13 11:13:02 +01:00
Tim Hunt
a28a5d74af MDL-29627 refactor quiz access rules into separate subplugins. 2011-10-13 11:13:00 +01:00
Sam Hemelryk
d87ef08598 Merge branch 'MDL-29447' of git://github.com/timhunt/moodle 2011-10-11 10:25:33 +13:00
Eloy Lafuente (stronk7)
202c2032fa Merge branch 'MDL-28469' of git://github.com/timhunt/moodle 2011-10-05 01:13:57 +02:00
Tim Hunt
8dd9ccf475 MDL-29447 quiz course reset does not reset the quiz_grades table.
Thank to Jean-Michel Vedrine for working out the basic idea of the fix.
2011-10-04 22:47:44 +01:00
Eloy Lafuente (stronk7)
c72cf85f17 Merge branch 'MDL-29511' of git://github.com/timhunt/moodle 2011-10-04 01:11:20 +02:00
Tim Hunt
e07cccfc25 MDL-28469 quiz settings pages should be pagelayout admin. 2011-10-03 16:38:34 +01:00
Tim Hunt
c3584ad683 MDL-29511 Fix problems on the quiz review questions page found while investigating this bug. 2011-09-29 21:46:39 +01:00
Tim Hunt
72bbb091a4 MDL-29570 Quiz editing page displays the wrong time in the status line sometimes. 2011-09-29 09:06:11 +01:00
Sam Hemelryk
87eca3192f Merge branch 'MDL-28424' of git://github.com/timhunt/moodle.git with changes 2011-09-27 11:24:02 +13:00
Eloy Lafuente (stronk7)
1a8ab39b3c Merge branch 'MDL-29427' of git://github.com/timhunt/moodle 2011-09-26 21:47:40 +02:00
Aparup Banerjee
94f59561ad Merge branch 'MDL-29464' of git://github.com/timhunt/moodle 2011-09-26 14:32:52 +08:00
Tim Hunt
79a46626d3 MDL-29427 quiz nav: information items should should have a state tooltip 2011-09-22 18:12:43 +01:00
Tim Hunt
572a96edb0 MDL-29428 quiz navigation panel should use 'This page' (accessibility improvement) 2011-09-22 17:56:02 +01:00
Tim Hunt
fabface827 MDL-29464 quiz add random question popup does not update sumgrades. 2011-09-21 16:39:31 +01:00
Tim Hunt
babfb615c9 MDL-28424 Reviewing a quiz in 'secure mode' gives a fatal error.
The problem was when output was being started in relation to when the fake block was added.

Took the opportunity to clean up the quiz renderer API a bit.
2011-09-21 16:37:21 +01:00
Eloy Lafuente (stronk7)
0e89333992 Merge branch 'MDL-26567' of git://github.com/timhunt/moodle 2011-09-21 00:10:30 +02:00
Tim Hunt
71c4154a98 MDL-26567 no grade category option on the quiz settings form.
Also, refine the standard_grading_coursemodule_elements method to add a
help string.

AMOS BEGIN
 CPY [gradecategory,grades],[gradecategoryonmodform,grades]
AMOS END
2011-09-20 11:10:34 +01:00
Eloy Lafuente (stronk7)
9d8d55a00e Merge branch 'w37_MDL-29029_m22_admintools' of git://github.com/skodak/moodle 2011-09-19 18:26:55 +02:00
Petr Skoda
b412f9c4c9 MDL-29029 move all the simpletest bits into new tool unittest
AMOS BEGIN
 MOV [pluginname,report_unittest],[pluginname,tool_unittest]
 MOV [unittest:view,report_unittest],[unittest:execute,tool_unittest]
 MOV [dbtest,core_admin],[dbtest,tool_unittest]
 MOV [addconfigprefix,core_simpletest],[addconfigprefix,tool_unittest]
 MOV [all,core_simpletest],[all,tool_unittest]
 MOV [codecoverageanalysis,core_simpletest],[codecoverageanalysis,tool_unittest]
 MOV [codecoveragecompletereport,core_simpletest],[codecoveragecompletereport,tool_unittest]
 MOV [codecoveragedisabled,core_simpletest],[codecoveragedisabled,tool_unittest]
 MOV [codecoveragelatestdetails,core_simpletest],[codecoveragelatestdetails,tool_unittest]
 MOV [codecoveragelatestreport,core_simpletest],[codecoveragelatestreport,tool_unittest]
 MOV [confignonwritable,core_simpletest],[confignonwritable,tool_unittest]
 MOV [coveredlines,core_simpletest],[coveredlines,tool_unittest]
 MOV [coveredpercentage,core_simpletest],[coveredpercentage,tool_unittest]
 MOV [deletingnoninsertedrecord,core_simpletest],[deletingnoninsertedrecord,tool_unittest]
 MOV [deletingnoninsertedrecords,core_simpletest],[deletingnoninsertedrecords,tool_unittest]
 MOV [droptesttables,core_simpletest],[droptesttables,tool_unittest]
 MOV [exception,core_simpletest],[exception,tool_unittest]
 MOV [executablelines,core_simpletest],[executablelines,tool_unittest]
 MOV [fail,core_simpletest],[fail,tool_unittest]
 MOV [ignorefile,core_simpletest],[ignorefile,tool_unittest]
 MOV [ignorethisfile,core_simpletest],[ignorethisfile,tool_unittest]
 MOV [installtesttables,core_simpletest],[installtesttables,tool_unittest]
 MOV [moodleunittests,core_simpletest],[moodleunittests,tool_unittest]
 MOV [notice,core_simpletest],[notice,tool_unittest]
 MOV [onlytest,core_simpletest],[onlytest,tool_unittest]
 MOV [pass,core_simpletest],[pass,tool_unittest]
 MOV [pathdoesnotexist,core_simpletest],[pathdoesnotexist,tool_unittest]
 MOV [prefix,core_simpletest],[prefix,tool_unittest]
 MOV [prefixnotset,core_simpletest],[prefixnotset,tool_unittest]
 MOV [reinstalltesttables,core_simpletest],[reinstalltesttables,tool_unittest]
 MOV [retest,core_simpletest],[retest,tool_unittest]
 MOV [retestonlythisfile,core_simpletest],[retestonlythisfile,tool_unittest]
 MOV [runall,core_simpletest],[runall,tool_unittest]
 MOV [runat,core_simpletest],[runat,tool_unittest]
 MOV [runonlyfile,core_simpletest],[runonlyfile,tool_unittest]
 MOV [runonlyfolder,core_simpletest],[runonlyfolder,tool_unittest]
 MOV [runtests,core_simpletest],[runtests,tool_unittest]
 MOV [rununittests,core_simpletest],[rununittests,tool_unittest]
 MOV [showpasses,core_simpletest],[showpasses,tool_unittest]
 MOV [showsearch,core_simpletest],[showsearch,tool_unittest]
 MOV [skip,core_simpletest],[skip,tool_unittest]
 MOV [stacktrace,core_simpletest],[stacktrace,tool_unittest]
 MOV [summary,core_simpletest],[summary,tool_unittest]
 MOV [tablesnotsetup,core_simpletest],[tablesnotsetup,tool_unittest]
 MOV [testdboperations,core_simpletest],[testdboperations,tool_unittest]
 MOV [testtablescsvfileunwritable,core_simpletest],[testtablescsvfileunwritable,tool_unittest]
 MOV [testtablesneedupgrade,core_simpletest],[testtablesneedupgrade,tool_unittest]
 MOV [testtablesok,core_simpletest],[testtablesok,tool_unittest]
 MOV [thorough,core_simpletest],[thorough,tool_unittest]
 MOV [timetakes,core_simpletest],[timetakes,tool_unittest]
 MOV [totallines,core_simpletest],[totallines,tool_unittest]
 MOV [uncaughtexception,core_simpletest],[uncaughtexception,tool_unittest]
 MOV [uncoveredlines,core_simpletest],[uncoveredlines,tool_unittest]
 MOV [unittestprefixsetting,core_simpletest],[unittestprefixsetting,tool_unittest]
 MOV [unittests,core_simpletest],[unittests,tool_unittest]
 MOV [updatingnoninsertedrecord,core_simpletest],[updatingnoninsertedrecord,tool_unittest]
 MOV [version,core_simpletest],[version,tool_unittest]
AMOS END
2011-09-17 19:43:00 +02:00
Tim Hunt
73a7a0c90d MDL-29360 quiz comment.php has broken JS for the Cancel button.
This swtichest it to more modern YUI3 approach.
2011-09-16 12:03:46 +01:00
Sam Hemelryk
8ebbb06adf MDL-29189 mutlilang Reviewed the uses of course shortname and ensured things are being formatted consistently 2011-09-08 09:30:27 +12:00
sam marshall
3e4c243500 MDL-27001 'Show description' feature part 3: Implementation for all modules
For modules that still used the 'old' generic object return from _get_coursemodule_info instead of returning a cached_cm_info object, I changed them to use the new format as part of this. This made a few areas of code regarding onclick links slightly nicer.
2011-09-06 11:03:06 +01:00
Eloy Lafuente (stronk7)
bae0925b4d Merge branch 'MDL-29141' of git://github.com/timhunt/moodle 2011-08-29 13:00:21 +02:00
Aparup Banerjee
a1b744594c Merge branch 'MDL-29144' of git://github.com/timhunt/moodle 2011-08-29 12:10:30 +08:00
Eloy Lafuente (stronk7)
c45eca3f06 Merge branch 'MDL-26302' of git://github.com/timhunt/moodle 2011-08-29 03:22:02 +02:00
Sam Hemelryk
e57bbf55ab Merge branch 'MDL-26819' of git://github.com/stronk7/moodle 2011-08-29 13:05:00 +12:00
Eloy Lafuente (stronk7)
1ccfd8dcbf MDL-26819 quiz statistics - use cross-db GROUP BY expression 2011-08-28 22:12:40 +02:00
Tom Cubanski
14bf45747d MDL-26302 quiz editing: top move button on the order and paging tab does not work.
It is strange that processes the submission already handles the submitted data from this change to the HTML.
2011-08-27 08:20:46 +01:00
M Kassaei
f28ef47e8f MDL-29144 quiz navigation: Screen-readers speak question state twice 2011-08-26 19:10:08 +01:00
Tim Hunt
918776f47d MDL-29111 quiz was passing 0 to ->review_url when it should have been null. 2011-08-26 18:21:43 +01:00
Tim Hunt
e20ad67d7b MDL-29141 question bank show question text checkbox does not match state. 2011-08-26 17:01:06 +01:00
Eloy Lafuente (stronk7)
0a4ca115b2 Merge branch 'w33_MDL-26796_m22_arrayparams' of git://github.com/skodak/moodle 2011-08-24 14:06:22 +02:00
Eloy Lafuente (stronk7)
2ed28439f6 Merge branch 'MDL-28976' of git://github.com/timhunt/moodle 2011-08-24 12:57:16 +02:00
Aparup Banerjee
553d343bf2 Merge branch 'w33_MDL-28982_m22_sqlfullname' of git://github.com/skodak/moodle 2011-08-24 03:03:50 +08:00
Eloy Lafuente (stronk7)
4abd7a07e1 Merge branch 'MDL-28996' of git://github.com/timhunt/moodle 2011-08-23 10:41:17 +02:00
Petr Skoda
1c8c6c34fd MDL-28982 fix DML use 2011-08-21 15:38:46 +02:00
Tim Hunt
a47a46f136 MDL-28996 Quiz view page list of attempts table is sometimes missing a cell. 2011-08-18 19:26:30 +01:00
Tim Hunt
45e5fbe11e MDL-28976 quiz was passing 0 to ->attempt_url when it should have been null.
There was also one other incorrect call that is fixed in this commit.
2011-08-18 14:00:30 +01:00
Tim Hunt
13bbfebc75 MDL-28226 quiz locallib. Fix PHPdoc comment and code to make the API clearer. 2011-08-18 13:58:14 +01:00
Petr Skoda
18bd7573d6 MDL-26796 convert array parameter cleaning to new functions 2011-08-18 08:40:33 +02:00
Eloy Lafuente (stronk7)
e1314fe345 Merge branch 'MDL-21934' of git://github.com/timhunt/moodle 2011-08-17 01:28:41 +02:00
Eloy Lafuente (stronk7)
78fe1bad47 Merge branch 'MDL-28365' of git://github.com/timhunt/moodle 2011-08-16 13:03:02 +02:00