158 Commits

Author SHA1 Message Date
Damyon Wiese
80b6f3b059 Merge branch 'MDL-60945' of https://github.com/NeillM/moodle 2017-12-12 11:31:16 +08:00
Neill Magill
3acb294828 MDL-60945 Web services: Too many progress records retrieved
The core_completion_get_activities_completion_status was getting the
progress for all users on the course called, and then discarding all
the records but one.

This change ensures that only progress for the user we are interested in
is retrieved from the database.

This has a side benefit of removing a full table scan from the query
finding the users inside the get_progress_all() method.
2017-12-11 08:41:16 +00:00
Mihail Geshoski
d381732329 MDL-54021 blocks: Course completion block lang problem 2017-12-08 09:24:03 +08:00
Pau Ferrer Ocaña
15ead7a176 MDL-60835 completion: Add overrideby field to completion status WS 2017-11-16 16:35:43 +01:00
Damyon Wiese
a66de3ca70 MDL-59909 calendar: Try hard not to fail the adhoc task.
Triggering a fatal error in an adhoc task is bad. It will be retried indefinitely.
Even though we are not sure how to get a module instance without a course module record,
it is possible and should not kill the Moodle site.
2017-10-25 15:42:14 +08:00
Jake Dallimore
b08337c35e MDL-37361 completion: Consolidate icon logic and clarify web service
- Icon generation logic moved to the course renderer.
- Web service should return the completion info only, not HTML.
- JS modified to handle icon rendering in relevant cases.
2017-10-10 17:12:22 +08:00
Jake Dallimore
8fbc41d8d5 MDL-37361 completion: minor code fixes. 2017-10-10 17:12:09 +08:00
Jake Dallimore
77165c9c83 MDL-37361 behat: added a test covering the activity completion report 2017-10-10 17:11:32 +08:00
Jake Dallimore
6f4adc6be4 MDL-37361 completion: make completion overrides visible to students
- Set icons in the course/renderer
- Use 'set' in lang strings for simplicity
- Code style fixes
2017-10-10 17:11:13 +08:00
Jake Dallimore
86f359bf68 MDL-37361 completion: automatic completion disabled when overridden
Changes:
- Activities with auto completion and a completion status overridden to
COMPLETION_COMPLETE are no longer processed by normal completion
triggers.
- All activities can still be completed by students when their
completion status has been overridden to COMPLETION_INCOMPLETE, via
either auto or manual triggers.
- Completion unit tests updated
2017-10-10 17:10:49 +08:00
Eiz Eddin Al Katrib
60a6b36cd5 MDL-37361 completion: Modified and Added phpunit tests 2017-10-10 17:10:37 +08:00
Eiz Eddin Al Katrib
a39918daae MDL-37361 completion: Enabled overriding activity completion status 2017-10-10 17:10:15 +08:00
David Monllao
7190f330b4 Merge branch 'MDL-59602_coursenav' of https://github.com/mrmark/moodle 2017-07-31 13:21:09 +02:00
Ankit Agarwal
65f15cd277 MDL-58906 completion: Fix incorrect phpdoc 2017-07-24 11:17:54 +05:30
Mark Nielsen
197e2bca5b MDL-59602 behat: make use of new course nav steps 2017-07-21 13:50:47 -07:00
Adrian Greeve
190d4ecf1e MDL-59287 core_completion: Bulk completion now updates events. 2017-07-10 09:40:02 +08:00
Adrian Greeve
190646bd75 MDL-59287 core_completion: Update to unit tests. 2017-07-10 09:40:02 +08:00
Adrian Greeve
1930749f46 MDL-59287 core_completion: Update API to use less DB calls. 2017-07-10 09:40:01 +08:00
Damyon Wiese
ddce4f4ba9 MDL-58136 cache: Add a course completion cache
The last change added 1 db read per course per page which is not OK. Add a cache to compensate.
2017-06-13 10:03:00 +08:00
Eloy Lafuente (stronk7)
2df7f223b8 MDL-58749 lang: fix couple of scenarios to use new lang string 2017-05-04 23:46:46 +02:00
Marina Glancy
694502b611 MDL-58138 completion: manual completion may have expected date 2017-04-21 15:01:32 +08:00
Marina Glancy
6c48135896 MDL-58138 completion: mform wants 0-based indexes for arrays 2017-04-20 13:49:56 +08:00
Jake Dallimore
273d310601 MDL-58138 completion: Fixes for a number of small issues. 2017-04-19 11:41:57 +08:00
Marina Glancy
32b93ea7f8 MDL-58138 completion: changes after rebasing
The defaults for the completion have been changed in MDL-55611
2017-04-19 08:56:11 +08:00
Marina Glancy
61167c16d0 MDL-58460 mod_data: work with bulk completion API
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Marina Glancy
6445f17bfc MDL-58408 completion: can not require grade if grading is not available
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore
22002ed74b MDL-58138 completion: consolidate bulk edit notifications to single call
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore
5976f85c95 MDL-58138 completion: move new lang strings to the completion lang file
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore
6b3b9c1d02 MDL-58138 completion: rebase on font-awesome changes.
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore
b17ee68202 MDL-58138 completion: Assorted linting fixes.
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Jake Dallimore
8db355c58f MDL-58138 tests: unit and behat tests covering bulk and default tabs
Part of MDL-58138 epic
2017-04-19 08:56:11 +08:00
Marina Glancy
a64a9f9ce4 MDL-58267 completion: style and capabilities cleanup
Part of MDL-58138 epic
2017-04-19 08:54:35 +08:00
Marina Glancy
7f53e8aa22 MDL-58267 completion: allow to set default activity completion
Part of MDL-58138 epic
2017-04-19 08:54:35 +08:00
Marina Glancy
06cdda468a MDL-58139 completion: bulk update completion
Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Marina Glancy
0cbc248dd3 MDL-58140 completion: access control refinements
Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Adrian Greeve
e8a71f8509 MDL-58140 completion: Default completion page.
Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Adrian Greeve
0b6208018f MDL-58140 completion: Added bulk activity completion page.
Part of MDL-58138 epic
2017-04-19 08:52:57 +08:00
Mark Nelson
e1cd93ce20 MDL-58423 core_calendar: moved \core_calendar\event class
Part of MDL-55611 epic.
2017-04-04 11:01:49 +01:00
Mark Nelson
4477520e5a MDL-58371 core_completion: ensure calendar constant is defined
Part of MDL-55611 epic.
2017-04-03 11:37:09 +08:00
Mark Nelson
7925aab94f MDL-57878 core_completion: added unit tests for new API
Part of MDL-55611 epic.
2017-04-03 11:37:09 +08:00
Mark Nelson
45d00aab43 MDL-57878 core_completion: added expected completion date function
Part of MDL-55611 epic.
2017-04-03 11:37:09 +08:00
Jun Pataleta
2c1a1b15b1 MDL-58102 completion: Behat fix
Part of MDL-55611 epic.
2017-04-03 11:37:08 +08:00
Simey Lameze
fdeeaff954 MDL-58265 core_test: replace I turn editing on steps
Also remove few more unnecessary steps that redirects behat to
site home page to actually get to the course.

Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Simey Lameze
c987d1b2ef MDL-58265 core_test: replace all uses of I follow course steps
Part of MDL-55611 epic.
2017-04-03 11:37:07 +08:00
Ryan Wyllie
3f0c421b22 MDL-57501 block_myoverview: add completion progress to renderables
Part of MDL-55611 epic.
2017-04-03 11:36:33 +08:00
Mark Nelson
5b3c691fd5 MDL-57443 core_completion: added API to retrieve completion progress
Part of MDL-55611 epic.
2017-04-03 11:36:07 +08:00
Damyon Wiese
8857c715d1 MDL-40759 icons: Behat fixes for font-awesome 2017-03-17 15:52:18 +08:00
Jake Dallimore
5a24e2177e MDL-57583 completion: fix bug with advcheckbox in course completion form
Added the appropriate checks to handle the advcheckbox post data.
2017-03-13 09:17:55 +08:00
Marina Glancy
3f9503468f MDL-4782 course: Behat tests for stealth mode support 2017-02-14 16:38:08 +08:00
Eloy Lafuente (stronk7)
6214e08f6a Merge branch 'MDL-57629-master' of git://github.com/jleyva/moodle 2017-01-17 20:55:05 +01:00