1189 Commits

Author SHA1 Message Date
Dan Poltawski
99fe296eb2 MDL-55168 css: remove 0-length units 2016-09-30 09:25:25 +01:00
Dan Poltawski
bc33e9bd3f MDL-55168 css: reformat plain css with stylefmt 2016-09-30 09:25:23 +01:00
Damyon Wiese
63e4df60f6 MDL-55839 behat: Behat fixes for theme_noname
This is a squash of many small fixes.
The list of changes are:

Initial set of behat selectors overrides required for new theme.

set core behat selectors if not overridden by theme

Remove pause

Fix for checkboxes not saving properly

Custom override for click in the user menu

Fix for behat guessing the field type.

Behat fix for guessing the correct field type.

Fix for missing closeElementBefore mforms mess.

Fix for textareas not displaying their contents.

Fix availability form element

Fix action menu selectors for activities in a course page

Fix textareas not retaining their values

Fix selector for blocks

I had to change the single select template to use an input instead of a button because of a
behat bug we have not tracked down yet.

Fix for frozen attribute in form elements

Use input instead of button while behat is still broken

Fix for navigation selector override

Behat selector fixes and multi-select fixes for templated select

Fix for configure blocks selector + booleans for autocomplete

Fixes for course_summary behat tests

Allow optgroups in single_select

Behat fixes for block_navigation

Fixes for url form element and activity chooser selectors

blocks_social - fix specific selector for behat

Fix export_for_template for selectgroups element.

Dont set empty id on the form

Fix direct call to behat_navigation in backup context

Checkbox empty value fix

Fix for assign grading panel popouts

file picker overrides to find a file manager in the page

Fix chat tests to use element name

Make selectors in mod_data behat less specific

MDL-55839: recent activity behat test relies on time()

SQUASH Honour mform element "class" attribute on the container

SQUASH Fixes for behat in mod_forum

SQUASH search form template showing value as text next to the button

SQUASH undo double selectgroup fix

SQUASH - The slightly different structure to action menus breaks course drag and drop

SQUASH Wrap loading icon in a span so the selector still works.

SQUASH Fix fragile javascript in report_loglive

SQUASH Fix tabtree, and selectgroups for mod_feedback

Also - do-not enhance the action menu - we are dropping support for this.

SQUASH Fix filemanager selector and pix_icon template for mod_forum tests.

SQUASH Fixes to breadcrumb and add formid to single select (fixes mod_glossary tests)

SQUASH lesson behat fixes. 95% of lesson styles were rubbish so they were disgarded.

SQUASH Fix lti behat tests - they were cheating and using a context step from quiz

SQUASH Behat fixes for quiz with new theme

SQUASH behat fixes for mod_wiki

SQUASH Workshop behat fixes

SQUASH Frozen form elements cannot use a readonly form element because it screws with the form JS "disabledIf" stuff.

SQUASH Fixes for grades behat tests

SQUASH behat fixes for groups

SQUASH blacklist action menu tests

SQUASH Fix for tag form element missing "manage standard tags" link

SQUASH Incomplete fixes for course behat tests

SQUASH behat fixes for badges

SQUASH Tags fixes for behat

SQUASH filepicker fixes for behat

SQUASH Abort guessing field type when we hit 'html'

SQUASH Fix for admin/tool/behat tests

SQUASH fix for admin tool behat tests

SQUASH fix for availabilty conditions hiding "aria-hidden" elements

SQUASH give the blocks more room. We get behat files because nav tree nodes are not in view

SQUASH Blocks fixed

Fix behaviour of unchecked checkboxes

SQUASH Remove incorrect step in user test

SQUASH behat fixes for course tests

Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart
ec3857fee2 MDL-55584 gradereport_singleview: Convert some elements to template
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart
ed7844b5f4 MDL-55224 theme_noname: RTL adjustments for auto-flipping era
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Juan Leyva
08d7965e63 MDL-55928 gradereport_user: New WS for retrieve grade items
It includes a refactor of the complete externallib.
Previously it was not possible to filter the report by groups.
2016-09-16 09:55:14 +01:00
Juan Leyva
345330d172 MDL-55928 gradereport_user: Return grade items data among the table data 2016-09-16 09:55:13 +01:00
Dan Poltawski
3a0bc0fdc4 MDL-55244 js: build changes
There should be no changes to minified code
2016-07-25 07:58:05 +01:00
Dan Poltawski
5bb4f444de MDL-55244 js: fix problems with eslint --fix
eslint --fix '**/yui/src/**/*.js'
2016-07-25 07:53:05 +01:00
Dan Poltawski
ad3f8cd18c MDL-54944 eslint: make the .eslintrc default stricter
Instead of using the more rollup-tolerant config for all files, make the
configuration stricter by default but lower in grunt for yui modules.

This means that manual runs (prechecker) or editor integrations will
flag up the errors as well as grunt.

Also add ignore lines to the core files so that eslint isn't noisy when
not running with grunt.
2016-07-11 12:44:34 +01:00
Eloy Lafuente (stronk7)
0f20bf7507 Merge branch 'wip-mdl-54589-mac' of https://github.com/rajeshtaneja/moodle 2016-06-22 01:42:15 +02:00
Rajesh Taneja
6a51c58542 MDL-54589 behat: Don't allow floating headers for behat 2016-06-20 16:03:36 +08:00
Rajesh Taneja
fba0ac63b8 MDL-54589 behat: Added hack for some OS/browsers 2016-06-20 16:03:36 +08:00
Dan Poltawski
cc3ca25e57 MDL-54652 singleview: remove invalid css decleration
margin-bottom can't be used with display: inline, so use padding
instead.
2016-06-16 20:49:04 +01:00
Dan Poltawski
9072631311 MDL-54652 grade_report: fix css lint issues
max-width: initial isn't valid css and in my testing it makes no
difference, so is removed.

We also remove invalid css on exception.

This reverts commit 72ece42858643c789d2c2f86fccdab0afefa18d0
2016-06-16 20:49:04 +01:00
Eloy Lafuente (stronk7)
4da854a68b MDL-54677 upgrade: add 3.1.0 separation line to all upgrade scripts 2016-05-23 01:31:34 +02:00
Eloy Lafuente (stronk7)
1abca11e0a MDL-54638 versions: bump all versions and requires near release
version = 2016052300 release version
requires= 2016051900 current rc1 version
2016-05-19 02:16:15 +02:00
Juan Leyva
7c357047cc MDL-54032 webservice: Fix plugin functions not using services 2016-05-03 13:00:13 +02:00
Damyon Wiese
821ab1bf9b MDL-52954 assign: Behat fixes because the assign grading ui has changed 2016-04-15 15:57:56 +08:00
Rajesh Taneja
921faad9ad MDL-53571 behat: Use Escaper for escaping
xpathLiteral has been depreacted, use Escaper instead
2016-04-06 15:38:31 +08:00
Rajesh Taneja
eb9ca848fa MDL-53381 behat: Replaced chained steps with api.
Behat 3.x doesn't support chained steps and hence
this is first step to get rid of chained steps in core.
2016-04-06 11:32:49 +08:00
Dan Poltawski
5821479ef6 Merge branch 'MDL-53239_master' of git://github.com/dmonllao/moodle 2016-03-21 14:12:10 +08:00
David Monllao
01f4ea8cce MDL-53239 grader report: Add all names to error msg 2016-03-17 10:57:57 +08:00
Andrew Nicols
ab5c48b0d5 Merge branch 'MDL-53279_master' of git://github.com/dmonllao/moodle 2016-03-15 12:19:22 +08:00
David Monllao
f32e6ffc00 MDL-53279 grades: Recalculate only required items
Skip grade categories and calculated grade items that do not depend
on .
2016-03-15 12:18:23 +08:00
Rajesh Taneja
42ad096fdb MDL-46891 Behat: Added support for behat 3 2016-03-11 10:51:15 +08:00
David Monllao
ae66ed23b6 MDL-52378 singleview: Using is_disabled instead of is_locked 2016-03-07 23:04:52 +01:00
Travis Noll
43cd0e3c9b MDL-52378 Singleview: Exclude Grade Attribute Permissions
Singleview users must have Manage Grade permission to modify the
Exclude grade attribute.
2016-03-07 23:04:42 +01:00
Cameron Ball
9566b021db MDL-53214 grades: Fix labels on feedback fields 2016-03-02 14:21:39 +08:00
Andrew Nicols
2b38214a16 Merge branch 'MDL-53214-master' of git://github.com/cameron1729/moodle 2016-03-01 09:40:44 +08:00
Eloy Lafuente (stronk7)
6ab07f97bf Merge branch 'MDL-49324-master' of git://github.com/andrewnicols/moodle 2016-02-24 07:55:51 +01:00
Andrew Nicols
beb964520a MDL-49324 gradereport_singleview: Fix unit tests 2016-02-24 14:39:10 +08:00
Andrew Nicols
47f084c6a1 MDL-49324 grades: Remove unnecessary @javascript tag from tests 2016-02-24 14:39:09 +08:00
Andrew Nicols
a2f6399806 MDL-49324 gradereport_singleview: Correct url params supplied to PAGE 2016-02-24 14:39:08 +08:00
Andrew Nicols
0a802c9c4e MDL-49324 grades: Create helper function for regrading on report view 2016-02-24 14:39:08 +08:00
Cameron Ball
ccdda8550b MDL-53214 grades: Ensure grader report correctly labels fields.
The editable fields for the grader report should have unique labels.
Previously category grade items were not being labelled with the
category name.
2016-02-24 10:30:43 +08:00
Dan Poltawski
2c720c9772 Merge branch 'MDL-50312_master' of https://github.com/jinhofer/moodle 2016-02-23 08:07:13 +00:00
Damyon Wiese
30be6c846a MDL-49324 Grades: Use a progress bar when recalculating gradebook grades 2016-02-23 08:35:10 +08:00
Rajesh Taneja
7b287e09e2 MDL-50484 core_grade: courseheader id should be unique
grader report show category with courseheader id
which gets replicated for all categories on page.
This will now be courseheader_categoryname.
2016-02-19 14:00:04 +08:00
Jun Pataleta
825a3fa9d1 MDL-48015 grade: Fix the display of grade categories 2016-02-09 13:32:28 +08:00
jinhofer
8cc02383bf MDL-50312 grade/report/grader: Fixed remaining issue
MDL-49764 fixed the appearance of user cells. However, the window
resize event was still incorrect. This is a fix for the window
resize event for ALL IE versions.
2016-01-29 12:16:06 -06:00
Dan Poltawski
574b76ace1 Merge branch 'MDL-52218_master_alt' of git://github.com/markn86/moodle 2016-01-18 14:03:54 +00:00
Andrew Nicols
2e6462f327 Merge branch 'MDL-52573-master' of git://github.com/danpoltawski/moodle 2016-01-18 14:32:41 +08:00
Andrew Nicols
324a43c51e MDL-52309 gradereport_history: Adjust comment 2016-01-18 09:37:29 +08:00
Andrew Nicols
8d9b6ec254 Merge branch 'MDL-52309' of https://github.com/smbader/moodle 2016-01-18 09:33:36 +08:00
Dan Poltawski
2811831ae6 MDL-52573 report_grader: only check cap of installed plugins
Previously we were linking to gradebook plugins regardless of whether
they were installed. This should be fixed properly in MDL-52678.
2016-01-14 10:20:43 +00:00
Dan Poltawski
1be8237d41 Merge branch 'MDL-49021_master' of git://github.com/markn86/moodle 2016-01-12 17:02:24 +00:00
Steve Bader
1dabeb8439 MDL-52309 gradereport_history: require user to submit parameters
Prevent a timely full report from loading when need is exceedingly
rare. Only execute the report when the user has submitted the form.
2016-01-11 11:12:30 -05:00
Mark Nelson
ae139d7911 MDL-52218 gradereport_grader: added behat test for switching views 2016-01-11 16:02:31 +08:00
Mark Nelson
20180b3167 MDL-52218 gradereport_grader: fixed 'grade:viewhidden' related errors
There were two main reasons why there were PHP errors.

1) We were not passing variables as references.
2) When we were restricting the number of items shown in
   the report we were not collecting all of the dependencies
   which were required when a user did *not* have the
   capability 'moodle/grade:viewhidden'. This would cause
   an undefined offset error due to the index missing in
   the dependency array.

This also meant that a user without the capability 'moodle/grade:viewhidden'
could view the course total without hidden items being taken into account
if they were not being displayed. To resolve this we now pass all the grades
and grade items when the user does not have the capability - which also solves
the PHP errors listed above.
2016-01-11 16:01:33 +08:00