Changed PARAM_TEXT to PARAM_NOTAGS to "search" param
because it's the same but WITHOUT lang support and we
don't need lang support there.
Of course, both require to verify that the output is always
escaped. In this case (mustache) it is. Or also p() or s().
Without that XSS on form values are relatively easy!
Before this change sections and blocks could not be moved to be the
top item when using keyboard drag and drop.
They can now be moved to the top in one action.
The way they move using keyboard drag and drop has changed when they
are below the item they are dropped on, not instead of appearing
below it they will be placed above it.
Before this change keyboard drag and drop of sections would alter
the structure of the page.
This occured because in this case the dragnode was the original node
Before this change when moving a section via drag and drop the
aria-label for the section was not being updated neither was the
title on the drag handle.
The result was the the drop menu on keyboard drag and drop displayed
the wrong information after a section was moved.
This patch removed the sectionname hidden element (that was not used
by the keyboard menu anyway)
Changed the aria-label of the section to aria-labelled by as this
means that the description will change as drag and drop updated
things without the need to add additional JavaScript.
When using section drag and drop, the topics and weeks formats expected
the '.section_add_menus' element to be present so it could update it on
section drop. Due to MDL-68056, this control is only sometimes present.
This has been updated to conditionally swap to address this.
span is not a valid content wrapper tag.
Moreover, according to W3C validation service report, it is not valid to
have div elements as children of a span element.
We can safely replace span with div here because the element's css class
is .action and display of .action is set to flex in both boost and
classic themes.
Only generate the non-ajax controls in cases where we know we need
them. Otherwise, only generate the new link style control. This patch
includes a behat check as many of our tests use the 'I add "Page" to
section "1"' syntax, which runs without JS.