1058 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
6ab07f97bf Merge branch 'MDL-49324-master' of git://github.com/andrewnicols/moodle 2016-02-24 07:55:51 +01:00
Andrew Nicols
beb964520a MDL-49324 gradereport_singleview: Fix unit tests 2016-02-24 14:39:10 +08:00
Andrew Nicols
47f084c6a1 MDL-49324 grades: Remove unnecessary @javascript tag from tests 2016-02-24 14:39:09 +08:00
Andrew Nicols
a2f6399806 MDL-49324 gradereport_singleview: Correct url params supplied to PAGE 2016-02-24 14:39:08 +08:00
Andrew Nicols
0a802c9c4e MDL-49324 grades: Create helper function for regrading on report view 2016-02-24 14:39:08 +08:00
Dan Poltawski
2c720c9772 Merge branch 'MDL-50312_master' of https://github.com/jinhofer/moodle 2016-02-23 08:07:13 +00:00
Damyon Wiese
30be6c846a MDL-49324 Grades: Use a progress bar when recalculating gradebook grades 2016-02-23 08:35:10 +08:00
Rajesh Taneja
7b287e09e2 MDL-50484 core_grade: courseheader id should be unique
grader report show category with courseheader id
which gets replicated for all categories on page.
This will now be courseheader_categoryname.
2016-02-19 14:00:04 +08:00
Jun Pataleta
825a3fa9d1 MDL-48015 grade: Fix the display of grade categories 2016-02-09 13:32:28 +08:00
jinhofer
8cc02383bf MDL-50312 grade/report/grader: Fixed remaining issue
MDL-49764 fixed the appearance of user cells. However, the window
resize event was still incorrect. This is a fix for the window
resize event for ALL IE versions.
2016-01-29 12:16:06 -06:00
Dan Poltawski
574b76ace1 Merge branch 'MDL-52218_master_alt' of git://github.com/markn86/moodle 2016-01-18 14:03:54 +00:00
Andrew Nicols
2e6462f327 Merge branch 'MDL-52573-master' of git://github.com/danpoltawski/moodle 2016-01-18 14:32:41 +08:00
Andrew Nicols
324a43c51e MDL-52309 gradereport_history: Adjust comment 2016-01-18 09:37:29 +08:00
Andrew Nicols
8d9b6ec254 Merge branch 'MDL-52309' of https://github.com/smbader/moodle 2016-01-18 09:33:36 +08:00
Dan Poltawski
2811831ae6 MDL-52573 report_grader: only check cap of installed plugins
Previously we were linking to gradebook plugins regardless of whether
they were installed. This should be fixed properly in MDL-52678.
2016-01-14 10:20:43 +00:00
Dan Poltawski
1be8237d41 Merge branch 'MDL-49021_master' of git://github.com/markn86/moodle 2016-01-12 17:02:24 +00:00
Steve Bader
1dabeb8439 MDL-52309 gradereport_history: require user to submit parameters
Prevent a timely full report from loading when need is exceedingly
rare. Only execute the report when the user has submitted the form.
2016-01-11 11:12:30 -05:00
Mark Nelson
ae139d7911 MDL-52218 gradereport_grader: added behat test for switching views 2016-01-11 16:02:31 +08:00
Mark Nelson
20180b3167 MDL-52218 gradereport_grader: fixed 'grade:viewhidden' related errors
There were two main reasons why there were PHP errors.

1) We were not passing variables as references.
2) When we were restricting the number of items shown in
   the report we were not collecting all of the dependencies
   which were required when a user did *not* have the
   capability 'moodle/grade:viewhidden'. This would cause
   an undefined offset error due to the index missing in
   the dependency array.

This also meant that a user without the capability 'moodle/grade:viewhidden'
could view the course total without hidden items being taken into account
if they were not being displayed. To resolve this we now pass all the grades
and grade items when the user does not have the capability - which also solves
the PHP errors listed above.
2016-01-11 16:01:33 +08:00
Mark Nelson
7481f4229a MDL-49021 gradereport_grader: final deprecation of get_collapsing_icon() 2016-01-06 10:39:53 +08:00
Mark Nelson
be5e0110ff MDL-49566 core: used reflection in unit tests
Also split the tests into multiple functions for each scenario.
2015-12-29 17:42:43 +08:00
Ankit Agarwal
bef0d6b052 MDL-49566 core: Write unittests for MDL-45898 2015-12-29 11:22:42 +08:00
Eloy Lafuente (stronk7)
7814a99341 Merge branch 'MDL-49743-master' of git://github.com/danpoltawski/moodle 2015-12-22 17:14:38 +01:00
jinhofer
c8b276a851 MDL-51900 grade/report/singleview: Added ctrl+arrow navigation
Also, added functionality for tab to traverse down the columns and
shift+tab to traverse up the columns.
2015-11-27 11:15:22 -06:00
Dan Poltawski
a24abd55e0 MDL-49743 singleview: slightly clarify logic
Make it clearer what the 'unset' behaviour is because previously
we've set the default for 'empty' values twice.
2015-11-25 15:04:43 +00:00
Conn
453f69263f MDL-49743 singleview: Prevent errors when no itemid was selected
Signed-off-by: Conn <conn@cmrwarwicker.com>
2015-11-25 15:02:14 +00:00
Dan Poltawski
6bef09a490 Merge branch 'MDL-52166' of https://github.com/timhunt/moodle 2015-11-23 09:43:31 +00:00
Eloy Lafuente (stronk7)
6d29c4acdd MDL-52140 upgrade: add 3.0.0 separation line to all upgrade scripts 2015-11-17 17:08:56 +01:00
Russell Smith
bb2c0b4526 MDL-50700 gradereport_overview: Call $PAGE->set_course
To ensure correct blocks are displayed.
2015-11-17 10:01:57 +08:00
Tim Hunt
e168e38813 MDL-52166 gradebook: overview report fails with separate groups 2015-11-16 14:37:42 +00:00
Eloy Lafuente (stronk7)
02c72ecb79 Merge branch 'MDL-50589-master' of git://github.com/jleyva/moodle 2015-11-11 16:53:08 +01:00
Eloy Lafuente (stronk7)
2e144835bb MDL-52059 versions: bump all versions and requires near release
version = planned 2015111600 release version
requires= current 2015111000 rc3 version
2015-11-10 12:33:52 +01:00
Juan Leyva
a7d13ecf2b MDL-50589 gradereport_user: Force regrade in external function 2015-11-05 09:40:38 +01:00
Paul Nicholls
245f45f4d6 MDL-51918 gradereport: Fix AJAX mode keyboard navigation
Keyboard navigation (ctrl+up/down/left/right) with AJAX enabled ceased
functioning with editing mode enabled after MDL-36606, as it was looking
for cells with a "clickable" class - but was only applying that class when
editing mode is NOT enabled.  This patch uses a new "gbnavigable" class to
control keyboard navigation, whether editing mode is on or not.  It also
addresses some browser compatibility and minor behavioural issues.
2015-11-04 11:27:35 +13:00
Adrian Greeve
42b3a58c47 MDL-51552 gradebook: Update to singleview behat test. 2015-10-30 10:08:02 +08:00
Adrian Greeve
81e3251512 MDL-51552 gradebook: Single view bulk insert fix.
Single view now doesn't overwrite non-empty grades.

A thank you to Sam Anderson and Robert Russo for providing a patch.
2015-10-29 16:00:46 +08:00
Simey Lameze
e2ec4f3a12 MDL-50483 gradereport_user: fix overlapping on the error message 2015-10-19 08:58:34 +08:00
Jinu Abraham
f712aa2877 MDL-50483 gradereport_user: fix the fatal error of no enrolled users 2015-10-19 08:58:34 +08:00
Dan Poltawski
e3b03886d0 MDL-47494 copyright: missed fixes from last commit
With thanks to Tim!
2015-10-13 09:55:28 +01:00
Dan Poltawski
bf47ddbdf3 MDL-47494 copyright: fix incorrect statement
(From copy/paste error, blame Tim :P)
2015-10-13 09:39:28 +01:00
Eric Merrill
12f946d999 MDL-36606 gradereport: Update AJAX grader to understand gradeless cells 2015-10-08 12:33:08 -04:00
Andrew Robert Nicols
df65120a75 MDL-36606 gradereport: Correctly handle ungraded assessment ajax grading 2015-10-08 09:51:22 -04:00
Juan Leyva
4485f7c549 MDL-49821 webservice: Add active user checks in external functions 2015-09-25 11:33:13 +02:00
Marina Glancy
d6bef7e706 MDL-51008 grades: show correct default value in overview report 2015-09-08 10:11:20 +08:00
Dan Poltawski
4ae71e93a8 MDL-49826 grade: hide singleview links when no permissions
Singleview only supports grade editors not viewers at this time.
2015-08-27 13:16:44 +02:00
David Monllao
61e44f4033 Merge branch 'mdl-50957' of git://github.com/cdsmith-umn/moodle 2015-08-25 10:06:49 +08:00
Clement Smith
368c1bb674 MDL-50957 grade/report/user: Fix division by zero
When using "sum of grades" and $grademax is zero, a division by zero
error occurs in fill_contributions_column() in
grade/report/user/lib.php.
2015-08-24 09:05:30 -05:00
Davo Smith
4021aa45ce MDL-49826 gradereport_singleview: fix permission check
Users with capability 'moodle/grade:edit' should be able to edit grade values
- 'moodle/grade:manage' is not needed, as grade items are not being changed.
2015-08-20 14:55:56 +01:00
Dan Poltawski
bf6395107b Merge branch 'MDL-50091' of git://github.com/timhunt/moodle 2015-06-22 12:06:49 +01:00
Tim Hunt
1c733bd604 MDL-50648 grader report: columns misaligned with some permissions
If a user can see the grader report and singleview report, but not
the user report ($CFG->grade_profilereport) then the colspans
were wrong and so the columns did not line up under the right headers.
2015-06-19 12:35:54 +01:00