19 Commits

Author SHA1 Message Date
Jake Dallimore
0504fd353b MDL-80746 core: make comboboxsearch a named_templatable
This class was rolling its own version of get_template_name, which
meant that calling code needed to first call get_template and was forced
to use render_from_template(). This fixes that by implementing the
named_templatable interface and the get_template_name method. Now,
renderables that extend comboboxsearch can just be passed to render()
for rendering.
2024-09-25 12:47:07 +08:00
Kevin Percy
939e6b546a MDL-80746 core_course: Move initials selector from core_grades 2024-09-25 11:03:55 +08:00
Shamim Rezaie
c1a2436cb5 MDL-80745 core_grades: deprecate core_grades_renderer::group_selector 2024-06-19 00:41:05 +10:00
Mathew May
68bf0f5b77 MDL-78885 comboboxsearch: Points from review 2024-03-22 05:50:06 +11:00
Shamim Rezaie
c122998463 MDL-78885 comboboxsearch: Comboboxes should have a meaningful label
Also, used the combobox's label as the dialogue's label as well
2024-03-22 04:24:23 +11:00
Shamim Rezaie
b4bb1cde97 MDL-78885 comboboxesearch: Comboboxes should have a name and value
- core_grades_renderer::group_selector() was changed previously, but it
  was providing redundant context data to
core_group/comboboxsearch/group_selector and on the other hand, it was
not providing 'name' and 'value' for core/comboboxsearch
- The $groupactionbaseurl parameter of
  core_grades_renderer::group_selector() is now deprecated as it was not
used.
- a bug is fixed: if only a lastname initial was set, the clear search
  button was not being displayed.
2024-03-22 04:23:25 +11:00
Shamim Rezaie
d886cba9d3 MDL-78885 comboboxsearch: Enable aria.js for auto handling
- Added the `dropdown` class to ensure toggle element focus when the
  dropdown is closed.
- Improved keyboard handling by adding the `dropdown` class.
  aria.js will automatically handle keyboard interactions.
- Removed redundant keyboard handling.
- The "view all results" option is just a normal option in a combobox.
  It should not be treated as the default action for a combobox.
- Ensured correct markup for 'Esc' key handling. aria.js automatically
  focuses on the toggle element if the dropdown's toggle and the
  dropdown menu are wrapped within a .dropdown element.
- Implemented menu closure for outside clicks and when leaving the edit
  box.
- Manually focused on the user search element when opening the search
 dropdown due to a focusLock issue.
- Fix the issue of another dropdown staying open
- Clicking on the clearSearchButton should not close the dropdown
2024-03-22 04:22:24 +11:00
Eloy Lafuente (stronk7)
ba1f804ffa
MDL-65292 style: Fix all function declarations white space
This has been generated running the following Sniffs, all
them part of the Moodle's CodeSniffer standard:
- PSR12.Functions.ReturnTypeDeclaration
- PSR12.Functions.NullableTypeDeclaration
- moodle.Methods.MethodDeclarationSpacing
- Squiz.Whitespace.ScopeKeywordSpacing

All them are, exclusively, about correct spacing, so the changes
are, all them, only white space changes.

Only exceptions to the above are 3 changes what were setting the
return type in a new line, and, when that happens, the closing
parenthesis (bracket) has to go to the same line than the colon.
2024-02-28 23:33:26 +01:00
Ilya Tregubov
cb2cf0602d
MDL-78775 core_grades: Fix Behat 2023-10-18 12:54:28 +08:00
Mathew May
b1063f5891 MDL-78097 grade: Allow the initials bar to pass current page params 2023-08-17 09:41:53 +08:00
Mathew May
a4b3b0d044 MDL-77991 core: Move tertiary search dropdown component 2023-08-03 09:07:18 +08:00
Shamim Rezaie
d2881df06b MDL-76246 core_grades: Group search widget to combobox 2023-03-22 20:59:14 +11:00
Ilya Tregubov
9934ec1363 Merge branch 'MDL-76134-abstract' of https://github.com/Chocolate-lightning/moodle 2023-01-09 14:39:28 +07:00
Mathew May
712f219c7c MDL-76134 gradebook: Hook into tertiary dropdown item 2023-01-09 09:22:20 +08:00
Luca Bösch
864a1eba5a MDL-76781 gradebook: support multilingual group names. 2023-01-05 13:27:39 +01:00
Ilya Tregubov
678a2bc29b MDL-75423 gradereport_singleview: Styling fixes. 2022-11-10 22:43:14 +08:00
Mihail Geshoski
be366c5b7c MDL-75513 core_grades: Renderer for the custom user header 2022-11-02 17:45:52 +08:00
Mihail Geshoski
8b2f9b0386 MDL-75513 core_grades: Create trigger element for the group selector
Creates a renderer method and a template for the element that would
trigger the group selector.
2022-11-02 17:45:52 +08:00
Mihail Geshoski
d1a0e4a95c MDL-72873 core_grades: Add general tertiary navigation 2021-12-16 00:10:13 +08:00