114202 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
6c35a65e1a
MDL-81522 phpunit: Add a few non-void return types to tests
This is the final (3rd) commit, where we are adding missing
return types to a few tests (using @depends) which return
types are non-void, but something really returned (for consume
by the dependent test).
2024-06-11 11:55:08 +02:00
Eloy Lafuente (stronk7)
4f7631113c
MDL-81522 phpunit: Add missing void return type to all tests #2
This commit includes more changes, all them also adding the :void
return type to unit tests missing them.

The difference is that all these changes, while also detected
perfectly by the moodle.PHPUnit.TestReturnType sniff, were not
auto-fixed (like the previous commit ones), because all them
do include some "return" statement and, for safety, we don't
fix them.

All the cases have been visually inspected and confirmed that
the existing "return" statements always belong to anon
functions within the test body and not the test own return statement.
2024-06-11 11:55:08 +02:00
Eloy Lafuente (stronk7)
01148a0816
MDL-81522 phpunit: Add missing void return type to all tests
While this change is not 100% required now, it's good habit
and we are checking for it since Moodle 4.4.

All the changes in this commit have been applied automatically
using the moodle.PHPUnit.TestReturnType sniff and are, exclusively
adding the ": void" return types when missing.
2024-06-11 11:55:07 +02:00
Jun Pataleta
d3ae1391ab
weekly release 4.5dev 2024-06-06 22:30:25 +08:00
Jun Pataleta
c42c94279a
NOBUG: Add upgrade notes 2024-06-06 22:30:24 +08:00
Jun Pataleta
8ae4cf9fe1
NOBUG: Fixed file access permissions 2024-06-06 22:30:03 +08:00
Jun Pataleta
9b5142ed3f
Merge branch 'MDL-81750-main' of https://github.com/davewoloszyn/moodle 2024-06-06 22:02:37 +08:00
Huong Nguyen
353d53b97d
Merge branch 'MDL-81813' of https://github.com/christianabila/moodle 2024-06-06 22:02:37 +08:00
Jun Pataleta
6439a4d2b8
Merge branch 'MDL-82045-main' of https://github.com/andrewnicols/moodle 2024-06-06 22:02:37 +08:00
Huong Nguyen
1b4cd89f11
Merge branch 'MDL-81146_disable_buttons' of https://github.com/leonstr/moodle 2024-06-06 22:02:37 +08:00
Andrew Nicols
8a92cb82a6
Merge branch 'MDL-81794-main' of https://github.com/meirzamoodle/moodle 2024-06-06 22:02:36 +08:00
Huong Nguyen
49bef6561b
Merge branch 'MDL-81875-main' of https://github.com/laurentdavid/moodle 2024-06-06 22:02:36 +08:00
Huong Nguyen
7934aa46ce
Merge branch 'MDL-81749-main' of https://github.com/aanabit/moodle 2024-06-06 22:02:36 +08:00
Huong Nguyen
f4c77509f3
Merge branch 'MDL-81989-main' of https://github.com/lameze/moodle 2024-06-06 22:02:36 +08:00
meirzamoodle
6322f15f93
MDL-81890 assign: confirm_sesskey fixed in view_fix_rescaled_null_grades 2024-06-06 22:02:35 +08:00
meirzamoodle
3721672e26
MDL-81890 enrol_lti: Fix sesskey checks 2024-06-06 22:02:35 +08:00
meirzamoodle
40b2fb9a31
MDL-81890 course: Fix sesskey checks 2024-06-06 22:02:35 +08:00
meirzamoodle
db2f97a6f4
MDL-81890 tool_moodlenet: Fix sesskey checks 2024-06-06 22:02:35 +08:00
Jun Pataleta
671218e0b9
MDL-81631 backup: Simplify logic using null coalescing operator 2024-06-06 22:02:35 +08:00
Jun Pataleta
e0ec62cfe5
Merge branch 'MDL-81631_master' of https://github.com/santoshndev/moodle 2024-06-06 22:02:34 +08:00
Jun Pataleta
6efc4177c5
Merge branch 'MDL-81894-main' of https://github.com/andrewnicols/moodle 2024-06-06 22:02:34 +08:00
Jun Pataleta
814df623b5
Merge branch 'MDL-78198-main' of https://github.com/andrewnicols/moodle 2024-06-06 22:02:34 +08:00
Jun Pataleta
2a216f639f
Merge branch 'MDL-82086' of https://github.com/paulholden/moodle 2024-06-06 22:02:34 +08:00
Huong Nguyen
3086b220be
Merge branch 'MDL-81397' of https://github.com/paulholden/moodle 2024-06-06 22:02:33 +08:00
Paul Holden
815b884b6c
MDL-81778 mod_bigbluebuttonbn: access checks when getting meeting URL. 2024-06-06 22:02:33 +08:00
Stevani Andolo
cd2d23d356
MDL-81412 calendar: Sanitise calendar event names 2024-06-06 21:54:46 +08:00
Andrew Nicols
847e1098da
MDL-82045 course: Destroy copy course modal instead of hiding it 2024-06-06 10:03:44 +08:00
Andrew Nicols
2e05b9111b
MDL-81894 core: system_clock should use the server timezone 2024-06-06 00:17:10 +08:00
Amaia Anabitarte
f185fdca52 MDL-81749 core_completion: Let custom rules to return failed state 2024-06-05 15:55:04 +02:00
lameze
bed551eab2 MDL-81989 install: remove unnecessary closing div tags 2024-06-05 13:56:33 +08:00
Cameron Ball
03cb18d6ff MDL-81774 curl: Strip auth headers when redirecting to different host 2024-06-05 02:34:19 +00:00
Jun Pataleta
e5d52aa315
Merge branch 'MDL-81982-main' of https://github.com/junpataleta/moodle 2024-06-05 10:30:44 +08:00
David Mudrák
a8cdd0d7a4
MDL-81982 lang: Fix strings order
Fixes the strings order in files where CI has detected the wrong order
of modified strings.
2024-06-05 10:25:29 +08:00
David Mudrák
6a95cab8a3
MDL-81982 lang: Use fixed strings in tests, too 2024-06-05 10:25:29 +08:00
Helen Foster
7b8da78e01
MDL-81982 lang: Import fixed English strings (en_fix) 2024-06-05 10:25:28 +08:00
Huong Nguyen
520a84f471
Merge branch 'MDL-81970-plagiarism_upgrade_txt' of https://github.com/leonstr/moodle 2024-06-05 09:13:29 +07:00
Huong Nguyen
c3a0cc0358
Merge branch 'MDL-81751-main' of https://github.com/durzo/moodle 2024-06-05 08:55:39 +07:00
David Woloszyn
92fc45fb97 MDL-81750 form: Add selector to match filemanager in group 2024-06-05 09:34:21 +10:00
Andrew Nicols
d2909a5e3d
Merge branch 'MDL-81940' of https://github.com/paulholden/moodle 2024-06-04 22:28:50 +08:00
Laurent David
6a2c1823ff MDL-81875 mod_data: Revert database autolink removal
Autolinks are used in the database for text fields via
the auto-linking filter.
The revert is partial here because of changes made
in MDL-70384 to all field forms/templates

This reverts commit 42edaba5 from MDL-80949
2024-06-04 16:08:16 +02:00
Paul Holden
1ab6151151
MDL-82086 theme_boost: consistent selector for textarea form controls.
In a similar vein to 31f6039635, we shouldn't assume form controls are
always descendents of `.mform` (e.g. the messaging drawer input).
2024-06-04 14:34:48 +01:00
Paul Holden
90a4216446
MDL-81397 courseformat: define section editing capabilities.
This ensures consistency for current page instance, when rendering
content in response to fragment AJAX requests.
2024-06-04 09:00:11 +01:00
Huong Nguyen
808a8679bf
Merge branch 'MDL-81936' of https://github.com/paulholden/moodle 2024-06-04 13:14:58 +07:00
Huong Nguyen
1d680644c2
Merge branch 'MDL-81955' of https://github.com/paulholden/moodle 2024-06-04 10:33:21 +07:00
Andrew Nicols
1790452026
Merge branch 'MDL-80208' of https://github.com/paulholden/moodle 2024-06-04 11:06:34 +08:00
Juan Leyva
36e0395bb9
MDL-80959 tool_mobile: Use different user keys for QR and auto login 2024-06-04 10:32:48 +08:00
Andrew Nicols
0800617868
Merge branch 'MDL-82047' of https://github.com/paulholden/moodle 2024-06-04 10:29:00 +08:00
Andrew Nicols
c5820bbc6e
Merge branch 'MDL-81321' of https://github.com/paulholden/moodle 2024-06-04 09:55:35 +08:00
Andrew Nicols
e96ac335e1
Merge branch 'MDL-81572' of https://github.com/paulholden/moodle 2024-06-04 09:54:12 +08:00
Andrew Nicols
aa43ded0c7
Merge branch 'MDL-82055' of https://github.com/paulholden/moodle 2024-06-04 09:50:13 +08:00