4651 Commits

Author SHA1 Message Date
nicolasconnault
6c76ea8dfa MLD-9506 Grade_grades_raw object now infers grademax and grademin from scale, if scaleid is given at the time of insert of update. 2007-05-09 08:56:08 +00:00
nicolasconnault
70f9a148af MDL-9506 Added grade_grades_text object to grade_grades_final and raw objects. 2007-05-09 08:10:27 +00:00
toyomoyo
ec19392b06 changing grade book db so that grade_grades_text can be referenced from grade_grades_final 2007-05-09 07:52:00 +00:00
nicolasconnault
6527197b4e MDL-9506 Unit test tables are now created and emptied using XMLDB. raw.gradescale and final.gradescale have been removed in favour of a single gradevalue. Scale value is no longer rounded until moment of display. A number of other changes which you can look at by browsing the diff :-) 2007-05-09 07:50:28 +00:00
moodler
b0b4ffe1ec Added CSS class for current language to every page MDL-9750 2007-05-09 06:49:23 +00:00
toyomoyo
48b8bba944 dropping gradescale for grade_raw and grade_final table 2007-05-09 05:56:34 +00:00
nicolasconnault
251aa315d1 Removed breaking unit test, originally set up to test xhtml validity throughout the site. 2007-05-09 05:42:06 +00:00
poltawski
72d2845296 MDL-9742 Converting tabs to spaces 2007-05-09 01:11:45 +00:00
poltawski
9f439b177d MDL-9742 Replaced stray tabs with spaces 2007-05-08 16:25:18 +00:00
poltawski
a044c05ddb MDL-9742 - changed tabs to spaces in a few places where there are one
or two
2007-05-08 15:07:25 +00:00
sam_marshall
3ef1be377b MDL-9741: Fixed broken link on editor help page 2007-05-08 14:57:37 +00:00
nicolasconnault
2c72af1f08 MDL-9506 Stuck on grade_category->generate_grades. I cannot figure out how to recursively generate raw grades for each category's associated grade_item based on that category's children categories and items. Heaps of other changes with this commit, including a new grade_object::update_from_db() method, which uses the state of the record in DB to update the current object with a matching id (useful when you insert an incomplete object in the DB and want to get the default values as set up in the DB). 2007-05-08 08:01:55 +00:00
nicolasconnault
0aa32279b7 MDL-9506 Issue 1: adjusting a gradeitem's value would result in a grade_final object with gradevalue assigned, even when a gradescale should have been assigned. Issue 2: double grade_final entries when calling grade_item->load_final() after grade_item->generate_final(). Issue 3: Calling grade_item->update_final_grade() without first calling grade_item->generate_final() would result in fatal error. generate_final() is now called if the raw and final arrays' sizes don't match. 2007-05-08 02:20:26 +00:00
poltawski
c3d1fbe943 MDL-9726 - fixed phpdoc comment from MartinD's commit 2007-05-07 08:34:08 +00:00
nicolasconnault
f151b07393 MDL-9506 Added category's associated grade_item object, and changed unit tests database data so that it creates its own test tables. 2007-05-07 07:33:11 +00:00
jamiesensei
986effb653 pass the category list page param from page to page in question bank editing pages. 2007-05-07 05:53:20 +00:00
jamiesensei
400edee1ec always make sure that page param is in the pageurl 2007-05-07 05:30:06 +00:00
jamiesensei
81be5cdec3 added argument to constructor to specify the name of the page parameter used to pass the page no of the list. Default to 'page' 2007-05-07 05:25:44 +00:00
toyomoyo
6ceebc1f32 merged fix for MDL-9656, blocks parents can be system context 2007-05-07 03:24:22 +00:00
moodler
6eaa3f09ce Merged changes for better performance in cases where there are lots of enrolment plugins MDL-9726 2007-05-07 03:10:22 +00:00
nicolasconnault
712d500777 MDL-9506 Removed implicit loading of associated objects from constructors (grade_item and grade_grades_raw) to avoid very large numbers of sql queries when only little data is required. The load_scale() method, for example, needs to be called explicitly. 2007-05-07 02:04:06 +00:00
martinlanghoff
0f7caaf84f get_my_courses() - ensure we have groupmode, groupmodeforce in $d_fields - calendar/lib.php counts on it 2007-05-06 05:37:28 +00:00
martinlanghoff
4dbca99edf get_my_courses() - added optimisation for guest login
- was causing very slow page generation
2007-05-06 05:28:39 +00:00
martinlanghoff
e4271d740c get_my_courses() - tighten default fields - faster, risky
This makes get_my_courses() faster/lighter in 2 ways

 - We fetch a ton less data from the DB
 - We store a tone less data in the Session

In a test environment, with a student enrolled in  3 _empty_ courses
(just created, empty modinfo, etc), this shaves 50% off the session
size on-disk.

The problem is callers that may be expecting a given field to appear by
default. Next step: walk all callers...
2007-05-06 05:27:31 +00:00
martinlanghoff
601edb900e get_my_courses() - skip checks if we know the user has moodle/site:doanything and we are observing $doanything
Author: Martin Langhoff <martin@catalyst.net.nz>
2007-05-06 05:26:59 +00:00
martinlanghoff
5970ccfbaf get_my_courses(): tighten cache scheme - part 2
the tighter cache was fragile as we always edit $field
2007-05-06 05:26:04 +00:00
martinlanghoff
c6325ef155 get_my_courses(): tighten cache scheme
This tightens the rather lax caching mechanism that
cached regardless of parameters.

Thanks to Matt Clarkson for the heads-up...
2007-05-06 05:22:03 +00:00
nicolasconnault
2b4f19a9ce MDL-9506 Fixed some small issues. 2007-05-04 09:04:40 +00:00
nicolasconnault
46566dd8c6 MDL-9506 Moved unit tests in a simpletest subfolder so they can be automatically grouped. Added grade_history and grade_text object and another heap of small implementations. 2007-05-04 07:40:51 +00:00
toyomoyo
6ec4869ecb adding a missing feedbackformat field 2007-05-04 07:35:54 +00:00
jamiesensei
e744ebba7b added a param to moodle_url constructor to provide params as an array just as a convenience to quickly construct a url with an array of params. 2007-05-04 05:45:33 +00:00
toyomoyo
daaf61f40c merged fix for MDL-9617, performance issues in calendar 2007-05-04 05:25:49 +00:00
nicolasconnault
52b72d77c5 MDL-9506 Reorganised the gradebook unit tests into more manageable classes. 2007-05-04 02:31:16 +00:00
toyomoyo
967f222f55 MDL-9510, cron job support of legacy grade functions in modules. Implementation is not finished as the gradebook grade_added event is not complete 2007-05-04 02:15:46 +00:00
jamiesensei
fcdb06c470 change to print_paging_bar function to optionally support the use of a moodle_url object as a parameter instead of a string.
small changes to moodle_url class
2007-05-03 10:03:59 +00:00
nicolasconnault
5501446df5 MDL-9506 Added grade_outcome.php. Also added unit test for creation of log in history table when grade_raw is updated. 2007-05-03 08:51:48 +00:00
nicolasconnault
4d0263c6e2 MDL-9506 See previous revision. This adds same functionality but in relation to the hidden field. 2007-05-03 08:08:38 +00:00
nicolasconnault
fae51e127b MDL-9506 Added grade_item::toggle_locking and unit tests. Affects all final grades if reqested. 2007-05-03 08:02:51 +00:00
ikawhero
08297dcb3c New mimetype for Inspiration application.
Icon and code patch from Julian Ridden.
2007-05-03 07:15:30 +00:00
nicolasconnault
27f95e9b47 MDL-9506 Upgraded grade_item::adjust_grade with Darlene's more elegant formula. Completed grade_category::get_children($depth, $arraytype). Added 4 constants to help that method. Added and passed all unit tests (111 now). 2007-05-03 07:10:22 +00:00
nicolasconnault
cb63031c37 MDL-9506 Removed childrentype after discussion with Martin D. 2007-05-03 05:44:33 +00:00
jamiesensei
360e503e6e MDL-9644 new class 'moodle_url' in weblib.php to handle constructing a url. It would internally stores params as an array and have methods to manipulate the array. The class can also output the params as hidden fields in a form or as a url with get params appended. 2007-05-03 04:34:53 +00:00
nicolasconnault
ec0009c3a4 MDL-9506 Added childrentype field to grade_categories table 2007-05-03 01:43:33 +00:00
ikawhero
8f8210b3e8 1. Changes to allow different priorities in the theme selection based on
CFG->themeorder setting

2. Changes to allow category themes. Theme can now be set for a category
which will apply to all sub-categories (unless they specifically have a
theme set) and to child courses (course theme and $CFG->themeorder
settings permitting). New config setting $CFG->allowcategorythemes must
be set. Off by default as it means extra database calls.

There is an ugly hack to find out if we are viewing course/category.php -
anyone welcome to tidy this up if they have a better idea.

GUI for setting category theme coming.
2007-05-02 09:35:35 +00:00
nicolasconnault
7c8a963f7b MDL-9506 Finished all unit test stubs, another batch to write soon. One one test fails because I haven't implemented recursive category hierarchy output yet, and not sure if it's needed. A grade_category already returns its immediate children, and that may be enough. 2007-05-02 07:20:13 +00:00
ikawhero
ec75a182db New field for category themes 2007-05-02 06:50:28 +00:00
toyomoyo
ca9ffa1887 adding capabilities for gradebook, MDL-9511 2007-05-02 06:30:54 +00:00
toyomoyo
9e2e5943dc modifications to eventslib 2007-05-01 08:59:39 +00:00
nicolasconnault
ce385eb4e3 MDL-9506 Implemented category path and depth, and wrote unit tests for them. 2007-05-01 08:56:37 +00:00
nicolasconnault
97b868a31c MDL-9506 Forgot to add the grade_scale.php file. 2007-05-01 05:47:10 +00:00