mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-01 22:42:35 +02:00
Code Issues Projects Releases Wiki Activity
107,670 Commits 36 Branches 528 Tags
Commit Graph

107670 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Eloy Lafuente (stronk7)
8b31b8e8d0 MDL-76675 date: Only test all TZ names with PHPUNIT_LONGTEST enabled 
It happens often that some timezone is renamed, split, added to the
IANAs list of timezones (that, for PHP is kept updated by the
php-timezonedb PECL extension).

When the information coming from the extension changes, all the
PHPUnit jobs in the world start failing (that's when CIs update
their PHP images, when devs update their packages, ...).

So, what we are doing here is to move that test that check for
every single string existing to be run only when PHPUNIT_LONGTEST
is enabled. That way only places running all tests will run that
one. And every other run just will skip it.

This corresponds to point 1 & 2 of the issue, lower impact in general
and, still be able to enable the tests to run.
 2023-01-27 08:48:22 +01:00
Andrew Nicols
62118364f2 Merge branch 'MDL-76562-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-01-27 14:24:26 +08:00
Andrew Nicols
0a4f551fff Merge branch 'MDL-75978-401' of https://github.com/JBThong/moodle into MOODLE_401_STABLE 2023-01-27 12:34:04 +08:00
Paul Holden
d8f7fb803f MDL-77040 core: assert types of returned Geoplugin data, not values. 
The results we get from these tests are beyond our control, and are
unreliable for use in testing.

See also previous change 215cd2d8 in similar tests.
 2023-01-26 13:24:06 +00:00
Paul Holden
64293da947 MDL-76662 tool_log: correct supported reports test assertions. 2023-01-26 13:09:13 +00:00
Davo Smith
dcd48987f7 MDL-76938 backup: fix restore of comments linked to a course format 2023-01-26 12:32:35 +00:00
Sara Arjona
67bbf6c416 weekly release 4.1.1+ 2023-01-26 09:59:12 +01:00
Lars Bonczek
d238db5f36 MDL-76948 mod_assign: Fix description of submission_unlocked event 2023-01-25 19:20:56 +01:00
Paul Holden
522ee5ae4c MDL-77042 mod_data: fix empty/zero equality check for numeric field. 2023-01-25 17:04:47 +00:00
Tim Hunt
deed4fe251 MDL-77024 quiz: fix metatdata on log events 
Some had the wrong edulevel or crud
 2023-01-25 16:12:37 +00:00
Jun Pataleta
a360fd0601 Merge branch 'MDL-76977-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-25 16:10:18 +08:00
Jun Pataleta
5e75da7598 Merge branch 'MDL-77036-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-01-25 16:02:23 +08:00
Stefan Hanauska
928633a33e MDL-76985 course: Redirect to moved section 2023-01-25 09:00:06 +01:00
Simey Lameze
6bf5c32402 MDL-77036 core_iplookup: update test_ipv4 test expectations 2023-01-25 15:15:07 +08:00
Jun Pataleta
6d90fc7c5b Merge branch 'MDL-76967-401' of https://github.com/lucaboesch/moodle into MOODLE_401_STABLE 2023-01-25 08:57:16 +08:00
Paul Holden
0a86c6a123 MDL-77003 javascript: improve string helper JSON detection. 
Changes in fbc2732d made the JS template string helper method
too strict in regards to what it considers a valid JSON object.

Co-authored-by: Mike Churchward <mike@brickfieldlabs.ie>
 2023-01-24 22:16:21 +00:00
Paul Holden
4b43da100c MDL-77023 javascript: always normalise component of lang strings. 
Co-authored-by: David Matamoros <davidmc@moodle.com>
 2023-01-24 16:44:06 +00:00
Jun Pataleta
addbbfdaae Merge branch 'MDL-76639-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-01-24 18:59:29 +08:00
Jun Pataleta
0006557b59 Merge branch 'MDL-76652-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-01-24 18:45:24 +08:00
Jun Pataleta
0813b938a3 Merge branch 'MDL-76655-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-01-24 18:27:00 +08:00
Andrew Nicols
710d0ef8f2 MDL-75945 core: Convert a floating value to an integer. 
In PHP 8.1, any implicit conversion of float to int, which leads to a loss in precision, is now deprecated.
To avoid the error warning, the code must explicitly convert a floating value to an integer.
 2023-01-24 16:53:34 +07:00
Jun Pataleta
fa51e1a149 Merge branch 'MDL-76362-401-extra' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-01-24 10:38:49 +08:00
Angelia Dela Cruz
066740a127 MDL-76655 behat: Coverage for workshop grading strategies 2023-01-24 09:09:26 +08:00
Paul Holden
26754aacd1 MDL-76354 competency: export user privacy data unconditionally. 
We should ensure that any past competency data for a user is always
exported, regardless whether competencies are currently enabled.
 2023-01-23 22:15:23 +00:00
Paul Holden
e0358d2eca MDL-77001 tiny_autosave: use valid lang string during privacy export. 2023-01-23 22:06:33 +00:00
Amaia Anabitarte
3fd5c885a1 MDL-76066 mod_data: Trigger field_deleted event when importing 2023-01-23 18:54:35 +01:00
sam marshall
40081f5342 MDL-76956 core_grades: Regrade progress bar should be more granular 
This change makes the regrade progress bar send frequent updates to
the web browser, even when processing within the same grade item, to
avoid timeout problems when there are a large number of users.
 2023-01-23 11:43:15 +00:00
Paul Holden
1aa113fd1f MDL-76584 question: correct temporary questionid upgrade field. 
Pass correct parameter/type in field constructor (`XMLDB_NOTNULL`)
for consistency. This corrects the definition and preserves the
truthyness of the value that was incorrectly passed previously.
 2023-01-23 09:16:39 +00:00
Eloy Lafuente (stronk7)
36b4f13e9b MDL-76362 workshop: check for empty (null included) feedbackreviewer 
As far as feedbackreviewer can be null, we cannot, since PHP 8.1
apply any string operation (trim, strlen...) on it, hence, checking
before applying.
 2023-01-23 09:19:32 +08:00
Eloy Lafuente (stronk7)
03bc275093 MDL-76362 enrol_lti: Prevent calling to DataConnector with null keys 
While it could have been fixed in DataConnector (3rd part lib), better
prevent in our code to call to it with null keys.

Covered by unit tests.
 2023-01-23 09:17:48 +08:00
Eloy Lafuente (stronk7)
e6dfa9ff3c MDL-76362 output: Preserve original behaviour for PHP 8.1 
Whenever the page_requirements_manager::js_fix_url()
is called with null url, it must throw an exception and emit 0 warnings.

It's covered by an explicit test:

test_js_fix_url_coding_exception with data set "Provide a null argument"
 2023-01-23 09:17:48 +08:00
Andrew Nicols
8f4bd4ce11 MDL-76362 core: Coding style fixes 2023-01-23 09:16:08 +08:00
Andrew Nicols
77a0a535b3 MDL-76362 core_privacy: Shortcircuit URL rewriting on empty content 2023-01-23 09:16:08 +08:00
Andrew Nicols
a4ea607c24 MDL-76362 core: Short circuit s() on empty values 2023-01-23 09:16:08 +08:00
Andrew Nicols
dbfb5eaa45 MDL-76362 core: Short-circuit strip_querystring on empty values 2023-01-23 09:16:08 +08:00
Andrew Nicols
788d86d7a3 MDL-76362 core_file: Check prefix exists before checking length 2023-01-23 09:16:07 +08:00
Andrew Nicols
a1f4f7bac5 MDL-76362 core: plugin names must be strings to be valid 2023-01-23 09:16:07 +08:00
Andrew Nicols
d08319ddf7 MDL-76362 core: Update core_component plugin name tests 2023-01-23 09:16:07 +08:00
Andrew Nicols
de4de9cec5 MDL-76362 core: Test coursealias before using 2023-01-23 09:16:07 +08:00
Andrew Nicols
ddf0f08cc9 MDL-76362 h5p: Use string as default lang param 2023-01-23 09:16:07 +08:00
Andrew Nicols
2250ab07e6 MDL-76362 qtype_numerical: Fix bug in phpdoc 2023-01-23 09:16:07 +08:00
Andrew Nicols
71c1fa0d8e MDL-76362 qtype_calculated*: Address issues with null strings 2023-01-23 09:16:07 +08:00
Andrew Nicols
5fbd2eac32 MDL-76362 qtype: Update formatting of qtype_calculated* upgradelib 2023-01-23 09:16:07 +08:00
Andrew Nicols
12b36d2a32 MDL-76362 qtype_numerical: Support empty units for apply_units 2023-01-23 09:16:07 +08:00
Andrew Nicols
5f412b3301 MDL-76362 qtype_numeric: Refactor answer tests 2023-01-23 09:16:07 +08:00
Andrew Nicols
4ff3447c8c MDL-76362 question: Add test for number(null) 2023-01-23 09:16:07 +08:00
Andrew Nicols
745080671b MDL-76362 question: Refactor question number unit tests 2023-01-23 09:16:07 +08:00
Andrew Nicols
5fbbb51882 MDL-76362 core: Use empty default string when getting prefs 
The json_decode function does not accept a null, which is the
traditional default for get_user_preferences. By passing a default of
am empty string we avoid issues in PHP 8.1.
 2023-01-23 09:16:06 +08:00
Marina Glancy
2dd7290ccb MDL-76362 various: Avoid passing nulls to functions that don't allow nulls 
PHP 8.1 is more strict on the parameter type. Functions such as trim(), strlen(), str_replace(), etc
show notice when null is passed as an argument
 2023-01-23 09:16:06 +08:00
Marina Glancy
d83368a475 MDL-76362 mustache: Override parent method to avoid PHP notices 
Parent method checks baseDir that is null in this case. This shows notices under PHP 8.1
 2023-01-23 09:16:06 +08:00