moodler
ba4418ad4e
Merged Urs fixes from 1.8 stable and reformatted a bit
2007-10-10 14:57:39 +00:00
skodak
03cedd6283
MDL-11432 eliminated majority of RecordCount uses, added several missing rs_close() - this should help improve perf on some platforms - Eloy says ;-)
2007-10-10 12:19:27 +00:00
nicolasconnault
b7064779f5
Updated copyright notice in header
2007-10-10 05:25:14 +00:00
moodler
f3c3a4d3b1
Added a timemodified field to forum_queue, and we now delete records
...
that are older than a week before processing digests.
After upgrade it's possible that some posts will be lost this way but
on the other hand it ensures that sites with problems like moodle.org
had will start working again.
We still need a recordset added to the digestposts loop.
MDL-11657
2007-10-10 02:52:25 +00:00
iarenaza
0baafc173a
Fix MDL-11632: Multiple files with emtpy lines outside PHP open/close tags
...
There are multiple issues with Moodle files containing empty or blank lines
(lines consisting of white spaces or tabs only) and/or white space before or
after the PHP open and close tags, notably with config.php and theme files.
2007-10-09 21:43:28 +00:00
skodak
4388027c37
MDL-11674 fixed mysql incompatible SQL in chat cron
2007-10-09 16:46:04 +00:00
tjhunt
6f3b54c8aa
MDL-9076 - Move the 'Add 3 more overall feedbacks' button inside that group of elements on the quiz settings form.
...
To make this possible, I added an extra argument to the repeat_elements method, which other people may find helpful on other forms.
2007-10-09 15:44:06 +00:00
tjhunt
e2833e8700
MDL-11617 - 'Student may review' heading on quiz settings form is now misleading. I have fixed some lang strings and improved the help. Also, finish off the clarification of how various capabilites affect quiz review that was started in MDL-11580.
2007-10-09 15:19:07 +00:00
skodak
a86840ecc9
do not optimise the $USER fetching - it was broken by mnethostid and would be again in future
2007-10-09 13:43:51 +00:00
skodak
922ddcad2c
fixed undefined $modcontext
2007-10-09 13:10:55 +00:00
gbateson
68a5a1244d
added escaping of quotes in TimesUp message, so that apostrophes do not cause Javascript errors
2007-10-08 06:45:27 +00:00
moodler
9f2ded7678
More passing around of context information to speed up things
2007-10-07 14:53:13 +00:00
skodak
8ce8fc85fc
MDL-11304 remerging fixes
2007-10-07 13:31:41 +00:00
moodler
c15b86dc95
Pass $modcontext down through the functions so that print_post is more efficient MDL-11606
2007-10-05 07:26:02 +00:00
moodler
2106444076
Get imagealt during outer loops so that print_user_picture is more efficient MDL-11606
2007-10-05 06:47:14 +00:00
moodler
2c894bb92d
Efficiency improvements to bring some SQL statements out of loops MDL-11606
2007-10-05 06:36:31 +00:00
skodak
1223d24a73
MDL-11580 support for hidden state modification in gradebook from activities (quiz now only) - part 1
...
the hiding/unhiding should be IMO locked in gradebook UI when activity overrides it
2007-10-04 22:57:14 +00:00
tjhunt
01600b5190
MDL-11580 - refinement to Yu's checkin, including removing the $CFG->openuniversityhacks.
...
Also, reviewing the new code made me realise that the code in mod/quiz/report/overview/report.php was a mess, so I cleaned it up a bit.
2007-10-04 15:57:09 +00:00
toyomoyo
fb72e817d9
MDL-11580, hide quiz grades when user has no grade:viewhidden capability and quiz is still open, need $CFG->openuniversityhacks flag set
2007-10-04 08:22:55 +00:00
gbateson
b3687f28f1
use target="$CFG->framename" instead of $CFG->frametarget when HotPot navigation is set to "Moodle navigation frame"so that Moodle does not get stuck in sub frame
2007-10-04 05:32:27 +00:00
gbateson
caf971045a
added 4 new functions for Moodle 1.9 gradebook: "hotpot_get_user_grades", "hotpot_update_grades", "hotpot_grade_item_update" and "hotpot_grade_item_delete"
2007-10-02 07:46:49 +00:00
gbateson
b2ae61320b
use new function "hotpot_stripslashes()" instead of PHP's "stripslashes()" to remove slashes after preg_replace with "e" modifier, because when MSSQL Server is installed, PHP's "stripslashes()" does not remove slashes, even if the Moodle database is not MSSQL
2007-09-30 04:21:52 +00:00
skodak
8df73369ce
MDL-11517 reserved word MOD used in table alias in questions backup code
2007-09-29 16:26:13 +00:00
skodak
95aa0af862
MDL-11472 fixed harcoded mdl_ prefix in sql queries
2007-09-27 08:41:19 +00:00
tjhunt
771b1a46f7
MDL-9331 - Problem with the tables on the quiz index page. Merged from MOODLE_18_STABLE.
2007-09-26 20:45:23 +00:00
tjhunt
fba3ea31bc
MDL-8682: Pressing enter when answering a short answer question can submit the wrong one. To fix this, I have disabled the enter key unless the keyboard focus is on a submit button (or inside a text box or HTML editor).
...
MDL-9451: Quiz answers can be lost if user navigates before page reloads. I am not totally sure I have fixed this, but I hope so. I moved the printing of the hidden form field with the list of questions on the page to the end of the form, so no answers will be processed unless the whole form loaded. Note that you could still lose data, but only if the page takes a really long time to load and you answer the first question and click submit before the whole quiz is loaded.
MDL-11463: The quiz uses two different timers, which is silly. I have removed the javascript that was ocasionally used to put a timer in the browser's title bar. Now we only use the one in the page for all cases.
Because MDL-8682 also needed javascript, I renamed timer.js to quiz.js so it could be a library of all the quiz's JavaScript, and started including it properly with require_js.
2007-09-26 18:15:31 +00:00
tjhunt
f59dba8497
MDL-11398 - Random questions sometimes ended up with names different from the cateogry they were actually picking from. Also, the same random questoin could be used in more than one quiz, in which case editing that question would change two quizzes unexpectedly. The fix is:
...
* Don't let the user set the name for random questions.
* Instead force the name to be "Random (catname)" (localised) whever the question is created or saved.
* When a category is renamed, rename all the random questions in it.
* Remove the restriction that Jamie seems to have added in 1.9 that was preventing the category of random questions from being edited.
2007-09-26 16:10:38 +00:00
moodler
ee8652f3de
Not a pretty fix but it gets the preferences out of the way where users won't keep hitting the wrong submit
2007-09-26 11:42:36 +00:00
tjhunt
44888f691a
Add $Id$ tags.
2007-09-26 10:13:23 +00:00
gbateson
88fe6acf9e
change CONTEXT_MODULE to CONTEXT_COURSE in order to fix "Invalid context creation for level 50 instance" error on "mod/hotpot/index.php" caused by get_context_instance(CONTEXT_MODULE, $course->id) in "mod/hotpot/lib.php"
2007-09-26 07:22:06 +00:00
gbateson
b64748eb54
corrected include path for "moodleform_mod.php"; changed $course->id to $COURSE->id;
2007-09-25 21:43:39 +00:00
tjhunt
c0ca082d2f
Remove spurious characters from some SQL statements.
2007-09-25 14:39:42 +00:00
stronk7
fcdea90774
Second pass. Modules. Some more default comments are out. MDL-11385
2007-09-24 22:17:05 +00:00
skodak
138e480e4d
very minor - fixing incorrect include_once('tabs.php') - this is not a library file
2007-09-24 17:20:08 +00:00
skodak
86c2f9e0da
MDL-10729 Active tabs are now marked active
2007-09-24 17:12:56 +00:00
nfreear
468c120ae9
Partial fix for reopened MDL-7474, Accessibility: "Provide alt text for ascending/ descending icons in glossary"
2007-09-24 17:09:37 +00:00
skodak
5978010dd2
MDL-11358 final grade from gradebook is now shown in assignments - students see only final grades from gradebook
2007-09-23 16:05:41 +00:00
skodak
fcac8e513a
MDL-11357, MDL-11358 cleanup and improvements in public grade API - new function grade_get_grades() that returns all grading information (grade item data, outcomes and user grades); other minor improvements and bugfixes; updated assignment to use new grade API
2007-09-22 20:21:44 +00:00
tjhunt
a4faed6925
MDL-10030 - the logic controlling whether students were allowed to see the review screen was wrong.
2007-09-21 16:01:40 +00:00
tjhunt
f0bb0a8738
MDL-10338 - quiz index page does not work in weekscss format. Merged from MOODLE_18_STABLE.
2007-09-21 11:10:37 +00:00
tjhunt
b5a16eb72e
MDL-6376 - Include quizzes on the MyMoodle page. Initial implementation by Stephen Bourget, with refinements by Tim Hunt. The logic for which quizzes are listed is very similar to the lesson module.
2007-09-21 11:05:04 +00:00
moodler
a365ee56cf
Fix for subscription and tracking buttons to remove links and improve accessibility and reduce crawler problems http://tracker.moodle.org/browse/MDLSITE-263
2007-09-21 02:52:51 +00:00
tjhunt
e63faf2b50
MDL-10376 - since roles and capabilities came along, the quiz was not very gracious if you were logged in as guest, or really logged in on the server, but using guest access to look a a particular course, or were enrolled in a course, but in a role that did not let you preview or attempt quizzes. This patch should clean up the logic for all these cases.
2007-09-20 15:14:24 +00:00
skodak
eedae98ef2
MDL-11357 removed _grade_updated() from activities and grade_item class
2007-09-20 07:43:57 +00:00
tjhunt
260812ba06
MDL-10972 - The lang string 'fullname', which is normally used for course fullnames, was being used for a person's full name in some quiz reports. This dual usage is not translatable into all languages. Merged from MOODLE_18_STABLE.
2007-09-19 15:52:27 +00:00
tjhunt
6ef56c991f
MDL-6043 - supplimental - make corse reset function update quiz open and close dates. Thanks to Shamim Rezaei for the implementation, which I edited slightly.
2007-09-19 15:38:14 +00:00
tjhunt
fca490bca0
MDL-6315 - When processing a manul grading action, if both the comment and the score are blank - as might be the case on the 'Grade all' page of the manual grading when the teacher uses it to grade some, but not all of the students - then do not record the question as graded. Merged from MOODLE_18_STABLE.
2007-09-19 10:56:24 +00:00
tjhunt
6c554fc9b8
XHTML Strictness. Merged from MOODLE_18_STABLE.
2007-09-19 10:32:09 +00:00
tjhunt
01c4e87acf
MDL-11095 - Use absolute path to include tabs.php, not a relative path, for greater robustness. Merged from MOODLE_18_STABLE.
2007-09-19 10:26:39 +00:00
martinlanghoff
f0d3bb9e9c
mod/chat: chat_update_chat_times() smarter
...
If cron hasn't run for a few days, it would take
several runs for chat_update_chat_times() to get things back on track.
Now it's all fixed in one go, saving a bit of DB traffic. It all adds
up...
2007-09-19 07:21:09 +00:00
