53 Commits

Author SHA1 Message Date
Michael Aherne
fc60769302 MDL-56668 competencies: Correct namespacing of coding_exception 2016-11-03 13:59:13 +00:00
Amanda Doughty
cc350fd9c8 MDL-47162 core_message: Add course id to message eventdata 2016-10-27 18:11:27 +02:00
Issam Taboubi
fd8043b2de MDL-56285 competency: fix move competencies capabilities
In learning plan templates, cannot move competencies
around even if capability templatemanage is given
to the role because of bad context check
2016-10-06 10:33:32 -04:00
Andrew Nicols
dbab30b127 MDL-55767 competency: Deprecate langstring and replace 2016-10-03 12:59:32 +08:00
Damyon Wiese
9e14057444 MDL-55767 competencies: Better exceptions for persistent
The persistent exceptions "squash" all the details and only display
them to developers. This leads to generic "Invalid persistent" messages
with no explanation. Instead lets include the message detail always.
2016-10-03 12:01:56 +08:00
Rajesh Taneja
52f3e060e4
MDL-55091 phpunit: Following has been deprecated.
1. getMock()
2. setExpectedException()
3. checkForUnintentionallyCoveredCode renamed to beStrictAboutCoversAnnotation
4. beStrictAboutTestSize renamed to enforceTimeLimit
5. UnitTestCase class is now fully removed.
2016-07-26 10:11:30 +08:00
Andrew Nicols
aa49ee0f29 Merge branch 'wip-mdl-55043' of https://github.com/rajeshtaneja/moodle 2016-07-07 11:27:58 +08:00
Rajesh Taneja
56c5c9a08a MDL-55043 core_competency: Sort by id to ensure we get expected result. 2016-07-10 11:25:06 +08:00
Eloy Lafuente (stronk7)
6e24e529c9 Merge branch 'wip-mdl-55043' of https://github.com/rajeshtaneja/moodle 2016-07-06 03:19:08 +02:00
Rajesh Taneja
2648dddd2a MDL-55043 core_competency: Set proper sort order for each field 2016-07-06 08:12:13 +08:00
Marina Glancy
799e001c15 MDL-55032 tool_lp: check access when showing link to competencies
Also if course competencies page is accessed without capabilities do
redirect before starting output.
2016-07-01 13:42:27 +08:00
Damyon Wiese
e824cd502d MDL-54997 competencies: Fix random unit test fail
Sorting on timecreated is not unique enough to
guarantee a predictable ordering.
2016-06-25 08:04:15 -07:00
Damyon Wiese
da880d320c MDL-54997 competencies: Listing evidence contexts
When listing the evidence for a user competency in a course,
the query is missing evidences for sub-contexts in the course.
2016-06-23 09:14:19 -07:00
Frederic Massart
d309f3e218 MDL-54542 competency: Really handle false negatives in plans to review 2016-05-19 11:42:15 +08:00
Frederic Massart
c07712db17 MDL-54542 competency: False negative when listing plans to review 2016-05-19 10:23:46 +08:00
Andrew Nicols
60e75de317 Merge branch 'MDL-54542-master' of git://github.com/FMCorz/moodle 2016-05-18 09:48:27 +08:00
Dan Poltawski
6967b71a34 Merge branch 'MDL-54546-master' of git://github.com/junpataleta/moodle 2016-05-13 18:11:29 +08:00
Andrew Nicols
07d4b49760 Merge branch 'MDL-54073-master' of git://github.com/junpataleta/moodle 2016-05-13 18:11:28 +08:00
Jun Pataleta
e5336562db MDL-54546 tool_lp: Use correct property types for user/course exporters 2016-05-12 19:04:58 +08:00
Frederic Massart
4e968dc8a7 MDL-54542 competency: Tests for listing of plans and comps to review 2016-05-12 16:16:03 +08:00
Frederic Massart
bbf727f175 MDL-54542 competency: Prevent long query aliases in get_sql_fields()
Otherwise we could hit ORA-00972 because they exceed 30 characters.
2016-05-12 16:14:32 +08:00
Jun Pataleta
32cf4bcb93 MDL-54073 tool_lp: Unescape PARAM_TEXT properties in templates
Use triple-curly brackets to unescape the PARAM_TEXT properties in
templates.
Changed idnumber's type to PARAM_RAW for frameworks and competencies.
2016-05-12 11:24:51 +08:00
Frederic Massart
9f659e1af5 MDL-54075 competency: False negatives due to random ordering and latency 2016-05-10 18:41:48 +02:00
Adam Olley
415023cefc MDL-54120 competency: Don't assume there are no existing scales
Every time a unit test for competencies adds a scale, it's creating them
with hardcoded id's - which should always be avoided. So this change has
the unit test keep track of the scale id's created without hardcoding
them.
2016-05-10 14:48:18 +09:30
Mark Nelson
02113beb10 MDL-53920 cohort: notify competencies on cohort deletion 2016-05-02 12:49:11 +08:00
Frederic Massart
42c28b0874 MDL-53937 core_competency: False negative with duedate on plan reopen 2016-04-29 12:19:43 +01:00
Frederic Massart
8ea0f17ae9 MDL-53879 competency: Remove limit on framework depth 2016-04-28 16:41:24 +08:00
David Monllao
e7c979dff8 Merge branch 'MDL-53632-master' of git://github.com/FMCorz/moodle 2016-04-26 11:29:51 +08:00
Issam Taboubi
18daa64cbf MDL-53878 tool_lp: Condition on displaying Link competencies button 2016-04-22 13:57:09 -04:00
Frederic Massart
5592edb646 MDL-53451 competency: Improve performance by bypassing api::is_enabled() 2016-04-22 11:34:39 +08:00
Frederic Massart
d789158566 MDL-53451 tool_lpmigrate: Fixing broken logic found in tests
Thanks to MSSQL, the only one with failures.
2016-04-20 17:52:09 +08:00
Frederic Massart
0abaf33e00 MDL-53451 competency: Fixing database errors on Oracle
- Random ordering caused by absence of ORDER BY clause
- Invalid query statemennt due to wrong string concatenation
- Cannot GROUP BY with CLOB columns
2016-04-20 15:44:01 +08:00
Frederic Massart
69c478660a MDL-53451 competency: Properly wrap those nasty function declarations
Pheww, we avoided a disaster.
2016-04-19 10:55:46 +08:00
Frederic Massart
746da8ba60 MDL-53632 competency: Consistently use the terms frameworks, plans, ...
- Templates: 'Learning plan templates'
- Plans: 'Learning plans'
- Frameworks: 'Competency frameworks'

When the context, or sentence, is already stating that we are talking
about 'learning plans' or 'competencies', it may sound redundant to
repeat those terms, therefore we can simply refer to 'Templates',
'Plans', and 'Frameworks'.
2016-04-18 16:51:39 +08:00
Frederic Massart
bfeb546f44 MDL-53451 competency: Fix tests failing due to context changes 2016-04-18 11:34:46 +08:00
Frederic Massart
de8cdb6854 MDL-53828 competency: Fetch right competency when viewing completed plan 2016-04-18 11:06:47 +08:00
Frederic Massart
1e99f31e33 MDL-53654 competency: Provide a way to delete evidence 2016-04-18 11:06:47 +08:00
Frederic Massart
56537316f6 MDL-53719 competency: Delete content upon course and cm delete/reset 2016-04-18 11:06:01 +08:00
Frederic Massart
91e5464282 MDL-53700 competency: Making CiBoT happier 2016-04-18 11:06:00 +08:00
Frederic Massart
899f46d6de MDL-53700 competency: Use URL resolver in events 2016-04-18 11:06:00 +08:00
Frederic Massart
07fc0ec380 MDL-53700 competency: Implementing a URL resolver 2016-04-18 11:06:00 +08:00
Frederic Massart
ca94bcdbdb MDL-53700 competency: Splitting competency rules logic and UI 2016-04-18 11:06:00 +08:00
Frederic Massart
e6dc03d7c4 MDL-53700 competency: Migrating language strings 2016-04-18 11:06:00 +08:00
Frederic Massart
4aa6acb22a MDL-53700 competency: Migrating comment related APIs to core 2016-04-18 11:05:59 +08:00
Frederic Massart
7160fb19d7 MDL-53700 competency: Migrating file serving to core 2016-04-18 11:05:59 +08:00
Frederic Massart
6be1373ee0 MDL-53700 competency: Migrating settings to core 2016-04-18 11:05:59 +08:00
Frederic Massart
5a1a685c28 MDL-53700 competency: Migrating events to core
Leaving comments behind for now as it's a tricky one.
2016-04-18 11:05:59 +08:00
Frederic Massart
81de839f37 MDL-53700 competency: Migrating external functions to core 2016-04-18 11:05:59 +08:00
Frederic Massart
e0b9ba28a4 MDL-53700 competency: Migrating tests to core 2016-04-18 11:05:59 +08:00
Frederic Massart
922634d3e5 MDL-53700 competency: Migrating data generator to core 2016-04-18 11:05:59 +08:00