Commit Graph

31 Commits

Author SHA1 Message Date
Sara Arjona
0cde029237 MDL-77230 mod_feedback: Validate feedback access
The get_items() and get_page_items() external methods should return
items only when the user has access. Otherwise, empty array for items
will be returned, with the exact error in the warnings parameter.
2023-02-17 12:41:10 +01:00
Andrew Nicols
a3cc26f8bb MDL-76583 core: Update uses of external_* classes 2023-01-19 07:34:09 +08:00
Juan Leyva
f39d43af41 MDL-60578 mod_feedback: Handle correctly site feedbacks 2018-09-04 14:18:41 +02:00
Marina Glancy
38fefb5cdf MDL-60578 mod_feedback: pass courseid to WS 2018-09-04 14:18:39 +02:00
Juan Leyva
7c3c0fa323 MDL-59132 mod_feedback: Fix anonymous responses numbering
This was done correctly by the web scrip but not by the WS.
2017-06-08 11:14:45 +01:00
Jake Dallimore
d8f9177462 Merge branch 'MDL-58412-master' of git://github.com/jleyva/moodle 2017-04-20 09:56:10 +08:00
Dan Poltawski
9c1889810a Merge branch 'wip-MDL-58502-master' of git://github.com/marinaglancy/moodle 2017-04-18 19:48:35 +01:00
Eloy Lafuente (stronk7)
ad02561c15 Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle 2017-04-11 16:47:29 +02:00
Juan Leyva
7f700290b2 MDL-58453 mod_feedback: Add missing security checks
Some checks done in mod/feedback/show_nonrespondents.php were missing.
- Check for anonymous feedback
- Check for real courses (not site home)
2017-04-11 09:42:27 +01:00
Andrew Nicols
b140b13c25 Merge branch 'MDL-58453-master' of git://github.com/jleyva/moodle 2017-04-10 11:23:37 +08:00
Marina Glancy
f4dba1755c MDL-58502 mod_feedback: courseid is not course where feedback is 2017-04-07 16:02:39 +08:00
Juan Leyva
94478c083d MDL-57813 mod_feedback: New WS mod_feedback_get_last_completed 2017-04-06 09:40:26 +02:00
Juan Leyva
682aea9b84 MDL-58453 mod_feedback: Refactor get_non_respondents WS
We should return more information like if the user started or not the
feedback and the total number of non respondents (to be able to
paginate).
2017-04-05 09:28:29 +02:00
Juan Leyva
a24289f12f MDL-57821 mod_feedback: New WS mod_feedback_get_responses_analysis 2017-04-04 12:01:23 +02:00
Andrew Nicols
6e1523c38b MDL-57822 feedback: Correct page param for nonrespondents WS 2017-03-29 11:20:57 +08:00
Juan Leyva
bb66bc4a89 MDL-57822 mod_feedback: New WS mod_feedback_get_non_respondents 2017-03-28 22:52:03 +02:00
Juan Leyva
52f57996f4 MDL-58230 mod_feedback: New WS mod_feedback_get_finished_responses 2017-03-28 22:50:36 +02:00
Juan Leyva
2b2a0319a0 MDL-58412 mod_feedback: Handle array parameters
We should handle array parameters for multi choice (multi select) .
2017-03-28 10:13:26 +02:00
Juan Leyva
592306c60b MDL-58412 mod_feedback: Always set gonextpage when moving forward
In some cases the last page will be omitted in a feedback (for example
when using dependent questions).
Because of that the save process will be launched in a page that is not
the last.
2017-03-28 10:05:56 +02:00
Juan Leyva
1b0b4ab25f MDL-58412 mod_feedback: Add default value for responses
In some cases we will be processing pages without responses, like a
page introduction with a label.
2017-03-28 10:01:25 +02:00
Juan Leyva
8e11464fd6 MDL-58412 mod_feedback: Remove access control in get_items
This function it is used for printing the list of questions.
The feedback preview doesn’t have any access restriction, you can see
the list of questions at any time.
2017-03-28 09:58:47 +02:00
Juan Leyva
ac9f0a6800 MDL-58229 mod_feedback: New WS get_unfinished_responses 2017-03-21 13:21:32 +01:00
Juan Leyva
82b2cd7d19 MDL-57820 mod_feedback: New WS mod_feedback_get_analysis 2017-03-21 13:12:35 +01:00
Juan Leyva
82a7a67869 MDL-57818 mod_feedback: New WS mod_feedback_process_page 2017-03-21 12:25:32 +01:00
Juan Leyva
74975948e5 MDL-57817 mod_feedback: New WS mod_feedback_get_page_items 2017-03-21 11:33:55 +01:00
Juan Leyva
951ddedf6f MDL-57816 mod_feedback: New WS mod_feedback_launch_feedback 2017-03-21 11:22:13 +01:00
Juan Leyva
bb676b74fe MDL-57815 mod_feedback: New Web Service mod_feedback_get_items 2017-03-16 15:35:06 +01:00
Juan Leyva
b315d721d9 MDL-57814 mod_feedback: New WS mod_feedback_get_current_completed_tmp 2017-03-15 15:31:38 +01:00
Juan Leyva
0f3c09979f MDL-57811 mod_feedback: New Web Service mod_feedback_view_feedback 2017-03-15 15:25:00 +01:00
Juan Leyva
3f62cbd33e MDL-57812 mod_feedback: New WS get_feedback_access_information 2017-03-15 15:23:24 +01:00
Juan Leyva
1f7734931f MDL-50538 mod_feedback: New WS mod_feedback_get_feedbacks_by_courses 2017-03-14 15:54:26 +01:00