Commit Graph

110 Commits

Author SHA1 Message Date
Sara Arjona
ae53d04144 Merge branch 'MDL-75337-master' of https://github.com/laurentdavid/moodle 2023-01-24 16:07:35 +01:00
Laurent David
fc72a1d7b1 MDL-75337 core: Single button - core changes
* Change all core calls toward single_button to use single_button::BUTTON_PRIMARY
    when needed
2023-01-24 06:01:35 +01:00
Eloy Lafuente (stronk7)
7fa7d4dd2a MDL-76362 workshop: check for empty (null included) feedbackreviewer
As far as feedbackreviewer can be null, we cannot, since PHP 8.1
apply any string operation (trim, strlen...) on it, hence, checking
before applying.
2023-01-23 09:17:48 +08:00
Thong Bui
c0903eade7 MDL-75877 workshop: Refactor outputs in view.php 2023-01-03 10:20:52 +07:00
hieuvu
98942df0c4 MDL-61401 workshop: Ability for tutors to search for students. 2022-08-16 20:22:19 +07:00
Peter Dias
1a83bd79e0 MDL-73437 workshop: Use templates for actionbar
* Convert the actionbar to use renderables/templates
* Introduce spacing below tertiary navigation
* Add headings on allocations after tertiary navigation
2022-01-10 16:06:47 +08:00
sam marshall
5e72715e4f MDL-71099 Lib: Move new user_fields class from core to core_user
This class would belong more appropriately within the 'user' API
(core_user) instead of within the 'core' API, since it is
directly related to user data.

Since the class has only just been added to Moodle, now is a good
time to move it.
2021-03-25 13:47:23 +00:00
sam marshall
558cc1b85e MDL-45242 Lib: Replace calls to deprecated functions
In all cases changes have been kept to a minimum while not making
the code completely horrible. For example, there are many instances
where it would probably be better to rewrite a query entirely, but
I have not done that (in order to reduce the risk of changes).
2021-03-10 10:57:10 +00:00
Huong Nguyen
8b52ca84ab MDL-68143 Workshop: should remember collapsed/expanded sections 2020-04-28 13:53:26 +07:00
Tim Hunt
1dcd0d3499 MDL-68233 renderers/block: remove illegal uses of $PAGE and $OUTPUT 2020-03-29 15:34:26 +01:00
Bas Brands
40ea67534c MDL-66999 theme_boost: @extend remove extends for tables 2019-12-12 11:27:56 +01:00
David Mudrák
b45193ca12 MDL-51932 workshop: Improve UX for teachers on switching workshop phases
The icon itself has been found insufficient, teachers did not realize it
was used to switch the phase. Its semantics is even less intuitive in
Boost when we do not show it on course outline any more.

So this patch starts to display the information that has been present
for assistive technologies only. As a side effect, I spotted there was a
bug that caused the id attribute "mod_workshop-userplancurrenttasks"
was used for all titles (not only the current one) so it did not
really serve the purpose well.
2017-04-18 18:00:59 +02:00
David Mudrák
5b1a074d89 MDL-54833 workshop: Provide accessible links to the current phase tasks
The screen reader had to read through all the phases tasks. This patch
adds an accessibility link to the list of the current phase tasks so the
user can skip directly to them.
2016-10-21 22:57:58 +02:00
Loc Nguyen
52554b172f MDL-54833 workshop: Enhance accessibility of the userplan widget
Change userplan HTML structure from table to unordered definition list
<dl> <dt> and <dd>. Add accessibility string for task-todo, task-done,
task-fail, task-info to be read by screen reader
2016-10-21 17:03:06 +02:00
David Monllao
1d17f51a8d Merge branch 'MDL-54832-master' of https://github.com/nashtechdev01/moodle 2016-07-11 06:47:13 +02:00
Eloy Lafuente (stronk7)
080c1e798b MDL-54934 workshop: ensure "Current phase" is always separated
Apparently some readers can join 2 adjacent spans completely, simply
adding a whitespace between them prevents that, ensuring separation.,
2016-07-06 11:30:40 +02:00
Eloy Lafuente (stronk7)
1d44e47cc4 Merge branch 'MDL-54934-master' of https://github.com/nashtechdev01/moodle 2016-07-05 20:44:14 +02:00
Loc Nguyen
e9bf00fb14 MDL-54832 workshop: adding landmark for userplantable
Accessibility enhance: add an aria-label on the userplan table so
that it's accessible to me through my screen reader
2016-07-05 20:37:56 +07:00
An Pham Van
1b0276d4bb MDL-54841 workshop: Combine links for attachment icon and text.
In a workshop activity, on the view submission page where having attachment(s), there's an accessibility issue.
There're 2 separate links for the icon and text which causes an issue for keyboard and screen reader users.
So the text and icon should be combined in one link.
2016-07-05 13:21:59 +07:00
Loc Nguyen
ddc9cff68b MDL-54934 workshop: indicate current phase
Indicate phase in page titles, current phase in userplan table
so that it's accessible to me through my screen reader
2016-07-01 19:08:53 +07:00
M Kassaei
bfde810a8b MDL-50673 workshop: Display all participants during submission phase
This patch adds a new report to be displayed during the submission
phase. The report displays all participants who are supposed to submit
their work into the workshop and the status of their submission.
2015-07-16 19:21:37 +02:00
Kevin Wiliarty
5a87760dd6 MDL-45116: Workshop submission title displays behind author picture 2014-04-15 13:50:52 -04:00
Sam Hemelryk
5cdcfcb988 MDL-44183 mod_workshop: unified @package use 2014-02-21 08:33:40 +13:00
Adrian Greeve
3263a3562d MDL-41158 mod_workshop: Workshop submission alternate name field fix. 2013-11-12 10:40:23 +08:00
Rossiani Wijaya
764d7ba9b4 MDL-41622 workshop mod: fix page heading levels.
Also, changing couple of the sub header to use notification, which is more appropriate.
2013-09-17 12:44:25 +08:00
Petr Škoda
96f81ea385 MDL-39474 introduce $CFG->debugdeveloper and cleanup $CFG init 2013-08-12 13:01:47 +02:00
David Mudrák
55c6c6f153 MDL-39491 Fix order of Workshop submission text processing
The order of format_text() and file_rewrite_pluginfile_urls() is
important to make filters work correctly.
2013-05-03 11:56:44 +02:00
David Mudrák
77d746a2f5 MDL-37602 Clean up and improve the overall feedback rendering
In order to use the overall feedback in assessments of example
submissions and in the assessment form preview, significant improvements
in the rendering machinery were done.

Workshop class provides two new methods overall_feedback_content_options()
and overall_feedback_attachment_options() as they are needed at various
scripts and libraries.

Overall feedback is displayed as a part of the workshop_assessment_form
only if the form is in editable mode (not frozen). If the form is
displayed in read-only (frozen) mode, the caller is expected to render
the overall feedback and list of attachments (the editor and filemanager
elements do not support frozen mode). To do so, the renderable
workshop_assessment now loads overall feedback data and provides two new
methods get_overall_feedback_content() and
get_overall_feedback_attachments() to be used by the renderer.

Renderable workshop_submission, workshop_assessment and related classes
now accept the workshop instance as the first parameter in their
constructors. This way, these renderable classes have access to the
workshop API.

In the future, the rendering of submission files should be improved in
the same way as is done in this patch (i.e. moving the logic and data
preparation out of the renderer into the renderable classes).
2013-03-26 21:25:46 +01:00
David Mudrák
4cd2b45548 MDL-38261 Replace deprecated file_encode_url() in workshop renderer 2013-02-28 18:53:37 +01:00
David Mudrák
57c1c7edfc MDL-38261 Display workshop submission attachments in a preview mode 2013-02-28 18:53:37 +01:00
Frederic Massart
06b7ed0a45 MDL-36415 usability: Use new up/down and ordering icons 2012-11-16 12:47:09 +08:00
David Mudrák
3cb4ce45c7 MDL-26349 Display the workshop final grades to participants when the activity is closed 2012-11-07 09:08:38 +01:00
Kanika Goyal
67ba9007b7 MDL-32227: Plagiarism API - add support for plagiarism api to workshop module 2012-07-24 01:52:54 +05:30
Marina Glancy
559276b153 MDL-32247,MDL-32831,MDL-32900 Use correct url building of file type icons
- function get_mimetypes_array() now contains also information about filetype groups and language strings
- use 'smart' human-readable mimetype description
- never determine filetype group based on filetype icon image! remove function mimeinfo_from_icon()
- get rid of class filetype_parser and file lib/filestorage/file_types.mm, replaced with functions file_get_typegroup(), file_extension_in_typegroup() and file_mimetype_in_typegroup()
- support multiple icon sizes, not only 16 and 32
- retrieve filetype icon only using proper functions file_..._icon() from lib/filelib.php throughout the code
- increase size of repository thumbnails to 90 and icons to 24 (will take effect when new icons exist)
2012-05-21 16:01:04 +08:00
David Mudrak
5547b0dce1 MDL-27508 introducing mod_workshop_renderer::perpage_selector() 2012-04-27 14:41:58 +02:00
David Mudrak
3fe6d62289 MDL-26099 workshop planner tool displays info about the automatic phase switching 2012-04-13 04:49:46 +02:00
David Mudrak
9862128087 MDL-32235 introducing new workshop scheduled allocation plugin
The idea is to build a plugin that will internally call the random
allocator when the submissions deadline is reached. The teacher is able
to pre-define the configuration for the random allocator.
2012-04-13 04:49:45 +02:00
David Mudrak
31cea236af MDL-32235 improving the allocation results rendering
The new renderable class workshop_allocation_result provides a cleaner
interface between the allocator's init() method and the allocation.php
script.
2012-04-13 04:49:45 +02:00
David Mudrak
cdc8577762 MDL-30453 Use correct renderable classes to represent assessments of example submission 2011-11-25 18:41:07 +01:00
David Mudrak
6403358838 MDL-27550 workshop: fixed XHTML strictness of H3 and A combo
H3 is block level element while A is in-line element in XHTML.
Credit goes to Sam Hemelryk for spotting this during the peer-review.
2011-08-02 23:34:04 +02:00
David Mudrak
2c75324ee6 MDL-27550 workshop: rendering links to the submission and the assessment page
This usability improvement helps to provide feedback quickly during the
grading evaluation phase.
2011-08-02 23:33:33 +02:00
David Mudrak
f68648e982 MDL-27550 workshop: display the feedback for the submission reviewer when the workshop is closed 2011-08-02 23:33:32 +02:00
David Mudrak
38504a4490 MDL-27550 workshop: assessments are now displayed via proper rendering subsystem
AMOS BEGIN
 MOV [assessmentbyknown,mod_workshop],[assessmentbyfullname,mod_workshop]
AMOS END
2011-08-02 23:33:32 +02:00
David Mudrak
0dfb4bad56 MDL-27550 workshop: display the feedback for the submission author when the workshop is closed
The method user_picture::fields() was not available when these SQL
statements were originally written. Now instead of hard-coding the list
of returned fields, the user_picture is asked for the list.

Together with this change, methods workshop::get_submission_by_id()
and workshop::get_submission_by_author() now return the information
about the user who provided the feedback and overwrote the grade.
2011-08-02 23:33:32 +02:00
Sam Hemelryk
367a75fae4 themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
David Mudrak
c2a3526639 MDL-22507 workshop grading report rendering 2010-10-20 13:13:21 +00:00
David Mudrak
a8b309a37d MDL-22507 workshop rendering of messages and allocation process fixed 2010-10-20 13:13:01 +00:00
David Mudrak
81b2288716 MDL-22507 workshop rendering fixed for submissions and example submissions 2010-10-20 13:12:31 +00:00
David Mudrak
65601f04a3 MDL-21249 workshop and its subplugins: fixing phpdocs @package and @subpackage 2010-09-30 14:44:33 +00:00
Petr Skoda
5924db724d fixed a few spelling problems and standardised stdClass 2010-09-18 14:18:39 +00:00