160 Commits

Author SHA1 Message Date
tjhunt
2ddba27f0a Correct comment. 2008-09-26 05:57:55 +00:00
tjhunt
739b07112e MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.
2008-09-23 07:18:15 +00:00
jamiesensei
c8b2ab1b00 MDL-7308 "Check all the DB columns used to store grades, and make sure they all use a consistent type." Since quiz->sumgrades is now string "0.00000" (quiz->sumgrades) no longer evaluates as false. Changing to (quiz->sumgrades != 0) 2008-09-08 10:35:14 +00:00
tjhunt
45da388f6d MDL-15452 - forgot to check a DB call for errors. 2008-09-04 04:52:29 +00:00
jerome
40f6f97f76 MDL-16307: move quiz_get_best_grade() in lib.php, and fix the DB request of quiz_user_complete() 2008-09-02 10:06:17 +00:00
tjhunt
62e76c6766 MDL-16263 A way for students to flag/bookmark, particular questions during a quiz attempt for later review.
This is an initial implementation that is now at a working state, but with a few things left to do. It seemed like a good idea to commit it before leaving work on Friday night.
2008-08-29 10:08:27 +00:00
tjhunt
e2249afe2b MDL-7010 Convert mod\quiz\config.html to mod/quiz/settingstree.php using the new admin tree system. 2008-08-26 01:05:01 +00:00
tjhunt
f88fb62c40 MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors. 2008-08-15 06:42:38 +00:00
lfrodrigues
2044a2b26f MDL-10107 - Removed old email_to_user with we still arround and added default message processor for user,
adminuser and on messagelib
2008-08-02 00:04:29 +00:00
moodler
3b120e464f MDL-10107 - First check-in of Messaging 2.0 code from Luis Rodrigues, GSOC student.
This new messaging system replaces all the various email_to_user() calls.
They are now replaced by events triggers, and the messages are then
processed centrally according to user preferences and sent to one or more
processors (email, popup, jabber etc...)

This code is not finished yet, a lot of work still has to be done on the
interface.  However, the basic structure is there and should be working.
Luis and I will be reviewing and polishing this heavily in the next few weeks.
2008-07-24 08:38:03 +00:00
tjhunt
b55797b8cc MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase. I was able to factor out some commonalities with review.php along the way. 2008-07-15 15:30:39 +00:00
jamiesensei
98f38217bb MDL-14216 "Improvements to regrade report - improved reporting of actions and dry run / regrade" 2008-07-11 07:27:14 +00:00
tjhunt
66d07f81a1 MDL-15538 - Rework attempt.php to use attemptlib.php - I had broken processing of submitted responses. Hopefully it is fixed again now. 2008-07-08 18:22:18 +00:00
tjhunt
1aab356193 MDL-15539 - Rework review.php to use attemptlib.php - clean up how review options are calculated, fix up some comments, and make some requires more robust. 2008-07-08 17:46:59 +00:00
tjhunt
78e7a3dd5d MDL-15452 - Put the OU quiz navigation improvements into the Moodle codebase - quite a lot of progress, sorry I am committing this as a big lump, but it took me a while to get the code back to a working state.
MDL-15537 - create oo attemptlib.php to hold shared code between attempt, summary and review.php
MDL-15541 - Refactor starting a new attempt into a new file startattempt.php
MDL-15538 - Rework attempt.php to use attemptlib.php
2008-07-08 16:33:47 +00:00
jamiesensei
26a29b1ab5 MDL-15250 "Adding a new function quiz_question_action_icons that outputs a string of html" 2008-06-15 11:52:07 +00:00
skodak
245ac55791 MDL-14679 last forgotten bits of dml conversion 2008-06-09 19:48:24 +00:00
skodak
dfee5a9a8a MDL-15113 converted some skipped dml stuff 2008-06-09 12:18:13 +00:00
nicolasconnault
9cf4a18b41 MDL-15113 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing.
MDL-15100 Fixed a bug in gradelib.php
Plus edited tablelib.php for table_sql upgrade to dmllib 2.0
2008-06-09 10:00:35 +00:00
tjhunt
97344ae331 Improve PHPdocs on a function. 2008-04-23 14:31:21 +00:00
jamiesensei
58ffdbb883 MDL-14471 - when attempt data is generated by a script then sometimes quiz_get_latest_attempt_by_user fetches the wrong attempt since timestart for the attempt is not a second apart from the last attempt - "patch to quiz/locallib.php function quiz_get_latest_attempt_by_user which makes the query simpler and also makes it more robust.
In the case that there are two attempts started in the same second, which can happen if you are generating random attempt data then the id field is used to tell which is the later attempt."
2008-04-23 06:45:11 +00:00
jamiesensei
e89e09d21d MDL-14283 attempt in mdl_question_states is always 1 - typo in attempt.php introduced in Tim's access rules refactor meant that attempt in quiz_attempts table was always set to 1. This meant that only one attempt was shown on the quiz/view.php page as well as causing other problems. 2008-04-09 13:01:40 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
tjhunt
6b84dd19ac Replace some tabs that managed to slip in. What is Eclipse playing at? 2008-03-07 12:36:16 +00:00
tjhunt
c52c62d1b1 MDL-13806 - Refactor all the code that implements the rules for whether students can attempt the quiz now into some classes.
Resource page now done as well. That should be everything.
2008-03-07 12:33:07 +00:00
tjhunt
f0079c3e81 MDL-13738 - Invalid context developer debug notice in manual grading. 2008-02-29 16:22:15 +00:00
tjhunt
255985f17b MDL-12776 - Quiz email notification and separate groups mode - student not in group -> all teachers get email I have changed it so that if the quiz is set to groups mode, and if the student is not in a group, then only teachers with 'accessallgroups' get emailed. 2008-02-28 22:44:12 +00:00
tjhunt
692b631d9d MDL-12815 - Quiz uses inconsistent class attribute for the paging bar. I have added the standard .paging class, but I have left the old class there too, so as not to break existing themes. 2008-02-28 21:43:50 +00:00
tjhunt
4f67bf8c4d MDL-13390 - Wrong links in quiz notification emails 2008-02-19 16:19:58 +00:00
tjhunt
b7b4f8bdc4 Improve the quiz_rescale_grade function, and call it from one other place, instead of duplicating code. Merged from MOODLE_19_STABLE. 2007-12-18 18:20:25 +00:00
tjhunt
5a128471cc Fix notice. 2007-12-12 17:47:35 +00:00
stronk7
87c06e6ebd Using new cross-db sql_isnotempty() function. MDL-12084 2007-12-07 15:58:04 +00:00
tjhunt
f63a4ff2cc Eliminate duplicate $Id$ tag. Merged from MOODLE_19_STABLE. 2007-11-07 15:26:37 +00:00
tjhunt
8289cdf33a MDL-10284 - wrong language string used on the quiz view page to inform students of the quiz deadline. I took the opportunity to strip out an unnecessary HTML table, and reviewing uses of the string /quiz(open|close)s?/ found one other inconsistency on the quiz editing form. Merged from MOODLE_18_STABLE. 2007-10-31 17:08:47 +00:00
tjhunt
e2833e8700 MDL-11617 - 'Student may review' heading on quiz settings form is now misleading. I have fixed some lang strings and improved the help. Also, finish off the clarification of how various capabilites affect quiz review that was started in MDL-11580. 2007-10-09 15:19:07 +00:00
tjhunt
01600b5190 MDL-11580 - refinement to Yu's checkin, including removing the $CFG->openuniversityhacks.
Also, reviewing the new code made me realise that the code in mod/quiz/report/overview/report.php was a mess, so I cleaned it up a bit.
2007-10-04 15:57:09 +00:00
toyomoyo
fb72e817d9 MDL-11580, hide quiz grades when user has no grade:viewhidden capability and quiz is still open, need $CFG->openuniversityhacks flag set 2007-10-04 08:22:55 +00:00
tjhunt
a4faed6925 MDL-10030 - the logic controlling whether students were allowed to see the review screen was wrong. 2007-09-21 16:01:40 +00:00
tjhunt
b5a16eb72e MDL-6376 - Include quizzes on the MyMoodle page. Initial implementation by Stephen Bourget, with refinements by Tim Hunt. The logic for which quizzes are listed is very similar to the lesson module. 2007-09-21 11:05:04 +00:00
tjhunt
07a7d85924 MDL-11267 - Anywone who can view quiz reports can delete student attempts. Merged from MOODLE_18_STABLE. 2007-09-17 16:17:24 +00:00
mattc-catalyst
5ada3c8e3a MDL-10888: groupings - mod/quiz - add groupings support 2007-08-27 03:56:39 +00:00
skodak
5bf243d131 MDL-10383 - groups/groupings refactoring nearly finished ;-) 2007-08-16 11:06:48 +00:00
jamiesensei
e7e62d45be Fix for MDL-10823 Access to question edit page denied from quiz preview screen. 2007-08-14 04:22:05 +00:00
jamiesensei
271e6decda merging MOODLE_19_QUESTIONS with HEAD 2007-08-09 21:51:09 +00:00
tjhunt
0675e5eb8f MDL-9519 - incorrectuse of language strings in quiz. Merged from MOODLE_18_STABLE. 2007-08-06 13:22:59 +00:00
tjhunt
de266537a7 MDL-10300 - cleaning incorrectly applied to overall feedback. 2007-07-30 10:33:43 +00:00
tjhunt
00719c02d6 MDL-10656 - Way to control when Overall feedback is displayed, independantly of the other sorts of feedback. Also, improve the layout of those settings on the quiz editing form. 2007-07-30 10:05:11 +00:00
tjhunt
ed8bebce5a MDL-10452 - start quiz UI is confusing if you have quiz:preview capability. Change the 'start/continue attempt button' to say 'start/continue preview' in this case. Merged from MOODLE_17_STABLE. 2007-07-13 15:58:42 +00:00
tjhunt
b0972c0593 MDL-648 - minor corrections. 2007-07-06 08:20:07 +00:00
tjhunt
ac48e43a89 MDL-648 - Email notification and confirmation when quizzes are submitted. Thanks to Graham Miller for implementing this to my design. 2007-06-26 16:34:05 +00:00