Nicolas Connault
dd15ef0e1b
MDL-36413 Added "this->" to exclude variable assignment
...
The this-> keyword was missing from the $exclude = array() statement.
2012-11-07 14:48:40 +08:00
Aparup Banerjee
84c04ff295
Merge branch 'MDL-35776' of git://github.com/timhunt/moodle
2012-10-09 11:53:12 +08:00
Eloy Lafuente (stronk7)
b5d155a417
MDL-34657 gropus UI: delete unused var.
2012-10-04 23:49:12 +02:00
Tim Hunt
70f5ed370f
MDL-34657 gropus UI: sort existing group memebers.
2012-10-04 11:45:56 +01:00
Tim Hunt
c62488c22f
MDL-35776 user ajax: fix sort order in chrome.
...
It seems that Chrome orders fields of objects in order of array key.
Therefore we must stop using user.id in the PHP arrays, and instead
ensure that we use sequential numbers.
This commit fixes the user selector.
2012-10-03 18:46:07 +01:00
Dan Poltawski
624feda48d
Merge branch 'MDL-35680' of git://github.com/timhunt/moodle
2012-10-02 09:52:12 +08:00
Tim Hunt
e783cc45ae
MDL-35680 user selector: more usable when queries are slow.
...
The problem is to do when you pause a bit, so a search starts, and then
type a bit more before the search finishes. It was behaving like this:
1. Type a bit, then pause.
2. First search request sent.
3. Type a bit more, then pause.
4. Second search request sent.
5. First search request completes.
6. You try to select one result.
7. Second search request comples, overwriting what you are selecting.
This fix works by cancelling the first request before sending the
second.
2012-09-27 19:03:34 +01:00
Tim Hunt
de867fa36e
MDL-34657 user selector: bug with "keep non-matching selected users"
2012-09-27 16:41:50 +01:00
Tim Hunt
9695ff811b
MDL-34657 user sorting: consistent sorting everywhere.
...
This commit coverts everything in the codebase to use the new
users_order_by_sql function when sorting lists of users. More details in
the bug.
Note that this does not change places where users are displayed in a
sortable table, and the sort order comes from the table.
2012-09-27 12:41:42 +01:00
Eloy Lafuente (stronk7)
519fb0b878
Merge branch 'wip-mdl-34606' of git://github.com/rajeshtaneja/moodle
2012-09-04 02:08:54 +02:00
Rajesh Taneja
25ac6d30f2
MDl-34606 Administration: id for clear button is set properly, and disabled on page load
2012-08-27 15:13:52 +08:00
sam marshall
1d1917aeaa
MDL-31973 Groups: groups_members table should have 'component', 'itemid' fields
2012-08-24 15:30:13 +01:00
Petr Škoda
cb94adc252
MDL-34776 improve multiple "NOT IN" enrolment and role related queries
2012-08-18 09:56:25 +02:00
Frederic Massart
4373103084
MDL-34460 Librairies: Replaced deprecated get_context_instance()
2012-07-26 13:23:28 +08:00
Rajesh Taneja
1e12c1203b
MDL-30651 libraries: Replaced deprecated PARAM_INTEGER with PARAM_INT
2012-07-19 15:37:46 +08:00
Petr Skoda
c52551dc3c
MDL-8249 localise standard role names and descriptions if empty
2012-07-06 08:22:34 +02:00
Marina Glancy
3c2ed2d7ce
MDL-31072: Fixed bug causing memory overflow for many-user systems:
...
when function find_users was supposed to be used for user validation but no userids were passed to it, it retrieved all users in the system.
This caused memory overflow on systems with too many users (like moodle.org).
Now we make sure that find_users is not called for validation if there is nobody to validate.
Also improved query inside find_users to make it work faster
2012-01-13 10:12:17 +08:00
sam marshall
5c60a847f5
MDL-26647 (1) 'extrauserselectorfields' -> 'showuseridentity', add capability
...
This change:
- Renames the existing setting 'extrauserselectorfields' to 'showuseridentity'
in preparation for using it in more places. (Upgrade change, new version.)
- Adds a new capability moodle/site:viewuseridentity, now required in order
to see the extra fields; if you don't have the capability, you don't see them
- Slightly improves the display of extra fields in user selector list; it used
to be like 'sam marshall, 01234567, email@address' and is now
'sam marshall [01234567, email@address]' ie the fields are in square
brackets
- Turns feature on for the group selector - the feature was enabled for other
user selectors but not for the group selector. Tim did the disable code, he
thinks this may be to do with more people having access to group selector -
probably not a problem now it is controlled by capability.
2011-11-04 13:57:08 +00:00
Petr Skoda
409ac82413
MDL-29233 revert the optional_param workaround and use this->multiselect to decide when we expect arrays
2011-09-05 09:02:47 +02:00
Rajesh Taneja
c600761b15
MDL-29104 course: Fixed optional_param_array usage for load_selected_users
2011-08-29 17:30:40 +08:00
Petr Skoda
18bd7573d6
MDL-26796 convert array parameter cleaning to new functions
2011-08-18 08:40:33 +02:00
Petr Skoda
cf717dc26b
MDL-27148 use new get_in_or_equal() param prefix instead of start
2011-04-14 15:15:01 +02:00
Adam Olley
9bf6815753
user-selector MDL-25975 Fixed timeout bug in user selector that was affecting IE8
2011-03-18 15:02:55 +08:00
Eloy Lafuente (stronk7)
cd5fdfd87a
MDL-25708 recordsets - tag and user directory
2011-01-22 13:34:28 +01:00
Petr Skoda
8a7703ce53
MDL-25973 add missing charset
2011-01-14 09:32:17 +01:00
Petr Skoda
1c7a2f84db
MDL-24787 fixing group UI to work for users without roles too
2010-10-26 13:38:05 +00:00
Aparup Banerjee
0e638ff452
ajax MDL-23694 added missing page context which fixes groups ui ajax search
2010-09-24 03:57:13 +00:00
Sam Hemelryk
0b3f854736
groups MDL-24262 Tidied up inline script from group selector
2010-09-20 02:22:19 +00:00
Petr Skoda
ca3b1fd973
fixed unterminated JS statements
2010-09-17 19:59:16 +00:00
Petr Skoda
eab8ed9fb7
fixed a few spelling errors in /admin/
2010-09-17 10:27:26 +00:00
Petr Skoda
f63ac65ac5
MDL-24079 converted sql_ilike() to new sql_like in user selectors
2010-09-04 11:46:00 +00:00
Petr Skoda
04aec3dacf
MDL-23927 do not use = 'guest' because we have CFG->siteguest AND it matches any other username with accents and different case in MySQL
2010-08-25 08:32:59 +00:00
jerome mouneyrac
206dd86100
webservice MDL-23471 fix XHTML strict issues + two XHTML strict issues related to the user selector form element and the admin_settings_heading class
2010-07-30 07:43:14 +00:00
Sam Hemelryk
f19497f22e
group-javascript MDL-22935 Fixed problematic conversion to Moodle 2 JS methods, Thanks Paul for the patch
2010-07-23 04:19:42 +00:00
Petr Skoda
df997f841f
MDL-21782 reworked enrolment framework, the core infrastructure is in place, the basic plugins are all implemented; see the tracker issue for list of unfinished bits, expect more changes and improvements during the next week
...
AMOS START
MOV [sendcoursewelcomemessage,core_admin],[sendcoursewelcomemessage,enrol_self]
MOV [configsendcoursewelcomemessage,core_admin],[sendcoursewelcomemessage_desc,enrol_self]
MOV [enrolstartdate,core],[enrolstartdate,enrol_self]
MOV [enrolenddate,core],[enrolenddate,enrol_self]
CPY [welcometocourse,core],[welcometocourse,enrol_self]
CPY [welcometocoursetext,core],[welcometocoursetext,enrol_self]
MOV [notenrollable,core],[notenrollable,core_enrol]
MOV [enrolenddaterror,core],[enrolenddaterror,enrol_self]
MOV [enrolmentkeyhint,core],[passwordinvalidhint,enrol_self]
MOV [coursemanager,core_admin],[coursecontact,core_admin]
MOV [configcoursemanager,core_admin],[coursecontact_desc,core_admin]
MOV [enrolledincourserole,core],[enrolledincourserole,enrol_manual]
MOV [enrolme,core],[enrolme,core_enrol]
MOV [unenrol,core],[unenrol,core_enrol]
MOV [unenrolme,core],[unenrolme,core_enrol]
MOV [enrolmentnew,core],[enrolmentnew,core_enrol]
MOV [enrolmentnewuser,core],[enrolmentnewuser,core_enrol]
MOV [enrolments,core],[enrolments,core_enrol]
MOV [enrolperiod,core],[enrolperiod,core_enrol]
MOV [unenrolroleusers,core],[unenrolroleusers,core_enrol]
AMOS END
2010-06-21 15:30:49 +00:00
Petr Skoda
4f0c2d0009
MDL-21655 big scary enrolment and roles improvements - see tacker for list of changes, includes other minor fixes too
2010-03-31 07:41:31 +00:00
Sam Hemelryk
456e4852c6
user-selector MDL-21537 Refactored JS to make use of YUI3
...
* YUI3 used instead of YUI2, converted all YUI2 components to YUI3 equivalents.
* Renamed user/selector/script.js to module.js
* Converted uses of the the user selector to YUI3 + the new events
2010-03-23 07:38:32 +00:00
Petr Skoda
41912a261f
MDL-21400 converting JS set_user_preference to M namespace and YUI3
2010-02-06 15:20:24 +00:00
Petr Skoda
9598d578bb
MDL-21420 modole_cfg converted to M.cfg
2010-01-21 22:19:46 +00:00
Petr Skoda
9dec75dbcc
MDL-21240 shortened urls now start with / everywhere
2010-01-18 20:57:32 +00:00
Petr Skoda
a685593466
MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions
2010-01-16 15:39:56 +00:00
Andrew Davis
bf1ac6d9ae
group MDL-20005 added display of other groups users are in
2009-12-21 08:13:50 +00:00
Petr Skoda
2f67a9b3a5
MDL-20700 whitespace terror returns yet again
2009-12-16 22:22:37 +00:00
Petr Skoda
b5d0cafc6f
MDL-20787 final switch to new $OUTPUT->pix_url() - yay!
2009-12-16 21:50:45 +00:00
Petr Skoda
f44b10ed93
MDL-21139 replace all yui functions/methods with yui2 to make room for yui3
2009-12-16 20:25:14 +00:00
Sam Hemelryk
c23c90093e
mod-forum MDL-17550 Converted subscribers.php to use the new user_selector control
...
At the same time I also converted weblib.php::check_theme_arrows to use UTF8 arrows rather than entities.
2009-12-10 02:11:28 +00:00
Petr Skoda
aa6c1ced0a
MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup
2009-11-04 08:11:02 +00:00
jerome
234c18e44d
user selector MDL-16992 just add a comment to the function phpdoc get_option() that must be implemented to use the base search ajax field
2009-10-14 07:25:59 +00:00
samhemelryk
ce221eb52d
user MDL-19825 Added set_url calls, replaced deprecated functions, and boilderplate
2009-09-25 04:02:46 +00:00
tjhunt
ddedf979b4
MDL-19690 - more $CFG->pixpath to $OUTPUT->old_icon_url
2009-07-03 06:19:25 +00:00