7483 Commits

Author SHA1 Message Date
David Monllao
77ac4d8c31 Merge branch 'MDL-63445-master' of git://github.com/bmbrands/moodle 2018-10-29 16:47:45 +01:00
Eloy Lafuente (stronk7)
f3d80b483b Merge branch 'MDL-63730-master-enfix' of git://github.com/mudrd8mz/moodle 2018-10-29 13:23:53 +01:00
Andrew Nicols
d4274bd951 Merge branch 'MDL-60520_master' of git://github.com/dmonllao/moodle 2018-10-29 07:39:58 +08:00
David Mudrák
f5d98e6173 MDL-63730 lang: Update Behat scenarios to use the new strings 2018-10-26 13:25:56 +02:00
Helen Foster
0c19b2c8fa MDL-63730 lang: Merge English strings from the en_fix language pack
Significant string changes:

* withselectedusers_help, core - removing mention of 'Add a common note'
  as the option no longer exists
* considereddigitalminor and digitalminor_desc, core - more
  child-friendly wording
* configmessagingallusers, core_admin - clearer explanation
* auth_dbtype, auth_db - fixed broken link
2018-10-26 12:48:40 +02:00
Eloy Lafuente (stronk7)
51da48f193 Merge branch 'MDL-63765-master' of git://github.com/damyon/moodle 2018-10-26 10:21:43 +02:00
Damyon Wiese
cfd390ee94 MDL-63765 behat: Fix behat tests opening a menu
If javascript is disabled, we don't need to open the menus at all. If it is enabled
we should use the custom step where possible.

In some tests (user profile) we have to use link_or_button because
the element that opens the menu will be a link or a button in different themes.
2018-10-26 16:14:41 +08:00
Jun Pataleta
96b9975b4b MDL-60514 tool_task: Remove run_task_now.feature
This test cannot be run on Behat anymore as the "Run now" feature
depends on $CFG->pathtophp. Even if it's set, the task executed via
"Run now" will be executed for the installed site itself and not on the
Behat test site.
2018-10-26 11:03:07 +08:00
Eloy Lafuente (stronk7)
513bb61301 Merge branch 'MDL-62904-master' of git://github.com/junpataleta/moodle 2018-10-26 00:03:43 +02:00
Jun Pataleta
35b76161b3 Merge branch 'MDL-60514-master-new-cron-execution' of https://github.com/tonibarbera/moodle 2018-10-25 15:06:47 +08:00
Toni Barberà Melià
c759ae5d55 MDL-60514 tasks: added new config parameter. changes in cron execution 2018-10-25 08:02:44 +02:00
Eloy Lafuente (stronk7)
3d18697115 Merge branch 'MDL-63153_master' of https://github.com/aanabit/moodle 2018-10-25 01:11:36 +02:00
Andrew Nicols
d95ad08f85 MDL-63619 tool_dataprivacy: Cache purposes in form 2018-10-24 08:48:18 +08:00
Andrew Nicols
3b002c86eb MDL-63619 tool_dataprivacy: Performance improvement 2018-10-24 08:48:18 +08:00
Andrew Nicols
d2aed78933 MDL-63619 tool_dataprivacy: Fix inheritance from parent contexts
Inheritance should behave such that all contexts inherit from their
parent context.

Prior to this fix, if the value was not set on a context, then it was
getting a default of 'Inherit', but instead of inheritting from the
parent context, it was inheritting from its parent context _level_ which
is just wrong.
2018-10-24 08:48:18 +08:00
Damyon Wiese
3ed1cec01e MDL-62139 behat: Invalid test
If javascript is disabled, we can't open the menu.
2018-10-23 16:47:20 +08:00
Bas Brands
a7712a9851 MDL-63445 core_renderer: display course image in context header 2018-10-23 09:41:26 +02:00
Andrew Nicols
e1cc780d90 MDL-63657 tool_mobile: Coding style fix 2018-10-23 11:21:51 +08:00
Andrew Nicols
38259438dd Merge branch 'MDL-63657-master' of git://github.com/mickhawkins/moodle 2018-10-23 11:19:46 +08:00
Andrew Nicols
33368fb6d5 MDL-63664 tool_policy: Whitespace fix 2018-10-23 10:54:15 +08:00
Michael Hawkins
1139481e58 MDL-63657 tool_mobile: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
2018-10-23 10:54:14 +08:00
Andrew Nicols
dfb151b2d9 Merge branch 'MDL-63664-master' of git://github.com/mickhawkins/moodle 2018-10-23 10:42:48 +08:00
Michael Hawkins
f6843ac966 MDL-63664 tool_policy: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
2018-10-23 10:02:58 +08:00
Andrew Nicols
e1121c2ed5 MDL-62560 tool_dataprivacy: Behat fix for protected check 2018-10-23 08:17:28 +08:00
David Monllao
14f70eda28 Merge branch 'MDL-62309-master-optionalpolicies' of git://github.com/mudrd8mz/moodle 2018-10-22 16:28:41 +02:00
David Monllao
d44ce97fe1 MDL-60520 analytics: Do not block model updates if the backend is down 2018-10-22 13:58:33 +02:00
David Monllao
ed12ba6ba8 MDL-60520 analytics: Per-model ml backend 2018-10-22 13:58:33 +02:00
David Monllao
f7642bebc5 Merge branch 'MDL-62560-master' 2018-10-22 12:52:58 +02:00
Andrew Nicols
9e217d8441 MDL-62560 tool_dataprivacy: Add a purpose override cache 2018-10-22 12:50:16 +02:00
Andrew Nicols
b519dab3bd MDL-62560 tool_dataprivacy: Fetch user purpose once 2018-10-22 12:50:16 +02:00
Andrew Nicols
a1d51ad8c6 MDL-62560 tool_dataprivacy: Add status logging 2018-10-22 12:50:16 +02:00
Andrew Nicols
efbb82ac31 MDL-62560 tool_dataprivacy: Add unit test for filtered userlist 2018-10-22 12:50:15 +02:00
Michael Hawkins
46bb823e04 MDL-63659 tool_monitor: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
2018-10-22 12:50:10 +02:00
Michael Hawkins
dcdd4f1053 MDL-63497 tool_dataprivacy: Add support for removal of context users
This issue is a part of the MDL-62560 Epic.
2018-10-22 12:48:32 +02:00
Amaia Anabitarte
f765fb380a MDL-63153 admin: Adding Moodle services page to Site Administration 2018-10-22 11:08:27 +02:00
David Mudrák
aa7e539c6f MDL-62309 tool_policy: Add Behat scenarios for the optional policies 2018-10-22 08:49:36 +02:00
David Mudrák
222c378870 MDL-62309 tool_policy: Amend behaviour of handler's accept() method
When accepting the policies via the sitepolicy handler, only compulsory
policies are to be marked as accepted. Optional policies will be left as
pending. Users must express their consent explicitly for them.

As a side product of the change, unit tests are added for the whole
handler class.
2018-10-22 08:49:36 +02:00
David Mudrák
ad5e2135c5 MDL-62309 tool_policy: Improve permission evaluation methods
Please refer to the unit tests for the specification of the expected
behaviour.
2018-10-22 08:49:36 +02:00
David Mudrák
4a742e4f94 MDL-62309 tool_policy: Update user acceptances reports
This adds support for optional policies to the user acceptance reports.
Distinguished are "Pending" acceptances (we did not hear yet) from
"Declined" (user did not agree). The status workflow updated to support
new transitions: pending -> declined and declined -> accepted.
2018-10-22 08:49:36 +02:00
David Mudrák
56390aa246 MDL-62309 tool_policy: New icons for user acceptances report
There was an accessibility issue with the previous icons that we used
the same "checked" shape just in different colours for different
meanings. New icons added for the new statuses:

* partial - a warning icon for the overall status column that the user
  has only some policies accepted, not all.
* pending - that we did not hear yet from the user - whcih is different
  from a declined policy.
2018-10-22 08:49:36 +02:00
David Mudrák
5348b1eef5 MDL-62309 tool_policy: Optional policies can be declined by the user
For optional policies, we provide a radio selector to let the user
choose the acceptance status on the consent page. For policies displayed
on their own page, we display a link to decline the policy.

The way how we pass the list of policy version ids to index.php has
changed so that we can now not only pass the list of ids, but also the
actual acceptance status (accepted / declined).
2018-10-22 08:49:36 +02:00
David Mudrák
faf4222edc MDL-62309 tool_policy: Add api::get_agreement_optional() method
This method allows to quickly check if the given policy version is
marked as optional or compulsory. This will be needed in other places
such as permissions check.
2018-10-22 08:49:36 +02:00
David Mudrák
1617fde9a8 MDL-62309 tool_policy: New API method to decline a policy
Policy can be declined. Optional policies do not need to be accepted to
use the site. But we still want to hear explicitly from the user.
2018-10-22 08:49:36 +02:00
David Mudrák
f98cd91a13 MDL-62309 tool_policy: Improve api::is_user_version_accepted() return
The method now returns three-state logic. A bool value true/false is
returned if the user has accepted/rejected the policy, respectively. A
null value is returned if the user did not express their agreement in
either way yet.

This allows to distinguish between "rejected the policy" and "did not
say anything about it yet" cases.
2018-10-22 08:49:36 +02:00
David Mudrák
9011d394ab MDL-62309 tool_policy: Add new field to hold the optional policy flag
The patch adds a new column to the database table to hold the
information if giving agreement to the policy is compulsory or optional.
The flag can be defined via the policy editing form and is displayed at
the policies management screen.

The last modified time merged with the version column at the policies
management screen to save a bit of horizontal space - needed as we
display more information now at the first column.
2018-10-22 08:49:36 +02:00
Matt Porritt
d5adb60fa3 MDL-62777 Administration: CLI upgrade new setting notification
During a CLI upgrade when there are new settings in core or in
a plugin, the settings are set to the defined defaults
automatically. There is no ouput shown on the CLI about which
new settings have been introduced or what default values the
setting are set to.

This patch outputs the name of the new setting and what the
default value being is set is to the CLI during an upgrade.
Objects and arrays are expanded into a human readable format.
This plugin also makes the function that sets the defaults to
be more robust so it isno longer required to be called multiple
times to ensure all settings are set.
2018-10-22 14:28:06 +11:00
Marina Glancy
97372ec17d MDL-63648 tool_xmldb: missing capability check 2018-10-19 11:36:40 +02:00
Eloy Lafuente (stronk7)
1845a5bbaa Merge branch 'MDL-63648-master' of git://github.com/marinaglancy/moodle 2018-10-18 23:54:06 +02:00
Eloy Lafuente (stronk7)
d6d5ea5d04 Merge branch 'MDL-62920-master' of https://github.com/aanabit/moodle 2018-10-18 23:47:37 +02:00
Jun Pataleta
500dc0b134 MDL-62904 tool_dataprivacy: Add data request links in profile page 2018-10-17 16:40:55 +08:00