4079 Commits

Author SHA1 Message Date
Jun Pataleta
477ef861a0 Merge branch 'MDL-68113-master' of https://github.com/HuongNV13/moodle 2020-04-16 11:46:50 +08:00
Sara Arjona
43cda51ea1 Merge branch 'MDL-68233' of https://github.com/timhunt/moodle 2020-04-06 12:51:22 +02:00
Huong Nguyen
f389e916f2 MDL-68113 Drag and drop into text questions: better responsive design
These changes also make it possible to print these questions.
2020-04-06 14:28:29 +07:00
Eloy Lafuente (stronk7)
d9bb17e696 Merge branch 'MDL-68300' of https://github.com/timhunt/moodle 2020-04-02 13:13:36 +02:00
Tim Hunt
a0f8944305 MDL-68300 question bank: merge duplicate Duplicate Behat tests 2020-04-02 11:18:55 +01:00
Eloy Lafuente (stronk7)
8ba6b97577 Merge branch 'MDL-68265-master' of git://github.com/andrewnicols/moodle 2020-04-01 23:29:13 +02:00
Sara Arjona
677f87e010 Merge branch 'MDL-68277' of https://github.com/timhunt/moodle 2020-04-01 09:14:36 +02:00
Tim Hunt
7459856d26 MDL-68300 questions: un-break duplicating questions without idnumbers
This was a regression caused by MDL-67934
2020-03-31 11:00:39 +01:00
Andrew Nicols
9a0523c6b8 MDL-68265 core_question: Switch question import to request dir 2020-03-30 08:14:46 +08:00
Tim Hunt
1dcd0d3499 MDL-68233 renderers/block: remove illegal uses of $PAGE and $OUTPUT 2020-03-29 15:34:26 +01:00
Tim Hunt
dbf72bb40f MDL-68277 qtype_essay: answer area in reviews should be right size
The answer box size is set by teachers and provides a useful
visual cue how long a response was expected. Therefore, it is
useful to keep the space at least that size in quiz reviews, etc.
2020-03-27 14:11:16 +00:00
Jun Pataleta
67077ae5aa Merge branch 'MDL-68149' of https://github.com/timhunt/moodle 2020-03-26 00:10:01 +08:00
Jun Pataleta
1cc247029e Merge branch 'MDL-68153' of https://github.com/timhunt/moodle 2020-03-25 22:34:36 +08:00
Jake Dallimore
9b8fc9be6d Merge branch 'MDL-67934' of https://github.com/timhunt/moodle 2020-03-25 08:28:27 +08:00
Tim Hunt
f2393804bf MDL-67934 questions: give a sensible default idnumber when duplicating 2020-03-12 18:07:11 +00:00
Tim Hunt
511801eaa9 MDL-68153 qbank: question of unknown type should not cause fatal error
Regression casued by MDL-67153
2020-03-11 20:40:51 +00:00
Tim Hunt
9440b54f8a MDL-68149 qtype_match: correctly distinguish 0 and 0.0 answers
Also added a test for backup & restore (which was working).
2020-03-11 13:43:21 +00:00
Tim Hunt
b060e7495c MDL-68149 qtype_match: Updatey tests to follow make_question() pattern 2020-03-11 13:41:13 +00:00
Bas Brands
e06b302ed5 MDL-67901 type_multichoice: clear my choice accessibility
Improve the accessibility for the clear my choice option. The
extra radio input controlling the reset feature was removed and
resetting the choice is now controlled by JavaScript.
This fixes the missing label reported in Accessibility audit and W3C
validation of the reset link

By this change this issue also fixes MDL-67280
2020-02-27 10:24:12 +01:00
Eloy Lafuente (stronk7)
2b97ab8adb Merge branch 'MDL-67947' of https://github.com/timhunt/moodle 2020-02-19 17:48:14 +01:00
Tim Hunt
887daf932c MDL-67947 questions: questions_in_use should ask all components
Previously it was only checking mods.
2020-02-19 11:55:04 +00:00
Sara Arjona
a7cd3a17fc Merge branch 'MDL-66834-master' of https://github.com/kepeter/moodle 2020-02-11 11:54:12 +01:00
Eloy Lafuente (stronk7)
986c5283cf Merge branch 'MDL-67832' of https://github.com/timhunt/moodle
(fixed a couple of typos in the merge commit)
2020-02-06 00:01:07 +01:00
Peter Eliyahu Kornfeld
3ab494b154
MDL-66834 Questions: add transaction, move trigger 2020-02-03 12:29:43 +02:00
Tim Hunt
1aacbb72d3 MDL-67832 quiz: fix lots of PHPdoc in attemptlib.php 2020-01-31 19:09:03 +00:00
Tim Hunt
2569fb5d2c MDL-67842 questions: Cannot remove the idnumber from a question 2020-01-30 17:24:59 +00:00
Eloy Lafuente (stronk7)
cefcb68f63 Merge branch 'MDL-64531-master-questiondeletejson' of git://github.com/mudrd8mz/moodle 2020-01-27 17:07:33 +01:00
Jun Pataleta
21b0f581e1 Merge branch 'MDL-67115' of https://github.com/stronk7/moodle 2020-01-23 15:12:56 +08:00
David Mudrák
8c1d645351 MDL-64531 course: Add Behat test for deleting a quiz with own questions
Teachers can delete Quiz activities that have a question in their own
context via AJAX request with the course recycle bin disabled. This used
to lead to "Unexpected token < in JSON" because of the extra HTML in the
output.
2020-01-20 18:20:57 +01:00
Eloy Lafuente (stronk7)
ee439d017e MDL-67115 core: php74 params order for implode()/join()
Passing parameters to implode() in reverse order is deprecated, use
implode($glue, $parts) instead of implode($parts, $glue).

This commit corresponds to phpunit and manual detections, core files.
2020-01-19 18:47:07 +01:00
Tim Hunt
76a49e4a1e MDL-67653 questions: prevent the flag flickering as the page loads 2020-01-10 14:27:42 +00:00
Eloy Lafuente (stronk7)
4621917c62 MDL-67114 core: php74 fix. Fix use of scalar as array in core
There are various places where it's not guaranteed that the
variable being used is array, and instead, can be null, bool, int...

We need to check that because php74 warns about it.

Where possible we have used the coalesce operator as
replacement for isset() ternary operations.
2020-01-03 11:33:15 +01:00
Adrian Greeve
42d7f7f9e4 Merge branch 'MDL-65809-master' of git://github.com/sarjona/moodle 2019-12-24 14:53:03 +08:00
Adrian Greeve
f00542c485 Merge branch 'MDL-66999-master' of git://github.com/bmbrands/moodle 2019-12-23 14:26:39 +08:00
Sara Arjona
a26cfe71d3 MDL-65809 upgrade: clean < 3.5.0 upgrade steps
This just deletes all the upgrade steps previous to 3.5.0. Some
small adjustments, like tweaking globals can also be applied
when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2018051700 (v3.5.0) as anti-cheating measure.

Previous commits have removed/deprecated all the upgradelib functions
not used anymore in codebase. Deletion has been documented in corresponding
upgrade.txt files:

- upgrade_fix_block_instance_configuration()
- upgrade_theme_is_from_family(), upgrade_find_theme_location()
and linkcoursesectionsupgradescriptwasrun setting
- upgrade_block_positions
- upgrade_fix_config_auth_plugin_names()
 and upgrade_fix_config_auth_plugin_defaults()
- format_xxx_upgrade_remove_numsections(), format_xxx_upgrade_hide_extra_sections()
and format_xxx_upgrade_add_empty_sections()
- filter_mathjaxloader_upgrade_cdn_cloudflare()
and filter_mathjaxloader_upgrade_mathjaxconfig_equal()
- get_assignments_with_rescaled_null_grades()

These have been kept because continue being used by restore:

- \core\task\refresh_mod_calendar_events_task
2019-12-20 12:20:43 +01:00
Shamim Rezaie
6d1eb00445 MDL-67151 qtype_numerical: convert the tolerance to string before saving
Fix the sqlserver issue when saving a number into a text field
2019-12-20 01:11:59 +11:00
Bas Brands
072fcde3ee MDL-66999 theme_boost: @extend phpunit fixes 2019-12-12 11:27:59 +01:00
Bas Brands
aa100b767f MDL-66999 theme_boost: @extend remove extends for questions 2019-12-12 11:27:58 +01:00
Shamim Rezaie
9173b83e58 MDL-67151 qtype_calculatedsimple: Support for the scientific format 2019-12-03 16:52:22 +11:00
Shamim Rezaie
a1f10c5ec5 MDL-67151 qtype_calculated: Support for the scientific format 2019-12-03 16:52:22 +11:00
Shamim Rezaie
bb8d19b885 MDL-67151 qtype_numerical: Support for the scientific format 2019-12-03 16:52:22 +11:00
Shamim Rezaie
35ca1475b5 MDL-67151 core_question: Support scientific format at question preview 2019-12-03 16:52:22 +11:00
Eloy Lafuente (stronk7)
492d047d11 MDL-67284 upgrade: add 3.8.0 separation line to all upgrade scripts 2019-11-17 11:40:19 +01:00
Eloy Lafuente (stronk7)
d5be859063 MDL-67199 versions: bump all versions and requires near release
version = 2019111800 release version
requires= 2019111200 current beta (week7roll1) version
2019-11-12 17:57:08 +01:00
Tim Hunt
c9491626ab MDL-67153 question bank: let qtype add actions to the edit menu 2019-11-06 19:32:15 +00:00
Jake Dallimore
72a5ab2130 Merge branch 'MDL-66965' of https://github.com/stronk7/moodle 2019-10-29 14:13:00 +08:00
Eloy Lafuente (stronk7)
32b625b6de Merge branch 'MDL-66956' of https://github.com/timhunt/moodle 2019-10-28 19:41:58 +01:00
Eloy Lafuente (stronk7)
88d29a1bb8 MDL-66965 core: php74 curly 2 square braces changes
Note this only modified core files, still there are a lot
of curly brace uses but all them are within 3rd part
libraries and will be handled apart.
2019-10-25 17:41:10 +02:00
Luca Bösch
f68616d750 MDL-67001 question: alignment and form spaces. 2019-10-23 10:59:24 +02:00
Eloy Lafuente (stronk7)
3c75bfa457 Merge branch 'MDL-66980' of https://github.com/timhunt/moodle 2019-10-21 20:26:34 +02:00