mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-02-13 12:34:28 +01:00
Code Issues Projects Releases Wiki Activity
46,063 Commits 36 Branches 523 Tags
Commit Graph

61 Commits

Author SHA1 Message Date
David Mudrak
d1571da6c8 MDL-25068 forum: fixed error string usage 
The string [cannotsubscribe,mod_forum] is supposed to be used for group
membership check only. I have fixed the two other usages of the string.
Note that the condition if (forum_subscribe()) was useless as the
function return true values only now after $DB conversion.
 2010-12-07 12:34:35 +00:00
David Mudrak
9a3adb2032 NOMDL forum: fixed the string wording to match the current code condition 
Previous string was used together with the legacy:guest capability.
However, the current code checks is_enrolled() instead. This led to a
weird situation when non-enrolled admin or manager could not subscribe
to a forum and the error message was completely confusing for them.
 2010-12-07 12:34:11 +00:00
David Mudrak
99eb51d9e4 MDL-22114 forum: fixed PAGE url param set 
I am pretty sure Sam overlooked this is in the commit afef965e
 2010-12-07 12:33:24 +00:00
Sam Hemelryk
afef965e28 mod-forum MDL-22114 Enhanced navigation options for forum in regards to subscription. 2010-04-21 08:05:03 +00:00
Petr Skoda
4f0c2d0009 MDL-21655 big scary enrolment and roles improvements - see tacker for list of changes, includes other minor fixes too 2010-03-31 07:41:31 +00:00
Petr Skoda
a685593466 MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions 2010-01-16 15:39:56 +00:00
Petr Skoda
2f67a9b3a5 MDL-20700 whitespace terror returns yet again 2009-12-16 22:22:37 +00:00
Sam Hemelryk
8f685009b3 forum MDL-21086 cleaned up boilderplates and php doc packages 2009-12-10 03:11:18 +00:00
Petr Skoda
1adbd2c350 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 14:55:15 +00:00
samhemelryk
cd4e6b1769 mod-forum MDL-19808 Added set_url calls, replaced deprecated functions 2009-09-24 06:41:04 +00:00
samhemelryk
15ca5e5e0d forum MDL-19808 Upgraded print_header and build_navigation calls to OUTPUT/PAGE equivilants 2009-09-04 05:50:21 +00:00
nicolasconnault
59e28d8f5d MDL-19808 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno 2009-08-20 08:44:35 +00:00
nicolasconnault
396fb912ff MDL-19808 Converted all print_footer() calls 2009-08-06 14:14:09 +00:00
skodak
93f66983cc MDL-17773 new get_login_url() function - fixes missing httpslogin tweaks 2009-01-02 22:56:48 +00:00
dongsheng
dde78cb8f2 MDL-14129, remove error() in forum mod. 2008-07-21 08:03:42 +00:00
nicolasconnault
4e44535526 MDL-15108 Upgrade finished, preliminary tests successful. Please continue testing. 2008-06-05 20:16:09 +00:00
skodak
35987665f4 MDL-14617 removed some legacy group code 2008-05-01 22:30:28 +00:00
skodak
90f4745c22 MDL-14113 patch for multiple issues - see tracker for subtasks; merged from MOODLE_19_STABLE 2008-04-13 19:15:02 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
scyrma
d417533252 Fix for par of the missing strings, as reported in MDL-12294 2007-11-26 04:10:08 +00:00
dwoolhead
01cbbbd70a MDL-11979 Forum subscriptions loop hole allowing users to subscribe to forums they should not have access to. 2007-11-16 16:31:00 +00:00
sam_marshall
52ca1e737e MDL-12055 Tweaked forum subscribe 'continue' address 2007-11-07 17:33:12 +00:00
sam_marshall
93e898eb4d MDL-12055 Tweaked forum subscribe 'continue' address 2007-11-07 17:04:48 +00:00
tjhunt
38e179a4ed MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation. 
This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.

Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.

If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.
 2007-10-12 15:55:49 +00:00
skodak
3a233b85c5 MDL-10947 https was replaced with httpss when wwwroot already is https credit goes to Tobias Marx 2007-08-22 19:36:24 +00:00
mattc-catalyst
01e3838853 MDL-9473: Initialise navlinks array before use 
Author: Matt Clarkson <mattc@catalyst.net.nz>
 2007-07-05 04:55:24 +00:00
mattc-catalyst
3b27b0fe21 MDL-9615: Correct incorrect use of term breadcrumbs 
- $crumbs -> $navlinks


Author: Matt Clarkson <mattc@catalyst.net.nz>
 2007-07-05 04:40:48 +00:00
mattc-catalyst
70c6c0ad70 MDL-9474: Updated build_navigation() to use global $COURSE 
- Removed $course parameter from build_navigation()
- Updated all calls to build_navigation()


Author: Matt Clarkson <mattc@catalyst.net.nz>
Committer: Matt Clarkson <mattc@catalyst.net.nz>
 2007-04-23 21:11:10 +00:00
mattc-catalyst
e3f58dfb4e Breadcrumbs: mod/forum changes 
- Modified to use build_navigation() for breadcrumb generation.


Author: Matt Clarkson <mattc@catalyst.net.nz>
 2007-04-16 21:12:29 +00:00
nicolasconnault
cdfe4875ec MDL-8783: Added appropriate language strings to resolve this usability issue. 2007-03-15 06:26:52 +00:00
vyshane
1466926adf Merged from 1.7. 2007-01-29 06:02:17 +00:00
vyshane
818c1b0592 Merged from 1.7. 2007-01-16 02:44:13 +00:00
skodak
1936c10e54 fixed obsoleted use of course->category to find site course - now used SITEID instead MDL-1899 2006-11-12 08:55:13 +00:00
moodler
a321d42bcd Better handling for guest in forums MDL-7125 2006-10-23 04:55:20 +00:00
moodler
0468976c9a SWEEPING CLEANUP 
The API was changed slightly so that has_capability now takes the
whole $context object (we almost always have it anyway)

The $kill thing was removed.   If you want to assert a capability
then use:

    require_capability('capname', $context);

with optional variables to modify the error message

Misc bugs here and there also removed and code tidied
 2006-08-14 05:55:40 +00:00
vyshane
9af1611a06 Replaced capability mod/forum:viewdiscussionsfromallgroups by 
moodle/site:accessallgroups in code. Removed former from mod/forum/db/access.php.
 2006-08-08 06:56:09 +00:00
moodler
bbbf2d4015 ROLES AND PERMISSIONS - FIRST CHECK-IN 
=======================================

WARNING:  DEV IS CURRENTLY VERY UNSTABLE.

This is a mega-checkin of the new Roles system.   A lot of changes have
been made in core and modules.

Currently there are a lot of rough edges and known problems.  We are
working hard on these .. .the reason for getting this into HEAD at this
stage is enable us to move faster (our branch was diverging from HEAD
too much).

Please keep an eye on http://docs.moodle.org/en/Roles for current status
and information for developers on how to use the new Roles system.
 2006-08-08 05:13:06 +00:00
skodak
2c3432e684 fixed problem when set both loginhttps and https in wwwroot, closes bug #5507 and #3848; merged from MOODLE_16_STABLE 2006-05-15 21:36:46 +00:00
skodak
0c0849cf5f lots of incorrect required_param()'s - there MUST be only two parameters not three!! 2006-03-08 00:08:51 +00:00
mjollnir_
098d27d46e New forum type: question and answer: requires students to post their answer before being able to view other posts. After initial post, students can view & respond normally 2006-01-16 04:57:48 +00:00
gustav_delius
4bb36a97ce subscribing always requires the user to be logged in, even for forums on the home page. 2005-10-31 14:21:29 +00:00
mjollnir_
67bbc9b7de Merged from MOODLE_15_STABLE: Postgres doesn't happily convert NULL to 0 for int fields, so we set it manually. Credit: Patrick Li 2005-08-02 22:48:20 +00:00
thepurpleblob
70e3da07fd Changed all optional_variable() and require_variable() to equivalent 
optional_param() and required_param() for greater security.
 2005-06-10 19:54:41 +00:00
stronk7
3849dae80f Now the FIRST string working under CFG->filterall is done: 
forum->name
(everything tested but email)

(I'm going to maintain a list of strings in Developers Wiki)
 2005-03-26 01:57:40 +00:00
gustav_delius
cd8d4471c8 Print course in footer 2005-03-17 15:12:07 +00:00
moodler
c9b8eb3435 Removed another dead-end for guests bug 1975 2005-03-07 04:47:39 +00:00
gustav_delius
ec81373f50 In order to ensure that when a teacher hides a resource or an activity that students really can't get at it, even if they know the direct links to its pages, I have given an optional third argument $cm to the functions require_login() and require_course_login(). Pages showing information about a particular course module now pass the course module object in this third argument. The login functions will then test if either the course module is visible or the user is a teacher. If neither is the case then the user is redirected to the course homepage after being shown a message "Sorry, this activity is currently hidden". 
(While I was at it I also turned the autologinguests off for most module pages, except on the index.php pages and the view.php pages for those modules that allow guests)
 2005-02-16 10:40:48 +00:00
gustav_delius
41905731b7 fixed capitalization and quoting of attribute values 2004-09-12 16:24:41 +00:00
gustav_delius
7b5944cdb3 Can now force subscribe INITIALLY, implementing suggestion by Howard in bug 1084 2004-08-29 19:17:27 +00:00
moodler
d31262021a Minor tweaks I forgot to check in from a long time ago 2004-05-18 03:14:01 +00:00