With previous commit some lang strings became unused. As far as they
are not reusable we are deleting them plain and straight. This is the
list of strings, for reference:
- orphanedquestionscategory
- orphanedquestionscategoryinfo
- oauth2upgrade_message_small
- oauth2upgrade_message_subject
- oauth2upgrade_message_content
- apiv1migration_message_small
- apiv1migration_message_subject
- apiv1migration_message_content
- security_key_notice_message_small
- security_key_notice_message_subject
- security_key_notice_message_content
- pendingupgrades_message_small
- pendingupgrades_message_subject
- pendingupgrades_message_content
This commits removes stuff from different upgradelib files, used
exclusively by the already deleted upgrade steps. Given such
exclusivity it was not needed to proceed with a 2-phase deprecation
as far as the functions were 100% internal to upgrade.
This is the list of deleted functions, all them docummented in their
corresponding upgrade.txt files:
- repository_picasa_admin_upgrade_notification();
- repository_googledocs_admin_upgrade_notification();
- repository_boxnet_admin_upgrade_notification();
- repository_alfresco_admin_security_key_notice();
- qtype_essay_convert_to_html();
- portfolio_picasa_admin_upgrade_notification();
- portfolio_googledocs_admin_upgrade_notification();
- portfolio_boxnet_admin_upgrade_notification();
- mod_book_migrate_moddata_dir_to_legacy();
- mod_book_migrate_all_areas();
- mod_book_migrate_area();
- mod_assignment_pending_upgrades_notification();
- upgrade_mysql_fix_unsigned_and_lob_columns();
- upgrade_course_completion_remove_duplicates();
- upgrade_save_orphaned_questions();
- upgrade_rename_old_backup_files_using_shortname();
- upgrade_mssql_nvarcharmax();
- upgrade_mssql_varbinarymax();
- upgrade_fix_missing_root_folders();
- upgrade_course_modules_sequences();
- upgrade_grade_item_fix_sortorder();
- upgrade_availability_item();
This just deletes all the upgrade steps previous to 2.7.0. Some
small adjustments, like adding missing MOODLE_INTERNAL or tweaking
globals can also be applied when needed.
Next commit will get rid of/deprecate all the upgradelib functions
not used anymore in codebase.
version = planned 2015051100 release version
requires= current 2015050500 rc1 version
Note: On purpose, the course format social wrong version (2015102100)
has been kept unmodified. Looking forward a solution right now.
Update core (repository & portfolio) to use autoload facilities,
getting rid of not-needed-anymore requires.
Clarify a bit the readme_moodle information and expected use.
This is a bit of an ugly way of saying 'I dont support queued exports'.
The google plugins need a valid user session in order to export to the
google services, thereforce we are forcing the export to be interactive
and not queued through cron, as this wont work in the current
implmenetation.
It's possible we could add offline access to the plugins, but I don't
believe it is worth the benefit for the additional complexity.
We are disabling the plugins if not configured. As part of
this upgrade we will emailing admins about this change
if they have a plugin configured.
This is required because OAuth 2 credentials are now required
in the plugin configuration.
NOTE: These strings are temporary and need to be improved.
Updated the various plugins to use OAuth 2.0 for authentication
against google apis. Google are phasing out AuthSub and pushing OAuth as
the replacement.
This changes repository_googledocs, repository_picasa,
portfolio_googledocs and portfolio_picasa
The token for requests is now stored in session rather than a user
prefence and it persists less but doesn't bother the user more than
necessary.
The google docs portfolio plugin is converted to use resumable upload
API as this appears to be what Google have replaced this with.
Unfortunately unlike authsub OAuth will require some setup by admins,
this is linked as a docs page.
* handlers can be defined as internal or external
* external handlers are not called instantly when inside DB transaction
* code cleanup
* more robust detection of broken handlers
* refixed unit tests
* removing all pending events from 1.9 - these can not be processed due to encoding changes
* finally using real 'component' in handlers table
I have discovered a bug with GoogleDocs portfolio in events. An event
handler was defined in googledocs/lib.php and so the cron included just
this library. But the inclusion failed because the superclass
portfolio_plugin_push_base was not known to cron.
IMHO it is generally good habit to require_once the file which defines
the parent classes.
From now on, all English strings use the new syntax. They are not
eval()'ed any more and the only valid placeholders are {$a} and
{$a->foobar}. No extra quotes escaping, dollar sign escaping and putting
double percent signs.
The modified files were exported from AMOS database repository in the
new syntax and were re-ordered by stringid. Standard GNU/GPL and PHPdoc
blocks are added. Where there was no copyright note so far, I added the
default one with Martin Dougiamas as the copyright holder.
Live long and prosper.
