23511 Commits

Author SHA1 Message Date
Jake Dallimore
805d92152e MDL-72299 mod_lti: fix html escaping when reposting cross site posts 2022-07-06 05:24:15 +02:00
Andrew Nicols
b71b2311f3 Merge branch 'MDL-73305_master' of https://github.com/tasosb/moodle 2022-07-06 11:15:51 +08:00
Jun Pataleta
1a74206dbc Merge branch 'MDL-74821-master' of https://github.com/junpataleta/moodle 2022-07-05 22:14:00 +08:00
Laurent David
629bb7f54d MDL-74821 mod_feedback: Fix HTML validator error
* Remove align attribute on table elements
* Fix dangling tr/td on multichoice rated
* Remove colspan as it is not used
2022-07-05 21:24:23 +08:00
Jake Dallimore
10c837f157 Merge branch 'MDL-74815-master' of https://github.com/junpataleta/moodle 2022-07-05 14:52:04 +08:00
Jake Dallimore
8e5a19b6cb Merge branch 'master_mdl-73498' of https://github.com/daniil-berg/moodle 2022-07-05 12:00:43 +08:00
Jun Pataleta
27b5573e51 Merge branch 'MDL-74516' of https://github.com/stronk7/moodle 2022-07-04 23:17:20 +08:00
Jun Pataleta
986e9a2777 Merge branch 'MDL-75008-master-enfix' of https://github.com/mudrd8mz/moodle 2022-07-04 22:18:39 +08:00
Jun Pataleta
d323559965 MDL-74815 pix: Convert PNG version of darkened SVG icons
* Conversion was done using rsvg-convert from librsvg
2022-07-04 14:03:39 +08:00
Jun Pataleta
12ee00bdf6 MDL-74815 pix: Darken colour of grey icons
* Change the fill colour of grey icons from #999 to #888.
2022-07-04 11:29:47 +08:00
Eloy Lafuente (stronk7)
64bf0e9165 MDL-74516 workshop: Better handling of floats for gradepass fields
This re-applies the same fix that was used for the central mod form
to the workshop activity. This is needed because the completion
support for this module is custom (there are 2 grade items), hence
the validations are also custom.

For more information, read the previous commit and MDL-74516

Unfortunately, because of a related bug with assessment completion
(see MDL-69690) we cannot provide automated testing for this
activity. Manual instructions will be provided instead.
2022-07-01 13:55:51 +02:00
Eloy Lafuente (stronk7)
b3b1006201 MDL-74516 activities: Better handling of floats for gradepass fields
Current code was relying on grade_floatval() that is not a validation
function. Instead, the gradepass field must be defined as proper float
and then perform the needed validations using unformat_float().

Note that the float element form has some particularities, see
MDL-73994 for more information and that makes us to have to check
for some values (null, zero) manually. Once that form element type
gets its behaviour fixed, the code will need to be revisited, hence
we have annotated it as comments for easier finding it in the future
(the same changes already were applied to other gradebook forms).

Also, remove an unreachable line of code (comparing with empty string)
within the grade_floatval() function because it's not possible anymore
to pass any string to it, as far as it's "?float" typed.

Covered as many cases with quiz completion as have been able to imagine.
2022-07-01 13:55:51 +02:00
David Mudrák
0c1d4b219a MDL-75008 lang: Use the fixed strings in Behat scenario files 2022-06-30 20:48:16 +02:00
Helen Foster
e73756abdd MDL-75008 lang: Import fixed English strings (en_fix) 2022-06-30 20:31:27 +02:00
Shamim Rezaie
d380bec38e Merge branch 'MDL-74812-master' of https://github.com/junpataleta/moodle 2022-06-30 13:34:17 +10:00
Jun Pataleta
028cbda036 Merge branch 'MDL-75048-master' of https://github.com/jleyva/moodle 2022-06-30 11:30:30 +08:00
Shamim Rezaie
3af7eee03d Merge branch 'MDL-75072-master' of https://github.com/junpataleta/moodle 2022-06-30 13:27:28 +10:00
Andrew Nicols
956bb8eb18 Merge branch 'MDL-74220-master' of https://github.com/NoelDeMartin/moodle 2022-06-30 10:58:12 +08:00
Andrew Nicols
68cc906825 Merge branch 'MDL-74744-master' of https://github.com/andelacruz/moodle 2022-06-30 10:51:22 +08:00
Andrew Nicols
31f23e2a9f Merge branch 'MDL-74841-master' of https://github.com/andelacruz/moodle 2022-06-30 10:43:34 +08:00
Jun Pataleta
fc87543d52 Merge branch 'MDL74387_master' of https://github.com/Amrita1991/moodle 2022-06-29 23:20:33 +08:00
Anastasios Bithas
53682b209b MDL-73305 mod_folder: Download Folder in a mlang formated folder 2022-06-29 12:46:44 +03:00
Jake Dallimore
f1ecddd709 Merge branch 'MDL-74864-master' of https://github.com/dpalou/moodle 2022-06-29 13:40:29 +08:00
Jun Pataleta
81faa8184e Merge branch 'MDL-74906-master' of https://github.com/snake/moodle 2022-06-28 23:33:04 +08:00
Dani Palou
341039b13b MDL-74864 forum: Allow specifying group in discussions generator 2022-06-28 06:59:39 +02:00
Jun Pataleta
b2bc76e0f7 Merge branch 'MDL-74929-master' of https://github.com/bmbrands/moodle 2022-06-28 11:07:48 +08:00
Jun Pataleta
d4fe1b3065 MDL-75072 mod_forum: Drop usecoursefullname forum setting 2022-06-27 17:48:59 +08:00
Jun Pataleta
564d0d73f4 MDL-75072 mod_forum: Revert the patch for MDL-74623
This reverts commit bd6fdd70d680ceec020bed28c43ad05c111c0f9d.
2022-06-27 17:39:13 +08:00
Jun Pataleta
fc76c284b1 Merge branch 'MDL-74623_master_v2' of https://github.com/TomoTsuyuki/moodle 2022-06-23 11:55:30 +08:00
Jun Pataleta
271c69fd84 Merge branch 'MDL-74785' of https://github.com/danmarsden/moodle 2022-06-23 09:48:47 +08:00
Juan Leyva
a3201673be MDL-75048 mod_quiz: Use new way to check if subcats are included 2022-06-22 18:14:05 +02:00
Shamim Rezaie
1296d39194 Merge branch 'master-MDL-71468-v4' of https://github.com/golenkovm/moodle 2022-06-22 14:54:01 +10:00
Tomo Tsuyuki
bd6fdd70d6 MDL-74623 mod_forum: Add course full name option for notification 2022-06-21 11:28:44 +10:00
Jun Pataleta
4ff4ce32e2 MDL-74812 mod_assign: Remove duplicate ID intro 2022-06-20 22:53:30 +08:00
Daniil Fajnberg
11dbde1294 MDL-73498 mod_lti: iframe allowed domain fixed 2022-06-20 15:53:45 +02:00
Jun Pataleta
a966a04e3b MDL-74812 gradingform_rubric: Fix contrast issues in rubric table
* Darken the score value using the green theme colour
* Use a light green theme colour for selection backgrounds
* Unify rubric styles related to background and text colour within the
  criteria.
2022-06-18 00:56:44 +08:00
Ilya Tregubov
be63f1c2ed Merge branch 'MDL-74296-master' of https://github.com/call-learning/moodle 2022-06-17 12:54:38 +04:00
Mikhail Golenkov
e4784db136 MDL-71468 assignfeedback_editpdf: Convert submissions via adhoc tasks 2022-06-17 18:04:17 +10:00
Jun Pataleta
8f947b8ebd Merge branch 'MDL-74533-master' of https://github.com/BruceGoodGuy/moodle 2022-06-17 10:17:12 +08:00
Bas Brands
dde7d102e9 MDL-74929 mod_assign: remove incorrect closing </div> 2022-06-15 09:00:31 +02:00
Jun Pataleta
21cb1ff330 Merge branch 'MDL-74790' of https://github.com/paulholden/moodle 2022-06-14 22:54:08 +08:00
Jun Pataleta
9343c046bd Merge branch 'MDL-74573-master' of https://github.com/aya-saad1/moodle 2022-06-14 22:37:08 +08:00
Sara Arjona
87226f0ff7 Merge branch 'master-MDL-74234-v2' of https://github.com/golenkovm/moodle 2022-06-14 15:38:56 +02:00
Mikhail Golenkov
6684ca3da7 MDL-74234 assign: Fix grading page for filtered out users 2022-06-14 19:04:06 +10:00
Jun Pataleta
10cbe48350 Merge branch 'MDL-74816-master' of https://github.com/dpalou/moodle 2022-06-14 14:03:51 +08:00
Jake Dallimore
49cb3cbbef Merge branch 'MDL_74310_master' of https://github.com/cengage/moodle 2022-06-13 11:45:55 +08:00
Laurent David
48d5ef1c93 MDL-74296 mod_bigbluebuttonbn: Fix completion indicator
* Completion view should work out of the box
* Patch the _user_outline and _user_complete so it works with completion view, while
implementing something better in MDL-74468
2022-06-10 18:05:27 +02:00
Amrita
a3226cf290 MDL-74387 url: exception for php to correct icon 2022-06-10 15:53:10 +02:00
Shamim Rezaie
34a78332ca Merge branch 'MDL-74495-feedback-on-manual-grading' of https://github.com/PhilippImhof/moodle 2022-06-10 13:12:12 +02:00
Andrew Nicols
efb5c089c6 Merge branch 'MDL-73466' of https://github.com/paulholden/moodle 2022-06-10 13:12:12 +02:00