mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity
95,890 Commits 36 Branches 519 Tags
Commit Graph

5351 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
492d047d11 MDL-67284 upgrade: add 3.8.0 separation line to all upgrade scripts 2019-11-17 11:40:19 +01:00
Jun Pataleta
e9f63f3fc0 Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle 2019-11-14 12:37:22 +08:00
Andrew Nicols
c3777543a6 MDL-67116 course: Restore removed line 
This line was inadvertently removed in a previous commit.
 2019-11-14 11:43:37 +08:00
Adrian Greeve
b6343156f9 Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle 2019-11-14 09:03:31 +08:00
Andrew Nicols
0a5a2ca89b MDL-67116 course: Strict empty string check required 
In PHP the following are true:

    assert('' == '');
    assert(0 == '');
    assert(null == '');

The options in the course completion settings are now:

    ''    => none selected
    [int] => itemnumber of activity course completion item.

In the case where the itemnumber was 0  this was being incorrectly
evaluated as an empty string due to the implicit cast to int of the
empty string:

    (int) '' === 0

As a result, the non-strict comparison means that the following are
identical:

    assert(0 == '');
    assert(0 == (int) '');
    assert(0 == '0');

Changing the comparison to a strict comparison is correct because it
ensures the type consitency between the empty string value, and the int
of itemnumber 0. It is safe because the value always comes from the
form, where an int is always returned, and not the DB, where a string is
returned.
 2019-11-14 08:59:56 +08:00
Jun Pataleta
289c9e14c4 Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle 2019-11-13 15:31:03 +08:00
Andrew Nicols
c035141971 MDL-67116 course: Fix completion disabled for gradable items 
The default value is an empty string (""), which in PHP evaluates to 0 when
cast to a string in our DML layer.

The fix is to forcibly make it null which is not cast to string in DML
for optional strings.
 2019-11-13 12:49:59 +08:00
Andrew Nicols
fe795b59e4 MDL-67116 form: Require grade in multi-grade-item activities 
AMOS BEGIN
  CPY [rating,rating],[grade_rating_name,rating]
AMOS END
 2019-11-13 10:14:37 +08:00
Ryan Wyllie
a492f69caf MDL-67116 course: allow grading completion for non ratings grade item 2019-11-13 10:11:44 +08:00
Eloy Lafuente (stronk7)
d5be859063 MDL-67199 versions: bump all versions and requires near release 
version = 2019111800 release version
requires= 2019111200 current beta (week7roll1) version
 2019-11-12 17:57:08 +01:00
Sara Arjona
3a9c515057 Merge branch 'MDL-66683-master' of git://github.com/cescobedo/moodle 2019-11-07 17:41:22 +01:00
cescobedo
5d69038bb6 MDL-66683 core: Revert MDL-66181 because created regressions 
This reverts commit ed080a580ffd0eea70ad3eaa9214234cf2463034.
This issue reverts the behaviour modified in MDL-66181, as that change
negatively impacted course-creation workflows. As this appears to be
the intended functionality, the Security team has agreed to revert
this change.
 2019-11-07 17:29:30 +01:00
Mathew May
e3bb3da406 MDL-66359 core_course: Modify get_enrolled_users_by_cmid 
We need to also provide a user's group along with the current information
 2019-11-07 10:47:45 +08:00
Andrew Nicols
e943e7d56f Merge branch 'MDL-66381-master' of git://github.com/Chocolate-lightning/moodle_forum-project 2019-11-05 11:58:56 +08:00
Mathew May
9d752481fc MDL-66381 core_course: Modify get_enrolled_users_by_cmid 
We need to also provide a user's picture along with the current information
 2019-11-01 11:46:37 +08:00
Andrew Nicols
cd0a9144b4 Merge branch 'MDL-66398-master' of git://github.com/aanabit/moodle 2019-11-01 10:39:08 +08:00
Amaia Anabitarte
acae15c710 MDL-66398 filter_displayh5p: Enabled by default. Fixing Unit tests 2019-10-30 12:14:27 +01:00
Mathew May
dc0145b19e MDL-66074 core_course: Correct documentation 2019-10-30 10:23:41 +08:00
Andrew Nicols
dc86a0f1c6 MDL-66079 mod_forum: Add field to support whole forum grading 
Part of MDL-66074
 2019-10-30 10:23:40 +08:00
Andrew Nicols
fcc88fddba MDL-66079 core_grades: Add support for multiple grade items in an activity 
Part of MDL-66074
 2019-10-30 10:23:40 +08:00
Mathew May
06e50afd5e MDL-66077 course: Add WS to get list of users in a cmid 
Part of MDL-66074
 2019-10-28 13:55:12 +08:00
Eloy Lafuente (stronk7)
a188424bb4 Merge branch 'MDL-66970_master' of git://github.com/dmonllao/moodle 2019-10-21 23:59:18 +02:00
David Monllaó
b4bb8688a5 MDL-66970 analytics: Extra testing for active enrolments 
I sneaked in an unrelated change to enrol-partly-active-ends-afterwards
test case as the endtime and enrolment timestart values were swapped.
The case when the enrolment start is after the analysis end is already
tested in enrol-after-end test case.
 2019-10-22 05:13:26 +08:00
David Monllaó
b00d35a6fc MDL-66970 analytics: Fix incorrect use of ?? 2019-10-22 05:13:26 +08:00
Andrew Nicols
8edb6d15f1 Merge branch 'MDL-66944_master' of https://github.com/t-schroeder/moodle 2019-10-21 13:47:42 +08:00
Adrian Greeve
6d98de3fc1 Merge branch 'MDL-66740-master' of git://github.com/marinaglancy/moodle 2019-10-18 11:06:55 +08:00
Jun Pataleta
95946a3294 Merge branch 'MDL-66806_master' of git://github.com/dmonllao/moodle 2019-10-18 09:36:51 +08:00
Tim Schroeder
d9d041e867
MDL-66944 course: fixed copy-paste-error in comment 2019-10-17 18:15:08 +02:00
Marina Glancy
959e4f0e97 MDL-66740 core_course: change defaults for course request settings 2019-10-14 12:22:16 +02:00
Marina Glancy
3e15abe500 MDL-66740 core_course: Add context to capabilities to request course 2019-10-14 11:38:13 +02:00
Davo Smith
629699355c MDL-66017 block_myoverview: Oracle compatibility fix 2019-10-11 00:09:56 +02:00
David Monllaó
f589788af1 MDL-66806 analytics: No predictions for hidden courses 2019-10-10 10:09:10 +08:00
Davo Smith
8d166d7745 MDL-66017 block_myoverview: filter by custom course field 2019-10-09 14:25:52 +01:00
Eloy Lafuente (stronk7)
40763810d9 Merge branch 'MDL-65327_master' of https://github.com/marxjohnson/moodle 2019-10-03 19:27:49 +02:00
Eloy Lafuente (stronk7)
35da660ab0 Merge branch 'MDL-66254_master' of git://github.com/dmonllao/moodle 2019-10-02 17:00:39 +02:00
David Monllaó
7bde26ed9f MDL-66254 analytics: Requires active enrolments for most of analysis 2019-10-02 08:12:56 +08:00
David Monllaó
ea30943119 MDL-66254 course: Unit tests for the new restrictions 2019-10-02 08:12:56 +08:00
David Monllaó
386d109172 MDL-62191 analytics: Support for bulk actions 2019-09-27 14:13:52 +08:00
David Monllaó
af29098a2e MDL-62191 course: Remove predictiondetails leftover 
The no_teaching model initially had just 1 indicator, the removed
code was deleting the action using an unexisting key.
 2019-09-27 14:12:48 +08:00
Eloy Lafuente (stronk7)
dd52ef0b64 Merge branch 'MDL-51327-master' of git://github.com/mihailges/moodle 2019-09-26 00:04:33 +02:00
Adrian Greeve
91577e2d54 Merge branch 'wip_MDL-66656_master' of git://github.com/gjb2048/moodle 2019-09-25 11:39:57 +08:00
Mihail Geshoski
efe8c3c663 MDL-51327 core_course: Allow subdirs in edit section form 2019-09-24 09:08:14 +08:00
Gareth Barnard
f254cef989
MDL-66656 format_social: Edit Summary Icon leads to 'File not found'. 2019-09-20 21:44:33 +01:00
Mark Johnson
d91aa1e760 MDL-65327 performance: Lazy-load module name strings 2019-09-20 08:59:34 +01:00
David Monllaó
2d9280e0df MDL-65588 analytics: New models for student accesses 2019-09-20 08:14:13 +08:00
Eloy Lafuente (stronk7)
0fd2fd7442 Merge branch 'MDL-66536_master' of git://github.com/dmonllao/moodle 2019-09-18 16:51:40 +02:00
Sara Arjona
84d613deee Merge branch 'MDL-64438-master-4' of git://github.com/mihailges/moodle 2019-09-18 12:52:12 +02:00
Mihail Geshoski
704f93f46f MDL-64438 core_course: Optionally display course category 2019-09-18 17:52:20 +08:00
David Monllaó
3581813348 MDL-66536 course: No teaching model renamed 2019-09-18 13:07:21 +08:00
David Monllaó
41db25935c MDL-66536 course: Custom message for students at risk 
AMOS BEGIN
    MOV [insightinfomessage,analytics],[insightinfomessageplain,analytics]
AMOS END
 2019-09-18 13:07:21 +08:00