Jun Pataleta
83cdcd99f2
Merge branch 'MDL-65697-master' of git://github.com/lameze/moodle
2019-05-28 13:31:41 +08:00
Simey Lameze
e72e711b82
MDL-65697 qtype_missingtype: include missing class
2019-05-24 07:01:24 +08:00
Sara Arjona
c13d1d2518
Merge branch 'MDL-65605-master' of git://github.com/rezaies/moodle
2019-05-21 13:47:31 +02:00
Eloy Lafuente (stronk7)
3572a25cc3
MDL-65644 upgrade: add 3.7.0 separation line to all upgrade scripts
2019-05-20 19:35:05 +02:00
Shamim Rezaie
c7ac83ca0a
MDL-65605 core_question: Fix the issue when get_draft_files returns nul
2019-05-20 23:44:02 +10:00
Simey Lameze
c970e181c7
MDL-65570 qtype_multianswer: use unique id function
2019-05-15 09:05:37 +08:00
Jun Pataleta
38c773d874
Merge branch 'MDL-65571' of git://github.com/stronk7/moodle
2019-05-13 15:47:52 +08:00
Adrian Greeve
7437b36652
Merge branch 'MDL-65560-master' of git://github.com/lameze/moodle
2019-05-13 09:43:58 +08:00
Eloy Lafuente (stronk7)
c9a1a6341c
MDL-65571 versions: bump all versions and requires near release
...
version = 2019052000 release version
requires= 2019051100 current beta (week6roll2) version
2019-05-12 23:46:34 +02:00
Eloy Lafuente (stronk7)
c3b8f0ceb3
Merge branch 'MDL-65537-master-enfix' of git://github.com/mudrd8mz/moodle
2019-05-10 20:07:50 +02:00
Helen Foster
f715376907
MDL-65537 lang: Import fixed English strings (en_fix)
...
Significant string changes:
* isdataunique_help and isfieldrequired_help,core_customfield -
explanatory wording
* forum:cantogglefavourite,mod_forum - 'Can toggle favourites.'
changed to 'Star discussions'
2019-05-10 10:17:47 +02:00
Simey Lameze
e3e0c974ee
MDL-65560 qtype_multichoice: prevent form change dialog
2019-05-10 13:28:50 +08:00
Jun Pataleta
2670aff7c1
Merge branch 'MDL-65445-qtype_ddwtos' of https://github.com/jonof/moodle
2019-05-09 15:58:45 +08:00
Adrian Greeve
7b43eea8bc
Merge branch 'MDL-65296' of https://github.com/timhunt/moodle
2019-05-07 16:24:36 +08:00
Andrew Nicols
dd457c4fa6
Merge branch 'MDL-65245' of https://github.com/timhunt/moodle
2019-05-03 10:50:32 +08:00
Adrian Greeve
eee677c024
Merge branch 'MDL-53140-master' of git://github.com/rezaies/moodle
2019-05-01 10:30:22 +08:00
Shamim Rezaie
47538a6b26
MDL-53140 qtype_calculatedsimple: Support locale-aware decimal points
2019-05-01 12:10:33 +10:00
Shamim Rezaie
75dc90370a
MDL-53140 qtype_calculated: Add support for locale-aware decimal points
2019-05-01 12:10:32 +10:00
Shamim Rezaie
326bb5474a
MDL-53140 qtype_numerical: Localised decimal separator bug fix
...
- Support decimal separator when it is not . or ,
- Also make sure that we don't remove . when thousandsseparator is .
- Display the answer fields in the editing form in the localised format
2019-05-01 12:10:32 +10:00
Shamim Rezaie
688c803550
MDL-53140 qtype_numerical: Support locale-aware decimal points
2019-05-01 12:10:32 +10:00
Shamim Rezaie
197e074eba
MDL-53140 question: Support localised floats when previewing a question
2019-05-01 12:10:32 +10:00
Shamim Rezaie
bb4079498f
MDL-53140 core_question: Support localised floats when editing questions
2019-05-01 12:10:32 +10:00
Sara Arjona
d5e084bcb6
MDL-5311 qtype_multichoice: replace label to a for clean button
...
To avoid behat errors with Firefox, the 'Clean my choice' has been
changed from label to link (with role button).
2019-04-30 20:47:33 +02:00
Jonathon Fowler
b2512618f1
MDL-65445 qtype_ddwtos: reposition draggables when the drops move
2019-04-30 12:43:21 +10:00
Jake Dallimore
fa1d3dff72
Merge branch 'MDL-5311-master' of git://github.com/lameze/moodle
2019-04-29 15:19:31 +08:00
Simey Lameze
2589dcea7b
MDL-5311 qtype_multichoice: make clear choice option accessible
...
Thanks to Damyon for the help with accessibility.
2019-04-29 15:16:08 +08:00
Simey Lameze
9064f17bbc
MDL-5311 qtype_multichoice: add php unit tests for the new option
2019-04-29 15:14:38 +08:00
Simey Lameze
1ff3987600
MDL-5311 qtype_multichoice: add behat scenario to question preview
2019-04-29 15:14:38 +08:00
Simey Lameze
3c1717bb09
MDL-5311 qtype_multichoice: add a bit of styling to the option
2019-04-29 15:14:34 +08:00
Simey Lameze
f6a778497e
MDL-5311 qtype_multichoice: add clear my choice option
2019-04-29 14:04:51 +08:00
VinhLe
4ca60a5660
MDL-36088 questions: Add new events
2019-04-29 11:16:19 +07:00
Stephen Bourget
93e435b909
MDL-36088 questions: Add new events
2019-04-29 11:15:36 +07:00
David Monllaó
03876f0b89
Merge branch 'MDL-65207-master' of git://github.com/lameze/moodle
2019-04-24 17:52:10 +02:00
David Monllaó
3d15deff15
Merge branch 'MDL-65222' of git://github.com/timhunt/moodle
2019-04-22 09:08:37 +02:00
Tim Hunt
7d2c7fed74
MDL-65296 questions: field should be declared
...
It was already being set, but IDE autocomplete etc did not know that.
2019-04-08 12:19:13 +01:00
Eloy Lafuente (stronk7)
01cdf16c0e
Merge branch 'MDL-65029-master' of git://github.com/timhunt/moodle
2019-04-05 00:39:10 +02:00
Jun Pataleta
01b79fd9f4
Merge branch 'MDL-65204_oraclemssql_assert_equals' of git://github.com/stronk7/moodle
2019-04-04 09:08:06 +08:00
Eloy Lafuente (stronk7)
87f196af93
MDL-65204 phpunit: more isEqual() strict string fixes
...
This is a followup of 85f47ba, where we were relaxing
the (new since phpunit 7.x) strict (===) isEqual()
comparison for strings. Copying the explanations for
easier understanding.
Link: https://github.com/sebastianbergmann/phpunit/issues/3185
Solution here is one of:
a) Return to the previous situation, making the comparison
softer. That can achieved by forcing different types, so
float == string works.
b) Changing APIs (both forms and database return strings) to
perform some conversion to floats. That would make float
comparison (with floats or strings) to work too.
The patch here follows the a) approach. Changing all the internals
for proper float handling sounds excesive when it has been working
perfectly since ever. So we went the easier route, just getting
rid of the new === comparisons when needed by changing expectation
types to float.
2019-04-03 22:08:16 +02:00
Sara Arjona
86c3df962f
Merge branch 'MDL-64506' of git://github.com/Chocolate-lightning/moodle
2019-04-03 19:30:28 +02:00
Mathew May
5cac5fa428
MDL-64506 templates: BS2 m-x-x to BS4 mx-x
2019-04-03 19:47:11 +08:00
Mathew May
29551c4b1a
MDL-64506 templates: Move BS2 btns' to BS4 btns'
...
well bs2 class is now card in bs4
2019-04-03 19:34:20 +08:00
Eloy Lafuente (stronk7)
85f47bae7f
MDL-65204 phpunit: various fixes to assertions
...
Namely:
- 3rd param of assertEquals() cannot be null.
- Some incorrect uses of assertNotEmpty().
- Comparing 2 strings now uses strict (===) evaluation.
Link: https://github.com/sebastianbergmann/phpunit/issues/3185
Solution here is one of:
a) Return to the previous situation, making the comparison
softer. That can achieved by forcing different types, so
float == string works.
b) Changing APIs (both forms and database return strings) to
perform some conversion to floats. That would make float
comparison (with floats or strings) to work too.
The patch here follows the a) approach. Changing all the internals
for proper float handling sounds excesive when it has been working
perfectly since ever. So we went the easier route, just getting
rid of the new === comparisons when needed by changing expectation
types to float.
2019-04-03 10:39:19 +08:00
Tim Hunt
be492e2a8f
MDL-65245 question engine: response vars should always be PHP strings
2019-04-02 16:32:40 +01:00
Tim Hunt
6c91e515b0
MDL-65245 question_attempt: fix PHPdoc and other PHPstorm warnings
2019-04-02 16:32:36 +01:00
Simey Lameze
d499cb3593
MDL-65050 core: delete orphaned files and functions
2019-04-01 12:57:05 +08:00
Simey Lameze
9c164d26fc
MDL-65050 core: add question_stats_cleanup_task scheduled task
...
This commit also removes orphaned question/engine/statisticslib.php
2019-04-01 12:57:05 +08:00
Simey Lameze
10810f421b
MDL-65050 core: move function code to question_preview_cleanup_task
...
This commit also deletes the legacy question_preview_cron() function.
2019-04-01 12:57:05 +08:00
Simey Lameze
9bec0e7e74
MDL-65207 core: replace typos by actually
2019-04-01 08:49:18 +08:00
Tim Hunt
05ea7ab19e
MDL-65222 questions: explain question walkthrough tests
2019-03-29 14:49:39 +00:00
Tim Hunt
f1ffd134d3
MDL-65029 questions: change question div id to acutally be unique
...
This is largely based on Simey Lameze's work.
2019-03-29 13:37:44 +00:00