1582 Commits

Author SHA1 Message Date
dongsheng
85db96c5b4 "MDL-17570, cleanup align property in div, merged from 1.9" 2008-12-10 06:48:54 +00:00
tjhunt
77eddcd527 course request: MDL-9854 major cleanup to the course request code.
* Rewrite all the forms to use formslib and improve usability.
* Put the place where admins need to go to process approvals in the admin menu.
* Show the request course/pending requests button on the page for the category that requested courses get added to.
2008-12-05 08:56:54 +00:00
pilpi
923602a056 quiz editing: MDL-17409 added some rtl CSS for the new quiz editing UI 2008-12-04 13:28:55 +00:00
tjhunt
8ed5dd63ee course categories: Fix many bugs with category editing and permissions. Clean up code.
Bugs: MDL-17479, MDL-16426, MDL-16063, MDL-16013, MDL-15658, MDL-15556, MDL-15161, MDL-14925, MDL-13742, MDL-11557.

* Simplify category editing permissions to just moodle/category:manage and moodle/category:seehiddencategories.
* Enforce those correctly. (Note MDL 17502 is still outstanding.)
* Don't screw up category sort order when you just edit name or description.
* Niceties like where redirects go when you cancel or submit forms.
* Make sure a global course creator can see the site admin block.
* Don't allow a category to be made the child of one of its children!
* General code cleanup to bring key files more in line with best pracitice.

Apologies for the fact it is one big patch, rather than a series of smaller patches. However, categoryedit.php, category.php and index.php where in pretty bad shape and needed significant cleaning up. categoryedit.php, in particular, was almost completely rewritten.

Merged from MOODLE_19_STABLE.
2008-12-04 08:53:10 +00:00
skodak
e0f81e94a6 MDL-17465 - separate live log capability adn admin tree link 2008-11-29 16:15:40 +00:00
pilpi
81f26811da quiz editing: MDL-17460 select element is populated with user-created data, CSS it width: 100% 2008-11-28 19:50:55 +00:00
pilpi
b48b5754f8 quiz editing: MDL-17294 fixed a TODO, added the url to usability testing results 2008-11-28 16:47:21 +00:00
pilpi
3814fb96fc quiz editing: MDL-17398 link to edit random question (configuration) in new UI 2008-11-28 15:43:10 +00:00
pilpi
7b2c3bde9e quiz editing: MDL-17451 CSS and whitespace fixes to truncate overlong question category name
Tested on opera 9.27, IE6, Firefox 3 on Ubuntu Linux 8.04
2008-11-28 15:16:40 +00:00
pilpi
9cdcf82665 quiz editing: MDL-17398 cleaned up random question display in the edit subtab
made the link in an empty random question more readable, added a link to show category contents after the list of sample questions of a random question
2008-11-28 14:07:06 +00:00
tjhunt
cc2c4572b1 quiz editing: MDL-17396 Quiz tab icons broken in IE
Well, that was a stunningly creating IE layout bug, and I have no idea why this work-around works. (The margin 0 and vertical-align are the essentail bits, the other two rules just make it look nicer.)

Also tweaked the layout in Firefox to position the icons a bit more nicely.
2008-11-26 04:03:45 +00:00
tjhunt
7da3ff2ef2 Spelling. 2008-11-24 07:43:22 +00:00
tjhunt
ff493b6b24 roles / profile: MDL-14937 A the user's roles report from contrib to core. Finish. 2008-11-24 06:33:35 +00:00
tjhunt
941e427680 unittests: MDL-17367 Fix regressions caused when admin/report/simpletest was renamed to unittest. Why was this done anyway? Some explanation in MDL-17001 might be nice. 2008-11-23 11:39:41 +00:00
pilpi
cafabd6341 quiz editing: MDL-17334 Fixed CSS: grading box in editing view explodes if font made smaller in Firefox 2008-11-22 17:59:16 +00:00
pilpi
78219d15c8 quiz editing: MDL-17284 converted tabs to space in CSS
my eclipse CSS editor does not seem to respect my setting here
2008-11-22 11:47:47 +00:00
pilpi
d9daa35ca9 quiz editing: MDL-17297 Got rid of editcss.js and adjusted stylesheets accordingly 2008-11-22 11:42:06 +00:00
pilpi
1cdbd5e46f quiz editing: MDL-17301 avoid inline CSS in mod/quiz/edit.php 2008-11-22 11:29:20 +00:00
pilpi
a9901a3fdf quiz editing: MDL-17336 Styles missing from styles_color.css as a result of committing to Moodle 2.0 HEAD 2008-11-20 17:31:54 +00:00
tjhunt
bed9cec80b define roles: MDL-16966 etc. polishing the new roles UI following a meeting with Martin.
* Move the show/hide advanced button a bit down the page.
* Improve save button caption when creating a role.
* Don't show defaults on the basic define roles screen.
* Explain the background shading on the advanced roels screen.
* Fix the problem with the risks link to Moodle docs.
* Help icon by the permissions column heading.
* Tables with rotated <th>s, make them vertical-align: bottom.
* Rename explain.php and explainhascapability.php to check.php and explain.php
* Tool tips on the number headers in the explain table.
* Explain table - role names were missing.
* Allow link_to_popup_window to work with full URLs.
2008-11-20 09:57:20 +00:00
tjhunt
0c90f98788 formslib: MDL-13210 - partial - try to make validation errores less annoying.
I have made them float right, and reduced the padding on the red box, so they don't cuause the height of the form to change so much, if the error fits to the right of the form control. I realise that some people may not like this, which I why I have done this in head only for now. I will revert this if told to.
2008-11-20 08:30:35 +00:00
tjhunt
75a32d8184 general cleanup of trailing whitespace. 2008-11-20 07:03:43 +00:00
tjhunt
fa583f5f6e quiz editing: MDL-17285 This is Olli Savolainen's new interface for editing quizzes.
This was started and usability tested as a Finnish Summer of Code project, and then Olli did further work on it in his own time to get it in shape for inclusion in Moodle 2.0. I reviewed all the code. There are a number of minor outstanding issues that will be fixed soon. See the subtasks of MDL-17284 for a list.

The goal of these changes is to:
* help teachers new to Moodle, so when they first see the quiz editing page, they don't go "Huh! What on earth am I supposed to do here?"
* help novice Moodle users understand and learn to use some of the more advanced quiz feature;
* but, without slowing down more experienced quiz users.

Naturally, with ambitous goals like that, we won't have managed to satisy everybody, but I think this change is a big step in the right direction.

There is extensive documentation on this project at http://docs.moodle.org/en/Development:Quiz_UI_redesign.
2008-11-20 06:59:11 +00:00
tjhunt
692103a2a5 Let any table have rotated text in its headers. Stolen from sam's activity completion report. 2008-11-18 10:17:27 +00:00
tjhunt
bbdb7070ca manage roles: MDL-8313 Provide a basic mode for the manage roles page.
* New basic define roles mode, with just an Allow checkbox for each capability.
* Button to toggle this form to/from advanced mode.
* Also, a separate mode for viewing a role definition, rather than just showing disabled checkboxes.
* Now duplicating a role just takes to you a pre-populated add role form, so you can double-check things before saving the new role.
* Deleting a role is now logged.
* Role reordering code cleaned up.
* You can now no longer delete the last role that has admin permissions.
* This includes a general refactor of manage.php, which eliminates manage.html, and splits of define.php.
2008-11-18 07:10:00 +00:00
tjhunt
f4acee5d78 role manage ui: MDL-8313 First version of the basic/advanced role define page.
This is being separated from manage.php. This code is only partly working. It displays (most) of a role definition, but does not yet let you save changes. However, I wanted to commit it before going home on Friday night. Since this is new code, it won't break anything.
2008-11-14 11:46:01 +00:00
tjhunt
8aee9bcc27 role override ui: MDL-8313 basic mode + toggle + usability improvements
* Basic mode just hides the prohobit column. Sadly that is all we can do.
* Button to toggle in and out of advanced mode, with user_perference.
* The permission you are selected is now on the page as a label, rather than just being in a tool-tip. (Not pretty, but helpful, I think. I may change my mind on this.)
* You can click anywhere in the table cell, rather than having to hit the radio button exactly.
* Brief instructions at the top of the page.
* Submit buttons both top and bottom of the page.
2008-11-14 05:46:27 +00:00
tjhunt
258571150e formslib/theme: Make class="advancedbutton" styles generic, so the same styling can be used on non-formslib forms. 2008-11-14 03:27:16 +00:00
tjhunt
dc191af610 roles explanation: MDL-13538 further interface improvements. 2008-11-13 01:44:29 +00:00
tjhunt
8a8272b0f4 roles explanation: MDL-13538 Integrate into the roles tab bar, and improve wording a bit.
Also, commit the lang strings I missed last time.
2008-11-12 10:13:43 +00:00
tjhunt
a6e7237adc roles explanation: MDL-13538 Make a table showing the result of has_capability for every capabiltiy in a context.
This implements the page showing the table. It is not yet integrated into the tab bar. To try this, go to an Assign roles page (one with URL .../admin/roles/assign.php?contextid=...) and change the 'assign' to 'explain'.
2008-11-12 07:55:09 +00:00
jamiesensei
746860479f MDL-17188 "effective question weight equation cannot cope with negative covariance of question grades" excluding such questions from equation 2008-11-10 11:56:37 +00:00
tjhunt
c679952e09 weblib: MDL-17085 a function to print a collapsible region of the UI, with the collapsed state stored in a user_perference - minor layout improvements for IE. 2008-11-04 07:22:23 +00:00
tjhunt
904998d8f9 user selection: MDL-17073 add options to control the search in a collapsible region. 2008-11-04 05:12:12 +00:00
tjhunt
c9f8e118c9 user selection: MDL-17072 Polishing the role assign page:
* Make the role being assigned clear in the title
* Make the options in the middle of the page be in a collapsable options section, collapsed by default.
* Put them in a smaller font too.
* Switch the date selectors here to use a shorter date format, and change 'Course start date' to 'Course start'.
2008-11-03 06:06:08 +00:00
tjhunt
f2eb500238 weblib: MDL-17085 a function to print a collapsible region of the UI, with the collapsed state stored in a user_perference. 2008-11-03 05:04:23 +00:00
tjhunt
6cab02ac52 user selection: MDL-16993 Convert the assign roles page to use the new components.
At the same time, I took the opportunity to try to work on some of the usability issues on this page. Note that I have not quite finished! So don't comment until tomorrow.

In the course of doing this, I also did: half of

MDL-11529 Show the number of assignees of each role in the change role dropdown on this page.
MDL-17067 Make it clear in the UI that admins are not allowed to unassign themselves.
2008-10-30 10:49:15 +00:00
tjhunt
96f1a7a265 roles admin: Improve the usability of the assign roles interface - this is the first half of the work. Part of MDL-16993.
To do this, I found a way to clean up the method signatures of a couple of accesslib methods, so I did, hence the fact that this seems to touch some unrelated files.

Also, there is a nice new method in accesslib get_context_url, which gives you the natural URL for a context, so the course view page, or the user profile, etc.
2008-10-30 06:26:18 +00:00
tjhunt
9787301687 user selection: MDL-16994 Improve the user selector used on the assign roles and group memebers pages - Convert the group memebership page. 2008-10-29 08:18:24 +00:00
fmarier
6a77823cb6 MDL-17037 Lossless optimization of all PNG and JPEG images 2008-10-28 01:50:10 +00:00
sam_marshall
35da0e8768 MDL-17003: Completion progress report needs paging system as large reports can kill browser 2008-10-24 16:20:37 +00:00
tjhunt
98bcd9d1ff roles interface: MDL-16965 make a view that explains the has_capability calculation for a given capability in a given context for a given user, like on http://docs.moodle.org/en/How_permissions_are_calculated. 2008-10-22 09:48:16 +00:00
tjhunt
834f7c4a5a qtype description: MDL-16863 Put back edit icon next to descriptions for teachers. 2008-10-21 06:34:14 +00:00
andreabix
f06287ad2f Fixed non compliant HTMl in README 2008-10-06 08:19:04 +00:00
tjhunt
1b63d34db7 MDL-16605 Add an ajaxy search box on the define/override roles screen to help find the capability you want 2008-09-26 06:50:31 +00:00
jamiesensei
01e6f9e9e4 MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
2008-09-24 08:55:46 +00:00
moodler
1dd62c0120 MDL-16267 Tweaking styles for layout of message editing 2008-09-23 03:16:53 +00:00
moodler
df6853e8eb MDL-16267 Removed another table and added "th" for better readability. Removed hardcoded styles 2008-09-23 03:15:02 +00:00
moodler
f3d095f870 MDL-16267 and MDL-10107
I did some further work tidying up the form.  I also just treat the popup like another plugin and moved all the config into the plugin.
This still needs help buttons everywhere now!
2008-09-23 03:05:44 +00:00
tjhunt
e26ba4d849 MDL-6751 - qtype admin page layout improvement. 2008-09-18 12:45:50 +00:00