1082 Commits

Author SHA1 Message Date
poltawski
6dcf276fb2 block_rss_client: MDL-13932 Fix equality typo 2009-07-29 13:13:04 +00:00
tjhunt
f1a34d8f05 block_rss_client: MDL-13932 Clean up a lot of the crap.
This was all in order to do MDL-19889!

* The old tabbed interface is gone.
* The manage feeds UI has been completely rewritten to be a few
separate sane scripts like managefeeds.php, editfeed.php and viewfeed.php
* This is used from both Admin -> plugins -> blocks ... and as a link from the block edit_form.php
* new edit_form.php for the block replacing config_istance.php.
* A lot of stuff to do with UI specific to this block has been removed from rsslib.php
2009-07-29 11:18:55 +00:00
tjhunt
f34b1a71a0 blocks: MDL-19889 Convert mentees block to use edit_form.php 2009-07-29 05:19:39 +00:00
tjhunt
b4a2d7f711 blocks: MDL-19889 Convert blog tags block to use edit_form.php - fix comment typo. 2009-07-29 05:13:34 +00:00
tjhunt
603c0789cb blocks: MDL-19889 Convert blog tags block to use edit_form.php 2009-07-29 05:12:47 +00:00
tjhunt
6526cc3468 blocks: MDL-19889 Convert random glossary block to use edit_form.php 2009-07-29 03:57:56 +00:00
tjhunt
c6084d31b4 blocks: MDL-19889 Convert quiz results block to use edit_form.php 2009-07-29 03:55:12 +00:00
tjhunt
a23bbaa30b blocks: MDL-19946 More bug fixes. 2009-07-29 03:51:16 +00:00
tjhunt
a19f419db2 blocks: MDL-19946 Block editing form must be displayed from the original URL, with properliy initialised $page 2009-07-28 09:59:21 +00:00
stronk7
4e1cb3397e MDL-18901 formatXXX fields - changed missed occurrence 2009-07-26 09:36:14 +00:00
dongsheng
346ac86b10 "MDL-19839, comments block" 2009-07-24 02:52:09 +00:00
dongsheng
1bcb7eb540 "MDL-19118, comments api" 2009-07-24 02:44:44 +00:00
tjhunt
d81f1d6fd8 blocks editing: MDL-19889 edit tag_flickr block form. 2009-07-21 10:32:34 +00:00
tjhunt
f1ec6a630c flickr and youtube blocks: don't call print_error!
That screws up the entire page the block appears on, when this is just an error local to this block.
2009-07-21 10:32:04 +00:00
tjhunt
7b2b1a915c blocks editing: MDL-19889 edit tags block form. 2009-07-21 09:45:27 +00:00
tjhunt
5f3d8dd52b blocks editing: MDL-19889 edit tag_youtube form. 2009-07-21 09:23:29 +00:00
tjhunt
a60bdd8cfd blocks editing: MDL-19889 tidy up HTML form class. 2009-07-21 09:20:44 +00:00
tjhunt
4092803615 Clean up some more todos. 2009-07-17 08:26:13 +00:00
tjhunt
1428f47181 block/search: Eliminate todo that was already done, and clean up whitespace. 2009-07-17 08:07:50 +00:00
tjhunt
f7acfadd0a admin block: MDL-16693 fix todo. 2009-07-17 07:46:04 +00:00
tjhunt
9ce7265cd0 admin bookmarks: remove useless todo. 2009-07-17 07:42:21 +00:00
tjhunt
73e2e5c03d blocks editing ui: MDL-19398 Can now edit the position of any block.
I think this is probaby insecure at the moment. I am still working on it.
2009-07-16 11:05:26 +00:00
tjhunt
1d13c75c15 blocks editing ui: MDL-19398 Can how precisely control block positioning using the edit icon
This mostly works now, but ...
* The UI needs further work. In particular we need a non-advanced mode.
* This only works for blocks that use a new edit_form.php to replace config_instance.html.
* .. and so far I have only implemented edit_form.php for the HTML block so far.
* Needs to be enabled (with no block-specific config) for blocks without instance config, so you can control their positioning.
2009-07-16 10:50:19 +00:00
tjhunt
ec972adefe Fix boilerplate. 2009-07-15 08:59:51 +00:00
tjhunt
15a00b4be0 blocks editing ui: MDL-19398 Remove stupid pass by reference.
Was causing errors when this method was called via block_method_result
2009-07-15 08:55:52 +00:00
tjhunt
7cf51142ab blocks editing ui: MDL-19398 Make block config_global.html files more strongly deprecated. 2009-07-15 08:52:33 +00:00
tjhunt
bc422e6955 blocks editing ui: MDL-19398 Make invisible blocks at least partly invisible. 2009-07-15 07:45:48 +00:00
tjhunt
ae42ff6fee blocks editing ui: MDL-19398 showing and hiding blocks now works. 2009-07-15 07:41:25 +00:00
tjhunt
1936f20b8b blocks editing ui: MDL-19398 move generating the block edit icons to blocklib.php
Since that is where the resulting actions are processed.
2009-07-14 10:57:06 +00:00
tjhunt
b97fb57fe3 fix typo 2009-07-14 09:35:33 +00:00
tjhunt
a2789e3426 blocks editing ui: MDL-19398 add block now secure. Delete block works insecurely.
Will add security checks in a moment.
2009-07-14 08:37:28 +00:00
tjhunt
f674ec8640 blocks: MDL-19010 show empty blocks if they have controls. 2009-07-14 07:06:06 +00:00
tjhunt
e92c286c20 block contexts: MDL-19098 every block should have a context
even non-course and sticky blocks.

The parent context is block_instances.parentcontextid.

The block context should be used for checking permissions directly
related to the block, like moodle/block:view or moodle/site:manageblocks.

However, if the block is displaying information about the current page,
for example the participants block showing who 'here', then it may be
better to use the context of the page where the bloack is appearing -
in other words $this->page->context - to check permissions about the
user's ability to see participants here.

Or, if the block is displaying something stronly related to courses,
for example, a course meny block, the block should probably use the
context for $this->page->course to check permissions.
2009-07-13 08:37:34 +00:00
skodak
462caf41b2 MDL-16630 do not show admin tree until the site is fully configured 2009-07-09 20:17:41 +00:00
tjhunt
d4a03c00ea themes & blocks - MDL-19077 & MDL-19010 blocks are now printed by the theme
The code to print blocks in now in theme layout.php files. (Or in
moodle_core_renderer::handle_legacy_theme)

Code for printing blocks everywhere else has been stripped out.
(Total diffstat 1225 insertions, 2019 deletions)

The way the HTML for a block instance is generated has been cleaned
up a lot. Now, the block_instance generates a block_contents
object which gives a structured representation of the block,
and then $OUTPUT->block builds all the HTML from that.

How theme config.php files specify the layout template and block
regions by page general type has been changed to be even more flexible.

Further refinement for how the theme and block code gets initialised.

Ability for scrits to add 'pretend blocks' to the page. That is,
things that look like blocks, but are not normal block_instances.
(Like the add a new block UI.)

Things that are still broken:
 * some pages in lesson, quiz and resource. I'm working on it.
 * lots of developer debug notices pointing out things that
   need to be updated.
2009-07-09 07:35:03 +00:00
tjhunt
666e84584c MDL-19690 - more $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-03 04:23:05 +00:00
tjhunt
e63f88c9a6 MDL-19690 - lots more $CFG->pixpath to $OUTPUT->old_icon_url
and $CFG->modpixpath to $OUTPUT->mod_icon_url
2009-07-02 12:07:58 +00:00
tjhunt
6b608f8f50 MDL-19690 - lots more $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-02 10:53:31 +00:00
tjhunt
4096752d1d MDL-19690 - first 53 $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-02 10:06:39 +00:00
nicolasconnault
98f7f6919e MDL-19677 Reverting prematurely committed blog patch 2009-07-02 06:43:43 +00:00
nicolasconnault
856b6fe6d2 MDL-19676 Removed course and group visibility settings for blog 2009-07-01 08:49:47 +00:00
tjhunt
c207b6bece Remove a few unnecessary references to global $THEME. 2009-06-25 03:26:58 +00:00
skodak
17da2e6f28 MDL-16438 centralise information about plugins to avoid duplication, includes local customisation conversion to standard plugin structure + fixes for some recent regressions; see tracker for more details and links to docs and forums discussions 2009-06-19 14:25:56 +00:00
skodak
9d7493399d MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:35:10 +00:00
skodak
bb4b6010f3 MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:17:10 +00:00
tjhunt
cf6155226c ajaxlib/require_js: MDL-16693 $PAGE->requires->... deprecates require_js etc.
There is a new implementation of require_js in lib/deprecatedlib.php,
based on $PAGE->requires.

There were a few other recently introduced functions in lib/weblib.php,
namely print_js_call, print_delayed_js_call, print_js_config and
standard_js_config. These have been removed, since they were never in
a stable branch, and all the places that used them have been changed
to use the newer $PAGE->requires->... methods.

get_require_js_code is also gone, and the evil places that were calling
it, even though it is an internal function, have been fixed.

Also, I made some minor improvements to the code I committed yesterday
for MDL-16695.

All that remains is to update all the places in core code that are
still using require_js.

(This commit also fixes the problem where the admin tree would not
start with the right categories expanded.)
2009-06-12 12:13:07 +00:00
tjhunt
f4d76b9cdf blocklib: MDL-19010 fix some minor problems with existing blocks. 2009-06-05 08:28:45 +00:00
stronk7
942cd61b2e MDL-19350 upgrade review - adding missing savepoints to blocks 2009-06-03 14:49:57 +00:00
tjhunt
e03c0c1d49 blocklib: MDL-19010 fix editing block config and block roles. 2009-05-08 07:47:50 +00:00
tjhunt
f4d38d20fb blocklib: MDL-19010 and now you can delete blocks too! 2009-05-08 06:34:40 +00:00