22724 Commits

Author SHA1 Message Date
Andrew Nicols
b124832fe6 Merge branch 'MDL-70970' of git://github.com/paulholden/moodle 2021-04-23 11:26:53 +08:00
Sara Arjona
c9c18da021 Merge branch 'MDL-71400-master' of git://github.com/mihailges/moodle 2021-04-22 13:16:23 +02:00
Shamim Rezaie
0ca7548443 MDL-71144 mod_scorm: Deprecate scorm_get_completion_state() 2021-04-22 21:11:43 +10:00
Shamim Rezaie
7d102bb67d MDL-71144 mod_quiz: custom_completion should not use deprecated function
This commit also removes an unnecessary DB query.
2021-04-22 21:11:43 +10:00
Shamim Rezaie
d9d0ae01d3 MDL-71144 mod_quiz: Deprecate quiz_get_completion_state() 2021-04-22 21:02:02 +10:00
Paul Holden
4264f85063 MDL-71200 mod_folder: ensure "Download folder" option is backed up. 2021-04-22 10:29:25 +01:00
Paul Holden
0de5ab4b43 MDL-71392 mod_quiz: don't display grade to pass if not set. 2021-04-22 09:53:24 +01:00
Mihail Geshoski
4e714cebae MDL-71400 assignfeedback_offline: Fix message after worksheet upload 2021-04-22 13:08:15 +08:00
abgreeve
8a53fe7f6b Merge branch 'MDL-28452-master' of git://github.com/bmbrands/moodle 2021-04-22 09:38:50 +08:00
Shamim Rezaie
a2bf666a0c MDL-71144 mod_lesson: Deprecate lesson_get_completion_state() 2021-04-22 10:08:11 +10:00
Shamim Rezaie
b4c8f0f8a6 MDL-71144 mod_survey: Deprecate survey_get_completion_state() 2021-04-22 10:08:11 +10:00
Shamim Rezaie
5f9aa4d35f MDL-71144 mod_glossary: Deprecate glossary_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
c9fa4f9cd7 MDL-71144 mod_forum: Deprecate forum_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
c10dfd7583 MDL-71144 mod_feedback: Deprecate feedback_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
08fb6a71b7 MDL-71144 mod_data: Deprecate data_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
17c3c4dc75 MDL-71144 mod_choice: Deprecate choice_get_completion_state() 2021-04-22 10:08:10 +10:00
Jun Pataleta
d484b3e371 MDL-71144 mod_assign: Deprecate assign_get_completion_state() 2021-04-22 10:08:04 +10:00
Sara Arjona
49dbf2c130 Merge branch 'MDL-64336' of https://github.com/NeillM/moodle 2021-04-21 17:13:57 +02:00
Neill Magill
bce4c28577 MDL-64336 assign: Add missing PHP doc 2021-04-21 15:14:15 +01:00
Neill Magill
06a69802d6 MDL-64336 assign: Teachers should be able to see all submissions
Before this change a teacher would be able to see users listed if:

* They have an active enrolment and can submit
* They have an an inactive enrolment for a role that can submit

After this change they will additonally be able to see users listed:

* That have an active enrolment and have submitted
* That have an inactive enrolment and have submitted

This means that if an assignment has it's context frozen all users
that have made some form of submission will still be listed.

It will also apply if the submission capability is removed from a
user.

If a user's enrolment is deleted they will not be listed.

The submission and grading counts have also been updated so
they will reflect the new rules.
2021-04-21 15:14:14 +01:00
Neill Magill
1f55fff393 MDL-64336 assign: Submissions should be visible while frozen
Before this change if a student visited an assignment that is
frozen they would only see the title and description even if
they had made a submission to it.

After the change they will be able to see the status of their
submission and any feedback and grades they have recived.

It will also make the Moodle app recognise that submission
should not happen because the assignment is frozen.

Tests based on ones created by Andrew Nicols
2021-04-21 15:14:14 +01:00
Marina Glancy
263c39ba21 MDL-71389 various: changes to unittests due to php8 changes:
- some engine error messages changed
- some warning levels changed
- the carriage return symbol randomly appears
- one phpunit assertion fails and not really representative of anything
2021-04-21 12:38:46 +02:00
Bas Brands
f9e1c2587a MDL-28452 core_user: migrate social profile fields
Create a new profile field type, move all existing content of the fields
'icq', 'skype', 'aim', 'yahoo', 'msn' and 'url' in the mdl_user table to
theses new profile fields if needed.

AMOS BEGIN
MOV [aimid,core],[aimid,courseimage,profilefield_social]
MOV [yahooid,core],[yahooid,profilefield_social]
MOV [skypeid,core],[skypeid,profilefield_social]
MOV [icqnumber,core],[icqnumber,profilefield_social]
MOV [msnid,core],[msnid,profilefield_social]
MOV [webpage,core],[webpage,profilefield_social]
AMOS END
2021-04-21 11:22:25 +02:00
Sara Arjona
d54a89ad2e Merge branch 'dynreg-upgrade-squash' of https://github.com/cengage/moodle 2021-04-21 09:58:29 +02:00
Jake Dallimore
49c97a866c Merge branch 'MDL-71030-master' of https://github.com/NashTechOpenUniversity/moodle 2021-04-21 12:06:50 +08:00
Claude Vervoort
ca80d53b38 MDL-70500 lti: dyn reg can be used to update tools 2021-04-20 17:12:28 -04:00
Sara Arjona
d0b3f1d24a Merge branch 'MDL-62244_master_label_view' of https://github.com/sheesania/moodle 2021-04-20 17:44:54 +02:00
Paul Holden
6c159262f0 MDL-70970 quizaccess_seb: consistent property array sorting by key.
In PHP8.0 using `ksort` was producing incorrect results by sorting
keys differing only in case in the wrong order. This change makes
sorting consistent between PHP versions.

Co-Authored-By: Tim Hunt <T.J.Hunt@open.ac.uk>
2021-04-20 14:36:13 +01:00
Rajneel Totaram
2ff9484417 MDL-71376 mod_quiz: fix undefined object reference 2021-04-20 20:10:04 +12:00
Thong Bui
a8c868822f MDL-71030 Quiz: Add 'who' made changes in question response history 2021-04-20 09:06:15 +07:00
Víctor Déniz
f7dd6b26b7 Merge branch 'MDL-71118-master' of git://github.com/lucaboesch/moodle 2021-04-19 19:43:32 +01:00
Eloy Lafuente (stronk7)
973a4a2ae1 Merge branch 'MDL-71181-master' of https://github.com/ettolrah/moodle 2021-04-19 18:58:14 +02:00
Dongsheng Cai
a42df81709 MDL-68747 mod_quiz: force LTR for quiz grading overview chart 2021-04-19 21:06:04 +10:00
Paul Holden
4b3f22e5d1 MDL-71127 mod_quiz: fix thrown exception for invalid question columns. 2021-04-19 09:06:56 +01:00
Luca Bösch
aee27d0a9b MDL-71118 core: Add grade (verb) string.
AMOS BEGIN
 CPY [grade,core],[gradenoun,core]
 CPY [grade,core],[gradeverb,core]
AMOS END
2021-04-17 11:46:09 +02:00
Eloy Lafuente (stronk7)
fc2e04d903 Merge branch 'MDL-71334-master' of git://github.com/mickhawkins/moodle 2021-04-16 19:59:37 +02:00
Jake Dallimore
64e24894f4 Merge branch 'master' of git://github.com/paulphillip5/moodle 2021-04-16 07:57:01 +01:00
Michael Hawkins
7ffc5a7160 MDL-71334 mod_lti: Fix manual activity completion behat test 2021-04-16 14:09:55 +08:00
Sara Arjona
e82e8b4b1c Merge branch 'MDL-71337-master' of git://github.com/junpataleta/moodle 2021-04-15 08:30:08 +02:00
Jun Pataleta
18ad675111 MDL-71337 mod_h5pactivity: Increase window size during test
The addition of the activity information moves the h5p content down
out of the window view on Firefox which causes the Check button to be
unclickable. This patch increases the window size to ensure that the
check button is visible and clickable.

Credits to Eloy <stronk7@moodle.org> for the thorough investigation
of the root cause of this issue :)
2021-04-15 12:44:31 +08:00
Paul Holden
16eefb1444 MDL-70772 mod_forum: check for valid usernode before making active. 2021-04-14 09:20:02 +01:00
Andrew Nicols
c10791cab9 Merge branch 'MDL-71169-master-execute' of git://github.com/mudrd8mz/moodle 2021-04-14 08:35:07 +08:00
Luca Bösch
37a1f2454a MDL-69874 workshop: Title mentions received assessments in close phase. 2021-04-13 11:52:36 +02:00
Adrian Greeve
83b71194cd Merge branch 'MDL-71161-master-4' of git://github.com/junpataleta/moodle 2021-04-13 11:42:30 +08:00
Eloy Lafuente (stronk7)
6e39487123 Merge branch 'mdl_71172' of https://github.com/AnupamaSarjoshi/moodle 2021-04-13 00:46:55 +02:00
Michael Hawkins
09a59a75c6 MDL-71161 mod_workshop: Display activity completion information 2021-04-13 01:21:12 +08:00
Michael Hawkins
907ce56d20 MDL-71161 mod_wiki: Display activity completion information 2021-04-13 01:21:12 +08:00
Michael Hawkins
f37c83da8d MDL-71161 mod_url: Display activity completion information 2021-04-13 01:21:12 +08:00
Simey Lameze
59249a54c9 MDL-71161 mod_survey: show survey activity info 2021-04-13 01:21:12 +08:00
Michael Hawkins
920646237d MDL-71161 mod_scorm: Display activity completion information 2021-04-13 01:21:12 +08:00