1298 Commits

Author SHA1 Message Date
Aparup Banerjee
8f43b3990d Merge branch 'MDL-25561_user_report_name_clickable' of git://github.com/andyjdavis/moodle 2011-12-20 15:52:38 +08:00
Andrew Davis
5625d33d17 MDL-25561 grade: made the student names clickable on the user report 2011-12-12 15:57:04 +08:00
Tim Hunt
bea2086c95 MDL-30498 user name can overlap user report icon. 2011-12-09 18:36:56 +00:00
Aparup Banerjee
46f2a9366a MDL-30604 Added upgrade lines to upgrade.php(s) 2011-12-09 01:28:59 +01:00
Andrew Davis
97451e029b MDL-26522 grade: made the user selection drop down on the user report behave more sensibly 2011-12-02 09:48:36 +08:00
Sam Hemelryk
6416c6c25b Merge branch 'MDL-30007' of git://github.com/stronk7/moodle 2011-12-01 17:14:52 +13:00
Andrew Davis
39ee0ced4a MDL-30494 grade: provided a failure string to gives people experiencing UTF character test failures a starting point for fixing the problem 2011-11-30 11:49:39 +08:00
Andrew Davis
58800b7c36 MDL-30494 grade: improved unit tests for tokenize() 2011-11-30 11:39:25 +08:00
Petr Skoda
25a333877c MDL-30007 standardise gradebook plugins version files 2011-11-29 21:20:13 +01:00
Sam Hemelryk
bada16d35c Merged branch 'wip-MDL-30361-master-rtlpatches' of git://github.com/nadavkav/moodle.git with changes 2011-11-29 13:51:25 +13:00
Aparup Banerjee
c47b8c7d0c Merge branch 'MDL-30288_override_checkbox' of git://github.com/andyjdavis/moodle 2011-11-24 16:14:37 +08:00
Aparup Banerjee
3ca3098f31 Merge branch 'MDL-29226' of git://github.com/lazydaisy/moodle 2011-11-24 14:39:53 +08:00
Andrew Davis
185db1c962 MDL-30288 gradebook: prevented grade grade feedback being wrapped in a text to html div tag which was causing it to look like feedback had been edited when it hadn't 2011-11-24 11:27:13 +08:00
Nadav Kavalerchik
f34f2891b8 MDL-29226 - right align grade category title, in course grade report (when in RTL mode)(cherry picked from commit 2f364ff) 2011-11-23 01:31:53 +02:00
Aparup Banerjee
6aabd59e69 Merge branch 'MDL-27703_user_report_sql' of git://github.com/andyjdavis/moodle 2011-11-22 13:48:24 +08:00
Sam Hemelryk
009b14c065 MDL-30270 rubric Cleaned up minor points after review before integration 2011-11-22 10:40:15 +13:00
Mary Evans
24050190e3 MDL-29226 RTL fixes - additions and amendments 2011-11-19 00:53:14 +00:00
Marina Glancy
a19d1057ca MDL-30270, MDL-30269: rubric interface/usability improvements:
- In rubric editor the line 'Current rubric status' is hidden if there is no status yet
- If present the style of the status is the same as on manage.php page
- For newly created rubric 'Add criterion' button is pre-pressed automatically
- Changed JavaScript to work for Mac browsers default settings and for IPad
- MDL-30269: added explanation message about score to grade mapping
- fixed bug with non-javascript 'Add criterion' behaviour
2011-11-18 15:35:24 +08:00
andrew
d3e303470d MDL-27703 gradebook: altered an sql query in the user report. join with no on clause causes an error in some DBs 2011-11-16 09:56:46 +08:00
Sam Hemelryk
1ae9aa2b8f Merged MDL-29108 Advanced grading 2011-11-14 22:01:05 +13:00
Marina Glancy
3c2b3cb3ee MDL-29108: added comments, declared functions visibility, renamed variables; also fixed MDL-30240 2011-11-14 14:53:14 +08:00
Marina Glancy
b1add93e47 MDL-30241: fixing Javascript to work in IE as well 2011-11-14 14:48:28 +08:00
David Mudrak
6f07a6a2ea MDL-29108 Advanced grading - renaming DB field forminstanceid to instanceid
As a response to Sam's review (7.4)
2011-11-13 14:07:33 +01:00
David Mudrak
71ab436aa9 MDL-29108 Advanced grading - renaming DB fields formid to definitionid
As a response to Sam's review (7.1 and 7.3)
2011-11-13 14:03:38 +01:00
David Mudrak
9e32368b29 MDL-29108 Remove all associated grading areas when the context is being deleted 2011-11-13 13:50:00 +01:00
David Mudrak
c15b933c69 MDL-29108 Orphaned areas are excluded from search results
If for any reason the referenced context does not exist any more, the
forms defined in relevant areas are considered removed (even if their
records still exist in the database).
2011-11-11 14:16:17 +01:00
David Mudrak
217116d414 MDL-29108 Improving get_grading_method() documentation
As a response to Sam's review (10)
2011-11-11 12:18:02 +01:00
David Mudrak
6f19a2a98b MDL-29108 Removing global variables where they are not needed
Spotted by Sam during the review (17.1 and 17.3)
2011-11-11 12:10:02 +01:00
David Mudrak
241d9463de MDL-29798 Final clean-up before submitting for the integration review 2011-11-09 22:08:09 +01:00
David Mudrak
37065c2e06 MDL-29793 Advanced grading forms attached to activity modules can be restored now 2011-11-08 23:33:40 +01:00
David Mudrak
9b553d472e MDL-29793 Advanced grading forms attached to activity modules are included in the backup now 2011-11-08 16:25:58 +01:00
Marina Glancy
c97933ffa3 MDL-30161: link from gradebook (grading analysis) only appears now in Grader report but for all items; in User report the link under activity name contains userid 2011-11-08 14:09:50 +08:00
Marina Glancy
050125d47e fixed bug that appeared when teacher grades student with a rubric for the first time 2011-11-08 09:15:42 +08:00
David Mudrak
bb50c37651 MDL-30162 The grading method can be selected when creating new instance of the activity module 2011-11-08 01:54:36 +01:00
David Mudrak
b2c16c6e51 Files embedded into the form description are now served by the core itself
The grading form description is in the core scope so it should be served
by the core, not by the plugin.
2011-11-08 01:06:47 +01:00
David Mudrak
b02b7c5add MDL-30111 Rubric - reordered English strings by stringid 2011-11-07 23:23:38 +01:00
Martin Dougiamas
de2eb195fe MDL-30111 Rubric - some English strings rewording 2011-11-07 23:19:51 +01:00
Marina Glancy
188e840b99 MDL-29481: when student is being regraded we try to pick up the latest saved but not submitted version of grading
There are no visible changes yet because at the moment rubric is only saved when it is submitted but this is a base for AJAX saving
2011-11-07 15:55:08 +08:00
Marina Glancy
13926e735d MDL-30159: fixed bug: When evaluating by advanced grading extra entries are inserted in grading_instances 2011-11-07 14:37:58 +08:00
Marina Glancy
ffbf4370a2 MDL-30023: rubric editor usability - automatically set scores for added levels 2011-11-07 13:07:43 +08:00
Marina Glancy
2d41a9115b Fixed small bug resulting in a warning message when creating new rubric 2011-11-07 13:07:30 +08:00
sam marshall
e4aec5bed3 MDL-26647 (6) Support showuseridentity on grader report, quiz report, SCORM report 2011-11-04 13:57:17 +00:00
Marina Glancy
59be90119e MDL-30023: rubric editor usability - support for tab key and adding multiple levels 2011-11-04 14:58:05 +08:00
Marina Glancy
4f110c471a MDL-30023: rubriceditor usability - skip buttons for reorder and delete in tabindex 2011-11-04 11:30:06 +08:00
David Mudrak
0455c99864 MDL-29920 User report may display the grade analysis link, too
The original idea was to use the link in the row header (the activity
link). However, for both unified user experience and the overall patch
design reasons, I finally decided not to alter the activity link but to
append the analysis icon. The user experience should be the same as in
the grader report.
2011-11-03 13:51:45 +01:00
David Mudrak
f17bb885e9 MDL-29920 Grader report does not need to cache grade.php existence flags any more
This caching is now performed by the underlying methods.
2011-11-03 13:50:34 +01:00
David Mudrak
eff314b06a MDL-29920 Performance improvements in the gradebook reports
Both methods get_activity_link() and get_grade_analysis_url() now cache
the results of the check whether the activity module provides grade.php
or not. Previously, get_activity_link() called file_exists() in every
call and get_grade_analysis_url() did not check the existence at all.

Note that this solution is still sub-optimal as apparently both methods
do very similar job. This should be refactored one day by a brave
developer who works on gradebook. Meanwhile, even this suboptimal
solution is more effective than the previous one for most courses.
2011-11-03 13:44:41 +01:00
Marina Glancy
0136124e21 MDL-30112: marking rubric filling instances for regrading
- If a used rubric being updated, teacher (moderator) is notified
- If the changes are significant, all instances automatically marked for regrade
- if the changes are minor (texts, options or sortorder), teacher can choose whether to mark for regrade or not
- The instances marked for regrade can be re-graded but students are not able to see the rubric
- when grading a message appears if the instance is marked for regrade and is not visible to students
2011-11-03 16:08:36 +08:00
David Mudrak
dd736a87ee Replaced deprecated get_system_context() with the new context_system::instance() 2011-11-02 23:35:05 +01:00
David Mudrak
9e3d352dee Improved handling of occupied target issue
If the target area already contains a form, we can't pick anything to
use there. If the user works in two windows or there are several
teachers modifying the same course, it can happen that the form suddenly
appears in the target area while we have the form picker still open. In
such case, we simply redirects the user to the target area instead of
displaying the pooky exception.
2011-11-02 22:29:47 +01:00