522 Commits

Author SHA1 Message Date
Mihail Geshoski
e13cbf9e27 MDL-60621 js: Add ability to set a modal to be scrollable or not
With this change the modal can be configured to be scrollable or not.
If enabled to be 'scrollable', the modal's body will become scrollable
when the modal's height exceeds the browser's height. This is useful
in cases where the content in the modal is quite large and extends the
modal beyond the browser's height, which usually results in a bad UI.
If 'scrollable' is not explicitely configured, it will be set as 'true'
by default as in most cases it would be the expected behaviour.
2020-06-30 10:18:19 +08:00
Shamim Rezaie
292a67aede MDL-68991 core: Prevent popup blockers blocking feedback window
Some browsers like Firefox are very inflexible with window.open()
and block it if it is not instantly invoked after the user click.

Also according to https://stackoverflow.com/a/6807615 it is best
practice to replace self:: with static::
2020-06-10 16:10:53 +10:00
Shamim Rezaie
363aaf6eaa MDL-68076 core: log user's click on feedback links 2020-06-04 11:57:26 +10:00
Shamim Rezaie
a3a9539bd7 MDL-68076 core: display the feedback link on footer 2020-06-04 11:57:24 +10:00
Shamim Rezaie
d74a826829 MDL-68076 core: display call to feedback on user dashboard 2020-06-04 11:38:49 +10:00
Jun Pataleta
d5eec2a2fd Merge branch 'MDL-67743-master-final' of git://github.com/andrewnicols/moodle 2020-05-27 14:51:25 +08:00
Jun Pataleta
039fc86902 Merge branch 'MDL-68750-master' of git://github.com/andrewnicols/moodle 2020-05-27 11:03:54 +08:00
Andrew Nicols
1be0f90c6f MDL-67917 core: Add custom template support to autocomplete
Part of MDL-67743
2020-05-27 10:49:43 +08:00
Andrew Nicols
f456195599 MDL-67917 core: Return newly added nodes from template helpers
Part of MDL-67743
2020-05-27 10:49:43 +08:00
Andrew Nicols
89db84b5b1 MDL-68750 core_tag: Add missing confirmation dialogue title 2020-05-26 12:55:29 +08:00
Mathew May
eff7ef2cd2 MDL-68788 core_notification: Check if the user is logged in 2020-05-21 16:33:25 +08:00
Jun Pataleta
f46b5f5f28 Merge branch 'MDL-68463-master-3' of git://github.com/andrewnicols/moodle 2020-05-19 12:24:14 +08:00
Andrew Nicols
bc9426c879 MDL-68528 js: Normalise core component for template strings 2020-05-19 11:40:44 +08:00
Andrew Nicols
ed0328397a MDL-68528 js: Normalise empty component to "core" for string 2020-05-19 11:37:55 +08:00
Andrew Nicols
814da16778 MDL-68463 core: Add helper functions to toggle checkboxes 2020-05-18 20:03:38 +08:00
Eloy Lafuente (stronk7)
036b1beb49 Merge branch 'MDL-68677-master' of git://github.com/andrewnicols/moodle 2020-05-15 01:58:41 +02:00
Sara Arjona
ccc7a30b3e Merge branch 'MDL-68200-master-take2' of git://github.com/rezaies/moodle 2020-05-14 13:10:01 +02:00
Andrew Nicols
84d8b45fdf MDL-68677 core: Enable prefetching when cachejs is disabled
With the templaterev issue resolved we should enable the prefetch module
when cachejs is enabled to avoid a different experience when cachejs is
enabled vs. disabled.

Previously there was little point in doing this due to a range of other
bugs (string normalisation, and misuse of templaterev).

With these issues resolved we should enabel the caching.
2020-05-14 14:10:55 +08:00
Andrew Nicols
b9dec51ab4 MDL-68677 core: Correct usage of templaterev for caching templates
The M.cfg.templaterev variable should only be used to present persistent
caching, not caching of content within the same page load.

Preventing caching of same-page content makes it difficult to develop
for real user experiences as content is slow to load and does not give a
realistic and consistent loading experience.

This change affects the loading of partials specifically which notably
includes the loading spinner. Without this patch the loading icon is
often not seen at all because it does not load in a timely fashion and
the content being loaded is loaded first.
2020-05-14 14:10:55 +08:00
Jun Pataleta
2a202f3b97 Merge branch 'MDL-68529' of https://github.com/Chocolate-lightning/moodle 2020-05-14 12:51:35 +08:00
Mathew May
f2d033a2bb MDL-68529 course: Refactor chooser to include loading 2020-05-12 16:59:54 +08:00
Jun Pataleta
e21252b309 MDL-68200 core: Support fixday/hour for core/user_date's get() method 2020-05-12 10:59:02 +10:00
Shamim Rezaie
127f69d3fe MDL-68200 core: Add calendartype param to user_date.loadDatesFromServer 2020-05-12 10:59:02 +10:00
Andrew Nicols
f879cc518e MDL-66109 js: Build changes for NodeJS upgrade
This change includes a build to fix all minified file changes in Moodle
as a result of upgrades to our build process.
2020-05-11 10:55:54 +08:00
Andrew Nicols
9b7e6e9c6c MDL-66109 js: Built file changes from new Node version 2020-05-11 10:53:35 +08:00
Jun Pataleta
6a71bccfea Merge branch 'MDL-68524-master' of git://github.com/andrewnicols/moodle 2020-05-05 10:50:09 +08:00
Andrew Nicols
a427a48c10 MDL-68524 core: Prefetch modal registry templates 2020-05-05 10:16:10 +08:00
Andrew Nicols
983baf4e34 MDL-68524 js: Add prefetch module 2020-05-05 10:16:10 +08:00
Andrew Nicols
67774a9567 MDL-68409 js: Convert cancel modals to ES6 2020-05-04 15:08:11 +08:00
Andrew Nicols
9050f3f17e MDL-68409 js: Convert alert and confirmation dialogues to use modal 2020-05-04 15:08:10 +08:00
Andrew Nicols
e8df743b3b MDL-68409 js: Convert core/notification to ES6 2020-05-04 15:07:49 +08:00
Andrew Nicols
b810c84f2b MDL-68409 js: Add Alert modal 2020-05-04 15:07:49 +08:00
Andrew Nicols
fc3d7d693a MDL-68409 js: Fix eslint failure in modal 2020-05-04 15:07:48 +08:00
Andrew Nicols
92810f7af9 MDL-68409 js: Add setButtonText modal helper 2020-05-04 15:07:48 +08:00
Andrew Nicols
fa6101ba27 MDL-68409 js: Add helper to register close event on save/cancel 2020-05-04 15:07:48 +08:00
Andrew Nicols
8d186121ab Merge branch 'MDL-57680' of https://github.com/timhunt/moodle 2020-05-01 11:00:19 +08:00
Andrew Nicols
cb8ad9c76e Merge branch 'MDL-68378-master' of git://github.com/rezaies/moodle 2020-04-29 08:19:09 +08:00
Tim Hunt
be612e5f68 MDL-57680 form autocomplete: fix triggering change event 2020-04-26 13:23:42 +01:00
Tim Hunt
588b86fd49 MDL-57680 form autocomplete: let singleselects be cleared.
This was already working after ajax had refreshed the choices, it was just
broken on first page load.
2020-04-26 13:23:42 +01:00
David Thompson
5bc86614a2 MDL-68477 libraries: support for Chart.js legend options. 2020-04-23 09:23:21 +08:00
Shamim Rezaie
505cc918b7 MDL-68378 lib: Added accessibleChange custom event 2020-04-22 04:16:44 +10:00
David Thompson
ab0d409991 MDL-68386 libraries: Enhancement for Area Charts support with chart.js. 2020-04-17 09:12:41 +12:00
Adrian Greeve
50dbf7e9c8 Merge branch 'MDL-68196-master' of git://github.com/rezaies/moodle 2020-04-16 10:55:11 +08:00
Shamim Rezaie
517e568e5a MDL-68196 core: not expand autocomplete elements too soon on IE 2020-04-16 12:25:37 +10:00
Jun Pataleta
9183c0c91a MDL-67663 core: Do not use aria-hidden="false" on drawer
From https://www.w3.org/TR/wai-aria-1.1/#aria-hidden:
* "aria-hidden="false" is known to work inconsistently in browsers"
2020-04-09 17:50:09 +08:00
Andrew Nicols
604887ce8f MDL-67827 behat: Pending JS improvements for dialogues 2020-03-06 12:59:38 +08:00
Mathew May
e6a5298394 MDL-67264 lib modal: Add deffered promises to content promises 2020-02-13 09:15:41 +08:00
David Mudrák
7630b42232 MDL-67447 form: Fix the duplicate autocomplete selection node
When the autocomplete selection is updated, the content of the selection
wrapper is replaced with the new list of selected items. We must replace
only the content of the selection wrapper and not to nest it into
itself.
2020-01-25 05:39:01 +01:00
Andrew Nicols
1bb7d46966 Merge branch 'MDL-67378-master' of git://github.com/rezaies/moodle 2020-01-08 11:11:45 +08:00
Andrew Nicols
bc47535677 Merge branch 'MDL-67376-master' of git://github.com/rezaies/moodle 2020-01-08 10:40:25 +08:00