780 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
47f708fc30 MDL-71782 behat: Ensure page after saving changes is there
A similar approach was followed @ MDL-67935, although the
case doesn't seem to be the same.

In any case, it's curious that all local execution are
100% passing and only CIs fail so often. Just guessing if,
maybe, there is some Chrome version factor around (we
are running older, sticky, versions @ CIs.
2021-07-10 00:18:33 +02:00
Claude Vervoort
c8c81a1357 MDL-71887 mod_lti: repost when no cookie due to crosssite request 2021-07-07 14:17:12 +08:00
Andrew Nicols
4f422785c6 MDL-71113 javascript: Improve basic JS Documentation 2021-06-18 09:38:05 +08:00
Andrew Nicols
92179b7057 MDL-71113 js: Fix all jsdoc warnings 2021-06-18 09:38:05 +08:00
Andrew Nicols
70dcc60862 MDL-71113 js: Bare minimum fixes to build jsdoc 2021-06-18 09:38:04 +08:00
Mathew May
c95b254046 MDL-70622 mod_lti: Tighten redirect param typing 2021-05-07 11:43:42 +08:00
Adam Olley
752ad3d8eb MDL-70622 mod_lti: Prevent xss on lti 1.3 authentication script
Without this, people can craft URLs that other users might use not realising
what they do - and as a XSS vulnerability, it could do any number of things the
clicking-user has access to do on the site.

Change-Id: I82adc71e8706d8929011b4b24523d5b62b8ccea1
2021-05-07 11:43:33 +08:00
David Mudrák
ad30fde448 MDL-71425 lang: Fix reworded strings in tests 2021-05-04 17:45:18 +02:00
Helen Foster
49efd0b4b6 MDL-71425 lang: Import fixed English strings (en_fix) 2021-05-04 14:51:44 +02:00
Ilya Tregubov
7d9fa772d9 MDL-66431 core: Fix lti test for classic theme. 2021-05-02 16:06:17 +02:00
Ilya Tregubov
cf1cf222e7 MDL-66431 core: Fix behat tests.
Move activity creation to data generators. Only fixing those
tests failing due to removing usemodchooser preference.
2021-05-01 16:22:03 +02:00
Sara Arjona
d54a89ad2e Merge branch 'dynreg-upgrade-squash' of https://github.com/cengage/moodle 2021-04-21 09:58:29 +02:00
Claude Vervoort
ca80d53b38 MDL-70500 lti: dyn reg can be used to update tools 2021-04-20 17:12:28 -04:00
Michael Hawkins
7ffc5a7160 MDL-71334 mod_lti: Fix manual activity completion behat test 2021-04-16 14:09:55 +08:00
Michael Hawkins
e3fb51e3c8 MDL-71161 mod_lti: Display activity completion information 2021-04-13 01:21:12 +08:00
Eloy Lafuente (stronk7)
ac086dcf23 Merge branch 'MDL-70896-master' of git://github.com/marinaglancy/moodle 2021-03-18 00:34:05 +01:00
Ilya Tregubov
eaf40e050e MDL-69680 lib: Replace deprecated jQuery functions 2021-03-04 12:48:26 +08:00
Marina Glancy
1e8375d830 MDL-70896 mod: libxml_disable_entity_loader is deprecated in php 8.0 2021-02-15 18:58:56 +01:00
Andrew Nicols
71b232e23a Merge branch 'MDL-70339-master' of git://github.com/peterRd/moodle 2021-02-03 08:54:31 +08:00
Jun Pataleta
793aa03598 MDL-70288 mod_lti: Remove unnecessary empty label string
* When a label is passed to an (advanced) checkbox and no text
  was provided, the label will be displayed on the right of the the
  checkbox element. So there's no point in passing an empty string for
  the label just to render the text to the right of the checkbox.
2021-02-02 13:53:05 +08:00
Peter Dias
1e2e5ea0d3 MDL-70339 mod_lti: Use the convenience function to get the right img 2021-01-20 11:49:40 +08:00
Adrian Perez
9e15569d48 MDL-69202 Restore backup: add getter method for oldmoduleid 2021-01-16 10:25:05 +01:00
Eloy Lafuente (stronk7)
77342b96fc MDL-69308 upgrade: remove all the < 3.6.0 upgrade steps
This just deletes all the upgrade steps previous to 3.6.0. Some
small adjustments, like tweaking globals can also be applied
when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2018120300 (v3.6.0) as anti-cheating measure.

Note that in this case, there wasn't any case of upgradelib
functions being used, hence we haven't to deprecate/remove
anything in codebase. When there is such a need, that is done
in separate commits (one for each function) and documented here.

See MDL-65809 commits for an example removing/deprecating a
good number of functions.
2021-01-13 19:11:19 +01:00
Jake Dallimore
d0915426f1 Merge branch 'MDL-69399-master_lti_alpha' of https://github.com/haietza/moodle 2020-12-23 11:36:34 +08:00
Víctor Déniz
92e59b663d Merge branch 'MDL-70284-dynreg-bug' of https://github.com/cengage/moodle 2020-12-21 16:39:08 +00:00
Michelle Melton
6c235e4e96 MDL-69399 LTI: Alphabetize LTI tool list in selection menu 2020-12-18 08:58:07 -05:00
Jun Pataleta
b4ea4caf0f Merge branch 'MDL-70361-dlrlid' of https://github.com/cengage/moodle 2020-12-15 11:16:58 +08:00
Claude Vervoort
3071777ddb MDL-70361 mod_lti: deeplinking multiple preserve resourceid and tag 2020-11-30 14:41:13 -05:00
Claude Vervoort
33594cf3a4 MDL-70284 mod_lti: dynreg fix response claims 2020-11-25 10:52:12 -05:00
Adrian Greeve
41b9a81caa Merge branch 'MDL-67668-master-2' of git://github.com/andrewnicols/moodle 2020-11-23 15:40:04 +08:00
Adrian Greeve
76ddbf3822 Merge branch 'MDL-67028-additional-custom-parameters' of https://github.com/cengage/moodle 2020-11-23 14:05:05 +08:00
Andrew Nicols
0d580d2b3e MDL-67668 behat: Update tests for inplace editable field type 2020-11-23 09:01:19 +08:00
Andrew Nicols
ba34d6e225 MDL-70148 behat: Update steps for keyboard 2020-11-17 15:14:43 +08:00
Claude Vervoort
6f34fe6dfe MDL-70074 mod_lti: add authorization_endpoint 2020-10-30 18:16:04 -04:00
Jun Pataleta
1ec3dda801 Merge branch 'MDL-67301-dynreg-squashed' of https://github.com/cengage/moodle 2020-10-26 12:40:31 +08:00
Claude Vervoort
84e90d5db4 MDL-67301 mod_lti: dynamic registration 2020-10-24 09:27:55 -04:00
Eloy Lafuente (stronk7)
f6711bb394 MDL-67673 phpunit: Fix the return type of template methods
All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.

At the same time, fix a few wrong function names,
provider data and param types, return statements...
2020-10-21 12:45:59 +02:00
Jake Dallimore
6325f848d8 Merge branch 'MDL-67695-master_get_lti_proxies' of https://github.com/andrewmadden/moodle 2020-10-20 11:08:16 +08:00
Eloy Lafuente (stronk7)
6b3774b7b7 Merge branch 'MDL-57756-text-customparams' of https://github.com/cengage/moodle into master 2020-10-19 22:31:51 +02:00
Andrew Madden
8177ccf566 MDL-67695 mod_lti: Use correct return structure for get_tool_proxies.
* Deprecated serialise_tool_proxy() as no longer used.
* Use tool_proxy_return_structure for each proxy.
* Added tests for getting all proxies and orphaned proxies.
2020-10-20 04:08:35 +11:00
Adrian Greeve
611a42b934 Merge branch 'MDL-68384-fix-spec-violations' of https://github.com/cengage/moodle 2020-10-09 12:06:37 +08:00
Adrian Hutchinson
9980578112 MDL-67028 mod_lti: Support CourseSection.timeFrame custom parameters 2020-10-05 07:55:02 -07:00
Claude Vervoort
80207a2ee1 MDL-57756 mod_lti: params change to text type 2020-10-01 17:37:29 -04:00
Claude Vervoort
957da4b564 MDL-67473 mod_lti: deeplinking multiple support
AMOS BEGIN
 CPY [contentitem_help,mod_lti],[contentitem_deeplinking_help,mod_lti]
AMOS END
2020-09-30 08:03:59 -04:00
Claude Vervoort
7263f2855d MDL-68384 mod_lti: fix spec violations bo claim name and dl value type 2020-09-28 16:53:33 -04:00
Claude Vervoort
5b8c646e68 MDL-66934 mod_lti: support context history param 2020-09-18 14:11:34 -04:00
Eloy Lafuente (stronk7)
5e124b9040 Merge branch 'MDL-69664-master' of git://github.com/junpataleta/moodle into master 2020-09-17 08:43:51 +02:00
Jun Pataleta
46d4cf0c98 MDL-69664 mod_lti: Apply correct badge class to tool card 2020-09-09 23:34:04 +08:00
Eloy Lafuente (stronk7)
432b9a9075 MDL-69521 core: Move all comments in code from 4.3 to 4.1 2020-09-08 18:59:46 +02:00
Justin Hunt
107a0c9874 MDL-66810 mod_lti: Reinstate deprecated default permissions on iframe
microphone, webcam, camera, midi, encrypted-media, geolocation
2020-08-27 09:43:26 +08:00