483 Commits

Author SHA1 Message Date
skodak
9376f5a66a MDL-11583 fixed use of capability moodle/grade:manageletters - now works in plugin selector 2007-10-03 20:24:59 +00:00
skodak
8dd5c1ee2f MDL-11585 false is not allowed default in admin_setting_configselect constructor 2007-10-03 20:02:12 +00:00
skodak
0e4da9e34f fixed context parameter in has_capability() call 2007-10-03 14:16:04 +00:00
nicolasconnault
ece966f06e MDL-11482 Resolved the sum icon issue (added a new x-bar icon) and resolved a dependency problem in moodlelib 2007-10-03 12:22:25 +00:00
skodak
284abb0925 MDL-11495 grade letter setting improvements:
* in_null for decimals defaults checks
* store letter settings only in database - no cfg settings
* separate configuration page for letters only - pluginselector+admin tree
* new capability to manage grade letters - similar to scales and outcomes
* added grade_letters db index
* grade letters related minor bugfixing
2007-09-28 20:12:43 +00:00
skodak
dafbc521ba MDL-11495 removed GRADE_DECIMALS_DEFAULT null constant, is_null() used instead for tests, -1 used in menu options 2007-09-28 11:08:44 +00:00
nicolasconnault
e9096dc2ca MDL-11480 Reviewed, tested, and pplied Petr's patch. 2007-09-28 07:55:51 +00:00
toyomoyo
e5ea84faba MDL-11478, fixing a notice 2007-09-28 01:53:45 +00:00
nicolasconnault
9fa46707f3 MDL-11456 the .grade-report-grader table {} style was cascading down to the popups (which use tables, alas...), so I created a number of css classes which now control color, font etc for caption and feedback cells of the popup. 2007-09-27 18:00:25 +00:00
skodak
662a057c77 MDL-11451 adding default ipaddress restriction and 7 days lifetime for user key 2007-09-27 07:06:17 +00:00
skodak
d0cbeafbcb MDL-11451 fixing silly typo in cap name 2007-09-27 06:56:51 +00:00
skodak
0a3bdfaf79 MDL-11451 grade publishing security/privacy improved - new capabilities needed for publishing, by default allowed only for admins; added warning to publishing option 2007-09-27 06:51:54 +00:00
toyomoyo
0893aa30e8 when no gradebook roles is set, there are lots of sql breakages so we should check gradebookroles first 2007-09-27 02:29:46 +00:00
skodak
d7a61f65c1 MDL-10985 improved form validation in xml grade import 2007-09-26 19:34:54 +00:00
skodak
1843999a77 MDL-10985 merged the xml and xmlurl grade import plug-in 2007-09-26 18:11:48 +00:00
skodak
8925adab08 fix of disabledIf fix :-( 2007-09-26 17:30:24 +00:00
skodak
4b282c641f fixed disabledif conditions 2007-09-26 16:49:37 +00:00
nicolasconnault
206f995349 Fixing OU report issues 2007-09-26 12:25:16 +00:00
skodak
c22e335d80 MDL-9636 fixed many sql injections in grade import code 2007-09-26 11:02:36 +00:00
skodak
235b07fb64 MDL-9636 grade_items are now limited to current course only - can not import into other courses anymore 2007-09-26 10:54:09 +00:00
skodak
e9dea7af66 MDL-9636 corrected the creation of new manual grade items, added source parameter 2007-09-26 10:00:51 +00:00
skodak
a700b5deee MDL-10985 import from remote xml file with key login option 2007-09-26 09:42:28 +00:00
nicolasconnault
d32100a522 Fixing OU report issues 2007-09-25 19:32:29 +00:00
nicolasconnault
31a6c06c46 MDL-11433 Implemented grade_items.decimals instead of user preference in grader report. 2007-09-25 14:40:49 +00:00
skodak
5e2fbccb33 no text formating in grade xml export for now - we need the original values for reimport 2007-09-25 11:02:12 +00:00
nicolasconnault
1796708d81 Replacing GRADE_REPORT_GRADE_DISPLAY_TYPE... by GRADE_DISPLAY_TYPE... 2007-09-25 08:22:20 +00:00
skodak
9a9b501187 MDL-11422 fixed duplicate title attribute 2007-09-24 11:11:48 +00:00
skodak
465b310d2b prevent error when somebody changes scale or grading type - old value does not fit the new scale 2007-09-23 12:09:16 +00:00
skodak
3f2b0c8aba MDL-11363 merged tables grade_grades with grade_grades_text - it is now possible to define fields as required and optional
finally fixed formula validation in calculation edit form
2007-09-22 11:39:59 +00:00
nicolasconnault
41f22daa71 MDL-11353 Completed the implementation. This included a new method in grade_item: get_displaytype(), since that value could be set to default, and we must then look up to course, then site values. And the get_letter() method in grade_grade has been modified to first check the grade_letters table. All works like a dream! 2007-09-19 15:37:46 +00:00
nicolasconnault
ac5b0a4919 MDL-11339 Moved the gradedisplaytype element from user prefs to the display element of the grade_item settings 2007-09-19 14:28:26 +00:00
nicolasconnault
109bf12cda MDL-11340 Finished! 2007-09-19 14:12:34 +00:00
nicolasconnault
bc6969ddeb MDL-11340 Almost complete: Just need the "Add grade letter" button 2007-09-19 13:49:26 +00:00
nicolasconnault
dbdffd2c96 MDL-11340 Almost complete: Just need the "Add grade letter" button 2007-09-19 12:45:44 +00:00
skodak
85c9ebb926 MDL-1883 improved perf when editing scales - new function xxx_scale_used_anywhere() 2007-09-18 18:37:58 +00:00
moodler
567883c836 Cleaned up the display of the export pages 2007-09-18 03:36:47 +00:00
nicolasconnault
a5b8be622c MDL-11275 added (submissions). Also fixed :
Issue:
    Teachers can edit grader report preferences (including switches for quickgrading and
    quickfeedback), but do not have access to the "Turn editing on/off" button, so they
    can't do quickgrading.
Solutions:
    1.Decouple the quickgrading and quickfeedback modes from the editing mode,
        and turn them on/off through the preferences page. New capability: moodle/grade:edit
        * preferences: don't show quickgrading if no capability grade:edit
        * If quickgrading is switched off as a preference and user doesn't have manage cap, show edit icons around grades when in editing mode
2007-09-17 17:31:48 +00:00
toyomoyo
5bb8a8154e MDL-11084, "s in grade comments causes problems 2007-09-17 06:53:24 +00:00
toyomoyo
4581501ede MDL-11276, average calculations are inaccurate in percentage form due to double rounding 2007-09-17 04:25:51 +00:00
toyomoyo
cb68af8b89 removing extra number_format(), format_float() already calls number_format() 2007-09-17 02:15:51 +00:00
skodak
8e1ec6be58 MDL-11298 use textlib_get_instance() instead of new textlib() 2007-09-16 18:49:41 +00:00
skodak
8fafbc0ea3 MDL-11296 fixed incorrect detection of duplicate scales in course 2007-09-15 21:17:11 +00:00
skodak
31314c1270 fixed wrong $options - this->keepdrop_options used instead 2007-09-15 13:23:28 +00:00
nicolasconnault
e171963b3e MDL-11278 Implementation is complete, but grade_categories records in DB are not affected by global settings. This way, when global settings are switched back to "Do not Force", the original category settings will be in place. 2007-09-14 17:21:30 +00:00
toyomoyo
00374cc5f0 MDL-11274, hide grades in the grader report if the current grades has no viewhidden capability 2007-09-14 08:43:10 +00:00
nicolasconnault
098042baea Issue:
The number of submissions in the Group average and Course average calculations
    should be shown in brackets. (submissions) should be added after the Group average
    and Course average labels.
Solution:
    new grader report preference (Display number of grades in average cells).
2007-09-14 06:57:30 +00:00
moodler
2c7a9bd2af Fix the location of the link to the site-wide grading preferences 2007-09-14 06:51:57 +00:00
moodler
6308b91c13 Changing string for Overall average (was logged under MDL-11233 even though that's not strictly the correct bug) 2007-09-14 05:45:38 +00:00
nicolasconnault
aae94377b7 Issue:
Only students should appear in the tutor report, however
    sorting by Surname results in the tutor being included, which we don't want.
Solution:
    Confirmed as a bug and filed in tracker: http://tracker.moodle.org/browse/MDL-11233

Issue:
    Clicking on Hide Groups reveals the results for all students
    and all tutors and course staff appear. A tutor should only be able to see
    the results for their tutor group
Solution:
    Prevent tutors from ever seeing student grades from other groups: use existing capabilities
        moodle/site:accessallgroups = off AND moodle/grade:viewall = on

Issue:
    Preferences tab should not be available to users without gradereport/grader:manage capability
Solution:
    Hide the tab completely

Issue:
    Apply different style to average cells
Solution:
    Add css classes to the different average cells, and write a default style in css file.

Issue:
    The Average under group average might be better labelled Course average.
Solution:
    Rename to "Complete average"
2007-09-13 15:11:16 +00:00
nicolasconnault
c421ad4b2e MDL-11233 Corrected typo in grader report lib, and added a second sort parameter for lastname and firstname sorts, to add consistency to result sets. Non-students no longer appear in the list 2007-09-13 13:44:35 +00:00