1425 Commits

Author SHA1 Message Date
Pierre Pichet
b800dc1990 MDL-25194 setting 'returnurl' and removing display of correctanswerfeedback... , left these only on calculatedmultichoice 2010-11-16 15:53:11 +00:00
Pierre Pichet
f9ce698969 MDL-25194 removing display of correctanswerfeedback... , left these only on calculatedmultichoice 2010-11-16 15:50:50 +00:00
Pierre Pichet
f065391d6d MDL-25194 settig 'returnurl' 2010-11-16 15:47:42 +00:00
Pierre Pichet
f5382dd25e MDL-25194 replace protected options of default_question_type by public optionsa defined in calculated.
the same parameter is used in calculatedsimple and caculatedmulti which extends question_calculated_qtype
2010-11-16 03:43:54 +00:00
Tim Hunt
8b1e050bd0 qtype multichoice MDL-25208 Saving questions was broken. 2010-11-15 17:17:48 +00:00
Tim Hunt
9dd460390c question import MDL-25200 was ignoring the category specified in the file. 2010-11-15 15:27:24 +00:00
Pierre Pichet
ab152de445 MDL-25192 and MDL-25194 import and saving images using instructions ['files'] array 2010-11-15 14:14:43 +00:00
Pierre Pichet
dec3f2128b MDL-25192 editing and saving instructions image usng question->id 2010-11-15 14:09:19 +00:00
Dongsheng Cai
41dcc2a508 MDL-25220 Question editors need to support subdirs 2010-11-15 06:37:13 +00:00
Petr Skoda
785d2cf2bd MDL-25031 fixed question ugprade - credit goes to Mark Nelson 2010-11-15 05:53:22 +00:00
Pierre Pichet
b21aea7408 MDL-25104 removing unnecessary $options = array_shift($oldoptions) line 192 that generates 2 question_numerical records,
this was added by inadvertence  in the last many lines modifications
2010-11-14 03:51:35 +00:00
Pierre Pichet
710903a6b3 MDL-25104 correcting import_or_save_files() function 2010-11-12 20:30:09 +00:00
Tim Hunt
69988ed452 questions MDL-25104 and MDL-25088 fix question editing and import
Editing of some qtypes was broken since a previous commit by me earlier in the week.

Import of XML and GIFT should now work, but could use some more testing.
2010-11-12 17:11:34 +00:00
Tim Hunt
13bb604ed5 question export MDL-25088 this is the first part. I think question export is now working for all types.
Import to follow soon.
2010-11-12 12:06:48 +00:00
Helen Foster
b0363c4138 MDL-25151 new help string thanks to Mark Nelson for reporting it missing 2010-11-12 11:31:53 +00:00
Tim Hunt
9203b70576 question deletion MDL-25173 when a question is deleted, all the associated files must be deleted. 2010-11-12 11:29:53 +00:00
Tim Hunt
cf991c1d85 question editing MDL-25151 Notices when editing random questions. 2010-11-12 10:23:29 +00:00
Pierre Pichet
a207b735a2 MDL-25168 decoding questiontext using new questiontext array [text].... 2010-11-12 02:45:30 +00:00
Tim Hunt
5d548d3e0a question bank MDL-24995 clean up a lot of deprecated code to do with moving questions around.
This should also fix MDL-25172, MDL-23021 and MDL-23073. In other words, moving questions between categories should now work.
2010-11-11 21:54:22 +00:00
Tim Hunt
a9efae50e3 question upgrade MDL-16094 fix up earlier mistakes in the text format upgrade.
There was a mistake in the text format upgrade in the question bank. The wrong conversions were performed, and the wrong arguments were passed to text_to_html in the conversions that were done.

Also, not all the calls to format_text had been updated to use the values in the new format columns.

I think this change fixes everything, but I have only had very limited time to test it. I am committing it anyway, because that seems to me to be the best way to maximise testing. I think that the new code is certainly better than the old code was.
2010-11-11 17:32:25 +00:00
Pierre Pichet
c8fdd86791 MDL-25104 Fixing cloze import and export 2010-11-09 04:07:37 +00:00
Pierre Pichet
0814c09938 MDL-25104 Fixing some other error about $files in $instructions param of numerical 2010-11-09 00:02:57 +00:00
Pierre Pichet
ae2c091f09 MDL-25104 Fixing some litle errors about $instructions param of numerical 2010-11-08 20:58:32 +00:00
Tim Hunt
2ed801777a question XML import MDL-25104 fix a whole bunch of minor errors. 2010-11-08 17:25:53 +00:00
Tim Hunt
4673212416 xml import/export MDL-25103 was not working due to out-of-memory errors when calling xmltidy, which broke XML wellformedness.
The solution is to not tidy the XML. The XML generated is already quite well laid out, and if we want it better, we should fix that, rather than trying to load the whole file into memory to reformat it.

Also, while investigating this, I found that we were not handling the mime-type of the exported file very elegantly, so I added a new mime_type method (defaults to getting the mime type of the file extension).
2010-11-08 15:51:10 +00:00
Pierre Pichet
22f17bcaff MDL-25086 numerical options for numerical questions, calculated and 1,9 import without images... 2010-11-06 15:38:36 +00:00
Pierre Pichet
ac582c3b25 MDL-25086 first modifications, numerical options for numerical questions 2010-11-06 02:16:07 +00:00
Dongsheng Cai
cde2709a88 MDL-15573, question export rewrite 2010-11-05 06:34:00 +00:00
Sam Hemelryk
367a75fae4 themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
Tim Hunt
93971a3b0f question type upgrade MDL-24863 Fix broken upgrade on MSSQL.
Thanks to mark williams for the report.
2010-11-04 09:49:00 +00:00
Tim Hunt
20d891228f MDL-24256 question category editing was messed up.
The unerlying problem seemed to be too many uses of pass-by-reference in listlib, where it was not necessary.
In investigating this code, I ended up doing a fair bit of cleaning up. Apologies that it leads to an unclear changeset.
2010-11-02 18:38:50 +00:00
Pierre Pichet
d8741145e8 MDL-24503 eliminating diagnostic echo or print_r() 2010-11-02 13:28:06 +00:00
Eloy Lafuente
d0ff90ed4f MDL-25000 backup - prevent calling get_mapping() with empty ids. Yay, 25000! 2010-11-02 01:05:43 +00:00
Tim Hunt
f2ca88b07f qtype_multichoice MDL-24937 multichoice questions were getting marked as answered even when they weren't. 2010-11-01 18:14:27 +00:00
Tim Hunt
157434a522 quiz/question javascript MDL-24170 Enter in a shortanswer question preview should not flag the question.
That bit of JavaScript from mod/quiz/attempt.php is needed in question preview too, so refactor a bit.

I was disappointed to find that the
$PAGE->requires->js_module('core_question_engine');
line was needed in quiz_get_js_module, but it seems to be.

Also change non-Moodle-y string "End test..." to "Finish attempt..."
2010-11-01 17:44:59 +00:00
Tim Hunt
48c19b2551 quiz lang MDL-24170 move an old string to a more logical name, before making the real change.
AMOS BEGIN
 MOV [finishattempt,mod_quiz],[submitallandfinish,mod_quiz]
AMOS END
2010-11-01 17:36:15 +00:00
Eloy Lafuente
9f68f2d5a6 MDL-24817 backup - added support for decode contents in plugins (and qtypes) 2010-11-01 15:49:01 +00:00
Sam Marshall
152f2c0777 Unit tests MDL-24994 Numerical question unit test was broken 2010-11-01 15:46:58 +00:00
Pierre Pichet
8f609a37cf MDL-10110 MDL-20296 improve grading when unit input is empty 2010-10-31 13:27:58 +00:00
Pierre Pichet
e8a67abab4 MDL-10110 Eliminating references to question_numerical_options table 2010-10-30 15:36:23 +00:00
Pierre Pichet
92b3600575 MDL-24503 recoding unit grading options 2010-10-30 15:14:57 +00:00
Tim Hunt
1f0fdc4018 quiz editing MDL-23761 $PAGE->set_heading should be set_header
Thanks to Derek Woolhead for the fix.
2010-10-25 16:17:57 +00:00
Eloy Lafuente
41941110fd MDL-22138 backup - I know smaller cathedrals than this, yay quizzes! 2010-10-24 10:43:42 +00:00
Tim Hunt
fde29fa59c quiz & qbank MDL-24453 some more return URLs that I missed the first time.
Also, fix a double-escaping bug when cancelling the form.
2010-10-18 15:53:54 +00:00
Tim Hunt
fb6dcdab11 quiz & qbank MDL-24453 fix all the ways you can edit a question, so that that returnurl paramterer acutally works.
I hope. Please test thoroughly.
2010-10-18 15:28:59 +00:00
Dongsheng Cai
c27353510d "MDL-15573, question bank the php4 compatiable code will broke in php5" 2010-10-13 04:13:46 +00:00
Dongsheng Cai
5b9199a04b "MDL-15573, fixed essey question type feedback text" 2010-10-12 10:29:50 +00:00
Petr Skoda
4756e9c9e2 MDL-21915 fixing remaining chmod and mkdir to use moodle file permissions 2010-10-06 19:06:52 +00:00
Pierre Pichet
5fe5e8ac5b MDL-23825 reactivating disabledif calls as they are working again 2010-10-02 01:59:17 +00:00
Petr Skoda
6bdfef5da9 MDL-24321 switching to standard stdClass() 2010-09-21 08:54:01 +00:00