mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-19 06:18:28 +01:00
Code Issues Projects Releases Wiki Activity
86,937 Commits 36 Branches 519 Tags
Commit Graph

2066 Commits

Author SHA1 Message Date
Mark Nelson
9b0f29239b MDL-60590 enrol_manual: button title depends on cohort list existence 
Also added a SELECTORS object to tidy the code by keeping the
selectors in a central location.
 2017-11-06 12:35:05 +08:00
Mark Nelson
8ce86ebba3 MDL-60590 enrol_manual: check cohorts exist before displaying select 2017-11-06 12:35:05 +08:00
Mark Nelson
1bd70073c5 MDL-60590 enrol_manual: only show cohorts with necessary capabilities 2017-11-06 11:22:45 +08:00
Andrew Nicols
2600f32927 Merge branch 'MDL-60506-master-fix1' of git://github.com/lameze/moodle 2017-10-25 12:45:56 +08:00
Simey Lameze
7a963e924c MDL-60506 enrol: remove unwanted hidden elements 2017-10-24 13:18:58 +08:00
Andrew Nicols
2f5284f5fb Merge branch 'MDL-60506-master' of git://github.com/lameze/moodle 2017-10-23 13:37:09 +08:00
Simey Lameze
92109e732d MDL-60506 enrol: use optional_param_array to handle cohorts array 2017-10-23 12:54:09 +08:00
Simey Lameze
b5a1ef52e0 MDL-60506 enrol: use optional_param_array to handle users array 2017-10-23 12:48:11 +08:00
John Okely
b58764ff99 MDL-42834 admin: Remove loginhttps 2017-10-23 12:25:35 +08:00
Mark Nelson
af835c24b2 MDL-60179 core: make it clear what enrolment instance is being edited 2017-10-19 14:57:23 +08:00
Jun Pataleta
4047fccba7 MDL-59811 enrol: Move get_user_enrolment_actions logic to parent class 
* These duplicated implementations can be simplified where the logic
  can be moved to enrol_plugin::get_user_enrolment_actions() method
  itself.
 2017-10-09 10:29:02 +08:00
Jun Pataleta
18000c6d60 MDL-59811 enrol: Unit tests for get_user_enrolment_actions() 2017-10-09 10:29:02 +08:00
Andrew Nicols
2a77813b51 MDL-59882 behat: Update known uses of dialogue CSS 2017-10-02 12:44:37 +08:00
Eloy Lafuente (stronk7)
186a8c1572 Merge branch 'MDL-43176' of https://github.com/NeillM/moodle 2017-09-20 10:12:37 +02:00
sam marshall
22ef155087 MDL-53169 Lib: enrol_get_my_courses can list available courses too 2017-09-19 12:19:49 +01:00
Neill Magill
dbe7012475 MDL-43176 enrol_meta: enrol_meta_sync query is inefficient 
Before this change the nested select did a full table scan of
either the enrol or user_enrolments table. This meant that
on large sites the query could be very slow.

This change ensures that there are no full table scans which
makes the query much more efficient.

In my testing the all courses version of the query changed
from ~15 s to ~ 5 s; the singles course version changed
from ~15 s to > 0.1 s
 2017-09-15 14:12:32 +01:00
Mark Nelson
93b47710ac MDL-59977 core: do not directly check 'viewparticipant' capability 2017-09-11 12:44:27 +08:00
Eloy Lafuente (stronk7)
95fc1e720c Merge branch 'MDL-59983-master-enfix' of git://github.com/mudrd8mz/moodle 2017-09-07 10:58:35 +02:00
Andrew Nicols
030ede54f8 MDL-59759 enrol: Update behat tests for unenrol confirm dialogue 2017-09-07 10:53:35 +02:00
Helen Foster
7698619bc6 MDL-59983 lang: Merge English strings from the en_fix language pack 
Significant string changes:

* mobileappenabled, setuplink and setuplink_desc in tool_mobile -
  improved wording
* getmoodleonyourmobile and custommenuitems_desc in tool_mobile -
  improved wording
 2017-09-05 11:01:09 +02:00
Jun Pataleta
b26ce53776 Merge branch 'MDL-59823-master' of git://github.com/damyon/moodle 2017-08-29 15:49:24 +08:00
Andrew Nicols
85419c5b2e Merge branch 'MDL-59828-master' of git://github.com/damyon/moodle 2017-08-29 11:56:28 +08:00
Damyon Wiese
d8e57f02a7 MDL-59828 autocomplete: Sizing issues on themes 
We want to avoid page jumps wherever possible. This change uses the original select element as a "proxy" to reserve the space
in the DOM for the enhanced auto-complete when the JS runs.

It uses visibility: hidden to make the select not rendered - but still take up space.

The exact sizing for the CSS was determined by testing and reverse engineering the bootstrap calculations.

The size of user pictures in selectors was reduced to avoid flicker when switching between no selection and a selected user. I
could have reserved a larger amount of space, but it looks worse for pickers with no pictures.
 2017-08-25 15:07:40 +08:00
Andrew Nicols
b05f2cd794 MDL-59859 enrol_manual: Improve modal creation ordering 2017-08-21 13:00:00 +08:00
Damyon Wiese
f4ddc4ecd3 MDL-59823 users: Enrol bulk op course instance 
The commit message above was my best attempt at meeting the very short restrictions on commit message first lines.

What it needed to say was: "Only show bulk enrolment operations for enrolment methods that have an instance in the course"
 2017-08-17 12:03:52 +08:00
Eloy Lafuente (stronk7)
19e8e56e7e Merge branch 'MDL-59756-master-2' of git://github.com/junpataleta/moodle 2017-08-15 13:38:01 +02:00
Damyon Wiese
5dd94c811d MDL-59370 behat: Behat fixes for enrolled users 
We removed the enrolled users page, so we need to update the behats that were using it.
 2017-08-14 11:06:22 +08:00
Damyon Wiese
4b50765bd5 MDL-59370 enrol: Kill the enrol/users page. 2017-08-14 11:06:16 +08:00
Jun Pataleta
00aba5ec9a MDL-59756 enrol: Swap positions of edit and unenrol actions 2017-08-11 10:18:30 +08:00
Jun Pataleta
1453d146b3 MDL-59366 enrol: Nuke manage_enrolments_from_participants.feature 
This will be removed soon. Better remove it now since it started to
cause failures after the new course participants page improvements
have landed.
 2017-08-04 09:51:28 +08:00
Jun Pataleta
37fc1d4db7 MDL-59366 enrol: Be more specific on which autocomplete is being opened 
* Specify that the autocomplete in the student's row in the
  participants table is being opened.
 2017-08-04 09:14:30 +08:00
Andrew Nicols
3d4739ab64 MDL-59602 enrol: Correct course name for restored course 2017-08-02 13:02:29 +08:00
Dan Poltawski
e3a2d7a473 Merge branch 'MDL-59366-master' of git://github.com/junpataleta/moodle 2017-08-01 10:36:14 +01:00
Andrew Nicols
5c5b130268 Merge branch 'MDL-58928-alt-attribute-enrolment-edit-delete-icons' of https://github.com/lucaboesch/moodle 2017-08-01 14:54:05 +08:00
Luca Bösch
da15576180 MDL-58928 enrol: delete and edit icon alt attribute 2017-07-31 17:31:07 +02:00
David Monllao
7190f330b4 Merge branch 'MDL-59602_coursenav' of https://github.com/mrmark/moodle 2017-07-31 13:21:09 +02:00
Jun Pataleta
445de896ef MDL-59366 enrol: Add $onlyenabled param in enrol instances getters 
* Add param in order allow flexibility for the methods to be able
to fetch only active enrol instances as well.

Part of MDL-59290.
 2017-07-28 16:11:56 +08:00
Jun Pataleta
91b099dbed MDL-59369 enrol: Fix add_to_group Behat tests 
Tab to the next element after selecting groups in order for
the autocomplete element to close and be able to click on the
"Save changes" link.
 2017-07-27 11:17:33 +08:00
Jun Pataleta
06aa592315 MDL-59369 enrol: Behat tests for plugin enrol actions 2017-07-26 09:44:33 +08:00
Jun Pataleta
fd0a43be1b MDL-59369 enrol: Introduce data-action attribute for enrol action links 2017-07-26 09:44:33 +08:00
Jun Pataleta
ea758b85e4 MDL-59369 enrol: Cleanup enrol pages 
* Cleanup edit enrolment form.
* Improve edit enrol form validation error message.
* Add modal custom data flag to edit enrolment form to hide action
  buttons if loaded via fragment.
* Point return URLs of edit enrolment and user unenrol pages back to
  participants page.
 2017-07-26 09:44:02 +08:00
Jun Pataleta
58c20c8108 MDL-59369 enrol: New ws core_enrol_external::edit_user_enrolment 2017-07-26 09:43:16 +08:00
David Monllao
58f86c4cc5 MDL-59174 enrollib: More flexibility for enrol_get_course_users 
Part of MDL-57791 epic.
 2017-07-24 08:36:46 +02:00
David Monllao
8970ff91bb MDL-59174 analytics: Analyser queries to enrollib 
Part of MDL-57791 epic.
 2017-07-24 08:36:46 +02:00
Mark Nielsen
197e2bca5b MDL-59602 behat: make use of new course nav steps 2017-07-21 13:50:47 -07:00
Damyon Wiese
dda64b6f45 MDL-59548 behat: Helpers for autocomplete 
Improve the helpers for autocomplete so that:
a) the set field for an auto complete will automatically close the suggestions list.
b) add a new helper to open the suggestions list
c) move the helper for clicking on an element in the suggestions list from tool_lp to core.
 2017-07-17 11:10:15 +08:00
Eloy Lafuente (stronk7)
28fcc33944 MDL-59437 behat: old "edit" cog to go to enrollments page is gone 
There use to be a little cot to easily navigate from the
participations page to the enrollments page.

In boost it was already hidden, but present and the test was still
working (non-javascript).

With the conversion, the functionality is 100% gone so, right now,
the only way to navigate from participats to enrollments (that will
dissappear with with unification), is using the course admin cog.
 2017-07-13 11:48:28 +08:00
Damyon Wiese
af6d23853a MDL-59365 enrol: Behat fixes 
Fixes for the new enrol users popup with behat.
 2017-07-13 10:55:01 +08:00
David Monllao
eac6f51590 Merge branch 'MDL-59368-master' of git://github.com/damyon/moodle 2017-07-12 16:46:49 +02:00
Damyon Wiese
2cc2001bef MDL-59365 enrol: Teachers can see other users on the site 
In order to enrol new users into a course, you need to see users who are not in the current course.
 2017-07-12 14:47:11 +08:00