Eloy Lafuente (stronk7)
3a5641cb74
MDL-67673 phpunit: Remove deprecated assertEquals() params
...
The optional parameters of assertEquals() and assertNotEquals()
are deprecated in PHPUnit 8 (to be removed in PHPUnit 9):
- delta => use assertEqualsWithDelta()
- canonicalize => use assertEqualsCanonicalizing()
- ignoreCase => use assertEqualsIgnoringCase
- maxDepth => removed without replacement.
More info @ https://github.com/sebastianbergmann/phpunit/issues/3341
Initial search done with:
ag 'assert(Not)?Equals\(.*,.*,' --php
Then, running tests and fixing remaining cases.
2020-10-21 12:46:00 +02:00
Eloy Lafuente (stronk7)
f6711bb394
MDL-67673 phpunit: Fix the return type of template methods
...
All the setup/teardown/pre/post/conditions template methods
now are required to return void. This was warned with phpunit 7
and now is enforced.
At the same time, fix a few wrong function names,
provider data and param types, return statements...
2020-10-21 12:45:59 +02:00
Eloy Lafuente (stronk7)
d584d34967
MDL-67886 phpunit: Make tests cross-db
...
The suggested SQL in some of the assertions was not cross-db
but db-dependent. Now we just keep that part out from the
assertions, because it's not important to verify the
errors that are being asserted.
2020-04-23 13:03:03 +02:00
Mark Nelson
47f3fa131a
MDL-67886 core: check_database_schema() checks for extra indexes
2020-04-23 00:45:43 +02:00
Mark Nelson
a8c38ce85b
MDL-67886 core: check_database_schema() checks for missing indexes
2020-04-22 23:22:18 +02:00
Shamim Rezaie
94e25092b2
MDL-58584 core_ddl: delete te loft over table in the test
2020-02-04 23:15:32 +11:00
Shamim Rezaie
934c2ee1b6
MDL-58584 core_ddl: getDropTableSQL should not do more than what it says
2020-02-03 15:07:15 +11:00
Brendan Heywood
97f63b4180
MDL-65311 core: Fixed regression caused by MDL-65130
2019-04-09 22:39:02 +10:00
Andrew Nicols
09d02b3914
MDL-65130 privacy: Fix memory hungry test
2019-03-21 09:52:24 +08:00
Tim Hunt
5abc431335
MDL-63020 ddl: fix nullable unique indexes in OCI and MS SQL
...
This works-around the default non-standard behaviour of these DB engines.
2018-09-20 17:41:22 +01:00
Tim Hunt
54b2b1d27f
MDL-63020 xmldb: Improve PHPdoc comments for better IDE autocomplete
2018-09-20 17:41:22 +01:00
Matteo Scaramuccia
211d04f43e
MDL-63319 ddl: Added getRenameFieldSQL() coverage
2018-09-14 22:41:18 +02:00
Matteo Scaramuccia
66c34d3578
MDL-63319 ddl: Improved rename_field() coverage
...
DB API should allow to rename fields, including renaming
those columns named using a reserved word.
2018-09-14 22:41:18 +02:00
Matteo Scaramuccia
12b6041aac
MDL-63319 ddl: MSSQL should rename reserved words
2018-09-14 22:31:39 +02:00
Matteo Scaramuccia
0fb34e9108
MDL-63319 ddl: MySQL should rename reserved words
2018-09-14 22:31:39 +02:00
Matteo Scaramuccia
1f8d943461
MDL-59596 ddl: Support MariaDB 10.2.4+ SQL_MODE new default value.
2018-03-26 23:12:36 +02:00
Jake Dallimore
fa2a9cc933
MDL-23887 database: fix use of deprecated system tables for mssql
...
Catalog views are available which we should use instead.
2018-01-02 17:19:17 +08:00
David Mudrák
7cdb4266e0
MDL-32113 xmldb: Fix and extend unit tests for XMLDB_TYPE_NUMBER
...
These tests describe the new behaviour of the XMLDB_TYPE_NUMBER fields.
2017-12-21 19:48:04 +01:00
David Mudrák
457eaef9ec
MDL-32113 xmldb: Remove hard-coded exceptions for long number fields
...
We are going to unify the maximum supported precision of all numeric
fields to 38 digits (which are the current Oracle and MSSQL limits). Get
rid of hard-coded exceptions for longer fields.
2017-12-21 15:37:08 +01:00
Matteo Scaramuccia
e8be9e7646
MDL-60793 core_ddl: Added the new MySQL 8 reserved words
2017-12-14 22:46:48 +01:00
Matteo Scaramuccia
596f4e6a23
MDL-59635 ddl: Added test_get_enc_quoted().
2017-09-04 11:46:54 +02:00
Dan Poltawski
23e1ce7d52
Merge branch 'wip-MDL-59476-master-2' of git://github.com/marinaglancy/moodle
2017-07-31 10:21:32 +01:00
Dan Poltawski
afa752eb12
Merge branch 'MDL-57698-master' of https://github.com/xow/moodle
2017-07-25 11:48:09 +01:00
Marina Glancy
c07c8c6e3e
MDL-59476 dml: temporary mysql tables should not use compressed rows
2017-07-25 13:49:53 +08:00
John Okely
469ffa6893
MDL-57698 mssql: Update reserve word list for generator
2017-07-21 14:41:55 +08:00
Adrian Greeve
3a8c989137
MDL-59561 database: Update to creating new indexes in mysql.
...
When updating the mysql system to utf8mb4 not all tables are
converted to the row format of compressed or dynamic. If a new
index is created there is a possibility that the table could be
using compact or redundant and then an error will be shown saying
that the index size is too large. This fix handles this exception
and converts the table over to compressed.
2017-07-21 09:27:08 +08:00
Eric Merrill
cd729dc905
MDL-58593 database: More efficiently track issued key names
2017-04-13 12:21:13 -04:00
Adrian Greeve
8c1288dbdb
MDL-48228 database: Unit test addition and update.
2017-03-01 09:03:12 +08:00
Adrian Greeve
0bbefd81cd
MDL-48228 database: Make utf8mb4 the default character set for mysql.
...
Thanks to Jetha Chan for providing the initial patch that this is
based on.
2017-03-01 09:03:12 +08:00
Russell Smith
848d212e7a
MDL-53495 database xmldb: Ensure field tests use constant.
...
Some tests were still using hard coded values which break
if the constants are changed.
2016-07-06 14:45:00 +10:00
Russell Smith
0b768e744f
MDL-53495 database xmldb: Use real length restriction.
2016-06-08 11:06:16 +10:00
Simey Lameze
87a3e50192
MDL-51374 core_dml: change database layer to pass table name as parameter
2016-03-15 14:43:45 +08:00
Russell Smith
d22a01fd99
MDL-53213 caching: Faster databasemeta caching for all databases.
2016-02-28 17:03:14 +11:00
Mark Nelson
5e156fe8ce
MDL-49724 core_ddl: final deprecation of guess_antolope_row_size()
2016-01-06 10:38:22 +08:00
Simey Lameze
0148cd852e
MDL-49723 tool: deprecate guess_antolope_row_size method
2015-04-10 09:33:35 +08:00
Damyon Wiese
112632ed58
Merge branch 'wip_MDL-46235_m28_innodbtext' of https://github.com/skodak/moodle
2014-08-26 12:28:47 +08:00
Petr Skoda
a45d54b8cb
MDL-46235 ddl: add support for large number of text fields in one database table
2014-08-25 12:40:57 +12:00
Eloy Lafuente (stronk7)
52953ff948
MDL-46918 ddl: cover behavior with unit test
2014-08-21 18:33:23 +01:00
Tim Hunt
5dc266d980
MDL-46918 ddl: fix error when renaming table already exists
2014-08-21 18:33:22 +01:00
Rajesh Taneja
a9950b49c4
MDL-46327 phpunit: drop_table should be used, rather then drop_temp_table
2014-08-19 17:16:55 +08:00
Rajesh Taneja
c1dc3f4793
MDL-46327 phpunit: Fixed oracle fail
2014-08-19 10:11:20 +08:00
Petr Skoda
b86912431e
MDL-45945 mssql: force default database collation in all tables including temp table
2014-07-04 15:04:50 +12:00
Petr Skoda
4153a7483d
MDL-45985 ddl: improve check_database_schema method in database_manager
2014-06-17 16:53:36 +12:00
Petr Škoda
5d4c82560b
MDL-44191 hack around MySQL 5.6 inability to lower auto_increment
2014-03-14 11:31:43 +08:00
Petr Škoda
ab3fc898f4
MDL-43761 use single query in mysql when crating tables
2014-01-24 13:46:30 +08:00
Petr Skoda
3f17d7091b
MDL-43761 refactor db manager code to send arrays of SQL to the dml driver
2014-01-24 13:45:07 +08:00
Russell Smith
8343b340c4
MDL-39725 database: Include stats collections in unit tests
2013-12-10 20:32:56 +11:00
Dan Poltawski
d06d812c51
Merge branch 'wip-MDL-40883-master' of git://github.com/marinaglancy/moodle
2013-11-08 15:32:11 +08:00
Marina Glancy
a9d11e3cd0
MDL-40883 ddl: unittest for objects name length
2013-11-08 13:17:47 +11:00
Marina Glancy
dcde391b44
MDL-40883 ddl: make sure object name never exceeds max length
...
Many thanks to Ray Bon for finding the problem
2013-11-08 11:58:35 +11:00