30728 Commits

Author SHA1 Message Date
Sara Arjona
26aaa7486a Merge branch 'MDL-77012-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-04-12 14:09:33 +02:00
Petr Skoda
f336875b1a MDL-76859 h5p: Fix behat failures
- Only resize if the H5P EmbedCommunicator is defined (otherwise, it was causing a
JS error)
- An unnecessary image has been removed from the greeting-card.h5p fixture package.
That way, the text will always be displayed (even if the iframe is still not
resized). Instead of replacing the original greeting-card-887.h5p file, I've
renamed it to greeting-card.h5p, to remove these ugly and unnecessary numbers
at the end of the file name).
2023-04-12 12:27:06 +02:00
Sara Arjona
6381daf52a Merge branch 'MDL-76993-401' of https://github.com/aanabit/moodle into MOODLE_401_STABLE 2023-04-12 09:54:22 +02:00
Amaia Anabitarte
3a38791d62 MDL-76993 core_course: Recover move right/left functionality
This is a backport of MDL-76990
2023-04-11 13:28:00 +02:00
Sara Arjona
5563e99f2c Merge branch 'MDL-77837-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-04-11 12:12:49 +02:00
Stevani Andolo
b796cbd03c MDL-77829 core: Added environment check for mod_assignment
Decided to add an environment check before uninstalling the
mod_assignment plugin to prevent data lost.
2023-04-10 13:54:00 +08:00
Andrew Nicols
202718f968 MDL-77837 core: Improve usage docs for cron_setup_user 2023-04-06 23:21:29 +08:00
Andrew Nicols
44d734147a MDL-77837 phpunit: Ensure that the cron user setter is used
When running an adhoc task in a unit test we should use the cron variant
of the set user method to mimic the behaviour of a real cron run.
2023-04-06 23:21:29 +08:00
Andrew Nicols
346cb39cff MDL-77837 cron: Ensure user is set when running tasks
We should be proactive in ensuring that the environment is clean when
running a task. We already ensure that we have a clean renderer and
other parts of the output chain, but we were not setting a clean user.

This change adds a call to setup the cron user before each task is
actually executed.
2023-04-06 23:21:29 +08:00
Anupama Sarjoshi
8b31922739 MDL-77148 core: Fix to export params for templates in correct format
When questions are filtered by tags in the question bank, the qtagids
params are passed in the array format. Though moodle_url handles this,
single_button::export_for_template cannot. Hence changes done in
weblib.php to provide params for export_for_template in the
suitable format.
Thanks Huong. I have added the Behat test you provided in the patch.
2023-04-06 14:38:29 +01:00
Paul Holden
360f9e37f8
MDL-77012 editor_tiny: correct block formats property syntax.
Co-authored-by: Hiroto Kagotani <hiroto.kagotani@gmail.com>
2023-04-04 09:53:20 +01:00
Paul Holden
701541f35b
Merge branch 'MDL-77227-401' of https://github.com/aanabit/moodle into MOODLE_401_STABLE 2023-04-03 10:56:19 +01:00
Andrew Nicols
0f092b86b5 Merge branch 'MDL-77783-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-03-31 11:31:05 +08:00
Ilya Tregubov
74f3c34cbf Merge branch 'MDL-70976-401' of https://github.com/laurentdavid/moodle into MOODLE_401_STABLE 2023-03-31 09:41:45 +08:00
Sara Arjona
7b13a543ad Merge branch 'MDL-77761-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-03-30 17:53:20 +02:00
Paul Holden
93c91af6a9
Merge branch 'MDL-77773-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-03-30 10:41:20 +01:00
Amaia Anabitarte
bc4b6cf8f7 MDL-77227 roles: Remove extra information for override page 2023-03-29 18:20:23 +02:00
Ilya Tregubov
b85f6a660b Merge branch 'MDL-77740-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-03-29 10:58:47 +08:00
Jun Pataleta
c99abd65ca MDL-77783 core: Validate sublugins.json
* Validate the decoded subplugins.json before processing it.
* Log errors if subplugins.json is invalid or if plugintypes is not
defined.
2023-03-29 09:29:57 +08:00
Jun Pataleta
436ed2c4cb MDL-77761 core_form: Add label for editor format selector 2023-03-29 08:09:54 +08:00
Andrew Nicols
5df8e8fa5f MDL-77773 editor_tiny: Improve initial editor size 2023-03-28 20:48:05 +08:00
Jun Pataleta
95d5b0aab0 MDL-77105 core: Cast custom data to an array when evaluating filtericon
Since other modules may treat custom data as an object, we need to make
cast it to an array before evaluating for the `filtericon` custom data.
2023-03-28 18:49:27 +08:00
Meirza
110ec6a703 MDL-77436 auth_oauth2: Update profile fields based on data mapping.
After the user creation, the system must call an update function to update profile_fields_*.
We also provided two functions into user/profile/lib.php to get available from other areas.
We added PHP unit testing for new public functions and
the Behat tests for custom profile fields with locked and unlocked statuses.

Co-authored-by: Matt Porritt <matt.porritt@moodle.com>
2023-03-28 11:47:23 +07:00
Matt Porritt
714764d966 MDL-77436 auth_oauth2: Allow admin to choose profile fields for mapping
Update oauth2 to allow mapping of provider attributes against
user profile fields. Fields can also be locked to prevent
user changes.

Co-Authored-By: Michael Milette <michael.milette@tngconsulting.ca>
2023-03-28 11:46:51 +07:00
Jun Pataleta
bc1d7e854b MDL-77105 core: Add upgrade.txt notes 2023-03-27 14:00:58 +08:00
Jun Pataleta
30b0b0cf40 MDL-77105 core: Add a filtericon parameter to course mod icon URLs
* If a plugin defines a `filtericon` custom data or uses its monologo
version of the icon, a `filtericon` parameter is being added to the
icon's URL. This information can help plugins determine whether to
render the activity icon as is or with CSS filtering.
2023-03-27 13:36:42 +08:00
Jun Pataleta
69948eda10 MDL-77105 core: Method to determine whether a plugin has monolog icons 2023-03-27 13:36:38 +08:00
Andrew Nicols
50d1671a54 MDL-77740 editor_tiny: Set the Editor window from the iFrame element
This is a workaround for an upstream bug which I have not been able to
reproduce outside of Moodle whereby the editor.contentWindow does not
math the editor.iframeElement.contentWindow when it should.

This issue only seems to affect Firefox, and it may even be a bug in
Firefox. It can only be reproduced when using a fresh browser which has
never had a TinyMCE window open.
2023-03-24 21:34:21 +08:00
Jun Pataleta
d2bc54fba9 Merge branch 'MDL-77669-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-03-24 11:51:36 +08:00
Meirza
29a1cf86a3 MDL-77669 dml: Added extrainfo in the DB options config.
extrainfo is an extra information for the DB driver, e.g. SQL Server,
has additional configuration according to its environment,
which the administrator can specify to alter and override any connection options.

Co-authored-by: LukeCarrier <luke@carrier.im>

This is a backport of MDL-64153.
2023-03-21 08:48:39 +08:00
Paul Holden
deced83b06
Merge branch 'MDL-72124_401_STABLE' of https://github.com/marxjohnson/moodle into MOODLE_401_STABLE 2023-03-20 17:04:54 +00:00
Mark Johnson
34c452afb4 MDL-72124 question: Fix system-level URLs in question events 2023-03-14 15:40:26 +00:00
Laurent David
8ee689f612 MDL-70976 core_files: Allow for draft files url inserted in content
* The file file_remove_editor_orphaned_files should take into account URL that
have been embedded in a tag content instead of an attribute (like src attribute)
* This will fix issue with inserting H5P content in calendar events.
2023-03-14 08:48:32 +01:00
Petr Skoda
7e96a1c887 MDL-76680 core: disable $USER->ignoresesskey on next page 2023-03-11 10:37:24 +01:00
Jake Dallimore
b9dedcd53e Merge branch 'MDL-77517-401' of https://github.com/juancs/moodle into MOODLE_401_STABLE 2023-03-10 11:39:52 +08:00
Andrew Nicols
3c1c543c53 Merge branch 'MDL-77037-401' of https://github.com/laurentdavid/moodle into MOODLE_401_STABLE 2023-03-09 21:59:37 +08:00
Sara Arjona
ab34f215a9 Merge branch 'MDL-76940-401' of https://github.com/laurentdavid/moodle into MOODLE_401_STABLE 2023-03-09 10:54:50 +01:00
Jun Pataleta
bb61d8392b Merge branch 'MDL-77559-401-2' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-03-09 15:57:44 +08:00
Laurent David
bdd1708455 MDL-77037 core_courseformat: Refresh course index
* Refresh course index when language change
2023-03-09 08:44:22 +01:00
Andrew Nicols
155f08fc68 Merge branch 'MDL-77420-401' of https://github.com/ferranrecio/moodle into MOODLE_401_STABLE 2023-03-09 11:58:41 +08:00
Andrew Nicols
3a363d0eec Merge branch 'MOODLE_401_STABLE' of https://github.com/fcbsd/moodle into MOODLE_401_STABLE 2023-03-09 10:29:43 +08:00
Andrew Nicols
cd48ae56c7 MDL-77559 js: Rebuild all JS with Node 16 2023-03-09 09:53:19 +08:00
Laurent David
ed08a4ee52 MDL-76940 core_courseformat: Index refreshing when role switch
* Hidden sections and content should not visible to students when switching role
2023-03-08 11:51:51 +01:00
Andrew Nicols
b9f8373e3f MDL-77470 editor_tiny: Apply upstream security fixes
- CVE-2022-23494
2023-03-08 01:00:30 +00:00
Lars Bonczek
d5ec540381 MDL-75659 core: Don't render component argument twice in mustache pix helper 2023-03-08 01:00:30 +00:00
Jun Pataleta
3c00ca0bb2 Merge branch 'MDL-77416-401-enfix' of https://github.com/vmdef/moodle into MOODLE_401_STABLE 2023-03-08 08:50:24 +08:00
Juan Segarra Montesinos
f9ec44d858 MDL-77517 js: Disable "Edit mode" button when clicked
When clicked, disable the "Edit mode" button just before doing a
redirection. It's been reported that after clicling several times the
button, an inconsistent state between the button and the editing mode is
achieved. The patch mitigates the issue.
2023-03-05 07:09:24 +01:00
Víctor Déniz
98f10149d6 MDL-77416 lang: Use fixed strings in tests 2023-03-03 13:27:01 +00:00
Helen Foster
192bad5ba2 MDL-77416 lang: Import fixed English strings (en_fix) 2023-03-03 13:25:53 +00:00
Tim Hunt
633ad42d6e MDL-77462 core_question: avoid passing null to preg_match 2023-03-03 08:48:09 +00:00