6167 Commits

Author SHA1 Message Date
Marina Glancy
064eccd4fc MDL-75525 reportbuilder: specify initial sorting for datasources 2022-11-07 15:43:45 +01:00
Eloy Lafuente (stronk7)
d590b08dfa MDL-75880 phpunit: fix all @coversDefaultClass missing @covers
Because @coversDefaultClass doesn't indicate any coverage (it's
just an alias to avoid having to write the class name in @covers),
this commit fixes all the files that were using that annotation
and missing any @covers.

Basically, replacing one by the other and done.
2022-11-04 16:51:20 +01:00
Sara Arjona
7d53813db7 Merge branch 'MDL-75349' of https://github.com/paulholden/moodle 2022-11-04 12:06:36 +03:00
Sara Arjona
e9596c1fca Merge branch 'MDL-75759-master' of https://github.com/junpataleta/moodle 2022-11-04 11:01:41 +08:00
Jun Pataleta
a343faaa7d MDL-75759 courseformat: Link classes in PHPDocs with @see tags
- Linking classes/methods mentioned in PHPDoc with @see tags help devs
checking the PHPDoc to quickly navigate to the class/method mentioned
and also helps us ensure that it points to the correct class/method.
- Some typo/grammar fixes as well in existing PHPDoc descriptions.
- Fixed parameter type in execute()'s PHPDoc block.
2022-11-03 11:57:25 +08:00
Simey Lameze
e43fef8fc9 MDL-75759 courseformat: fix documentation of stateupdates tests 2022-11-03 11:37:10 +08:00
Jun Pataleta
dbf67c06bb MDL-75759 courseformat: Fix stateactions test
* Require lib/externallib.php in
\core_courseformat\output\local\state\cm::export_for_template()
* Point @coversDefaultClass to the proper class.
2022-11-03 11:35:42 +08:00
Jun Pataleta
5e84f00acb Merge branch 'MDL-73141-master' of https://github.com/dravek/moodle 2022-11-01 09:25:34 +08:00
Sara Arjona
aaca32f7e1 Merge branch 'MDL-75771-master' of https://github.com/PhMemmel/moodle 2022-10-31 13:39:43 +01:00
Jun Pataleta
9bdfcc46d3 Merge branch 'MDL-75358-master' of https://github.com/marinaglancy/moodle 2022-10-31 10:10:16 +08:00
David Matamoros
b0802f49a6 MDL-73141 core_cohort: Convert cohort listing to Report Builder 2022-10-29 12:45:50 +02:00
Víctor Déniz
04d8fc6070 Merge branch 'MDL-68437-master' of https://github.com/mihailges/moodle 2022-10-28 17:44:50 +01:00
Philipp Memmel
b4c292166a MDL-75771 core_courseformat: Add behat test for show_editor function 2022-10-28 17:24:37 +02:00
Philipp Memmel
4294acc5ab MDL-75771 core_courseformat: Fix capability for edit controls
course_format\base:show_editor now by default uses 'moodle/course:manageactivities', but also accepts other capabilities as param
2022-10-28 17:24:37 +02:00
Sara Arjona
8c12bc9ba7 Merge branch 'MDL-76023' of https://github.com/paulholden/moodle 2022-10-27 17:03:51 +02:00
Jake Dallimore
5a9a6dd090 Merge branch 'MDL-75868-master' of https://github.com/ferranrecio/moodle 2022-10-27 16:41:08 +08:00
Víctor Déniz
f531f46d9e Merge branch 'MDL-75074-master' of https://github.com/sammarshallou/moodle 2022-10-24 16:43:08 +01:00
Víctor Déniz
c209719811 Merge branch 'MDL-67020_master' of https://github.com/marxjohnson/moodle 2022-10-21 09:07:58 +03:00
Paul Holden
6c9b4d1e24 MDL-75349 course: include groups entity data in participants report. 2022-10-20 12:33:17 +01:00
Paul Holden
06f013eec6 MDL-76023 course: fix access to custom data in notification task.
The message class `customdata` property is automatically JSON encoded
via magic setter method, so we can't append to it directly.
2022-10-19 18:49:04 +01:00
Ilya Tregubov
3f568024a1 MDL-76033 core: bump version in is_major_upgrade_required
MDL-58266 changes db structure. So upgrade must happen before
accessing any page.
2022-10-19 15:08:44 +03:00
Mark Johnson
9e7d9a0e9b MDL-67020 Cache: Prevent unnecessary coursemodinfo rebuild 2022-10-19 09:04:30 +01:00
Ilya Tregubov
057f732bf1 Merge branch 'MDL-58266-master' of https://github.com/JBThong/moodle 2022-10-17 12:51:59 +03:00
hieuvu
c6e018e04e MDL-58266 core_completion: Add new view table. 2022-10-14 00:30:28 +07:00
Jun Pataleta
80b20781f0 Merge branch 'MDL-74887-master' of https://github.com/sh-csg/moodle 2022-10-14 00:28:27 +08:00
Jun Pataleta
36e4ca71c6 Merge branch 'MDL-75034' of https://github.com/paulholden/moodle 2022-10-12 14:24:35 +08:00
Marina Glancy
41b93bd7e5 MDL-73424 general: Internal methods must have same type as parent
Otherwise the error is thrown in PHP8.1
2022-10-10 16:46:13 +02:00
Stefan Hanauska
c4523503d2 MDL-74887 course: Hide stealth mode without view page 2022-10-08 08:09:40 +02:00
Paul Holden
b3828cebd2 MDL-75034 reportbuilder: move classes into consistent namespace.
Use `reportbuilder` level two namespace for report related classes
(entities, system reports, etc) within components and sub-systems.
2022-10-07 15:05:34 +01:00
sam marshall
f696590f0a MDL-75074 core_courseformat: Output classes are not inherited
If you have one course format that extends another one, any course
format output classes that are not defined in the child format will
now inherit from the parent (instead of from the base class as
before).
2022-10-03 11:22:35 +01:00
Ferran Recio
a941eb3314 MDL-75868 core_courseformat: optional section badges
The current implementation conditions the highlight and hidden form
student badges to the present of the badges in the HTML. This way if a
format does not include those badges the code will continue working.
2022-10-03 12:17:45 +02:00
Andrew Nicols
d41a859d5a Merge branch 'MDL-75836' of https://github.com/jrchamp/moodle 2022-09-30 20:41:51 +08:00
Mihail Geshoski
383e1893b2 MDL-68437 course: ws support to optionally fetch only active users
Modifies the 'core_course_get_enrolled_users_by_cmid' webservice and
the generic js methods that call this webservice and enables defining
whether the ws should only return the active users or all enrolled
users in the course.
2022-09-30 02:23:18 +08:00
Jonathan Champ
cc9863576e MDL-75836 activities: preserve moodleform validation errors 2022-09-26 19:26:38 -04:00
Eloy Lafuente (stronk7)
0ed53be9b2 MDL-66902 tests: Fix all incorrect namespaces
This issue just goes over all the currently incorrect
namespaces in test cases and:

1. Change the namespace to the correct one.
2. Move/rename it to correct location if needed (level 2 and down).
3. Remove not needed MOODLE_INTERNAL check when possible.
4. Remove file phpdoc when the file only has one class.
5. Make small adjustments in case the change of namespace requires it.
2022-09-26 14:12:16 +02:00
Marina Glancy
dcc44ae4c0 MDL-75358 reportbuilder: display nulls as empty cells for numeric/bool 2022-09-20 18:18:38 +02:00
Jun Pataleta
4f8106e6cb Merge branch 'MDL-73933-master' of https://github.com/ferranrecio/moodle 2022-09-16 10:49:23 +08:00
Ferran Recio
8777705827 MDL-73933 core_courseformat: hide and show reactive action
Hide, show and stealth actions were still using the old YUI
module. Now they are using the new course editor
2022-09-15 16:39:29 +02:00
Jun Pataleta
95e2214283 Merge branch 'MDL-75398-master' of https://github.com/junpataleta/moodle 2022-09-15 11:34:56 +08:00
Ferran Recio
f69b48865a MDL-75398 core_courseformat: deprecate 4th cmname construct param 2022-09-15 11:28:55 +08:00
Jun Pataleta
46849455be Merge branch 'MDL-75714' of https://github.com/stronk7/moodle 2022-09-15 09:24:50 +08:00
Eloy Lafuente (stronk7)
d1bf45ec18 MDL-75714 navigation: Cover a couple of situations with behat
- Guest user attempting to access to single-activity course.
- Not enrolled user attempt to access to single-activity course.

Both should, by default, land to the "cannot access/enrol" page.
2022-09-14 23:35:19 +02:00
Víctor Déniz
63f31ccc7b Merge branch 'MDL-75625-master' of https://github.com/ferranrecio/moodle 2022-09-14 20:00:06 +01:00
Paul Holden
b40d438fbf MDL-75708 reportbuilder: consider stress tests as requiring longtest.
We should respect the value of the PHPUNIT_LONGTEST constant in the
report source stress tests, as it was discovered after 165e26fa that
the default configuration of some CIs (GHA) was not sufficient to run
them.

Hence, use the PHPUNIT_LONGTEST to determine whether to execute said
tests. Note this constant is enabled on internal CI.
2022-09-09 11:11:39 +01:00
Ilya Tregubov
7bf964c94e Merge branch 'MDL-75555-master' of https://github.com/justusdieckmann/moodle 2022-09-07 16:36:58 +04:00
Paul Holden
208adcf3d1 MDL-73938 reportbuilder: better Oracle support of long text columns.
Specifically during column grouping/aggregation, we need to avoid CLOB
datatype inconsistencies (ORA-00932).
2022-09-05 12:08:54 +01:00
Paul Holden
165e26fad9 MDL-73938 reportbuilder: helper methods for automating report tests.
Implement stress tester methods for iterating over report columns,
aggregation and conditions. Assert that each works correctly in
isolation, and when used in conjunction with other columns.
2022-09-05 12:07:17 +01:00
Ferran Recio
188d304a4b MDL-75625 core_courseformat: fix MDL-71979 comments 2022-09-01 12:41:55 +02:00
Jun Pataleta
83a7fde2c0 Merge branch 'MDL-75019-master' of https://github.com/andelacruz/moodle 2022-08-31 20:25:37 +08:00
Justus Dieckmann
b3e97db59c MDL-75555 core_courseformat: Remove duplicate section collapse requests
Previously, by simulating a click, the section toggle listener
was invoked again. Instead, it now uses the bootstrap collapse
function directly.
2022-08-25 23:20:06 +02:00