"cute" code (courseid > 1, both checking for non-zero and non-courseid value)
can lead to mistakes later. And it's my own code, even...
Also removed one obsolete function.
Calendar events in day view now show their start and end times. The only thing
I 'm not satisfied with is that they also show the full start and end dates,
even if it's not really needed (e.g. for a 15:00 -> 17:00 event). Still, it's
loads better than only showing the start time.
Events that span more than one month now have their duration shown correctly in
each day of all subsequent months. For some reason I didn't quite figure out,
this happened till now only on events that spanned at least THREE months. Whatever...
Also, removed a small unused part of a global statement in view.php.
is correct only for GMT+0 timezones. Fixed it in upcoming events displays to
separate days as they are in the user's timezone, will continue to pursue this.
Things are now easier for visitors and guests. We should do some regression
testing though: if you are a visitor or a guest and then you login (either
after browsing the site or immediately by typing a Moodle URL in the location
bar, without having a Moodle session at all), do user events always get shown
correctly? Does anything abnormal happen to the courses filter?
Now when moving to a calendar screen (technically, view.php) from a course
block, the course drop down list defaults to that course. The implementation
is OK, but I may change it (there is a faster way).
- events are now shown in a consistent way
- upcoming events and days are calculated with the same function
- it's now not possible to edit module events directly
- various tidying up
* Changed the expired events' color to dimmed
* Added "new event" button in upcoming events screen
* Small improvement (more robust) in redirection from set.php to upcoming events
Fixed wrong redirection after changing filters for all calendar screens
Fixed course selection menu to work without javascript
Moved course selection menu to the header, and added it to all screens
All screens now conform to the selected course in the menu
Small improvements in the way guests are handled
1. Much better and more intuitive handling of filters.
2. Simplified user interface for guests.
3. Feature request implemented: bug #1431
4. A number of significant bugfixes
Now the module icon is shown before the event name in the mini-month tooltips.
Maybe this would be better with the module name instead, but I don't know.
Comment in the bugtracker if this isn't what we want.
When the admin is logged in as a different user, user events are shown
correctly in the calendar.
Also, fixed a very-recently-introduced bug which appears to have escaped
notice so far.
courses other than the one you are browsing are not displayed in the month
views or as upcoming events, except only if you explicitly do it in the
full month view. However, if you manually go to a day with such an event and
get a day view, you will see the event. Should I find a way to hide that too?
(REAL fix this time! ;-)
Thanks for the report, Eloy. I now know what I was doing wrong. Because on my
dev site I have the same TZ as the server, sometimes I can make mistakes and
"get away with them". :-/
Now if you are a teacher in a course, you now see ALL group events in that course.
As a result, admins see group events for all courses.
Maybe it needs more work than this, though.