99 Commits

Author SHA1 Message Date
tjhunt
a4514d91de Renamed new commentary feature to 'general feedback'. 2006-09-19 13:35:42 +00:00
tjhunt
cd06115fa7 Convert mod/quiz/view.php to roles, and further tidy up the code flow in there. This touches other files because I had to change a function in locallib that had an $isteacher parameter.
I have not converted the rest of the quiz, and I don't intend to. I am hoping Moodle.com will do it.

I hope this does not introduce any bugs, but view.php is so complicate (at least it is less complicated than it was) and the quiz has so many options, that it is hard to be sure. This needs lots of testing before 1.7 is released.
2006-08-25 16:03:54 +00:00
tjhunt
212b7b8cd9 MDL-5270 - give students a feeback comment for their performance in the entire quiz.
Also, along the way I noticed and fixed MDL-6290 student grades not rescaled when quiz maximum grade changed.
2006-08-22 17:31:26 +00:00
tjhunt
1b8a7434e2 Bug 6239 - Allow questions to have some teacher-supplied commentary.
While implementing this, I removed the ~100 lines of very similar code from the top of each question type's editquestion.html template, and moved this to a the function print_question_form_start() in the base class, which uses the template question/type/editquestionstart.html. This is described in more detail here: http://moodle.org/mod/forum/discuss.php?d=51590, and is why this patch makes the codebase 523 lines smaller.
2006-08-11 14:59:18 +00:00
thepurpleblob
f6beb499b6 Now includes question/editlib.php
NOTE: This might well be the wrong thing to do and need
backed out, but until I hear otherwise it gets quiz working again!!
2006-05-03 12:27:06 +00:00
mjollnir_
eb55a1bfb9 Avoiding warning in last commit:
mod/quiz/index changes to only display quiz grades when teacher allows
Changes to index.php to only allow student to view overall quiz scores when
teacher has not set options forbidding this, and it can't give away what
scores were for attempts where results should still be hidden.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-18 22:57:28 +00:00
mjollnir_
40377b188b mod/quiz/index changes to only display quiz grades when teacher allows
Changes to index.php to only allow student to view overall quiz scores when
teacher has not set options forbidding this, and it can't give away what
scores were for attempts where results should still be hidden.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-18 22:55:28 +00:00
mjollnir_
d78a1cf6d8 mod/quiz/locallib bugfix get_qn_options now uses more sensible defaults.
Previously get_question_options used options for
after-attempt-while-quiz-open, when called while a attempt was still in
progress.  Changed it to use options for immediately-after-attempt instead.
Credit: Peter Bulmer peterbulmer@catalyst.net.nz
2006-04-18 22:54:51 +00:00
gustav_delius
b6e907a245 Manual grading 2006-04-07 16:00:29 +00:00
moodler
ba76a8f5cf Fixing some Javascript errors on IE 2006-04-05 02:40:34 +00:00
gustav_delius
4dca7e51ca Some minor improvements in the handling of review options, the setting of timestamp, and improvements to the documentation 2006-03-22 17:22:36 +00:00
gustav_delius
f67172b64b Moved code to delete questions and question categories to lib/questionlib.php
Also fixed bug 4949
2006-03-21 09:06:34 +00:00
gustav_delius
dc1f00de19 Some little fixes and more renaming to cleanly separate question code from quiz code
Renaming tables:
quiz_answers -> question_answers
quiz_categories -> question_categories

Renaming functions:
quiz_get_category_menu -> question_category_menu
quiz_get_category_coursename -> question_category_coursename
quiz_categorylist -> question_categorylist
2006-03-01 07:03:57 +00:00
gustav_delius
4f48fb42af Towards removing reference to quiz module from the question code
Renaming tables:
quiz_questions -> question
quiz_states -> question_states

Renaming functions:
quiz_delete_question -> delete_question
quiz_get_question_options -> get_question_options
quiz_get_states -> get_question_states
quiz_restore_state -> restore_question_state
quiz_save_question_session -> save_question_session
quiz_state_is_graded -> question_state_is_graded
quiz_extract_responses -> question_extract_responses
quiz_regrade_question_in_attempt -> regrade_question_in_attempt
quiz_process_responses -> question_process_responses
quiz_isgradingevent -> question_isgradingevent($event)
quiz_search_for_duplicate_responses -> question_search_for_duplicate_responses
quiz_apply_penalty_and_timelimit -> question_apply_penalty_and_timelimit
quiz_print_question_icon -> print_question_icon
quiz_get_image -> get_question_image
quiz_make_name_prefix -> question_make_name_prefix
quiz_get_id_from_name_prefix -> question_get_id_from_name_prefix
quiz_new_attempt_uniqueid -> question_new_attempt_uniqueid
quiz_get_renderoptions -> question_get_renderoptions
quiz_print_quiz_question -> print_question
quiz_get_question_responses -> get_question_responses
quiz_get_question_actual_response -> get_question_actual_response
quiz_get_question_fraction_grade -> get_question_fraction_grade
quiz_get_default_category -> get_default_question_category


Renaming constants:
QUIZ_EVENT.... -> QUESTION_EVENT....
QUIZ_MAX_NUMBER_ANSWERS -> QUESTION_NUMANS
2006-02-28 09:26:00 +00:00
thepurpleblob
7ac1e095b8 Moving export default filename function. 2006-02-24 18:49:01 +00:00
thepurpleblob
71d0be31d6 Removed import export functions 2006-02-24 15:46:59 +00:00
gustav_delius
4b32fd66ab Moved function quiz_question_used from mod/quiz/locallib.php to question_used in lib/questionlib. Fixed some more links. 2006-02-24 12:53:47 +00:00
gustav_delius
80a5e194ff Updated quiz scripts to work with the separate question scripts in moodle/question 2006-02-24 10:43:06 +00:00
gustav_delius
f0b2c1cc2b Applied fixes from bug 4319. Thanks to Jaroslav 2006-02-15 08:59:32 +00:00
gustav_delius
03d1753c1c Renamed table quiz_newest_states to question_sessions 2006-02-15 08:38:41 +00:00
gustav_delius
721b5b28c9 Stopped using the language strings for the assignment module because that was requested in bug 4558. 2006-02-12 21:23:54 +00:00
gustav_delius
8779eab55d Avoid error messages in case $quiz->sumgrades is zero, closing bug 4454. Merged from STABLE 2006-02-12 21:08:43 +00:00
gustav_delius
49347eacc5 Fix for question numbering provided by razzor, bug 3807 2005-07-25 14:19:21 +00:00
gustav_delius
6afbc42c4e Merged from STABLE 2005-07-23 09:31:07 +00:00
gustav_delius
9bc2d82a46 Merging from STABLE 2005-07-07 18:34:12 +00:00
gustav_delius
bb52d44c6a Due date and start date are now optional, as requested in bug 867 and bug 3635 2005-07-07 17:16:56 +00:00
gustav_delius
a08e9552fa More steps towards the separation of questions from the quiz module. 2005-07-03 09:53:02 +00:00
gustav_delius
d115d8c736 I have introduced the new field $attempt->uniqueid, see http://mantis.york.ac.uk/moodle/mod/forum/discuss.php?d=852#3380 2005-07-02 18:14:51 +00:00
gustav_delius
ad7e7ba882 Two name changes:
1) in all module-indpendent code the variable $quiz has been renamed to $cmoptions (it holds the options set by the course module which does not necessarily have to be a quiz, it could be a lesson for example).
2) quiz_restore_question_sessions() has the simpler name quiz_get_states
Also got rid of the quizfile.php in favour of file.php
2005-07-02 16:07:05 +00:00
gustav_delius
0d156caaae I have started on the re-organisation to allow other modules to use the questiontypes.
Moved all code that is not specific to the quiz module out of locallib.php into questionlib.php.
The default questiontype class is now defined in quiz/questiontypes/questiontype.php.
See http://mantis.york.ac.uk/moodle/mod/forum/discuss.php?d=852
2005-07-02 11:42:42 +00:00
gustav_delius
ed460c8e04 I am committing the essay question type contributed by Mark Nielsen, see http://moodle.org/mod/forum/discuss.php?d=25845. 2005-06-26 16:21:11 +00:00
gustav_delius
39395fd60b merged from stable 2005-06-12 09:57:13 +00:00
gustav_delius
fc44ee0de8 Merged from stable 2005-06-05 20:51:15 +00:00
gustav_delius
7bbe08a267 Merged from stable 2005-06-04 09:58:35 +00:00
stronk7
3686d611d9 Simplify the quizzes_category_used() function.
I was using the $excluded parameter to avoid
loops between categories. A->B->A. Think we can
assume such loops won't exist, so I've deleted
the $excluded use.

Merged from MOODLE_15_STABLE
2005-05-31 16:33:18 +00:00
thepurpleblob
55631ee73a Merged from STABLE 2005-05-31 13:35:15 +00:00
thepurpleblob
8cedc8a7f5 Merged changes from STABLE 2005-05-31 10:12:13 +00:00
stronk7
ca653ec706 Added the sort_categories_by_tree() function that
returns an ordered array of categories following
the parent-child relationships. It doesn't forget
any category and returns all the categories passed
although their parent were incorrect. Try to build
as much tree structure as possible.

Merged from MOODLE_15_STABLE
2005-05-30 23:59:42 +00:00
stronk7
b5b6aa75a1 Now the quizzes_category_used() function supports searching
for uses recursively plus an array of excluded categories.

Needed to solve bug 2459...in progress.

Merged from MOODLE_15_STABLE
2005-05-30 22:29:47 +00:00
stronk7
0ca4fa367c Added the quizzes_category_used() to detect the list of
quizzes that are using questions from one category.

It relies in the quizzes_question_used() function. Will
be use in the 'orphan_categories' bug (#2459)

(http://moodle.org/bugs/bug.php?op=show&bugid=2459)

Merged from MOODLE_15_STABLE

With some previously unmerged changes added too!! Please check them
Gustav!!
2005-05-29 19:02:51 +00:00
gustav_delius
a472ce5960 New version of item analysis from Enrique 2005-05-23 07:25:33 +00:00
mindforge
920fb237c4 In locallib the function quiz_restore_question_sessions did not load the timestamp field for states. This was fixed by replacing the list of fields in the query by a s.* 2005-05-20 11:44:59 +00:00
gustav_delius
67f74fec53 Some code cleanup: the function extract_response() is not used any more 2005-05-18 19:59:12 +00:00
gustav_delius
278553ffdc Avoid break between answer and feedback in multiple choice question 2005-05-18 03:00:55 +00:00
stronk7
87dddc1445 Replaced some (not all) tabs to spaces.
I've leave unmodified formats and nusoap library
2005-05-16 22:51:16 +00:00
gustav_delius
1f48479ebf quiz_upgrade_states() now creates entries in the quiz_newest_states table only for states that are associated to those questions that are listed in $attempt->layout. 2005-05-16 19:21:34 +00:00
gustav_delius
1b6fe5003a Removed some notices, some polishing.
No need to load all users and then remove teachers, can simply load all students.
2005-05-15 19:37:37 +00:00
gustav_delius
af4ed42f9f fixed bug 3258 2005-05-15 16:06:17 +00:00
gustav_delius
0fc5939983 item analysis report contributed by Enrique Castro 2005-05-15 14:40:38 +00:00
gustav_delius
488cf46b65 Cleaned up issues to do with timing. So for example late submissions are now detected correctly. 2005-05-15 11:45:12 +00:00