26902 Commits

Author SHA1 Message Date
Simey Lameze
a020b02078 MDL-67914 core_table: unit tests for table view fetch webservice 2020-04-01 15:13:35 +08:00
Simey Lameze
1592c3c498 MDL-67914 core_table: implement dynamic table sorting 2020-04-01 15:13:31 +08:00
Eloy Lafuente (stronk7)
70598a90ca Merge branch 'MDL-68183-master-mysqlpwdresetsql' of git://github.com/mudrd8mz/moodle 2020-03-26 01:08:04 +01:00
Eloy Lafuente (stronk7)
fee4dd7b20 Merge branch 'MDL-68116-master' of git://github.com/sarjona/moodle 2020-03-26 00:13:52 +01:00
Jun Pataleta
e17046d2c6 Merge branch 'MDL-67024-master' of git://github.com/farhan6318/moodle 2020-03-25 08:34:41 +08:00
Jake Dallimore
9b8fc9be6d Merge branch 'MDL-67934' of https://github.com/timhunt/moodle 2020-03-25 08:28:27 +08:00
Jake Dallimore
82a1e8da34 Merge branch 'MDL-68135-master' of git://github.com/rezaies/moodle 2020-03-24 12:10:33 +08:00
Sara Arjona
fb56f5190c MDL-68116 atto_h5p: deprecate unused strings 2020-03-20 10:07:34 +01:00
Sara Arjona
186a0361a3 MDL-68116 atto_h5p: simplify fields to add H5P content
The embed section has been removed in order to simplify this screen.
It was added to make easier include content coming from h5p.org but,
as soon users won't be able to use it, it makes no sense.
Users will still be able to use the "HTML" button to paste the
embed code.
2020-03-20 10:07:34 +01:00
Farhan Karmali
caf5ebb582 MDL-67024 Lib: Check if user->mnethostid is set before using it 2020-03-20 11:59:04 +05:30
Peter Dias
dacdc4a467 MDL-60817 file: Populate header only if exists 2020-03-19 15:29:36 +00:00
Adrian Greeve
aab8d9a1c0 Merge branch 'MDL-68081-master' of https://github.com/kritisingh1/moodle 2020-03-19 11:26:25 +08:00
Adrian Greeve
9b57e08e8b Merge branch 'MDL-67924' of https://github.com/Chocolate-lightning/moodle 2020-03-19 09:41:30 +08:00
Jun Pataleta
b703435b2e Merge branch 'MDL-68108-master' of git://github.com/crazyserver/moodle 2020-03-18 23:01:08 +08:00
Víctor Déniz Falcón
fa3ee722b5 Merge branch 'MDL-60817-master-4' of git://github.com/mihailges/moodle 2020-03-18 14:26:30 +00:00
Pau Ferrer Ocaña
e6faed9bf0 MDL-68108 formslib: Add element password inline template 2020-03-18 08:45:04 +01:00
David Mudrák
2d60593892 MDL-68183 auth: Fix the performance of get_complete_user_data search
When searching for the user by a case-insensitive field (email address
is the only one supported now), the performance may be very poor as the
DB cannot use the index due to the LOWER() operation and the full
sequential scan of all the user records is performed. On some DBs such
as MySQL, this can be significantly improved by pre-filtering the users
with accent-insensitive search.

So we first perform accent-insensitive search for potential candidates
in a subselect, which can use the index. Only then we perform the
additional accent-sensitive search on this limited set or records.
2020-03-17 14:52:32 +01:00
David Mudrák
3621b497d2 MDL-68183 auth: Fix the performance of signup_validate_data search query
When searching for other users with the same email address, we perform
the case-insensitive and accent-sensitive search. That may be expensive
as some DBs such as MySQL cannot use the index in that case. Instead,
sequential scan of all the user records is performed and the comparison
uses the LOWER function to filter the matching records. This leads to
significant performance heavy queries which in turn represent a surface
for DoS attacks.

For that reason, we first perform accent-insensitive search for
potential candidates in a subselect, which can use the index. Only then
we perform the additional accent-sensitive search on this limited set or
records.
2020-03-17 14:52:32 +01:00
Sara Arjona
9d95fdf23f Merge branch 'MDL-67707-master' of git://github.com/ferranrecio/moodle 2020-03-17 09:03:12 +01:00
Adrian Greeve
cc00258669 Merge branch 'MDL-67970-master' of git://github.com/rezaies/moodle 2020-03-17 15:23:49 +08:00
Shamim Rezaie
f064e11579 MDL-67970 course: More informative aria-label for 'more help' 2020-03-17 18:19:20 +11:00
Shamim Rezaie
604df144d2 MDL-67970 output: use fieldset in core/chooser instead of label 2020-03-17 18:16:25 +11:00
Shamim Rezaie
0499a8c24f MDL-67970 core: remove unnecessary roles
- The navigation role is unnecessary for element nav
- The textbox role is unnecessary for element textarea
2020-03-17 18:16:25 +11:00
Shamim Rezaie
b48b4d2244 MDL-67970 output: fixed duplicate id attribute
action_menu::export_for_template generates the id attributes and send it
to core/action_menu_trigger template as part of the attributes variable.
2020-03-17 18:16:25 +11:00
Shamim Rezaie
668df7663f MDL-67970 search: fixed stray end tag (input) 2020-03-17 18:16:25 +11:00
Adrian Greeve
082153573c Merge branch 'MDL-67981' of https://github.com/timhunt/moodle 2020-03-17 11:30:33 +08:00
Ferran Recio
252e112376 MDL-67707 mod_h5pactivity: add plugin to standard list 2020-03-16 17:52:08 +01:00
Ferran Recio
40cef8afe7 MDL-67707 core_h5p: move shared h5p files to core fixtures 2020-03-16 17:52:08 +01:00
Simey Lameze
88ba207d2e MDL-67913 core_table: introduce dynamic table interface 2020-03-16 11:44:31 +08:00
Andrew Nicols
44effcb419 MDL-67913 core_table: Add filter classes 2020-03-16 11:44:31 +08:00
Andrew Nicols
1142e1bc83 MDL-67913 core: Add new core_table component path 2020-03-16 11:44:31 +08:00
Mihail Geshoski
17ddce9676 MDL-60817 core_repository: Show a warning if file extension is modified 2020-03-13 13:17:44 +08:00
Mathew May
ddd387ef68 MDL-67924 core: Now show the editing button everywhere 2020-03-13 08:50:14 +08:00
Tim Hunt
f2393804bf MDL-67934 questions: give a sensible default idnumber when duplicating 2020-03-12 18:07:11 +00:00
Eloy Lafuente (stronk7)
41f191b341 Merge branch 'MDL-68125-regression' of https://github.com/brendanheywood/moodle 2020-03-12 01:19:23 +01:00
Eloy Lafuente (stronk7)
0b698cb00b Merge branch 'MDL-67752-master-userstats' of git://github.com/mudrd8mz/moodle 2020-03-12 00:23:30 +01:00
Brendan Heywood
17b04bdb25 MDL-68125 core: Fixed $CFG->reverseproxyignore install regression 2020-03-12 09:36:17 +11:00
kritisingh1
02c350947f MDL-68081 Groups: Fixes string error in member removal function 2020-03-11 17:28:54 +05:30
Andrew Nicols
63e821fb41 Merge branch 'MDL-67063-master' of git://github.com/sarjona/moodle 2020-03-11 16:06:00 +08:00
Sara Arjona
08fda3e0f8 MDL-67063 h5p: new h5plib plugintype for supporting multi coreAPI
A new plugintype has been created for having more than one installed
third-party H5P libraries. Existing libraries have been moved from
lib/h5p to the new h5plib_v124 plugin.
2020-03-11 08:46:16 +01:00
Andrew Nicols
e55d14e8d2 Merge branch 'MDL-68146' of https://github.com/stronk7/moodle 2020-03-11 11:33:25 +08:00
Eloy Lafuente (stronk7)
8aee741e24 MDL-68146 forms: remove duped help and advanced icons in checkboxes
They are exceptionally shown later, after the checkbox text already.

This is a fix for the regression introduced by MDL-63424.
2020-03-10 22:59:36 +01:00
Eloy Lafuente (stronk7)
c30cddf43b Merge branch 'MDL-67189-master' of git://github.com/dpalou/moodle 2020-03-10 11:28:44 +01:00
Dani Palou
096c46bb4e MDL-67189 external: Add test to catch PHP exceptions 2020-03-10 08:26:43 +01:00
Dani Palou
2603034e0a MDL-67189 external: Catch Throwable in call_external_function 2020-03-10 08:26:43 +01:00
Shamim Rezaie
32ec05466a MDL-68135 output: remove the presentation role from user pic
"presentation" is not a valid role for the img element.
Moreover, it doesn't make sense to have both role="presentation" and
aria-hidden="true" for an element at the same time.
For more info please see:
https://timwright.org/blog/2016/11/19/difference-rolepresentation-aria-hiddentrue/
2020-03-10 16:30:08 +11:00
Eloy Lafuente (stronk7)
9dc5d5ce0b Merge branch 'MDL-67827-master' of git://github.com/andrewnicols/moodle 2020-03-09 20:36:09 +01:00
Sara Arjona
32a05b5625 MDL-67063 core: fix error for supporting numbers in component
Component names should always support numbers (but the first character).
This patch will add PARAM_COMPONENT the expected regular expression
to validate the expected format.
2020-03-06 20:21:31 +01:00
Sara Arjona
06299fc604 MDL-67063 output: make public get_jsrev method 2020-03-06 20:21:31 +01:00
Tim Hunt
1b6b554118 MDL-67981 questions: avoid errors deleting contextless questions 2020-03-06 17:57:11 +00:00