mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity
99,563 Commits 36 Branches 519 Tags
Commit Graph

69 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
bd5fdcfccd MDL-63422 general: review core loop / switch / case / continue 
This commit reviews all continue uses in core happening within a
loop / switch / case hierarchy. This does not cover:

- Changes to libraries. Will be handled in another issue / commit.
- Uses out from loops, will be reviewed by other commit.

The policy followed has been:
- When possible, take rid of the continue.
- When clearly the intention was to jump to next element in loop
  change to continue 2
- When it was not clear, keep old behavior switching to break, no
  matter how weird the behavior may be.
 2018-10-31 00:17:59 +01:00
Matteo Scaramuccia
307dce6cf3 MDL-60793 mod_chat: Renamed 'system' into 'issystem' 
'system' is now a reserved word in MySQL 8.0.3+.
 2017-12-18 15:23:11 +01:00
Damyon Wiese
efe2681894 MDL-57772 chat: BEEP is back baby! 2017-11-07 11:25:02 +08:00
Marina Glancy
484b43f456 MDL-60281 general: create_function is deprecated in PHP7.2 2017-10-16 09:37:19 +08:00
Russell Smith
1fcf0ca8a5 MDL-35628 performance: Remove dirname() where possible. 
dirname() is a slow function compared with __DIR__ and using
'/../'.  Moodle has a large number of legacy files that are included
each time a page loads and is not able to use an autoloader as it is
functional code.  This allows those required includes to perform as
best as possible in this situation.
 2016-06-10 08:06:49 +10:00
Matteo Scaramuccia
8e1f21d47b MDL-43483 mod_chat: Fixed race condition issues, including not useful logs. 2014-11-24 08:58:38 +08:00
Andrew Davis
c52b4db52d MDL-46465 mod_chat: assorted coding style fixes 2014-07-28 10:01:41 +08:00
Dan Poltawski
571944c2a1 Merge branch 'm27_MDL-43482_Lot_Of_Passed_By_Reference_Messages' of https://github.com/scara/moodle 2014-01-07 17:20:44 +08:00
Petr Škoda
90627d9d59 MDL-43527 eliminate last references to safe_mode 
Safe mode is not availabel in PHP 5.4 any more...
 2014-01-02 09:23:15 +08:00
Matteo Scaramuccia
323f4fff46 MDL-43482 Chat Lot of "Only variables should be passed by reference". 2013-12-24 11:02:29 +01:00
sam marshall
3ef7279f26 MDL-42084 Core: Change set_time_limit to core_php_time_limit::raise everywhere 
Exceptions (places where set_time_limit is still left) are:

Third-party libraries:
  ADODB
  PHPMailer

Moodle core:
  PHPUnit - not relevant (CLI mode)
 2013-11-06 16:40:01 +00:00
Frederic Massart
f49d814abc MDL-40048 mod_chat: Replacing add_to_log with new events 
For this to be done properly, a new function to send the message
and trigger the event has been created. Following that a
data generator for chat, and some unit tests.
 2013-09-23 11:41:33 +08:00
Aparup Banerjee
27fec8650b Merge branch 'wip-MDL-29463-master' of git://github.com/phalacee/moodle 2012-09-11 14:46:44 +08:00
Aparup Banerjee
fda1d233a7 Merge branch 'MDL-27398_master' of git://github.com/dmonllao/moodle 2012-09-10 14:29:47 +08:00
David Monllao
bd9cb43e09 MDL-27398 mod_chat Removing PAGE references 2012-09-10 14:09:02 +08:00
David Monllao
32b49bbd84 MDL-27398 mod_chat Adding file basic doc 2012-09-10 14:09:02 +08:00
David Monllao
24242682df MDL-27398 mod_chat Removing deprecated calls and moving dependencies 
Credit to Jorge Villalon
 2012-09-10 14:08:49 +08:00
David Monllao
e54370d7fb MDL-27398 mod_chat Adding CLI_SCRIPT to chat daemon 
Credit to Jorge Villalon
 2012-09-10 14:08:22 +08:00
Jason Fowler
24eb0897cb MDL-29463 - Chat - Change socket_setopt to socket_set_options 2012-09-08 11:53:37 +08:00
David Monllao
84ac37f0f4 MDL-34068 mod_chat Sending text/html headers when sending the messages frame output for the first time 2012-09-07 12:10:36 +08:00
Petr Skoda
431ac39634 MDL-26623 fix file permissions 
The permissions are now going to be verified as part of the weekly release process.
 2011-03-01 12:26:49 +01:00
Petr Skoda
8a7703ce53 MDL-25973 add missing charset 2011-01-14 09:32:17 +01:00
Petr Skoda
0e7de62880 MDL-19698 deprecated assign new by ref in chat server - there are much worse problems left I think 2010-07-19 08:32:19 +00:00
Andrew Davis
cda0469680 chat MDL-22564 removed old commented out code and added a missing definition of $OUTPUT 2010-05-26 01:53:27 +00:00
Andrew Davis
eaed2fd163 ajax MDL-22286 removed references to the previous version of the JS function openpopup() 2010-05-05 02:05:58 +00:00
Petr Skoda
812dbaf7d5 MDL-21198 improved/simplified $OUTPUT->user_picture() + regression fixes, performance fixes and detected performance problems when printing user avatars 2009-12-27 19:47:21 +00:00
Petr Skoda
e7521559ed MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 13:17:47 +00:00
nicolasconnault
af7bad7997 MDL-19804 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno 2009-08-20 08:42:59 +00:00
tjhunt
d1dd5d030f chat: Remove unnecessary call-time pass by reference. 2009-07-24 09:16:09 +00:00
nicolasconnault
6dbcaceef1 MDL-19418 Replaced ereg* by preg* 2009-06-22 01:22:37 +00:00
tjhunt
c13a5e71cc moodle_page: MDL-12212 start of new moodle_page class 
* has course and status fields
* $PAGE->status updated by print_header and footer
* $PAGE->set_course now replace course_setup function
* global $PAGE created in setup.php
* unit tests for functionality so far
* Moodle still seems to work after this commit!
 2009-05-06 08:29:22 +00:00
dongsheng
1f8abb893b MDL-15370, remove old html and javascript code, merged from 1.9 2008-10-08 06:48:57 +00:00
dongsheng
6e5f40eadc MDL-14650, create a new table chat_messages_current to save latest 8 hours messages, could improve performance. The expired message will be deleted in chat_cron function 2008-07-24 03:15:03 +00:00
Francois Marier
6800d78e06 Drift between CVS and git 
- large deletions
- lucene updates
- error() => print_error()
- NO_MOODLE_COOKIES define
- various other things
 2008-06-25 17:31:23 +00:00
skodak
d3bf6f92f6 MDL-15104 chat dml conversion 2008-06-08 15:49:36 +00:00
dongsheng
64fcd675f7 "MDL-7362, allow_call_time_pass_reference setting may cause bug, see tracker, merged from MOODLE_19_STABLE, thanks James" 2008-05-01 08:32:04 +00:00
dongsheng
1a084d1541 "MDL-10944, fix undefined property in chatd.php, merged from MOODLE_19_STABLE" 2008-05-01 06:55:07 +00:00
skodak
9152fc9938 MDL-8323 finished full conversion to proper $COURSE global - no more $CFG->coursetheme, $CFG->courselang - improved course_setup(), current_language() and current_theme(); and Chameleon theme fixes needed for global $COURSE 
MDL-7962 chat seems to be completely broken in head (fixed wrong JS)
* reworked chat themes support
MDL-8338 Cron does not need cookies
MDL-8339 forum cron capabilities problems
* minor deprecated function current_encoding() cleanup
 2007-01-28 21:18:08 +00:00
moodler
f4ba7e1a54 Bend over for XHTML 1.0 Strict ... MDL-8049 
Removed Javascript language attribute tags and added CDATA
 2007-01-03 14:44:17 +00:00
defacer
281d70ac2d Merging from STABLE: 
Three improvements:

1. $nomoodlecookie = true. I just found out about this undocumented(?) hack(?)
   in lib/setup.php which is the perfect way to suppress some warnings. We
   don't need a session cookie for the chatd.

2. If allow_call_time_pass_reference is Off, socket_getpeername can't work.

3. Suppress "call time pass by reference is deprecated" messages for
   socket_getpeername, we don't have any choice here.
 2005-07-08 03:51:38 +00:00
martinlanghoff
a9a9bdba55 Merged from MOODLE_14_STABLE - insert_record() - major efficiency improvements for Postgres databases on insert. Also fixed many calls to insert_record() which discard the returned record id to not ask for the record id. 2005-04-01 05:55:10 +00:00
skodak
e7fbd0b3f2 Chatd cleanup finished, from now on only bug fixing. 2005-02-12 10:54:25 +00:00
moodler
89f688b6c6 Removed some THEME 2005-02-10 18:22:31 +00:00
skodak
9824495127 detection of oversized requests from clients 2005-02-06 10:06:25 +00:00
skodak
2ac0d13b6f reverted some unfinished changes in chatd - enter message 2005-02-04 21:14:19 +00:00
skodak
516121bd0d radical chat clean up, see forum for details 2005-02-03 20:39:27 +00:00
defacer
bc6c7c26b6 Better comments and some more diagnostic messages to help with bug hunting. 
Also changed a > to >= to make the polling interval precice to the second.
 2005-01-17 22:26:20 +00:00
defacer
548c4e2e55 Fix for bug 2285: chatd shows all chat users as present in every chatroom 
Should be fixed, but needs testing.
 2004-12-15 07:08:31 +00:00
defacer
233ca8bf60 Undoing an incorrect instance of htmlentity encoding a &. Probably got in 
with all the XHTML frenzy. Thanks to Daryl for helping to debug this! :-)
 2004-10-03 16:40:20 +00:00
gustav_delius
8f0cd6ef0f Resolved problems with previous replacement of 
& to & and fixed redirect() to entity encode the
inut where needed.
Julian Sedding
 2004-09-21 11:41:58 +00:00