440 Commits

Author SHA1 Message Date
Bas Brands
a3f7695f07 MDL-66721 core_chooser: height correction for chooser modal 2020-01-06 10:07:16 +01:00
Andrew Nicols
04e67878f9 MDL-67285 core: YUI dialogues must use focuslock
YUI Dialogues were using an older method for locking focus to modals,
but this way conflicts with the way in which we lock focus for AMD
modules.

As a result, when an AMD dialogue launches a YUI dialogue the focus is
not correctly locked and it is not possible to focus on anything in the
YUI dialogue.

This includes a minor changes to the focuslock AMD module to ensure that
it is possible to loop the focus in both directions. Many of our older
YUI dialogues are themselves focusable. As a result we need to include
the lock region in the calculation when calculating the possible
descendants.
If we do not do so then the reverse looping does not work.
2019-11-19 07:40:36 +08:00
Andrew Nicols
c72f5e33c5 MDL-66845 core: YUI Dialogues should have the same zIndex as bootstrap
Part of MDL-66074

This change allows YUI Modals to sit in the same space above the
fullscreen modal and other such elements.
2019-10-30 10:23:41 +08:00
Peter
d439fac53c MDL-52849 core: Focus reader onto popup with ajax errors 2019-08-12 10:45:08 +08:00
Andrew Nicols
0f2b29242e Merge branch 'MDL-65469-master' of git://github.com/peterRd/moodle 2019-06-17 14:18:40 +08:00
Peter
dfd0021749 MDL-65469 core: Expose formchecker to initialize current form state 2019-06-17 11:55:56 +08:00
Andrew Nicols
871679c9e0 Merge branch 'MDL-65509-master' of git://github.com/rezaies/moodle 2019-06-12 08:47:55 +08:00
Damyon Wiese
7aeeb44463 MDL-34498 session: Add a checker to warn before session expiry
Replaces old yui module checknet.
2019-06-06 09:31:01 +08:00
Shamim Rezaie
dc468ac523 MDL-65509 javascript: Make core dialogues translatable 2019-06-05 17:36:02 +10:00
Damyon Wiese
260565e305 MDL-64573 output: ajax form event
Add an event that can be fired when an mform is about to be submitted via ajax.
This allows custom field types to perform an action when the form is submitted.

The atto text editor will reset any autosaves when the form is submitted.
2019-04-24 16:17:49 +08:00
Mathew May
9757c65687 MDL-64506 Javascript: Remove docking JS.
Deprecate related lang strings & base functions now return false.
2019-04-03 19:34:20 +08:00
Damyon Wiese
cdc7390446 MDL-64331 modals: Be careful closing modals
Don't close a modal when the user clicks outside of it and the modal contains a form.
2019-04-02 10:02:26 +08:00
Ryan Wyllie
7e0305be70 MDL-60207 javascript: remove click handler in YUI modal initialiser 2018-05-29 10:05:00 +08:00
Treu Quan
30e1f5a023 MDL-60207 javascript: close modal when user touch/click outside it 2018-05-29 10:04:37 +08:00
Bas Brands
e58362ed1e MDL-62160 Theme boost: center buttons on notification popup 2018-04-25 10:18:36 +02:00
Amy Groshek
ecdfab51a3 MDL-60478 mod_scorm: Makes checknet alerts less obtrusive.
Alters checknet component to accept frequency,
timeout, and maxalerts arguments. Sets checknet
launched during SCORM session for 30 sec
frequency, 10 sec timeout, and 1 alert max.
2017-11-20 12:59:14 -06:00
Andrew Nicols
bd90b61ad2 MDL-59312 js: Improve display of exception stacktrace 2017-06-23 10:44:15 +08:00
David Mudrák
64b6651cfa MDL-59269 lang: Fix ability to uninstall certain language packs
In the issue MDL-39319 (6ddf92c77), the ability to uninstall multiple
language packs at once was added. By a mistake, the PARAM_ALPHAEXT was
used as paramater type for the dash-separated list of language packs to
be uninstalled. Language packs with a number in the name (such as
en_us_k12) do not pass the ALPHAEXT cleaning.

This patch changes the parameter cleaning to PARAM_SAFEPATH which is
more appropriate for the given scenario as language code themselves must
be SAFEDIRs.
2017-06-16 14:15:25 +02:00
Andrew Nicols
2154c9824d Merge branch 'MDL-40759-master' of git://github.com/damyon/moodle 2017-03-20 13:57:38 +08:00
Damyon Wiese
b9b409cfc3 MDL-40759 icons: Peer review fixes (all minor) 2017-03-17 15:52:46 +08:00
Damyon Wiese
8857c715d1 MDL-40759 icons: Behat fixes for font-awesome 2017-03-17 15:52:18 +08:00
Damyon Wiese
95b06c13c6 MDL-40759 icons: Refactor icon system to be extensible. 2017-03-17 15:51:29 +08:00
Damyon Wiese
e6bf10c772 MDL-40759 dragdrop: Use a pix icon renderer for drag handles. 2017-03-17 15:51:28 +08:00
Jake Dallimore
3d4339b817 MDL-58182 javascript: Fix for buttons regression in core dialog.
Fixes a regression caused by MDL-56364, wherein the buttons were made
readOnly, meaning addButtons wouldn't work. This removes that change,
while maintaining the original dependency between the buttons and the
closeButton config options.
2017-03-17 09:05:04 +08:00
Jake Dallimore
35fcaac78b MDL-56364 javascript: Prevent bad prototype chains in core dialogue
The DIALOGUE object was using Y.clone to copy the input config, messing
up the prototype chains for any objects in the config param. Really,
this doesn't need to clone the config, so I've refactored to avoid doing
so. Also moved some of the other attribute init and setup calls to the
appropriate places (initializer and modifyAttrs).
2017-02-24 08:25:31 +08:00
Dan Poltawski
d83d87f6ac MDL-56640 yui: remove moodle-core-formautosubmit
It's easily achieved with jquery primatives
2016-12-20 10:02:06 +00:00
Damyon Wiese
f2405a5f5c MDL-56242 theme_boost: Fix styling for confirm boxes (js and in page)
They should be left aligned with a header, content and footer (right aligned with the buttons).

There should be a primary continue button and a secondary cancel button.
2016-11-14 11:11:28 +08:00
Damyon Wiese
9280f62e38 MDL-56196 mod_lti: Fix popups and secret form in boost 2016-11-08 14:27:26 +08:00
Dan Poltawski
f95c00e551 Merge branch 'wip-MDL-54986-master' of https://github.com/Beedell/moodle 2016-11-04 14:31:00 +00:00
John Beedell
6e1e299554 MDL-54986 Quiz: Disable add button for quiz with attempts 2016-11-02 17:02:59 +00:00
David Monllao
f5d9072e51 Merge branch 'MDL-56462-master' of git://github.com/damyon/moodle 2016-11-02 09:14:09 +08:00
Dan Poltawski
5ad34c43f6 Merge branch 'MDL-56597-master' of git://github.com/damyon/moodle 2016-10-31 15:10:02 +00:00
Damyon Wiese
58488d0ff0 MDL-56462 boost: Fix assign grading options form
Classes attribute was not being honoured by all form element templates.
Formchangechecker was only looking for the ignoredirty class on the element,
in boost it is on the container.
Assign had specific styles to hide the submit buttons that were not matching in boost.
2016-10-28 12:24:50 +08:00
Damyon Wiese
bff9fd896a MDL-56597 theme_boost: Maintenance warning styles 2016-10-27 10:41:42 +08:00
David Ligne
f2510387e5 MDL-56442 administration: Display hours in maintenance mode messages 2016-10-20 13:17:07 -04:00
Deepa Jayaprakash
9b24ebd665 MDL-55861 course: Click drag&drop icon, incorrect activities shown 2016-09-29 16:42:10 +01:00
Frederic Massart
a13dd17cf6 MDL-55593 core: Drag & drop accessible menu uses aria attributes
Part of MDL-55071
2016-09-23 10:55:18 +01:00
Rajesh Taneja
43759f5e23
MDL-46514 behat: Catch errors shown by JS 2016-08-19 06:46:27 +08:00
Eloy Lafuente (stronk7)
ddf1d5c692 Merge branch 'MDL-55244-master' of git://github.com/danpoltawski/moodle 2016-07-27 00:19:40 +02:00
Dan Poltawski
3a0bc0fdc4 MDL-55244 js: build changes
There should be no changes to minified code
2016-07-25 07:58:05 +01:00
Dan Poltawski
bc8b6dc652 MDL-55244 js: fix various lint warnings in yui
* Incorrect brace style
* Empty functions
* Multiple var statemnts
2016-07-25 07:53:05 +01:00
Dan Poltawski
5bb4f444de MDL-55244 js: fix problems with eslint --fix
eslint --fix '**/yui/src/**/*.js'
2016-07-25 07:53:05 +01:00
Adrian Greeve
b559497393 MDL-54796 forms: Editor restore event created.
The editor restore event is currently being subscribed
to by the change checkers to refresh their savedstate.
2016-07-25 10:42:58 +08:00
Dan Poltawski
ad3f8cd18c MDL-54944 eslint: make the .eslintrc default stricter
Instead of using the more rollup-tolerant config for all files, make the
configuration stricter by default but lower in grunt for yui modules.

This means that manual runs (prechecker) or editor integrations will
flag up the errors as well as grunt.

Also add ignore lines to the core files so that eslint isn't noisy when
not running with grunt.
2016-07-11 12:44:34 +01:00
Cameron Ball
fd5466af99 MDL-54722 navigation: Properly overflow expanded nav trees 2016-06-01 10:15:22 +08:00
David Monllao
f0a2dbf188 Merge branch 'MDL-54121-master' of git://github.com/damyon/moodle 2016-05-17 17:16:12 +08:00
Andrew Nicols
6885517d78 MDL-54121 core-notification: Fix lockscroll recalc for nest dialogues 2016-05-13 12:12:05 +08:00
Damyon Wiese
79e4a72f09 MDL-54121 core-notification: Make dialogues re-calculate the lockscroll
When the content of a dialogue changes after it is first opened - you need to call centerDialogue()
to make sure it still sits in the middle of the window. In addition this now recalculates the "lockScroll"
so that if you need to scroll down to see all of the dialogue you can do it.
2016-05-11 13:52:47 +08:00
Andrew Nicols
a321eb06b7 MDL-53293 core: Add destructor phases to core-dragdrop 2016-05-11 08:19:39 +08:00
Ryan Wyllie
5d2c5ba3e4 MDL-51983 actionmenu: fix hideIfOutside
The hideIfOutside function was being too restrictive with the
selector for checking if the event occurred within a menu child
(anchor tag) rather than the menu itself.
2015-11-04 03:42:09 +00:00