mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-10 10:58:38 +01:00
Code Issues Projects Releases Wiki Activity
65,769 Commits 36 Branches 523 Tags
Commit Graph

262 Commits

Author SHA1 Message Date
Damyon Wiese
e7af192606 MDL-36804 Assign history: Fix automatic coding error when using auto-reopen method 
This fix should call the gradebook function is_passed - but the gradebook is returning a record with
not enough information to create an instance of grade_grade.
 2013-04-05 15:53:38 +08:00
Damyon Wiese
a8fdb36cf2 MDL-36804 Assignment attempt history: Fix warning on saving a new grade. 
This is a fix for the case when there is a submission but no grade.
 2013-04-05 10:03:00 +08:00
Damyon Wiese
e84900648b MDL-36804 Assign attempt history: Fix course unit tests 
Handle missing attemptreopenmethod in add/update instance.
 2013-04-03 17:31:12 +08:00
Damyon Wiese
95bef9d170 MDL-36804 Assign: Fix undeclared global $USER and undefined variable $userid 2013-04-02 13:44:25 +08:00
Damyon Wiese
df211804f1 MDL-36804 mod_assign - allow students to resubmit work and display a submission + grading history 
This is based on work by Davo Smith with input from Fernando Oliveira (Thanks guys!).
 2013-04-02 13:37:51 +08:00
prateeksachan
f7884095de MDL-38361: Fixed typos in mod/assign/locallib.php 2013-03-30 23:39:56 +05:30
Damyon Wiese
520fee918e MDL-36832 Assignment Use MUC for useridlist: Fix for quickgrading checkbox 2013-02-27 11:24:42 +08:00
Dan Poltawski
e1350c61d1 Merge branch 'MDL-36832-master' of git://github.com/damyon/moodle 2013-02-25 14:19:36 +08:00
Tim Lock
9ecded01cc MDL-38113: Blind Marking grader email reveals submitters details 2013-02-25 11:13:25 +08:00
Damyon Wiese
d08e6c31fb MDL-38061 Assignment - Use $CFG->showuseridentity to add extra fields to the assignment grading table/user summary. 2013-02-22 10:30:56 +08:00
Damyon Wiese
c211409998 MDL-36832 Assignment Fix issues found by unit tests with previous patch 2013-02-21 11:22:06 +08:00
Damyon Wiese
d04557b364 MDL-36832 Assignment - Use MUC for caching the useridlist and change all pages to redirect after post. 
This means that the $PAGE->url is properly set for all pages and is required to fix some edge cases with the comments api when
javascript is disabled. It also means logging in after a timeout will work nicely and other Good Things (tm).
 2013-02-21 11:04:07 +08:00
Damyon Wiese
b0da618b61 MDL-37337 Assignment: Restructure assignment settings screen to make it "wieldy" 2013-02-15 11:26:21 +08:00
Dan Poltawski
4ac341c9b6 Merge branch 'MDL-37646-master' of git://github.com/damyon/moodle 2013-02-04 13:49:23 +08:00
Dan Poltawski
d5a13bca09 Merge branch 'MDL-37710-master' of git://github.com/damyon/moodle 2013-02-04 12:12:11 +08:00
Damyon Wiese
46692c3a81 MDL-37635 Assign: Prevent errors when viewing a feedback for an assignment with no gradeitem in gradebook 
Also adds unit tests to verify that:
Feedback is visible even if there is no grade
The grade is not shown if the gradeitem is hidden unless you have mod/assign:grade capability
 2013-02-01 13:46:08 +08:00
Damyon Wiese
3e1b63f1c8 MDL-37710 Assign: Fix pluginfile permission checks for student viewing their own team submission. 
This change adds a function to the assign class to allow the permissions for a group submission
to be checked and updates all the submission plugins to call it.
 2013-01-29 17:14:36 +08:00
Damyon Wiese
6792b8f5d3 MDL-37646 Assign: Quickgrading fix when using grading filters or lots of students. 2013-01-29 14:36:18 +08:00
Dan Poltawski
0a9b944a15 Merge branch 'MDL-36587-master' of git://github.com/damyon/moodle 
Conflicts:
	mod/assign/locallib.php
 2013-01-15 11:19:40 +08:00
Sam Hemelryk
0fe5a201c0 Merge branch 'MDL-37030-master' of git://github.com/damyon/moodle 
Conflicts:
	mod/assign/locallib.php
	mod/assign/submission/onlinetext/locallib.php
 2013-01-15 10:37:54 +13:00
Sam Hemelryk
6f51092fbe Merge branch 'MDL-35413-master' of git://github.com/damyon/moodle 
Conflicts:
	mod/assign/locallib.php
 2013-01-09 11:59:43 +13:00
Damyon Wiese
47f48152f7 MDL-35413 Assignment: Add unit tests (lots of them). 2013-01-04 15:51:08 +08:00
Damyon Wiese
e5403f8c44 MDL-36904 Assignment: Fix all errors and warnings from codechecker 2013-01-04 15:46:15 +08:00
Damyon Wiese
d6c673ed4e MDL-36712: Assignment - Do not always send feedback available emails when grade is created 
The entry in the assign_grades table contains grades feedback and other settings such as locked.
Only send the student an email about new feedback if it is actually grades or feedback that
has been added. This is done by using another state for the mailed flag (2) which means "unset".
 2013-01-04 14:46:14 +08:00
Dan Poltawski
b20d65f271 Merge branch 'MDL-37037-master' of git://github.com/damyon/moodle 2012-12-24 12:23:03 +08:00
Sam Hemelryk
bef123d608 Merge branch 'MDL-36966-master' of git://github.com/damyon/moodle 2012-12-24 11:16:26 +13:00
Damyon Wiese
2406815bbf MDL-37030 Assignment: Fix error on download all submissions. 
When group submissions and blind marking are enabled, an error is thrown
when a teacher trys to download all submissions in a zip. The fix is to
move the url rewriting from the plugin to the assign class so it is
done in a standard way by all modules. The rewriting is done to make images
in a text editor field resolve correctly.
 2012-12-18 12:17:25 +08:00
Damyon Wiese
afa3e637a4 MDL-37037 Assignment Some minor refactoring of the previous patch 
This just makes the control flow a bit easier to read.

I also added a continue button to take you back to the grading page.
 2012-12-18 09:19:23 +08:00
Michael Aherne
5c77835865 MDL-37037 assign Show message if no files to download 2012-12-18 08:54:10 +08:00
Damyon Wiese
64220210de MDL-35740 Assignment: Change the assignment index page to use a renderer. 
This also cleans up the patch to prevent students from seeing the number of submissions for the assignment.
 2012-12-18 08:44:53 +08:00
Raymond Wijaya
f81dc1222d MDL-36966 Assignment: Bug - Student submission appears graded by themselves. 
Fix a bug when a student editing his submission after it has been graded, it changes the 'graded by' details to the student's name in the feeback summary
 2012-12-18 08:39:31 +08:00
Damyon Wiese
0c7b691035 MDL-37165 Assignment: Oracle fix for count_submissions_with_status (and friends). 
Oracle does not like the use of AS after a join.
 2012-12-14 15:10:06 +08:00
Dan Poltawski
c3c2fc538a Merge branch 'MDL-36712-master' of git://github.com/damyon/moodle 2012-12-11 14:00:25 +08:00
Kirill Astashov
9b7a5f654a MDL-36587 Assignment: Hide Download All links when no submission have been made 2012-12-11 11:25:05 +08:00
Dan Poltawski
74bf44284a Merge branch 'MDL-35476-master' of git://github.com/damyon/moodle 2012-12-11 10:49:12 +08:00
Sam Hemelryk
fc6acfe242 Merge branch 'MDL-36905' of git://github.com/rwijaya/moodle 2012-12-11 15:44:37 +13:00
Sam Hemelryk
4e0c4ec70d Merge branch 'MDL-36263-master' of git://github.com/damyon/moodle 2012-12-11 10:17:57 +13:00
Dan Poltawski
6aa4fccc74 MDL-36167 fix trailing whitespace 2012-12-10 17:35:58 +08:00
Dan Poltawski
76089dc378 Merge branch 'MDL-36167-master' of git://github.com/damyon/moodle 2012-12-10 17:31:41 +08:00
Damyon Wiese
8f7e1c05af MDL-36263 Assignment: Do not count submissions of unenrolled users 2012-12-10 14:54:24 +08:00
Damyon Wiese
7a9fd6da43 MDL-36908 Assignment: Additional fixes for preventing empty submissions 2012-12-10 14:54:24 +08:00
Rossiani Wijaya
49f0c151dd MDL-36905 accessibility for assignment grading: add label for grading actions and operations select options 2012-11-29 15:06:49 +08:00
Damyon Wiese
871941a37a MDL-35476 Assignment: Make submissions_open public so it can be used by plugins 2012-11-28 14:46:17 +08:00
Damyon Wiese
a732e1f714 MDL-35966 Assignment - Localisation issue - use userdate not strftime 
This is causing a database error (reported on MySQL) when strftime returns
non-utf8 characters.  This occurs when sending assignment notifications.

This was reported and a solution provided by Chien Wen-Chang(簡文章).
 2012-11-27 16:19:01 +08:00
Dan Poltawski
db0b3c5078 Merge branch 'MDL-36184-master' of git://github.com/damyon/moodle 2012-11-27 13:58:20 +08:00
Sam Hemelryk
fa8d78a485 Merge branch 'MDL-36829' of https://github.com/kastashov/moodle 2012-11-27 11:05:40 +13:00
Kirill Astashov
398a414801 MDL-36829: Fix outcome value not being saved when grading a submission 2012-11-26 16:23:02 +10:30
Damyon Wiese
56672cb7b4 MDL-36712: Assignment grading with custom scale is affected by the current language 2012-11-21 15:35:08 +08:00
Damyon Wiese
34b8f3a83d MDL-35963: Assignment - do not accept empty submissions 2012-11-21 13:46:50 +08:00
Dan Poltawski
77f948a2f7 Merge branch 'MDL-36289' of git://github.com/netspotau/moodle-mod_assign 2012-11-21 12:00:28 +08:00