317 Commits

Author SHA1 Message Date
Damyon Wiese
45fdcb7ce3 MDL-43723 Blocks drag and drop: Javascript cleanup
Declare the selector instead of repeating it several times.
2014-02-25 17:01:45 +08:00
Damyon Wiese
58ff6e51df Merge branch 'MDL-43723-master-nomerge2' of git://github.com/mouneyrac/moodle 2014-02-25 16:43:56 +08:00
Andrew Nicols
29ee3cf789 MDL-44101 Javascript: Apply widget-focusonclose to some core dialogues
Conflicts:
	lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js
2014-02-24 16:31:55 +08:00
Andrew Nicols
7ae6ce009e MDL-44101 Javascript: Introduce a module to focus after widget close
This module supports focusing on a specified Node, or attempting to
determine the Node which caused the displayed the Widget to return focus to
that location.
2014-02-24 16:31:09 +08:00
Sam Hemelryk
c10affa57b Merge branch 'MDL-43997-master' of git://github.com/andrewnicols/moodle
Conflicts:
	lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js
2014-02-18 09:31:32 +13:00
Andrew Nicols
cfa770b47b MDL-43997 Javascript: Make all informative dialogues display correctly
Most of the moodle core dialogue types should be shown modally, and
centred. They should also be shown on instantiation.

Rather than re-define all of these settings, this patch introduces a new
subclass of M.core.dialogue which sets them up with the same settings.
2014-02-17 10:49:45 +08:00
Jerome Mouneyrac
d14f5265b2 MDL-43723 restrict the drag and drop to the move icon instead of dragging the entire block header 2014-02-17 09:16:53 +08:00
Sam Hemelryk
fa52e6494d Merge branch 'MDL-44042-master' of git://github.com/andrewnicols/moodle
Conflicts:
	lib/yui/build/moodle-core-dragdrop/moodle-core-dragdrop-min.js
2014-02-17 09:06:58 +13:00
Sam Hemelryk
87643ff599 Merge branch 'MDL-44079-master' of git://github.com/andrewnicols/moodle
Conflicts:
	lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js
2014-02-17 08:48:39 +13:00
Sam Hemelryk
80ce7e1a8d Merge branch 'MDL-43979-master' of git://github.com/andrewnicols/moodle 2014-02-17 08:27:48 +13:00
Andrew Nicols
2ab0238ff6 MDL-44042 Javascript: Handle moving to the top of the current section with keyboard 2014-02-13 10:11:00 +08:00
Andrew Nicols
bc0477392b MDL-44079 Javascript: Closing a tooltip should pass event details 2014-02-11 12:17:53 +08:00
Andrew Nicols
bf24abd221 MDL-44079 Javascript: Check whether a dialogue is focused before closing 2014-02-11 12:17:52 +08:00
Andrew Nicols
2f5c1441d7 MDL-43979 Javascript: Correct checking of attributes during dialogue init
Various dialogue attributes are optional and are provided by the parent and
not provided as attributes to the dialogue being initted.

As a result, if the setting is not provided during init, we were assuming
that the value would be false rather than checking the real attribute.
2014-02-10 22:00:43 +08:00
Sam Hemelryk
52b7e8aa58 Merge branch 'MDL-43267-master-3' of git://github.com/andrewnicols/moodle 2014-02-10 14:53:51 +13:00
Andrew Nicols
7e804d0cb4 MDL-43992 Javascript: Remove <return> key listener for confirmation
The listener was previously confirming, even when the cancel or 'No'
buttons were selected. However, having the default action as 'Confirm'
seems dangerous in this situation, so removing this option entirely.
2014-02-07 16:35:49 +08:00
Andrew Nicols
8659df93f9 MDL-43267 Javascript: Improve focus before and after drag/drop 2014-02-07 15:10:09 +08:00
Andrew Nicols
02839a35f0 MDL-43267 Javascript: Remove aria drag/drop related attributes for drag/drop
Since we provide an alternative interface rather than describing the
locations for each drop, we should not add aria-grabbed, or
aria-dropeffect.
2014-02-07 13:36:41 +08:00
Andrew Nicols
34bcc6a95c MDL-43267 Javascript: Improve accessibility of keyboard move
Change the keyboard move descriptions to allow for more detailed
descriptions such as:
* "After 'X'"; or
* "To top of section 'Y'"
2014-02-07 13:36:41 +08:00
Marina Glancy
c71b7b7c44 Merge branch '38923-27' of git://github.com/samhemelryk/moodle 2014-02-05 12:49:02 +08:00
Sam Hemelryk
ee729af1e4 MDL-38923 theme_bootstrapbase: pre-integration fixups
* Fixed the way we added the block class to the dock panel in dock.js
* Added a class to the h2 that is used to test dock title width
* Fixed RTL alignment issues as best I could at present
* Fixed overlap of dock + navbar on small screens
* Fixed the docked block width to be constrained to the available space
* Fixed hidden actions on docked blocks
2014-02-05 15:07:44 +13:00
Sam Hemelryk
abaae2a548 MDL-38923 dock: allowed for space before first time 2014-02-05 11:21:09 +13:00
Sam Hemelryk
2a203eee8d MDL-38923 theme_bootstrapbase: tidied up dock implementation
Also:
* Changed to a CSS based compacting solution
* Converted dock colours to variables
* RTL fixes for the dock
2014-02-05 11:21:09 +13:00
Sam Hemelryk
2f166b3284 Merge branch 'MDL-43885-master' of git://github.com/andrewnicols/moodle 2014-02-04 12:41:00 +13:00
Sam Hemelryk
68ad9d82bf Merge branch 'MDL-43886-master' of git://github.com/andrewnicols/moodle
Conflicts:
	lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js
2014-02-04 11:14:11 +13:00
Andrew Nicols
649c80e6a4 MDL-43885 Javascript: Make the [X] button work like 'No' in relevant dialogues
The [X] button on the dialogue is another form of the 'No' button and
should behave as such. In some dialogues this matters more than others
because the dialogue is destroyed.
2014-01-29 11:16:47 +08:00
Andrew Nicols
0860dd78f7 MDL-43886 Javascript: Remove dialouges from the DOM upon destroy 2014-01-29 00:02:03 +08:00
Andrew Nicols
478d82db06 MDL-42928 JavaScript: Disable lockScroll for small chooserdialogues 2014-01-28 09:49:32 +08:00
Andrew Nicols
73747aea77 MDL-42928 JavaScript: Add LockScroll to all modal dialogues 2014-01-28 09:49:32 +08:00
Andrew Nicols
5ab39a0e97 MDL-42928 JavaScript: Create a module to handle page scroll locking 2014-01-28 09:49:32 +08:00
Sam Hemelryk
d9bf4be487 MDL-43598 dialogue: fixed bug with render procedure 2014-01-13 08:27:46 +13:00
Andrew Nicols
a67233e76f MDL-43262 JavaScript: Correct use of centered attribute override
This should be done using an attribute modification, rather than at the
constructor level.
2014-01-13 08:26:28 +13:00
Andrew Nicols
c46cca4f94 MDL-43262 JavaScript: Correct visible attribute override
This should be done using an attribute modification, rather than at the
constructor level.
2014-01-13 08:26:28 +13:00
Andrew Nicols
16d024348a MDL-43262 JavaScript: Correct width attribute override
This should be done using an attribute modification, rather than at the
constructor level.
2014-01-13 08:26:28 +13:00
Damyon Wiese
8af52d3188 Merge branch 'MDL-34356-master' of git://github.com/andrewnicols/moodle 2014-01-07 16:57:49 +08:00
Dan Poltawski
62bfe6202e Merge branch 'MDL-43323-master' of git://github.com/andrewnicols/moodle 2014-01-07 10:34:40 +08:00
Andrew Nicols
1cce5dfb9a MDL-43281 Blocks: Retrieve a newly created block after creating it
Although we were previously creating the DOM markup for a block region if
it did not exist, we were not making use of it.

This change ensures that we make use of that block region as part of the
blocks code.
2013-12-30 14:15:32 +08:00
Andrew Nicols
80cd508669 MDL-34356 JavaScript: Allow chooser dialogues to submit values for hidden elements
When we submit the chooser dialogue, we disable the radio buttons used for
selection. Since browsers do not actually submit values for disabled
elements, we store the radio value in a hidden element which is not
disabled.

This commit abstracts this out of the activity chooser and into the generic
chooser dialogue such that other types of chooser dialogue may use it.
2013-12-28 11:35:52 +08:00
Sam Hemelryk
a92617fa3f Merge branch 'MDL-43410-master' of git://github.com/andrewnicols/moodle 2013-12-24 09:13:05 +13:00
Andrew Nicols
ce4da4612e MDL-43323 JavaScript: Lazily load exception dependencies for tooltip
Only load the exception-related dependencies for tooltip when required. In
normal situations they should not be required at all.
2013-12-23 08:20:43 +08:00
Sam Hemelryk
8ca4f69539 Merge branch 'MDL-43325-master' of git://github.com/andrewnicols/moodle
Conflicts:
	lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js
2013-12-23 09:54:26 +13:00
Andrew Nicols
af4d19abfb MDL-43410 JavaScript: Stop event propagation when opening the action menu
In certain situations, the click event is propagated through to the
hideIfOutside and immediately closes the menu.

This happens when blocks are dock for example.
2013-12-18 11:44:43 +08:00
Eloy Lafuente (stronk7)
f77233dfaa Merge branch 'MDL-43404_master' of git://github.com/dmonllao/moodle 2013-12-18 02:24:08 +01:00
Sam Hemelryk
bf6529bbd4 Merge branch 'MDL-43234-master' of git://github.com/andrewnicols/moodle
Conflicts:
	lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js
2013-12-18 09:53:02 +13:00
David Monllao
4415b667a4 MDL-43404 behat: Form change checker disabled when running behat 2013-12-17 18:39:31 +08:00
Sam Hemelryk
233e6b985b Merge branch 'MDL-43259-master' of git://github.com/andrewnicols/moodle
Conflicts:
	lib/upgrade.txt
2013-12-17 16:32:35 +13:00
Andrew Nicols
5c1d99b027 MDL-43325 JavaScript: Set a default visibility for most Moodle dialogues
We used to ignore the 'visible' field in the initializer, but now we hide
dialogues if visible is false. This was an unintentional change from the
stable API and means that confirmation boxes, alerts, and exceptions are no
longer shown by default.
2013-12-12 16:20:02 +08:00
Andrew Nicols
5947ab3333 MDL-43259 JavaScript: Stop using deprecated lightbox config setting when instantiating dialogues 2013-12-11 16:56:49 +08:00
Sam Hemelryk
df1498f711 Merge branch 'MDL-42796-master' of git://github.com/andrewnicols/moodle 2013-12-11 11:13:32 +13:00
Sam Hemelryk
176521e560 Merge branch 'MDL-38774-master' of git://github.com/andrewnicols/moodle 2013-12-10 09:25:51 +13:00