Dan Poltawski
9b62a3eb71
MDL-55048 js: rebuilt files with new version of uglifyjs
2016-07-11 15:53:10 +01:00
Dan Poltawski
6e304922fb
MDL-54944 js: built files after changes
2016-07-07 12:11:07 +01:00
Dan Poltawski
5602dc1735
MDL-54944 js: ensure functions are consistent in return val
...
Mostly we are being incosnistent when giving an early-exit shortcut.
Detected by http://eslint.org/docs/rules/consistent-return
2016-07-07 12:11:07 +01:00
Dan Poltawski
7b7d55e11a
MDL-54944 js: split variable intialisations in multiple lines
...
To increase code clarity, we don't allow multiple intilisations to be
confused with each other.
Detected by http://eslint.org/docs/rules/one-var-declaration-per-line
2016-07-07 12:11:06 +01:00
Dan Poltawski
2d2b6c9d22
MDL-54944 js: remove uncessary .call() uses
...
Detected by http://eslint.org/docs/rules/no-useless-call
2016-07-07 12:11:06 +01:00
Dan Poltawski
b1c4d0f2d7
MDL-54944 js: Remove uncessary bind() calls
...
Most of these cases, we are already capturing this in a temporary
variable, so the bind becomes uncessary.
Discovered by http://eslint.org/docs/rules/no-extra-bind
2016-07-07 12:11:06 +01:00
Dan Poltawski
9f5f3dcc83
MDL-54944 js: Fix spacing of objects coding style
...
Fixed by http://eslint.org/docs/rules/object-curly-spacing
2016-07-07 12:11:05 +01:00
Dan Poltawski
037de71996
MDL-54944 eslint: Add rules from Policy decision
...
Also bump eslint to v2.13.1 and make the version explicit in
package.json
2016-07-07 12:10:49 +01:00
Dan Poltawski
7f70d548fe
MDL-54939 amd: build modified files
2016-06-17 09:03:18 +01:00
Dan Poltawski
c96f55e6f9
MDL-54939 amd: fix lint issues
...
Mostly correcting jsdoc, some other line wrapping rules and empty
functions.
2016-06-17 09:03:18 +01:00
Dan Poltawski
35be582696
MDL-54939 amd: Fix lint issues fixable with eslint --fix
2016-06-16 19:33:00 +01:00
Dan Poltawski
3adb62b727
MDL-52127 js: check amd files with eslint grunt task
...
I have spent quite a lot of time working through the current list of
eslint options and configuring them for Moodle style and I think this is
a very good basis to start us at (as well as taking some of out jshint
options out with https://www.npmjs.com/package/polyjuice ). Thanks to
Andrew Nicols, Mark Johnson and Frédéric Massart for some refinements.
With this configuration the grunt build will fail if errors are present
in the js (though you can of course tell jshint to ignore some errors,
as I have done in admin/tool/lp/amd/src/competency_rule_points.js and
defining the Y global in lib/amd/src/yui.js ).
The grunt task will not report warnings by default, but a new
--show-lint-warnings flag will help achieve that. Editor
integrations/stanadalone eslint tool will surely be a better way of
getting eslint errors rather than using the grunt task.
2016-06-11 10:14:35 +01:00
Frederic Massart
6e91817178
MDL-54721 report_competency: Do not ignore the first user selection
2016-05-26 17:54:52 +08:00
Andrew Nicols
2239883b56
MDL-53293 tool_lp: Destroy dragdrop instance before re-creating
2016-05-11 08:19:39 +08:00
David Monllao
8ec64e757e
Merge branch 'MDL-53989-master' of git://github.com/ryanwyllie/moodle
2016-05-09 07:37:09 +08:00
Ryan Wyllie
fd83879728
MDL-53989 cbe: CMD + click selection for competency picker
2016-05-06 04:40:02 +00:00
Andrew Nicols
1c693f7226
MDL-53730 JavaScript: Build form-autocomplete
2016-05-06 09:27:33 +08:00
Adrian Greeve
be8b9189c4
MDL-53730 JavaScript: Fix for competency autoselect issue.
...
When trying to select a user or competency the first select
would not work. Worked fine on the second select. This fixes
that problem and tidies up the code.
2016-05-06 09:27:32 +08:00
Dan Poltawski
f6ab2b87e6
Merge branch 'MDL-53879-master' of git://github.com/FMCorz/moodle
2016-04-29 12:18:05 +01:00
Jun Pataleta
0bb7552429
MDL-53494 tool_lp: Set correct competency and user ID attributes
...
Sets the correct competency and user ID data attributes for the list of
user competencies in the plan.
2016-04-29 12:18:04 +01:00
Frederic Massart
8ea0f17ae9
MDL-53879 competency: Remove limit on framework depth
2016-04-28 16:41:24 +08:00
Jun Pataleta
60a9993bce
MDL-53494 tool_lp: Fix dialogue display when plan is completed
2016-04-27 09:09:52 +01:00
Dan Poltawski
587580a0df
Merge branch 'MDL-53494_master' of https://github.com/StudiUM/moodle
2016-04-26 11:31:55 +01:00
David Monllao
6e233df58e
Merge branch 'MDL-53667-master' of git://github.com/FMCorz/moodle
2016-04-26 11:38:00 +08:00
Issam Taboubi
ee0ca65f4e
MDL-53678 tool_lp: Dropdown list plan displays horizontal scroll bar
2016-04-22 13:51:52 -04:00
Issam Taboubi
7fbbd771f7
MDL-53494 tool_lp: user_competency_in_plan page should be in a popup
2016-04-22 12:32:46 -04:00
David Monllao
f3eb9951d1
MDL-53451 tool_lp: Removing unnecessary built modules
2016-04-19 13:56:49 +08:00
Frederic Massart
4474c87401
MDL-53451 competency: Removing sneaky whitespaces
2016-04-19 12:21:36 +08:00
Frederic Massart
e912927d7b
MDL-53667 tool_lp: Use event delegate for competency dialogue
...
This was causing dramatical performance issues when the module
was loaded hundreds of times on the same page, causing each instance
to detach and attach a new event listener.
2016-04-18 14:52:48 +08:00
Frederic Massart
1e99f31e33
MDL-53654 competency: Provide a way to delete evidence
2016-04-18 11:06:47 +08:00
Issam Taboubi
5f887f4b96
MDL-53528 tool_lp: Allow user to choose parent when creating competency
2016-04-18 11:06:01 +08:00
Frederic Massart
81de839f37
MDL-53700 competency: Migrating external functions to core
2016-04-18 11:05:59 +08:00
Frederic Massart
67bc0eaf38
MDL-53700 competency: Migrate main classes to core
2016-04-18 11:05:59 +08:00
Jun Pataleta
4a4bda6d2d
MDL-53567 tool_lp: Close menubar on click
...
This patch enables the closing of the menubar when a menu item is
clicked or when any other element outside the menubar is clicked.
2016-04-18 10:59:01 +08:00
Serge Gauthier
d57c079a6c
MDL-53551 tool_lp: Can't have a read-only view of competency frameworks
2016-04-18 10:59:01 +08:00
Damyon Wiese
9785dd8174
MDL-53452 tool_lp: Change update_course_competency_settings param to stdClass
...
Allows for future settings to be added without changing the function signature.
2016-04-18 10:59:00 +08:00
Damyon Wiese
5cb320c10b
MDL-53452 competencies: Remove suggestion feature (except tests).
2016-04-18 10:58:59 +08:00
Damyon Wiese
7ba074873c
MDL-53452 competencies: Add course and admin setting to push competency ratings outside a course
2016-04-18 10:58:59 +08:00
Frederic Massart
def7cd6032
MDL-53628 tool_lp: Pick competencies from context and above in templates
2016-04-18 10:58:59 +08:00
Jun Pataleta
85a719e496
MDL-53540 tool_lp_amd: Use currentTarget for comp dialog click handler
2016-04-18 10:58:58 +08:00
Frederic Massart
de3b9193fa
MDL-53529 tool_lp: Consistent 'add' buttons for templates and courses
2016-04-18 10:58:58 +08:00
Frederic Massart
1f58618863
MDL-53186 tool_lp: Removing push for review when adding competencies
2016-04-18 10:58:58 +08:00
Serge Gauthier
71cb304ad8
MDL-53186 tool_lp: Send competencies in review from evidence interface
2016-04-18 10:58:58 +08:00
Frederic Massart
6e20a8de26
MDL-53380 tool_lp: Framework auto complete element
2016-04-18 10:58:56 +08:00
Frederic Massart
5bbb99f9b7
MDL-53421 tool_lp: Allow multiple instances of scale config on page
2016-04-18 10:58:56 +08:00
Frederic Massart
3e0b090c7b
MDL-53212 tool_lp: Only store the required information in scaleconfig
2016-04-18 10:58:55 +08:00
Jun Pataleta
55ac216a66
MDL-52747 tool_lp: Show courses linked to competency in plan
...
Show courses that are linked to the given competency for a given
learning plan on a modal dialogue.
2016-04-18 10:58:55 +08:00
Frederic Massart
9db9cdadb2
MDL-52754 tool_lp: Use ScaleValues AMD module in ScaleConfig
2016-04-18 10:58:54 +08:00
Serge Gauthier
c7484fcc35
MDL-52754 tool_lp: Dropdown list of scales with single quotes in values
2016-04-18 10:58:54 +08:00
Serge Gauthier
7deba3c0a1
MDL-52860 tool_lp: Add confirmation dialogue when removing a competency
2016-04-18 10:58:54 +08:00
