Commit Graph

54 Commits

Author SHA1 Message Date
Marina Glancy
4832a0b3dd MDL-53227 mod_feedback: merge files complete_guest.php and complete.php
Simplify access check, add behat tests
2016-03-18 07:54:59 +08:00
Michael Milette
89e68e6c1e MDL-42460 mod_feedback: Fix markup validation 2016-02-22 22:41:32 +08:00
Michael Milette
cba011942c MDL-42462 - Feedback - Fix for WCAG 2.0 issue with Informational and Error Content Displayed in red
1) The same code used in other Moodle forms is now used in Feedback to display the "There are required fields in this form marked (*/Required field)" message at the top of the screen and each of the asterisks next to required fields.

2) Feedback specific styles (missingrequire, feeback_required_mark), which were used to highlight required and error fields, have been eliminated. These colours are now controlled by the common Moodle styles (mform1, mform, fdescription, required, req and error) that are used throughout the rest of Moodle for a more uniform appearance.

3) Field level error reporting now displays a message instead of just highlighting the field in a similar way that other Moodle forms do.

Affected files:

- /mod/feedback/styles.css
- /mod/feedback/complete.php
- /mod/feedback/complete_guest.php
- /mod/feedback/edit.php
- /mod/feedback/print.php
- /mod/feedback/item/captcha/lib.php
- /mod/feedback/item/info/lib.php
- /mod/feedback/item/multichoice/lib.php
- /mod/feedback/item/multichoicerated/lib.php
- /mod/feedback/item/numeric/lib.php
- /mod/feedback/item/textarea/lib.php
- /mod/feedback/item/textfield/lib.php
- /mod/feedback/lang/en/feedback.php

Signed-off-by: Michael Milette <michael.milette@instruxmedia.com>
2014-04-03 09:25:37 -04:00
Tomasz Muras
1298acc707 MDL-43656 mod_feedback: availablity date logic incorrect 2014-03-03 11:23:44 +08:00
Sam Hemelryk
9714baa1bb MDL-44155 mod_feedback: unified @package use 2014-02-18 10:50:13 +13:00
Marina Glancy
7480dbc5f2 Merge branch 'MDL-42505-Feedback-Inappropriate-use-of-fieldset-tags-around-cancel-button' of git://github.com/michael-milette/moodle 2014-02-11 14:13:39 +08:00
Rossiani Wijaya
8c6ca6961a MDL-42339 - removed double formatting for set_title() and set_heading() 2014-02-05 14:47:23 +08:00
Michael Milette
ca5849e5dc MDL-42505 - Feedback plugin: Inappropriate use of fieldset tags around form and cancel button
Changes:
* Removed the fieldset HTML tags around the Cancel button at the bottom of the form.
* Removed the fieldset HTML tags around the whole form.
* Added missing fieldset tags around groups of radio buttons and checkboxes.
* Removed unordered list wrapping dropdown lists.
* Removed duplicate label for dropdown lists.

Modified Files:
* mod/feedback/complete.php
* mod/feedback/complete_guest.php
* mod/feedback/item/multichoice/lib.php
* mod/feedback/item/multichoicerated/lib.php

Signed-off-by: Michael Milette <michael.milette@instruxmedia.com>
2014-01-28 09:43:56 -05:00
Ankit Agarwal
3f6fd94140 MDL-40047 events: Replace add_to_logs with new events in feedback 2013-10-01 10:12:06 +08:00
Rossiani Wijaya
846cebe5b3 MDL-40687 Feedback: improve page heading levels and layouts 2013-09-09 09:48:05 +08:00
David Monllao
2c979976e1 MDL-34464 mod_feedback Replace all instances of get_context_instance() with respective context_XXXX class in mod/feedback 2012-07-27 09:13:57 +08:00
Andreas Grabs
e7fc2ff42e MDL-27675 - Feedback module abuses data_submitted 2012-06-06 23:17:35 +02:00
Sam Hemelryk
378eb6f6a2 Revert "Merge branch 'MDL-27675_master_wip' of git://github.com/grabs/moodle"
This reverts commit a09a9be812, reversing
changes made to 08e0aaa173.
2012-05-30 16:34:11 +12:00
eLeDia GmbH (Andreas Grabs)
1cb73662b2 MDL-27675 - Feedback module abuses data_submitted 2012-05-28 00:40:05 +02:00
Andreas Grabs
9a2c4dbd00 MDL-27675 - Feedback module abuses data_submitted 2012-05-28 00:40:04 +02:00
Andreas Grabs
abd2899cad MDL-31768 - it is not possible to add a picture to the thanks page in feedback 2012-04-02 11:16:32 +08:00
Andreas Grabs
9c5bc7a580 MDL-29804 - Clean up Feedback modules coding style 2011-10-28 00:30:42 +02:00
Sam Hemelryk
367a75fae4 themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
Andreas Grabs
8d8e6694c8 MDL-24958 - bad permission check on anonymous feedbacks 2010-10-31 22:05:57 +00:00
Petr Skoda
91c49d9233 improved variable initialisation 2010-09-18 12:51:47 +00:00
Andreas Grabs
73043833e9 MDL-19489 - add conditional branching (my first try) 2010-05-16 20:05:51 +00:00
Andreas Grabs
7620725fe5 wrong appearance on feedbacks located on the frontpage 2010-05-14 11:49:59 +00:00
Andreas Grabs
9d092aa91c adding line $PAGE->set_heading(format_string($course->fullname)); 2010-05-09 21:37:48 +00:00
Andreas Grabs
6a471fe007 MDL-17069 - no longer using $_POST 2010-05-02 21:56:06 +00:00
Andreas Grabs
31c0fa53b0 Start replacing tables with div-tags and css-classes 2010-05-02 12:00:56 +00:00
Andreas Grabs
194dd279cc fixed typos 2010-04-30 11:48:33 +00:00
Andreas Grabs
9d5fbd6554 the function feedback_print_item() now is splitted into 3 functions
feedback_print_item_preview()
feedback_print_item_complete()
feedback_print_item_show_value()
Now there is more control over the output
2010-04-21 11:48:49 +00:00
Andreas Grabs
b6f2600152 correction of $cm, $course, $feedback setup 2010-04-02 21:26:17 +00:00
Andreas Grabs
c987dbad0e removed all calls to feedback_load_capabilities() 2010-04-02 11:34:28 +00:00
Andreas Grabs
5dee2210f4 Non standard codingstyle,
replaced some urls with use of moodle_url class
2010-03-28 15:29:49 +00:00
Andreas Grabs
8001d6e794 MDL-19846 - Admin ability to submit answers 2010-03-08 22:02:36 +00:00
Petr Skoda
a685593466 MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions 2010-01-16 15:39:56 +00:00
Sam Hemelryk
92059c7ee5 mod MDL-21169 Removed update this module button and ensured there was a link in the settings block for it. 2009-12-23 01:57:55 +00:00
Petr Skoda
1adbd2c350 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 14:55:15 +00:00
samhemelryk
84973212c4 mod-feedback MDL-19807 Added set_url calls, replaced deprecated functions 2009-09-24 06:11:39 +00:00
agrabs
f1b9e2df43 MDL-19773 - Cannot have code like $SESSION->feedback = new object(); in mod/feedback/lib.php 2009-09-16 12:21:47 +00:00
samhemelryk
84f797db5d feedback MDL-19807 Updated print_header and build_navigation to OUTPUT and PAGE equivalents 2009-09-07 08:10:42 +00:00
nicolasconnault
9fad7b201e MDL-19807 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:14:12 +00:00
nicolasconnault
d4b1d58ca3 MDL-19807 Converted print_box* to $OUTPUT->box* 2009-08-10 04:59:26 +00:00
nicolasconnault
c6ea08764b MDL-19807 Converted all print_footer() calls 2009-08-06 14:15:15 +00:00
nicolasconnault
53b1f5da00 MDL-19807 Migrated calls to print_heading 2009-08-06 08:20:46 +00:00
skodak
973d2660e6 MDL-16613 sesskey cleanup 2009-01-02 10:51:26 +00:00
skodak
d877685831 MDL-16613 sesskey cleanup 2009-01-02 10:51:26 +00:00
skodak
d4a1fcaf11 MDL-16613 sesskey cleanup 2009-01-02 10:36:25 +00:00
dongsheng
ff9b4ea40a "MDL-17570,clean align property, merged from 1.9" 2008-12-10 07:24:11 +00:00
dongsheng
5d2edd1ce9 "MDL-14129, fixed hardcoded print_error in feedback module" 2008-09-25 08:47:55 +00:00
agrabs
488b13baba MDL-14779 Show analysis to students setting in Feedback module does not provide enough contol over who see feedback 2008-06-22 18:02:54 +00:00
skodak
294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
skodak
0085fff8b2 MDL-15107 feedback dml conversion 2008-06-07 22:22:06 +00:00
agrabs
c184660d31 MDL-14522 - new capability "receivemail" for better control who gets the email after
a response.
New option site_after_submit to define the url of the continue-button after completing
 a feedback
2008-05-14 22:34:00 +00:00