Commit Graph

120 Commits

Author SHA1 Message Date
Simey Lameze
30452f23cb MDL-55352 mod_feedback: Change series labels on multi choice rated 2016-08-02 09:23:18 +08:00
Simey Lameze
9698ca2d20 MDL-55352 core: Label values series should override tooltip 2016-07-29 13:22:59 +08:00
Rajesh Taneja
35f7cf429c MDL-54987 behat: Fixed feedback scenarios to display chart data
Now chart data is not visible by default,
we need to click 'Show chart data' to view.
Also, extra space is not required between
% as it's done by chart library
2016-07-27 11:00:54 +08:00
Simey Lameze
32917a9561 MDL-54987 core: final charts project polishing 2016-07-25 10:43:35 +01:00
Simey Lameze
7cd65bcb76 MDL-55308 mod_feedback: Convert analysis chart to the new library
Part of MDL-54987 epic.
2016-07-25 10:43:31 +01:00
Marina Glancy
c0dd0e3543 MDL-41640 mod_feedback: info question should default to course
Also hide "response time" from options in case of anonymous feedback
2016-05-06 09:27:34 +08:00
Marina Glancy
ac29314ed1 MDL-41640 mod_feedback: do not show 0 responsetime 2016-05-06 09:27:33 +08:00
Marina Glancy
bc73c64071 MDL-53638 mod_feedback: fix to responsetime in non-anon answer 2016-04-29 12:18:02 +01:00
Marina Glancy
c04dc3ca13 MDL-53638 mod_feedback: JS confirmation of deleting item 2016-04-27 16:04:44 +08:00
Marina Glancy
c33c1ed59e MDL-53638 mod_feedback: analysis page enhancements 2016-04-27 13:28:45 +08:00
Marina Glancy
c83c052230 MDL-53638 mod_feedback: change items classes
remove duplication by creating methods in the parent class
delete unused methods
add new method complete_form_element() that hooks into the moodleform
2016-04-27 13:28:44 +08:00
Marina Glancy
0e548b8063 MDL-53588 mod_feedback: always submit checkboxes 2016-03-31 17:21:23 +08:00
Marina Glancy
17a6064dd3 MDL-50941 mod_feedback: client validation of maxlength 2016-03-31 09:34:16 +08:00
Marina Glancy
4ba67534d8 MDL-53557 mod_feedback: fix to formatting float 2016-03-30 09:17:51 +08:00
David Monllao
686bb3ea9d Merge branch 'wip-MDL-53557-master' of https://github.com/marinaglancy/moodle 2016-03-29 13:28:04 +08:00
Marina Glancy
2aad1094b1 MDL-29303 mod_feedback: allow any characters in labels 2016-03-27 21:47:49 +08:00
Marina Glancy
17e166847b MDL-53557 mod_feedback: partial boundaries in numeric items 2016-03-27 21:37:32 +08:00
Marina Glancy
372a92a7dc MDL-50941 mod_feedback: change default legnth for shorttext to 255 2016-03-18 08:18:54 +08:00
Marina Glancy
17f53b45ab MDL-44952 mod_feedback: set value for hidenoselect if disabled 2016-03-01 12:21:00 +08:00
Dan Poltawski
b70b436875 Merge branch 'MDL-44952-master' of git://github.com/marinaglancy/moodle 2016-02-29 16:34:22 +08:00
Marina Glancy
42756192d7 MDL-53129 mod_feedback: forms cleanup and behat tests 2016-02-23 13:17:21 +08:00
Marina Glancy
8ad534bd9f MDL-44952 mod_feedback: validate required multichoice 2016-02-22 22:01:02 +08:00
Tony Butler
1e31f11852 MDL-28484 core_lib: Add function for https detection
Signed-off-by: Tony Butler <tonyjbutler@gmail.com>
2014-10-03 13:02:29 +01:00
Dan Marsden
9b4162fb1d MDL-31366 Feedback: decode htmlchars on output to excel 2014-07-11 13:28:16 +12:00
Andreas Grabs
c2ebf60636 MDL-45592 mod_feedback - unwanted linebreak after import or duplicating a feedback 2014-05-29 17:16:26 +02:00
Mark Nelson
f68fee244a MDL-42462 mod_feedback: added $OUTPUT to list of global variables used to avoid error 2014-04-09 15:37:21 +08:00
Michael Milette
cba011942c MDL-42462 - Feedback - Fix for WCAG 2.0 issue with Informational and Error Content Displayed in red
1) The same code used in other Moodle forms is now used in Feedback to display the "There are required fields in this form marked (*/Required field)" message at the top of the screen and each of the asterisks next to required fields.

2) Feedback specific styles (missingrequire, feeback_required_mark), which were used to highlight required and error fields, have been eliminated. These colours are now controlled by the common Moodle styles (mform1, mform, fdescription, required, req and error) that are used throughout the rest of Moodle for a more uniform appearance.

3) Field level error reporting now displays a message instead of just highlighting the field in a similar way that other Moodle forms do.

Affected files:

- /mod/feedback/styles.css
- /mod/feedback/complete.php
- /mod/feedback/complete_guest.php
- /mod/feedback/edit.php
- /mod/feedback/print.php
- /mod/feedback/item/captcha/lib.php
- /mod/feedback/item/info/lib.php
- /mod/feedback/item/multichoice/lib.php
- /mod/feedback/item/multichoicerated/lib.php
- /mod/feedback/item/numeric/lib.php
- /mod/feedback/item/textarea/lib.php
- /mod/feedback/item/textfield/lib.php
- /mod/feedback/lang/en/feedback.php

Signed-off-by: Michael Milette <michael.milette@instruxmedia.com>
2014-04-03 09:25:37 -04:00
Marina Glancy
7480dbc5f2 Merge branch 'MDL-42505-Feedback-Inappropriate-use-of-fieldset-tags-around-cancel-button' of git://github.com/michael-milette/moodle 2014-02-11 14:13:39 +08:00
Michael Milette
ca5849e5dc MDL-42505 - Feedback plugin: Inappropriate use of fieldset tags around form and cancel button
Changes:
* Removed the fieldset HTML tags around the Cancel button at the bottom of the form.
* Removed the fieldset HTML tags around the whole form.
* Added missing fieldset tags around groups of radio buttons and checkboxes.
* Removed unordered list wrapping dropdown lists.
* Removed duplicate label for dropdown lists.

Modified Files:
* mod/feedback/complete.php
* mod/feedback/complete_guest.php
* mod/feedback/item/multichoice/lib.php
* mod/feedback/item/multichoicerated/lib.php

Signed-off-by: Michael Milette <michael.milette@instruxmedia.com>
2014-01-28 09:43:56 -05:00
Tony Butler
802f85076a MDL-43632 mod_feedback: Use SSL for reCAPTCHA API request if Moodle is using it 2014-01-10 10:40:23 +00:00
Michael Milette
a059b434f7 MDL-42310 feedback mod - Enable filtering of multichoice and multichoice rated controls
Conflicts:
	mod/feedback/item/multichoice/lib.php
	mod/feedback/item/multichoicerated/lib.php

Signed-off-by: Michael Milette <michael.milette@instruxmedia.com>
2014-01-03 10:24:49 +08:00
Andreas Grabs
73bbdce8c6 MDL-42521 mod_feedback - Feedback does not show line graphs in Clean theme 2013-11-03 19:11:27 +01:00
Andreas Grabs
bb4191ff4d MDL-42210 mod_feedback - convert tabs to space 2013-10-20 10:22:56 +02:00
Michael Milette
690266bcf7 MDL-42210-Feedback-Input-Labels
Adds labels to the input fields in the Feedback module including: multichoice, multichoicerated, numeric, textarea and textfield.
2013-10-20 10:22:54 +02:00
Ankit Agarwal
0601e0eef6 MDL-40402 libraries: Replace get_system_context() with context_system::instance() in core 2013-07-04 15:41:06 +08:00
Frederic Massart
4a02b4312a MDL-39435 feedback: Fix missing calls to setType 2013-05-01 10:36:23 +08:00
Andreas Grabs
25d37fe24c MDL-37800 mod_feedback - item "information" does not appear correctly 2013-02-01 11:44:52 +01:00
Sam Hemelryk
f44e7d0a77 Merge branch 'MDL-36357' of git://github.com/danpoltawski/moodle
Conflicts:
	user/view.php
2013-01-09 09:34:22 +13:00
Kevin Wiliarty
a6a33636eb MDL-35221 mod_feedback: replace checkbox with advcheckbox for all requirable feedback question types 2012-11-29 11:30:19 -05:00
Dan Poltawski
0e35ba6ffc MDL-36357 cleanup - remove double semicolons 2012-11-15 09:51:26 +08:00
Andreas Grabs
9b90584f43 MDL-34952 - change get_info() to public access 2012-08-24 21:56:45 +02:00
Aparup Banerjee
0367f6b1aa Merge branch 'MDL-34564_accessibility' of git://github.com/rwijaya/moodle 2012-08-07 14:57:34 +08:00
Andreas Grabs
94848b0748 MDL-34658 - Saving failed because missing or false values 2012-08-03 12:01:45 +02:00
Rossiani Wijaya
f203506463 MDL-34564 accessibility compliance for feedback module: Add forform input text and select tag 2012-08-03 11:53:55 +08:00
David Monllao
2c979976e1 MDL-34464 mod_feedback Replace all instances of get_context_instance() with respective context_XXXX class in mod/feedback 2012-07-27 09:13:57 +08:00
Andreas Grabs
f65c82636a MDL-33932_master - added array_unique() 2012-06-25 21:45:33 +02:00
Sam Hemelryk
5f17311f52 MDL-27675 mod_feedback: Fixed up white space 2012-06-21 11:40:38 +12:00
Sam Hemelryk
d2448b8bd2 Merge branch 'MDL-27675_master' of git://github.com/grabs/moodle 2012-06-21 11:25:07 +12:00
Andreas Grabs
e7fc2ff42e MDL-27675 - Feedback module abuses data_submitted 2012-06-06 23:17:35 +02:00
Sam Hemelryk
378eb6f6a2 Revert "Merge branch 'MDL-27675_master_wip' of git://github.com/grabs/moodle"
This reverts commit a09a9be812, reversing
changes made to 08e0aaa173.
2012-05-30 16:34:11 +12:00