mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 21:49:15 +01:00
Code Issues Projects Releases Wiki Activity
113,406 Commits 36 Branches 519 Tags
Commit Graph

5103 Commits

Author SHA1 Message Date
Mathew May
aa2ef1fe9c MDL-80416 qtype_ordering: Tests for reuse functionality 
Part of: MDL-79863
 2024-04-05 09:24:02 +08:00
Mihail Geshoski
6631b37eca MDL-79879 qtype_ordering: Improve the settings page 
Part of: MDL-79863
 2024-04-05 09:23:59 +08:00
Ilya Tregubov
272c8976fe MDL-79863 qtype_ordering: Ensure qtype_ordering is compatible with PHP 8.2 
Co-authored by: Mathew May <mathewm@hotmail.co.nz>
 2024-04-04 16:21:07 +08:00
Mathew May
63ed08c050 MDL-79905 qtype_ordering: Improve test coverage for question ordering 
Part of: MDL-79863
 2024-04-04 16:21:07 +08:00
Ilya Tregubov
ec320c2e49 MDL-79873 qtype_ordering: Template to output formulation and controls. 
Part of: MDL-79863
 2024-04-04 16:21:07 +08:00
Mathew May
9d060922ae MDL-79874 qtype_ordering: Move feedback into exporter 
Part of: MDL-79863
 2024-04-04 16:21:07 +08:00
Kevin Percy
e1357ee51c MDL-79863 qtype_ordering: Coding style improvements part 2 
Co-authored by: Tim Hunt <T.J.Hunt@open.ac.uk>
 2024-04-04 16:20:50 +08:00
Ilya Tregubov
d00061da26 MDL-79877 qtype_ordering: Template to output correct parts 
Part of: MDL-79863
Creates an exporter class and a template to output the correct
part  to a given question attempt.
 2024-04-04 16:00:52 +08:00
Mathew May
36822f0c0a MDL-79870 qtype_ordering: Remove unused code 
Part of: MDL-79863
 2024-04-04 16:00:51 +08:00
Mathew May
cf1bcfce18 MDL-79884 qtype_ordering: Add unit coverage and exemptions 
Part of: MDL-79863
 2024-04-04 16:00:51 +08:00
Ilya Tregubov
de5fc46b41 MDL-79875 qtype_ordering: Template to output grade detail 
Part of: MDL-79863
Creates an exporter class and a template to output the grade
detail to a given question attempt.
 2024-04-04 16:00:51 +08:00
Shamim Rezaie
31fc5161c9 MDL-79863 qtype_ordering: Coding style improvements part 1 
Co-authored by: Ilya Tregubov <ilya@moodle.com>
Co-authored by: Mihail Geshoski <mihail@moodle.com>
Co-authored by: Shamim Rezaie <shamim@moodle.com>
 2024-04-04 16:00:51 +08:00
Mathew May
18182c30e6 MDL-79871 qtype_ordering: Further changes for readability 
Part of: MDL-79863
- Reduce usage of jQuery to only a couple of variables. These are left as is due to how heavy the usage is and how the base dnd seems to assume jQuery objects here and there.
- Templated the proxy string so we dont have to pull it in and replace tokens on the fly.
- Moved around functionality a bit to make for more concise reading and obvious delegation of responsibility
 2024-04-04 15:26:44 +08:00
Mathew May
646f1c75d1 MDL-79871 qtype_ordering: Improve typing and documentation 
Part of: MDL-79863
 2024-04-04 15:26:44 +08:00
Mathew May
0136414cd8 MDL-79871 qtype_ordering: Move functions out of constructor 
Part of: MDL-79863
- Alot of functionality was bound to the constructor, this has been picked out into various methods for easier debug.
 2024-04-04 15:26:44 +08:00
Mathew May
d70277d050 MDL-79871 qtype_ordering: Move existing modules into class 
Part of: MDL-79863
- Taken the existing module and done the bare minimum to make it work within one class that gets called.
 2024-04-04 15:26:44 +08:00
Mathew May
416ffeed36 MDL-79871 qtype_ordering: Remove shipped core libs 
Part of: MDL-79863
 2024-04-04 15:26:44 +08:00
Mihail Geshoski
bc2bfead5c MDL-79876 qtype_ordering: Template to output the correct response 
Part of: MDL-79863
Creates an exporter class and a template to output the correct
response to a given question attempt.
 2024-04-04 15:26:44 +08:00
Mihail Geshoski
6531fa70d7 MDL-79876 qtype_ordering: Create an abstract class for the renderables 
Part of: MDL-79863
Creates an abstract class in qtype_ordering/output that implements the
renderable interface. Each renderable that is used to output a given
component of the ordering question should extend this abstract class.
 2024-04-04 15:26:43 +08:00
Mihail Geshoski
532c361386 MDL-79876 qtype_ordering: get_response() in qtype_ordering_test_helper 
Part of: MDL-79863

Previously, get_response() was implemented in almost every PHPUnit
testing class in qtype_ordering and these implementations were
idenical. In order to avoid code duplication a new static method
get_response() has been created within the qtype_ordering_test_helper
class.
Also, each individual implementation within the PHPUnit testing
classes has been removed/modified and all related calls had been
replaced by qtype_ordering_test_helper::get_response().
 2024-04-04 15:26:43 +08:00
Mathew May
377dc97590 MDL-79863 qtype_ordering: Version bump for core 2024-04-04 15:26:41 +08:00
Gordon Bateson
82bca92947 MDL-79863 qtype_ordering: qtype_ordering small fix to download URLs in readme.txt 2024-04-04 10:59:31 +08:00
Tim Hunt
cca146e8b0 MDL-79863 qtype_ordering: Save hints as the question author wants them (#75) 
There was some old code that forced all questions to have
at least 2 hints, but we have teachers who want exactly one hint
for a question in their exams.

Also, the hint-saving code was duplicating a lot of core code,
so I cleaned it up.
 2024-04-04 10:59:31 +08:00
Anupama Sarjoshi
4e825f2960 MDL-79863 qtype_ordering: Ordering M4.2: Changes to export_to_xml - remove unused answerfiles (#74) 
Thanks Anupama!
 2024-04-04 10:59:31 +08:00
Gordon Bateson
4b80d7b6e0 MDL-79863 qtype_ordering: * Fix Behat failure following button change in Moodle master branch 2024-04-04 10:59:31 +08:00
Tim Hunt
ed8147a556 MDL-79863 qtype_ordering: Ordering: fix stats calculations when items longer than 100 characters (#73) 
* Ordering: fix stats calculations when items longer than 100 characters

* Fix Behat failure following button change in Moodle master branch
 2024-04-04 10:59:31 +08:00
Gordon Bateson
44c4676fc4 MDL-79863 qtype_ordering: Co-authored-by: Anupama Sarjoshi <anupama.sarjoshi@open.ac.uk> 2024-04-04 10:59:31 +08:00
Tim Hunt
ba23a42edd MDL-79863 qtype_ordering: Ordering question type. Upgrade to work with Moodle 4.0, 4.1 and 4.2 (#72) 
* Add moodle-plugin-ci github actions configuration

* Rebuild JavaScript

* Fix behat test failing in Moodle 4.0

* Ordering: better define 'rows' for items in horizontal list #401861 #55

* Ordering: Option to show number of correct choices/highlight correct and incorrect placement.

* Ordering: Improper alignment of feedback with Horizontal layout of items

* Ordering: make M4-compatible (including behat etc.) #606639

* M4: Behat: question/type/ordering tests failing #598659

* Fix grunt errors

* Fix unreliability in the preview Behat tests

* Fix Moodle 4.0-style regrading

Also, correctly initialise all parts of the question object in initialise_question_instance

* Update CI config

---------

Co-authored-by: sangnguyen <sna67@open.ac.uk>
Co-authored-by: Thong Bui <qktc1422@gmail.com>
Co-authored-by: Anupama Sarjoshi <anupama.sarjoshi@open.ac.uk>
 2024-04-04 10:59:31 +08:00
Gordon Bateson
fc4adc6003 MDL-79863 qtype_ordering: qtype_ordering optimize code to ensure that recorded responses are no longer than 100 bytes. 2024-04-04 10:59:30 +08:00
Gordon Bateson
b3c86b05b7 MDL-79863 qtype_ordering: qtype_ordering optimize code to ensure that recorded responses are no longer than 100 bytes. 2024-04-04 10:59:30 +08:00
Mahmoud Kassaei
b681b06a26 MDL-79863 qtype_ordering: PHPunit: Some compatibilirty in question_test & questiontype_test (#69) 
qtype_ordering #69 Fix errors in unit test. Many thanks to Mahmoud Kassaei
 2024-04-04 10:59:30 +08:00
Gordon Bateson
f56dc82e52 MDL-79863 qtype_ordering: qtype_ordering modify markdown syntax for long help messages (for compatability with Moodle 3.11) 2024-04-04 10:59:30 +08:00
ewallah
1ba7af3582 MDL-79863 qtype_ordering: Update questiontype_test.php (#64) 
Declaration of qtype_ordering_test::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void
Declaration of qtype_ordering_test::tearDown() must be compatible with PHPUnit\Framework\TestCase::TearDown(): void
 2024-04-04 10:59:30 +08:00
Gordon Bateson
164bca54d6 MDL-79863 qtype_ordering: qtype_ordering fix Issue #63. Restore missing method 'set_default_value()' 2024-04-04 10:59:30 +08:00
Gordon Bateson
d5691b5097 MDL-79863 qtype_ordering: qtype_ordering add message to CHANGES.txt 2024-04-04 10:59:30 +08:00
Gordon Bateson
8973b055d3 MDL-79863 qtype_ordering: qtype_ordering in edit form, rename 'get_default_value()' method to 'get_my_default_value()' for compatability with Moodle >= 3.10 2024-04-04 10:59:30 +08:00
Gordon Bateson
c74e93c23c MDL-79863 qtype_ordering: qtype_ordering modify declaration of parameters accepted by get_default_value method in the edit form 2024-04-04 10:59:30 +08:00
Gordon Bateson
c6be47652f MDL-79863 qtype_ordering: qtype_ordering update CHANGES.txt to include recent contributions by Tim Hunt and HuongNV13 2024-04-04 10:59:30 +08:00
Gordon Bateson
6a1d9cb57f MDL-79863 qtype_ordering: qtype_ordering update CHANGES.txt to include recent contributions by Tim Hunt and HuongNV13 2024-04-04 10:59:30 +08:00
Huong Nguyen
72f9dbe111 MDL-79863 qtype_ordering: Fixing bugs (#52) 
Thanks very much, HuongNV13 (1) Items crash together horizontally (2) Number/letter no longer tracks with dragged item
 2024-04-04 10:59:30 +08:00
Tim Hunt
211edfdaeb MDL-79863 qtype_ordering: Update Behat tests to use the MDL-66821 changes (#49) 
Thanks very much, Tim Hunt. (1) Update Behat tests to use the MDL-66821 changes (2) Fix Behat test that was failing
 2024-04-04 10:59:30 +08:00
Gordon Bateson
6c6942faca MDL-79863 qtype_ordering: qtype_ordering fix JS error on Moodle >= 3.7 caused by incorrect syntax in 'define' statement in key_codes.js 2024-04-04 10:59:29 +08:00
Gordon Bateson
43c7e39a74 MDL-79863 qtype_ordering: qtype_ordering standardize layout and spelling in CHANGES.txt 2024-04-04 10:59:29 +08:00
Gordon Bateson
f87cb2c76b MDL-79863 qtype_ordering: qtype_ordering standardize layout and spelling in CHANGES.txt 2024-04-04 10:59:29 +08:00
Gordon Bateson
5b1ca09260 MDL-79863 qtype_ordering: Many thanks as always Mahmoud Kassaei ! 2024-04-04 10:59:29 +08:00
Mahmoud Kassaei
62becffa9b MDL-79863 qtype_ordering: Numberingstyle does not display properly in notactive mode (#47) 
Many thanks as always Mahmoud Kassaei !
 2024-04-04 10:59:29 +08:00
Gordon Bateson
932437c333 MDL-79863 qtype_ordering: qtype_ordering tidy up text in CHANGES.txt 2024-04-04 10:59:29 +08:00
Gordon Bateson
c26560a2b9 MDL-79863 qtype_ordering: qtype_ordering set up preliminary version of CHANGES.txt 2024-04-04 10:59:29 +08:00
Gordon Bateson
58cd34d502 MDL-79863 qtype_ordering: qtype_ordering fix behavior in Adaptive mode, with 'Whether correct' review option enabled 2024-04-04 10:59:29 +08:00
Gordon Bateson
ae7ee93bf0 MDL-79863 qtype_ordering: qtype_ordering (github-issue #43 and #44): rename upper case numberstyles to ABCD and IIII in order to differentiate from lower case styles on DBs, such as MySQL, which use case insensitive indexes. 2024-04-04 10:59:29 +08:00