43 Commits

Author SHA1 Message Date
skodak
ac9b080524 MDL-10202 merge raw and final grade tables 2007-06-20 23:06:29 +00:00
skodak
95affb8a35 MDL-9137 readding GRADE_AGGREGATE_MODE 2007-06-18 15:29:20 +00:00
skodak
b8ff92b66b MDL-9137 various grading improvements
1/ initial support for migration of old grade_items and categories (not tested)
2/ rewritten grade update and calculation logic
3/ initial support for calculation formulas
4/ minor API refactoring and cleanup
5/ various small bugfixes
6/ fixed use of grademax with scales
7/ fixed some unit tests

TODO:
* implement proper locking of grades - needs discussion
* force recalculation of all formulas after adding/removing/changing of grade items
* better delete flag support
* support for NULLs n backup - Eloy already proposed a solution
* support for NULLs in set_field()
* speedup
* more unit tests nd functional tests
2007-06-18 13:43:40 +00:00
skodak
f70152b7bb MDL-10104 grade_create_item() in gradelib.php was obsoleted by grade_update() function which does the creation and update of grade_items 2007-06-12 20:19:38 +00:00
skodak
d185c3ee5d MDL-9516 improved support for activities with legacy grading 2007-06-12 10:33:52 +00:00
skodak
e648f890ef grade_update now supports more grade_item properties 2007-06-11 10:55:31 +00:00
skodak
34e67f76a8 MDL-10076 finalize grade_is_locked() and implement grade item locking in assignment 2007-06-10 20:34:07 +00:00
skodak
4cf1b9be9d MDL-10062 - changes in raw grade handling of feedback and information
improved grade_update() function
2007-06-09 14:16:20 +00:00
skodak
c5b5f18dc1 MDL-9516 update_grade() inline docs 2007-06-07 08:34:04 +00:00
skodak
b67ec72f57 MDL-9516 update_grade(); now required $source of grading to allow modification of original grades in activities through grade_updated event 2007-06-06 23:04:24 +00:00
skodak
b919d68049 fixed mnod typo 2007-06-06 07:59:55 +00:00
skodak
612607bd47 MDL-9516 new central grading function update_grade(); to be improved/tested more tomorrow 2007-06-05 22:58:37 +00:00
nicolasconnault
210611f6ee MDL-9629 Changed grade_item.gradetype default to 1, added GRADE_TYPE_NONE constant = 0, incrementing existing constants by 1. Set up auto-generation of idnumber for grade_item if itemmodule and iteminstance are set, only a temporary stub if they are not set (must be replaced by correct generation code). New category form now has server-side validation (not using formslib) 2007-06-05 08:50:24 +00:00
nicolasconnault
de420c11c5 MDL-9317 Applying Petr's second patch 2007-05-29 00:56:44 +00:00
skodak
7bddd4b787 MDL-9632; MDL-9545 basic assignment grading support - event triggers implemented + some minor cleanup 2007-05-28 08:55:15 +00:00
nicolasconnault
d990776605 MDL-9137 Applied parts of Petr's patch on the gradebook objects. Unit tests unaffected. 2007-05-28 02:05:21 +00:00
toyomoyo
3abe994563 fixing a typo 2007-05-24 03:07:27 +00:00
toyomoyo
5283e9598d correcting handling of scales 2007-05-23 07:26:38 +00:00
toyomoyo
9d5c91b111 fixing scale for grade_grab_grades() 2007-05-23 06:25:13 +00:00
skodak
d46306de6a MDL-9848 eventslib improvements and cleanup 2007-05-22 10:26:29 +00:00
toyomoyo
9fffb69162 MDL-8877, specify time of manual enrolments and related improvements for changing enrolment period from user/index.php. Thanks Andrei! 2007-05-22 02:08:22 +00:00
nicolasconnault
8ff4550af2 MDL-9506 Refactored some of the category methods into grade_tree, same for unit tests. 2007-05-17 02:22:32 +00:00
toyomoyo
85ac09edc6 taking out a debugging line 2007-05-15 03:39:20 +00:00
toyomoyo
9492291c82 some changes to events to make grade_added work 2007-05-15 03:19:01 +00:00
moodler
bfe7297e47 First rough cut at a grade_handler for Yu to continue with 2007-05-14 09:38:41 +00:00
nicolasconnault
096858ffcf MDL-9506 Finally cracked the category aggregation. However, more thorough unit tests need to be written, with exact expectations instead of ranges, as currently used. All unit tests pass. 2007-05-14 04:14:22 +00:00
nicolasconnault
2df712352d MDL-9506 Almost completed category aggregation, including generation of raw and final grades held by these categories. Only a few small glitches remain, that cause these grades not to be generated properly. This is the last critical element of the gradebook API, so I'm looking forward to finishing it :-) 2007-05-11 08:46:34 +00:00
nicolasconnault
6527197b4e MDL-9506 Unit test tables are now created and emptied using XMLDB. raw.gradescale and final.gradescale have been removed in favour of a single gradevalue. Scale value is no longer rounded until moment of display. A number of other changes which you can look at by browsing the diff :-) 2007-05-09 07:50:28 +00:00
nicolasconnault
2c72af1f08 MDL-9506 Stuck on grade_category->generate_grades. I cannot figure out how to recursively generate raw grades for each category's associated grade_item based on that category's children categories and items. Heaps of other changes with this commit, including a new grade_object::update_from_db() method, which uses the state of the record in DB to update the current object with a matching id (useful when you insert an incomplete object in the DB and want to get the default values as set up in the DB). 2007-05-08 08:01:55 +00:00
nicolasconnault
46566dd8c6 MDL-9506 Moved unit tests in a simpletest subfolder so they can be automatically grouped. Added grade_history and grade_text object and another heap of small implementations. 2007-05-04 07:40:51 +00:00
toyomoyo
967f222f55 MDL-9510, cron job support of legacy grade functions in modules. Implementation is not finished as the gradebook grade_added event is not complete 2007-05-04 02:15:46 +00:00
nicolasconnault
5501446df5 MDL-9506 Added grade_outcome.php. Also added unit test for creation of log in history table when grade_raw is updated. 2007-05-03 08:51:48 +00:00
nicolasconnault
27f95e9b47 MDL-9506 Upgraded grade_item::adjust_grade with Darlene's more elegant formula. Completed grade_category::get_children($depth, $arraytype). Added 4 constants to help that method. Added and passed all unit tests (111 now). 2007-05-03 07:10:22 +00:00
nicolasconnault
d5bdb228a5 MDL-9506 Finished grade_item::adjust_grade, which now also adjusts scale grades correctly. Added grade_scale object to wrap around the current non-normalized scale DB table. When/if we upgrade to grade_scales and grade_scale_items DB tables, changing the grade_scale class will be easy. 2007-05-01 05:45:54 +00:00
nicolasconnault
869807d8e4 MLD-9506 Corrected update_final_grades() in grade_item, which was updating the grade_raw table
instead of grade_final. Made a few other adjustments.
2007-04-30 05:25:19 +00:00
nicolasconnault
a8995b34df MDL-9506 Added grade_grades_raw as a proper object used by grade_item. Also added a global function in gradelib for updating grade_grades_raw objects. 2007-04-30 04:49:25 +00:00
nicolasconnault
3058964f85 MDL-9506 Number of important changes, restored unit test stability, on to next changes... 2007-04-27 07:28:41 +00:00
nicolasconnault
60cf74305d MDL-9506 More work in the unit tests 2007-04-26 08:29:30 +00:00
nicolasconnault
f9f4a93b4e MDL-9506 Refactored gradelib.php: an abstract class (php5 in mind) holds data and methods common
to all grade_* objects. The unit test file has also been refactored to improve clarity.
2007-04-26 07:14:12 +00:00
nicolasconnault
27fbffb62b MDL-9506 More implementation of gradebook API and more unit tests. 2007-04-26 04:39:40 +00:00
nicolasconnault
619a59a70f MDL-9506 Set up the unit test bed and continued to implement gradebook API. 2007-04-24 08:50:19 +00:00
nicolasconnault
42bbccd722 MDL-9506 Finished initial draft of gradebook API. 2007-04-24 05:41:28 +00:00
nicolasconnault
5834dcdb1d MDL-9506 First draft of gradelib, and the stubs for the unit tests. 2007-04-23 09:00:32 +00:00